All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eddie Horng <eddiehorng.tw@gmail.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Trond Myklebust <trondmy@primarydata.com>,
	"bfields@fieldses.org" <bfields@fieldses.org>,
	"miklos@szeredi.hu" <miklos@szeredi.hu>,
	"linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>,
	"jlayton@kernel.org" <jlayton@kernel.org>
Subject: Re: readdir returns d_type=DT_UNKNOWN to overlay exported dir (NFSv3)
Date: Fri, 16 Mar 2018 23:06:37 +0800	[thread overview]
Message-ID: <CALLuPvpJ+dQ7oh7Hr=nVUMiwYC=GZb=j08n7OCht+9o9tFKJwg@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxjHnO+zw4TVXD78WM6nw3VXfUjN0ReKo7PGS98zT9FuaQ@mail.gmail.com>

> Eddie,
>
> I rebased and push branch ovl-xino [1] to my github, it includes the
> fix you already
> tested.
>
> If your proprietary filesystem does not implement the operation encode_fh()
> and uses the default 32INO encoding then you don't have to specify any new
> mount option. If it implements its own file handle encoding, you need to specify
> overlay mount option -o xino to declare that all inode numbers are
> limited to 32bit
> (or at least not using 64bit).
>
> Cheers,
> Amir.
>
> [1] https://github.com/amir73il/linux/commits/ovl-xino

I tested ovl-xino with my proprietary filesystem and ext4, the result
is great -- readdir returns correct d_type.
Really thanks your effort to find root cause and provide solution so fast.
In addition, do you plan to merge the fix or even the xino feature in 4.16?

Thanks,
Eddie

  reply	other threads:[~2018-03-16 15:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14  8:42 readdir returns d_type=DT_UNKNOWN to overlay exported dir (NFSv3) Eddie Horng
2018-03-14  9:56 ` Amir Goldstein
2018-03-14 11:02 ` Jeff Layton
2018-03-14 14:16   ` Trond Myklebust
2018-03-14 14:30     ` Jeff Layton
2018-03-14 15:03       ` Amir Goldstein
2018-03-14 15:06         ` Trond Myklebust
2018-03-14 15:14           ` Amir Goldstein
2018-03-14 15:40             ` Eddie Horng
2018-03-15  9:23               ` Eddie Horng
2018-03-15  9:47 ` Eddie Horng
2018-03-15 13:13   ` Amir Goldstein
2018-03-15 13:22     ` Trond Myklebust
2018-03-15 14:30       ` Eddie Horng
2018-03-15 18:40         ` Amir Goldstein
2018-03-15 21:48           ` Amir Goldstein
2018-03-16  6:25             ` Eddie Horng
2018-03-16  7:23               ` Amir Goldstein
2018-03-16  8:06                 ` Eddie Horng
2018-03-16  9:50                   ` Amir Goldstein
2018-03-16 15:06                     ` Eddie Horng [this message]
2018-03-16 15:28                       ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALLuPvpJ+dQ7oh7Hr=nVUMiwYC=GZb=j08n7OCht+9o9tFKJwg@mail.gmail.com' \
    --to=eddiehorng.tw@gmail.com \
    --cc=amir73il@gmail.com \
    --cc=bfields@fieldses.org \
    --cc=jlayton@kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=trondmy@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.