* [PATCH net-next] tcp: introduce skb_rbtree_walk_safe() and use it in tcp_clean_rtx_queue()
@ 2018-11-28 12:16 Yafang Shao
2018-11-28 14:44 ` Eric Dumazet
0 siblings, 1 reply; 5+ messages in thread
From: Yafang Shao @ 2018-11-28 12:16 UTC (permalink / raw)
To: davem, edumazet; +Cc: netdev, linux-kernel, Yafang Shao
When walk RB tree, we'd better use skb_rbtree_walk* helpers, that can make
the code more clear.
As skb_rbtree_walk() can't be used in tcp_clean_rtx_queue(), so the new
helper skb_rbtree_walk_safe() is introduced.
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
---
include/linux/skbuff.h | 5 +++++
net/ipv4/tcp_input.c | 5 ++---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 73902ac..37ff792 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -3256,6 +3256,11 @@ static inline int __skb_grow_rcsum(struct sk_buff *skb, unsigned int len)
for (skb = skb_rb_first(root); skb != NULL; \
skb = skb_rb_next(skb))
+#define skb_rbtree_walk_safe(skb, root, tmp) \
+ for (skb = skb_rb_first(root); \
+ tmp = skb ? skb_rb_next(skb) : NULL, skb != NULL; \
+ skb = tmp)
+
#define skb_rbtree_walk_from(skb) \
for (; skb != NULL; \
skb = skb_rb_next(skb))
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index f323978..ab6add2 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -3043,7 +3043,7 @@ static int tcp_clean_rtx_queue(struct sock *sk, u32 prior_fack,
struct tcp_sock *tp = tcp_sk(sk);
u32 prior_sacked = tp->sacked_out;
u32 reord = tp->snd_nxt; /* lowest acked un-retx un-sacked seq */
- struct sk_buff *skb, *next;
+ struct sk_buff *skb, *tmp;
bool fully_acked = true;
long sack_rtt_us = -1L;
long seq_rtt_us = -1L;
@@ -3055,7 +3055,7 @@ static int tcp_clean_rtx_queue(struct sock *sk, u32 prior_fack,
first_ackt = 0;
- for (skb = skb_rb_first(&sk->tcp_rtx_queue); skb; skb = next) {
+ skb_rbtree_walk_safe(skb, &sk->tcp_rtx_queue, tmp) {
struct tcp_skb_cb *scb = TCP_SKB_CB(skb);
const u32 start_seq = scb->seq;
u8 sacked = scb->sacked;
@@ -3126,7 +3126,6 @@ static int tcp_clean_rtx_queue(struct sock *sk, u32 prior_fack,
if (!fully_acked)
break;
- next = skb_rb_next(skb);
if (unlikely(skb == tp->retransmit_skb_hint))
tp->retransmit_skb_hint = NULL;
if (unlikely(skb == tp->lost_skb_hint))
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] tcp: introduce skb_rbtree_walk_safe() and use it in tcp_clean_rtx_queue()
2018-11-28 12:16 [PATCH net-next] tcp: introduce skb_rbtree_walk_safe() and use it in tcp_clean_rtx_queue() Yafang Shao
@ 2018-11-28 14:44 ` Eric Dumazet
2018-11-28 16:53 ` Eric Dumazet
2018-11-29 2:32 ` Yafang Shao
0 siblings, 2 replies; 5+ messages in thread
From: Eric Dumazet @ 2018-11-28 14:44 UTC (permalink / raw)
To: Yafang Shao, davem, edumazet; +Cc: netdev, linux-kernel
On 11/28/2018 04:16 AM, Yafang Shao wrote:
> When walk RB tree, we'd better use skb_rbtree_walk* helpers, that can make
> the code more clear.
> As skb_rbtree_walk() can't be used in tcp_clean_rtx_queue(), so the new
> helper skb_rbtree_walk_safe() is introduced.
This makes things slower. Let me explain inline.
>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> ---
> include/linux/skbuff.h | 5 +++++
> net/ipv4/tcp_input.c | 5 ++---
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 73902ac..37ff792 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -3256,6 +3256,11 @@ static inline int __skb_grow_rcsum(struct sk_buff *skb, unsigned int len)
> for (skb = skb_rb_first(root); skb != NULL; \
> skb = skb_rb_next(skb))
>
> +#define skb_rbtree_walk_safe(skb, root, tmp) \
> + for (skb = skb_rb_first(root); \
> + tmp = skb ? skb_rb_next(skb) : NULL, skb != NULL; \
> + skb = tmp)
> +
> #define skb_rbtree_walk_from(skb) \
> for (; skb != NULL; \
> skb = skb_rb_next(skb))
> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> index f323978..ab6add2 100644
> --- a/net/ipv4/tcp_input.c
> +++ b/net/ipv4/tcp_input.c
> @@ -3043,7 +3043,7 @@ static int tcp_clean_rtx_queue(struct sock *sk, u32 prior_fack,
> struct tcp_sock *tp = tcp_sk(sk);
> u32 prior_sacked = tp->sacked_out;
> u32 reord = tp->snd_nxt; /* lowest acked un-retx un-sacked seq */
> - struct sk_buff *skb, *next;
> + struct sk_buff *skb, *tmp;
> bool fully_acked = true;
> long sack_rtt_us = -1L;
> long seq_rtt_us = -1L;
> @@ -3055,7 +3055,7 @@ static int tcp_clean_rtx_queue(struct sock *sk, u32 prior_fack,
>
> first_ackt = 0;
>
> - for (skb = skb_rb_first(&sk->tcp_rtx_queue); skb; skb = next) {
> + skb_rbtree_walk_safe(skb, &sk->tcp_rtx_queue, tmp) {
> struct tcp_skb_cb *scb = TCP_SKB_CB(skb);
> const u32 start_seq = scb->seq;
> u8 sacked = scb->sacked;
> @@ -3126,7 +3126,6 @@ static int tcp_clean_rtx_queue(struct sock *sk, u32 prior_fack,
> if (!fully_acked)
> break;
>
> - next = skb_rb_next(skb);
We call skb_rb_next() here only, not at the beginning of the loop.
Why ?
Because we can break of the loop if the current skb is not fully acked.
So your patch would add unnecessary overhead, since the extra sk_rb_next()
could add more extra cache line misses.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] tcp: introduce skb_rbtree_walk_safe() and use it in tcp_clean_rtx_queue()
2018-11-28 14:44 ` Eric Dumazet
@ 2018-11-28 16:53 ` Eric Dumazet
2018-11-28 17:26 ` Eric Dumazet
2018-11-29 2:32 ` Yafang Shao
1 sibling, 1 reply; 5+ messages in thread
From: Eric Dumazet @ 2018-11-28 16:53 UTC (permalink / raw)
To: Yafang Shao, davem, edumazet; +Cc: netdev, linux-kernel
On 11/28/2018 06:44 AM, Eric Dumazet wrote:
>
> Because we can break of the loop if the current skb is not fully acked.
>
> So your patch would add unnecessary overhead, since the extra sk_rb_next()
> could add more extra cache line misses.
I am testing the following optimization, since we can avoid the rb_next() call
when we reached snd_una
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index f32397890b6dcbc34976954c4be142108efa04d8..6829e470f0c186a73c34dca414cd4a2b379baded 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -3126,7 +3126,8 @@ static int tcp_clean_rtx_queue(struct sock *sk, u32 prior_fack,
if (!fully_acked)
break;
- next = skb_rb_next(skb);
+ next = (scb->end_seq == tp->snd_una) ? NULL : skb_rb_next(skb);
+
if (unlikely(skb == tp->retransmit_skb_hint))
tp->retransmit_skb_hint = NULL;
if (unlikely(skb == tp->lost_skb_hint))
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] tcp: introduce skb_rbtree_walk_safe() and use it in tcp_clean_rtx_queue()
2018-11-28 16:53 ` Eric Dumazet
@ 2018-11-28 17:26 ` Eric Dumazet
0 siblings, 0 replies; 5+ messages in thread
From: Eric Dumazet @ 2018-11-28 17:26 UTC (permalink / raw)
To: Yafang Shao, davem, edumazet; +Cc: netdev, linux-kernel
On 11/28/2018 08:53 AM, Eric Dumazet wrote:
>
>
> On 11/28/2018 06:44 AM, Eric Dumazet wrote:
>>
>
>> Because we can break of the loop if the current skb is not fully acked.
>>
>> So your patch would add unnecessary overhead, since the extra sk_rb_next()
>> could add more extra cache line misses.
>
> I am testing the following optimization, since we can avoid the rb_next() call
> when we reached snd_una
>
> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> index f32397890b6dcbc34976954c4be142108efa04d8..6829e470f0c186a73c34dca414cd4a2b379baded 100644
> --- a/net/ipv4/tcp_input.c
> +++ b/net/ipv4/tcp_input.c
> @@ -3126,7 +3126,8 @@ static int tcp_clean_rtx_queue(struct sock *sk, u32 prior_fack,
> if (!fully_acked)
> break;
>
> - next = skb_rb_next(skb);
> + next = (scb->end_seq == tp->snd_una) ? NULL : skb_rb_next(skb);
> +
> if (unlikely(skb == tp->retransmit_skb_hint))
> tp->retransmit_skb_hint = NULL;
> if (unlikely(skb == tp->lost_skb_hint))
>
This does not work since we use next skb after the loop :
1) if (!skb)
tcp_chrono_stop(sk, TCP_CHRONO_BUSY);
This test could use tcp_rtx_queue_empty()
2) SACK reneging
if (skb && (TCP_SKB_CB(skb)->sacked & TCPCB_SACKED_ACKED))
flag |= FLAG_SACK_RENEGING;
3) FLAG_SET_XMIT_TIMER
} else if (skb && rtt_update && sack_rtt_us >= 0 &&
sack_rtt_us > tcp_stamp_us_delta(tp->tcp_mstamp,
tcp_skb_timestamp_us(skb))) {
flag |= FLAG_SET_XMIT_TIMER; /* set TLP or RTO timer */
So this idea is not feasible.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] tcp: introduce skb_rbtree_walk_safe() and use it in tcp_clean_rtx_queue()
2018-11-28 14:44 ` Eric Dumazet
2018-11-28 16:53 ` Eric Dumazet
@ 2018-11-29 2:32 ` Yafang Shao
1 sibling, 0 replies; 5+ messages in thread
From: Yafang Shao @ 2018-11-29 2:32 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David Miller, Eric Dumazet, netdev, LKML
On Wed, Nov 28, 2018 at 10:44 PM Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>
>
> On 11/28/2018 04:16 AM, Yafang Shao wrote:
> > When walk RB tree, we'd better use skb_rbtree_walk* helpers, that can make
> > the code more clear.
> > As skb_rbtree_walk() can't be used in tcp_clean_rtx_queue(), so the new
> > helper skb_rbtree_walk_safe() is introduced.
>
> This makes things slower. Let me explain inline.
>
> >
> > Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> > ---
> > include/linux/skbuff.h | 5 +++++
> > net/ipv4/tcp_input.c | 5 ++---
> > 2 files changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> > index 73902ac..37ff792 100644
> > --- a/include/linux/skbuff.h
> > +++ b/include/linux/skbuff.h
> > @@ -3256,6 +3256,11 @@ static inline int __skb_grow_rcsum(struct sk_buff *skb, unsigned int len)
> > for (skb = skb_rb_first(root); skb != NULL; \
> > skb = skb_rb_next(skb))
> >
> > +#define skb_rbtree_walk_safe(skb, root, tmp) \
> > + for (skb = skb_rb_first(root); \
> > + tmp = skb ? skb_rb_next(skb) : NULL, skb != NULL; \
> > + skb = tmp)
> > +
> > #define skb_rbtree_walk_from(skb) \
> > for (; skb != NULL; \
> > skb = skb_rb_next(skb))
> > diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> > index f323978..ab6add2 100644
> > --- a/net/ipv4/tcp_input.c
> > +++ b/net/ipv4/tcp_input.c
> > @@ -3043,7 +3043,7 @@ static int tcp_clean_rtx_queue(struct sock *sk, u32 prior_fack,
> > struct tcp_sock *tp = tcp_sk(sk);
> > u32 prior_sacked = tp->sacked_out;
> > u32 reord = tp->snd_nxt; /* lowest acked un-retx un-sacked seq */
> > - struct sk_buff *skb, *next;
> > + struct sk_buff *skb, *tmp;
> > bool fully_acked = true;
> > long sack_rtt_us = -1L;
> > long seq_rtt_us = -1L;
> > @@ -3055,7 +3055,7 @@ static int tcp_clean_rtx_queue(struct sock *sk, u32 prior_fack,
> >
> > first_ackt = 0;
> >
> > - for (skb = skb_rb_first(&sk->tcp_rtx_queue); skb; skb = next) {
> > + skb_rbtree_walk_safe(skb, &sk->tcp_rtx_queue, tmp) {
> > struct tcp_skb_cb *scb = TCP_SKB_CB(skb);
> > const u32 start_seq = scb->seq;
> > u8 sacked = scb->sacked;
> > @@ -3126,7 +3126,6 @@ static int tcp_clean_rtx_queue(struct sock *sk, u32 prior_fack,
> > if (!fully_acked)
> > break;
> >
> > - next = skb_rb_next(skb);
>
> We call skb_rb_next() here only, not at the beginning of the loop.
>
> Why ?
>
> Because we can break of the loop if the current skb is not fully acked.
>
> So your patch would add unnecessary overhead, since the extra sk_rb_next()
> could add more extra cache line misses.
>
I thought this extra sk_rb_next() doesn't add much overhead before,
since it won't take long time to execute.
Seems I made a mistake.
Thanks
Yafang
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-29 2:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-28 12:16 [PATCH net-next] tcp: introduce skb_rbtree_walk_safe() and use it in tcp_clean_rtx_queue() Yafang Shao
2018-11-28 14:44 ` Eric Dumazet
2018-11-28 16:53 ` Eric Dumazet
2018-11-28 17:26 ` Eric Dumazet
2018-11-29 2:32 ` Yafang Shao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.