From: Yafang Shao <laoar.shao@gmail.com> To: kernel test robot <oliver.sang@intel.com> Cc: 0day robot <lkp@intel.com>, Petr Mladek <pmladek@suse.com>, Kees Cook <keescook@chromium.org>, Peter Zijlstra <peterz@infradead.org>, Steven Rostedt <rostedt@goodmis.org>, Al Viro <viro@zeniv.linux.org.uk>, LKML <linux-kernel@vger.kernel.org>, lkp@lists.01.org, Andrew Morton <akpm@linux-foundation.org>, Valentin Schneider <valentin.schneider@arm.com>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, qiang.zhang@windriver.com, robdclark@chromium.org, christian@brauner.io, Dietmar Eggemann <dietmar.eggemann@arm.com>, Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@redhat.com>, Vincent Guittot <vincent.guittot@linaro.org>, Benjamin Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>, Daniel Bristot de Oliveira <bristot@redhat.com>, aubrey.li@linux.intel.com, yu.c.chen@intel.com Subject: Re: [sched.h] 317419b91e: perf-sanity-tests.Parse_sched_tracepoints_fields.fail Date: Thu, 14 Oct 2021 17:24:23 +0800 [thread overview] Message-ID: <CALOAHbD540exB5DDfB8DDh8WXvsag9JsdMmC0yxriWMaoAVfOg@mail.gmail.com> (raw) In-Reply-To: <20211014072707.GA18719@xsang-OptiPlex-9020> On Thu, Oct 14, 2021 at 3:08 PM kernel test robot <oliver.sang@intel.com> wrote: > > > > Greeting, > > FYI, we noticed the following commit (built with gcc-9): > > commit: 317419b91ef4eff4e2f046088201e4dc4065caa0 ("[PATCH v3 3/4] sched.h: extend task comm from 16 to 24 for CONFIG_BASE_FULL") > url: https://github.com/0day-ci/linux/commits/Yafang-Shao/task_struct-extend-task-comm-from-16-to-24-for-CONFIG_BASE_FULL/20211010-182548 > base: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git 7fd2bf83d59a2d32e0d596c5d3e623b9a0e7e2d5 > > in testcase: perf-sanity-tests > version: perf-x86_64-7fd2bf83d59a-1_20211010 > with following parameters: > > perf_compiler: clang > ucode: 0xde > > > > on test machine: 8 threads 1 sockets Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz with 32G memory > > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): > > > > > If you fix the issue, kindly add following tag > Reported-by: kernel test robot <oliver.sang@intel.com> > > 2021-10-13 18:00:46 sudo /usr/src/perf_selftests-x86_64-rhel-8.3-317419b91ef4eff4e2f046088201e4dc4065caa0/tools/perf/perf test 13 > 13: DSO data reopen : Ok > 2021-10-13 18:00:46 sudo /usr/src/perf_selftests-x86_64-rhel-8.3-317419b91ef4eff4e2f046088201e4dc4065caa0/tools/perf/perf test 14 > 14: Roundtrip evsel->name : Ok > 2021-10-13 18:00:46 sudo /usr/src/perf_selftests-x86_64-rhel-8.3-317419b91ef4eff4e2f046088201e4dc4065caa0/tools/perf/perf test 15 > 15: Parse sched tracepoints fields : FAILED! That issue is caused by another hardcode 16 ... Seems we should make some change as below, diff --git a/tools/perf/tests/evsel-tp-sched.c b/tools/perf/tests/evsel-tp-sched.c index f9e34bd26cf3..401a737b1d85 100644 --- a/tools/perf/tests/evsel-tp-sched.c +++ b/tools/perf/tests/evsel-tp-sched.c @@ -42,7 +42,7 @@ int test__perf_evsel__tp_sched_test(struct test *test __maybe_unused, int subtes return -1; } - if (evsel__test_field(evsel, "prev_comm", 16, false)) + if (evsel__test_field(evsel, "prev_comm", TASK_COMM_LEN, false)) ret = -1; if (evsel__test_field(evsel, "prev_pid", 4, true)) @@ -54,7 +54,7 @@ int test__perf_evsel__tp_sched_test(struct test *test __maybe_unused, int subtes if (evsel__test_field(evsel, "prev_state", sizeof(long), true)) ret = -1; - if (evsel__test_field(evsel, "next_comm", 16, false)) + if (evsel__test_field(evsel, "next_comm", TASK_COMM_LEN, false)) ret = -1; if (evsel__test_field(evsel, "next_pid", 4, true)) @@ -72,7 +72,7 @@ int test__perf_evsel__tp_sched_test(struct test *test __maybe_unused, int subtes return -1; } - if (evsel__test_field(evsel, "comm", 16, false)) + if (evsel__test_field(evsel, "comm", TASK_COMM_LEN, false)) ret = -1; if (evsel__test_field(evsel, "pid", 4, true)) > 2021-10-13 18:00:46 sudo /usr/src/perf_selftests-x86_64-rhel-8.3-317419b91ef4eff4e2f046088201e4dc4065caa0/tools/perf/perf test 16 > 16: syscalls:sys_enter_openat event fields : Ok > > > > To reproduce: > > git clone https://github.com/intel/lkp-tests.git > cd lkp-tests > sudo bin/lkp install job.yaml # job file is attached in this email > bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run > sudo bin/lkp run generated-yaml-file > > # if come across any failure that blocks the test, > # please remove ~/.lkp and /lkp dir to run from a clean state. > > > > --- > 0DAY/LKP+ Test Infrastructure Open Source Technology Center > https://lists.01.org/hyperkitty/list/lkp@lists.01.org Intel Corporation > > Thanks, > Oliver Sang > -- Thanks Yafang
WARNING: multiple messages have this Message-ID (diff)
From: Yafang Shao <laoar.shao@gmail.com> To: lkp@lists.01.org Subject: Re: [sched.h] 317419b91e: perf-sanity-tests.Parse_sched_tracepoints_fields.fail Date: Thu, 14 Oct 2021 17:24:23 +0800 [thread overview] Message-ID: <CALOAHbD540exB5DDfB8DDh8WXvsag9JsdMmC0yxriWMaoAVfOg@mail.gmail.com> (raw) In-Reply-To: <20211014072707.GA18719@xsang-OptiPlex-9020> [-- Attachment #1: Type: text/plain, Size: 4064 bytes --] On Thu, Oct 14, 2021 at 3:08 PM kernel test robot <oliver.sang@intel.com> wrote: > > > > Greeting, > > FYI, we noticed the following commit (built with gcc-9): > > commit: 317419b91ef4eff4e2f046088201e4dc4065caa0 ("[PATCH v3 3/4] sched.h: extend task comm from 16 to 24 for CONFIG_BASE_FULL") > url: https://github.com/0day-ci/linux/commits/Yafang-Shao/task_struct-extend-task-comm-from-16-to-24-for-CONFIG_BASE_FULL/20211010-182548 > base: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git 7fd2bf83d59a2d32e0d596c5d3e623b9a0e7e2d5 > > in testcase: perf-sanity-tests > version: perf-x86_64-7fd2bf83d59a-1_20211010 > with following parameters: > > perf_compiler: clang > ucode: 0xde > > > > on test machine: 8 threads 1 sockets Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz with 32G memory > > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): > > > > > If you fix the issue, kindly add following tag > Reported-by: kernel test robot <oliver.sang@intel.com> > > 2021-10-13 18:00:46 sudo /usr/src/perf_selftests-x86_64-rhel-8.3-317419b91ef4eff4e2f046088201e4dc4065caa0/tools/perf/perf test 13 > 13: DSO data reopen : Ok > 2021-10-13 18:00:46 sudo /usr/src/perf_selftests-x86_64-rhel-8.3-317419b91ef4eff4e2f046088201e4dc4065caa0/tools/perf/perf test 14 > 14: Roundtrip evsel->name : Ok > 2021-10-13 18:00:46 sudo /usr/src/perf_selftests-x86_64-rhel-8.3-317419b91ef4eff4e2f046088201e4dc4065caa0/tools/perf/perf test 15 > 15: Parse sched tracepoints fields : FAILED! That issue is caused by another hardcode 16 ... Seems we should make some change as below, diff --git a/tools/perf/tests/evsel-tp-sched.c b/tools/perf/tests/evsel-tp-sched.c index f9e34bd26cf3..401a737b1d85 100644 --- a/tools/perf/tests/evsel-tp-sched.c +++ b/tools/perf/tests/evsel-tp-sched.c @@ -42,7 +42,7 @@ int test__perf_evsel__tp_sched_test(struct test *test __maybe_unused, int subtes return -1; } - if (evsel__test_field(evsel, "prev_comm", 16, false)) + if (evsel__test_field(evsel, "prev_comm", TASK_COMM_LEN, false)) ret = -1; if (evsel__test_field(evsel, "prev_pid", 4, true)) @@ -54,7 +54,7 @@ int test__perf_evsel__tp_sched_test(struct test *test __maybe_unused, int subtes if (evsel__test_field(evsel, "prev_state", sizeof(long), true)) ret = -1; - if (evsel__test_field(evsel, "next_comm", 16, false)) + if (evsel__test_field(evsel, "next_comm", TASK_COMM_LEN, false)) ret = -1; if (evsel__test_field(evsel, "next_pid", 4, true)) @@ -72,7 +72,7 @@ int test__perf_evsel__tp_sched_test(struct test *test __maybe_unused, int subtes return -1; } - if (evsel__test_field(evsel, "comm", 16, false)) + if (evsel__test_field(evsel, "comm", TASK_COMM_LEN, false)) ret = -1; if (evsel__test_field(evsel, "pid", 4, true)) > 2021-10-13 18:00:46 sudo /usr/src/perf_selftests-x86_64-rhel-8.3-317419b91ef4eff4e2f046088201e4dc4065caa0/tools/perf/perf test 16 > 16: syscalls:sys_enter_openat event fields : Ok > > > > To reproduce: > > git clone https://github.com/intel/lkp-tests.git > cd lkp-tests > sudo bin/lkp install job.yaml # job file is attached in this email > bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run > sudo bin/lkp run generated-yaml-file > > # if come across any failure that blocks the test, > # please remove ~/.lkp and /lkp dir to run from a clean state. > > > > --- > 0DAY/LKP+ Test Infrastructure Open Source Technology Center > https://lists.01.org/hyperkitty/list/lkp(a)lists.01.org Intel Corporation > > Thanks, > Oliver Sang > -- Thanks Yafang
next prev parent reply other threads:[~2021-10-14 9:25 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-10 10:24 [PATCH v3 0/4] task_struct: extend task comm from 16 to 24 for CONFIG_BASE_FULL Yafang Shao 2021-10-10 10:24 ` [PATCH v3 1/4] connector: use __get_task_comm in proc_comm_connector Yafang Shao 2021-10-10 10:24 ` [PATCH v3 2/4] fs/exec: use strscpy instead of strlcpy in __set_task_comm Yafang Shao 2021-10-10 10:24 ` [PATCH v3 3/4] sched.h: extend task comm from 16 to 24 for CONFIG_BASE_FULL Yafang Shao 2021-10-10 12:52 ` kernel test robot 2021-10-10 13:05 ` Yafang Shao 2021-10-14 7:27 ` [sched.h] 317419b91e: perf-sanity-tests.Parse_sched_tracepoints_fields.fail kernel test robot 2021-10-14 7:27 ` kernel test robot 2021-10-14 9:24 ` Yafang Shao [this message] 2021-10-14 9:24 ` Yafang Shao 2021-10-14 12:42 ` Mathieu Desnoyers 2021-10-14 12:42 ` Mathieu Desnoyers 2021-10-14 13:05 ` Yafang Shao 2021-10-14 13:05 ` Yafang Shao 2021-10-14 13:09 ` Mathieu Desnoyers 2021-10-14 13:09 ` Mathieu Desnoyers 2021-10-14 13:11 ` Yafang Shao 2021-10-14 13:11 ` Yafang Shao 2021-10-14 13:50 ` Mathieu Desnoyers 2021-10-14 13:50 ` Mathieu Desnoyers 2021-10-14 14:40 ` Yafang Shao 2021-10-14 14:40 ` Yafang Shao 2021-10-14 14:48 ` Steven Rostedt 2021-10-14 14:48 ` Steven Rostedt 2021-10-14 15:05 ` Yafang Shao 2021-10-14 15:05 ` Yafang Shao 2021-10-14 16:14 ` Kees Cook 2021-10-14 16:14 ` Kees Cook 2021-10-15 2:05 ` Yafang Shao 2021-10-15 2:05 ` Yafang Shao 2021-10-15 2:14 ` Steven Rostedt 2021-10-15 2:14 ` Steven Rostedt 2021-10-15 2:20 ` Yafang Shao 2021-10-15 2:20 ` Yafang Shao 2021-10-19 16:51 ` Arnaldo Carvalho de Melo 2021-10-19 16:51 ` Arnaldo Carvalho de Melo 2021-10-20 4:01 ` Yafang Shao 2021-10-20 4:01 ` Yafang Shao 2021-10-10 10:24 ` [PATCH v3 4/4] kernel/kthread: show a warning if kthread's comm is truncated Yafang Shao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CALOAHbD540exB5DDfB8DDh8WXvsag9JsdMmC0yxriWMaoAVfOg@mail.gmail.com \ --to=laoar.shao@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=aubrey.li@linux.intel.com \ --cc=bristot@redhat.com \ --cc=bsegall@google.com \ --cc=christian@brauner.io \ --cc=dietmar.eggemann@arm.com \ --cc=juri.lelli@redhat.com \ --cc=keescook@chromium.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lkp@intel.com \ --cc=lkp@lists.01.org \ --cc=mathieu.desnoyers@efficios.com \ --cc=mgorman@suse.de \ --cc=mingo@redhat.com \ --cc=oliver.sang@intel.com \ --cc=peterz@infradead.org \ --cc=pmladek@suse.com \ --cc=qiang.zhang@windriver.com \ --cc=robdclark@chromium.org \ --cc=rostedt@goodmis.org \ --cc=valentin.schneider@arm.com \ --cc=vincent.guittot@linaro.org \ --cc=viro@zeniv.linux.org.uk \ --cc=yu.c.chen@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.