* [PATCH v2 0/3] use sys/xattr.h instead of attr/xattr.h
@ 2018-06-27 10:18 Lu Fengqi
2018-06-27 10:18 ` [PATCH v2 1/3] fsstress: remove include <attr/xattr.h> Lu Fengqi
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Lu Fengqi @ 2018-06-27 10:18 UTC (permalink / raw)
To: fstests
The attr v2.4.48 has removed <attr/xattr.h>, so remove the check for the
<attr/xattr.h>, and use <sys/xattr.h> instead in t_immutable. And, It's
timing to remove useless xattr.h from fsstress.
Changelog:
v2: remove useless xattr.h from fsstress
Lu Fengqi (3):
fsstress: remove include <attr/xattr.h>
src/t_immutable: use sys/xattr.h instead of attr/xattr.h
build: remove <attr/xattr.h> check
configure.ac | 1 -
ltp/fsstress.c | 3 ---
m4/package_attrdev.m4 | 11 -----------
src/t_immutable.c | 2 +-
4 files changed, 1 insertion(+), 16 deletions(-)
--
2.18.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 1/3] fsstress: remove include <attr/xattr.h>
2018-06-27 10:18 [PATCH v2 0/3] use sys/xattr.h instead of attr/xattr.h Lu Fengqi
@ 2018-06-27 10:18 ` Lu Fengqi
2018-06-27 10:18 ` [PATCH 2/3] src/t_immutable: use sys/xattr.h instead of attr/xattr.h Lu Fengqi
2018-06-27 10:18 ` [PATCH 3/3] build: remove <attr/xattr.h> check Lu Fengqi
2 siblings, 0 replies; 11+ messages in thread
From: Lu Fengqi @ 2018-06-27 10:18 UTC (permalink / raw)
To: fstests
Since commit de6d86177ff8 ("QA test updates - fixes for pquota, extsize,
fsstress, and ensure mount options passed through to test_dev. Merge of
master-melb:xfs-cmds:24763a by kenmcd.") remove llistxattr from
fsstress, xattr.h is useless.
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
---
v2: remove useless xattr.h
ltp/fsstress.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/ltp/fsstress.c b/ltp/fsstress.c
index 1bffa115bf2d..edbb3f2f8fb9 100644
--- a/ltp/fsstress.c
+++ b/ltp/fsstress.c
@@ -10,9 +10,6 @@
#include <stddef.h>
#include "global.h"
-#ifdef HAVE_ATTR_XATTR_H
-#include <attr/xattr.h>
-#endif
#ifdef HAVE_ATTR_ATTRIBUTES_H
#include <attr/attributes.h>
#endif
--
2.18.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/3] src/t_immutable: use sys/xattr.h instead of attr/xattr.h
2018-06-27 10:18 [PATCH v2 0/3] use sys/xattr.h instead of attr/xattr.h Lu Fengqi
2018-06-27 10:18 ` [PATCH v2 1/3] fsstress: remove include <attr/xattr.h> Lu Fengqi
@ 2018-06-27 10:18 ` Lu Fengqi
2018-06-27 10:18 ` [PATCH 3/3] build: remove <attr/xattr.h> check Lu Fengqi
2 siblings, 0 replies; 11+ messages in thread
From: Lu Fengqi @ 2018-06-27 10:18 UTC (permalink / raw)
To: fstests
Since attr v2.4.48 has removed <attr/xattr.h>, use <sys/xattr.h>
provided by glibc.
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
---
src/t_immutable.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/t_immutable.c b/src/t_immutable.c
index 9a4e0169ec60..eadef78f9cbb 100644
--- a/src/t_immutable.c
+++ b/src/t_immutable.c
@@ -23,7 +23,7 @@
#include <grp.h>
#include <libgen.h>
#include <sys/acl.h>
-#include <attr/xattr.h>
+#include <sys/xattr.h>
#include <linux/fs.h>
#include <linux/magic.h>
#include <xfs/xfs.h>
--
2.18.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/3] build: remove <attr/xattr.h> check
2018-06-27 10:18 [PATCH v2 0/3] use sys/xattr.h instead of attr/xattr.h Lu Fengqi
2018-06-27 10:18 ` [PATCH v2 1/3] fsstress: remove include <attr/xattr.h> Lu Fengqi
2018-06-27 10:18 ` [PATCH 2/3] src/t_immutable: use sys/xattr.h instead of attr/xattr.h Lu Fengqi
@ 2018-06-27 10:18 ` Lu Fengqi
2018-06-29 6:46 ` Eryu Guan
2 siblings, 1 reply; 11+ messages in thread
From: Lu Fengqi @ 2018-06-27 10:18 UTC (permalink / raw)
To: fstests
Since fsstress and src/t_immutable don't need attr/xattr.h, just remove
<attr/xattr.h> check.
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
---
configure.ac | 1 -
m4/package_attrdev.m4 | 11 -----------
2 files changed, 12 deletions(-)
diff --git a/configure.ac b/configure.ac
index 57092f1c484b..63ea032dc564 100644
--- a/configure.ac
+++ b/configure.ac
@@ -51,7 +51,6 @@ AC_PACKAGE_NEED_XFSCTL_MACRO
AC_PACKAGE_NEED_XFS_HANDLE_H
AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE
-AC_PACKAGE_NEED_ATTR_XATTR_H
AC_PACKAGE_NEED_ATTRIBUTES_H
AC_PACKAGE_WANT_ATTRLIST_LIBATTR
AC_PACKAGE_NEED_GETXATTR_LIBATTR
diff --git a/m4/package_attrdev.m4 b/m4/package_attrdev.m4
index 12251ceb63c3..6bf21b1799e5 100644
--- a/m4/package_attrdev.m4
+++ b/m4/package_attrdev.m4
@@ -1,14 +1,3 @@
-AC_DEFUN([AC_PACKAGE_NEED_ATTR_XATTR_H],
- [ AC_CHECK_HEADERS([attr/xattr.h])
- if test "$ac_cv_header_attr_xattr_h" != "yes"; then
- echo
- echo 'FATAL ERROR: attr/xattr.h does not exist.'
- echo 'Install the extended attributes (attr) development package.'
- echo 'Alternatively, run "make install-dev" from the attr source.'
- exit 1
- fi
- ])
-
AC_DEFUN([AC_PACKAGE_NEED_ATTR_ERROR_H],
[ AC_CHECK_HEADERS([attr/error_context.h])
if test "$ac_cv_header_attr_error_context_h" != "yes"; then
--
2.18.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] build: remove <attr/xattr.h> check
2018-06-27 10:18 ` [PATCH 3/3] build: remove <attr/xattr.h> check Lu Fengqi
@ 2018-06-29 6:46 ` Eryu Guan
2018-06-29 7:50 ` Lu Fengqi
0 siblings, 1 reply; 11+ messages in thread
From: Eryu Guan @ 2018-06-29 6:46 UTC (permalink / raw)
To: Lu Fengqi; +Cc: fstests
On Wed, Jun 27, 2018 at 06:18:54PM +0800, Lu Fengqi wrote:
> Since fsstress and src/t_immutable don't need attr/xattr.h, just remove
> <attr/xattr.h> check.
>
> Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
> ---
> configure.ac | 1 -
> m4/package_attrdev.m4 | 11 -----------
> 2 files changed, 12 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 57092f1c484b..63ea032dc564 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -51,7 +51,6 @@ AC_PACKAGE_NEED_XFSCTL_MACRO
> AC_PACKAGE_NEED_XFS_HANDLE_H
>
> AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE
> -AC_PACKAGE_NEED_ATTR_XATTR_H
> AC_PACKAGE_NEED_ATTRIBUTES_H
> AC_PACKAGE_WANT_ATTRLIST_LIBATTR
> AC_PACKAGE_NEED_GETXATTR_LIBATTR
> diff --git a/m4/package_attrdev.m4 b/m4/package_attrdev.m4
> index 12251ceb63c3..6bf21b1799e5 100644
> --- a/m4/package_attrdev.m4
> +++ b/m4/package_attrdev.m4
> @@ -1,14 +1,3 @@
> -AC_DEFUN([AC_PACKAGE_NEED_ATTR_XATTR_H],
> - [ AC_CHECK_HEADERS([attr/xattr.h])
> - if test "$ac_cv_header_attr_xattr_h" != "yes"; then
> - echo
> - echo 'FATAL ERROR: attr/xattr.h does not exist.'
> - echo 'Install the extended attributes (attr) development package.'
> - echo 'Alternatively, run "make install-dev" from the attr source.'
> - exit 1
> - fi
> - ])
> -
Looks like we could remove the check for getxattr too.
AC_DEFUN([AC_PACKAGE_NEED_GETXATTR_LIBATTR],
...
Thanks,
Eryu
> AC_DEFUN([AC_PACKAGE_NEED_ATTR_ERROR_H],
> [ AC_CHECK_HEADERS([attr/error_context.h])
> if test "$ac_cv_header_attr_error_context_h" != "yes"; then
> --
> 2.18.0
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] build: remove <attr/xattr.h> check
2018-06-29 6:46 ` Eryu Guan
@ 2018-06-29 7:50 ` Lu Fengqi
2018-06-30 4:02 ` Eryu Guan
0 siblings, 1 reply; 11+ messages in thread
From: Lu Fengqi @ 2018-06-29 7:50 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests
On Fri, Jun 29, 2018 at 02:46:02PM +0800, Eryu Guan wrote:
>On Wed, Jun 27, 2018 at 06:18:54PM +0800, Lu Fengqi wrote:
>> Since fsstress and src/t_immutable don't need attr/xattr.h, just remove
>> <attr/xattr.h> check.
>>
>> Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
>> ---
>> configure.ac | 1 -
>> m4/package_attrdev.m4 | 11 -----------
>> 2 files changed, 12 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 57092f1c484b..63ea032dc564 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -51,7 +51,6 @@ AC_PACKAGE_NEED_XFSCTL_MACRO
>> AC_PACKAGE_NEED_XFS_HANDLE_H
>>
>> AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE
>> -AC_PACKAGE_NEED_ATTR_XATTR_H
>> AC_PACKAGE_NEED_ATTRIBUTES_H
>> AC_PACKAGE_WANT_ATTRLIST_LIBATTR
>> AC_PACKAGE_NEED_GETXATTR_LIBATTR
>> diff --git a/m4/package_attrdev.m4 b/m4/package_attrdev.m4
>> index 12251ceb63c3..6bf21b1799e5 100644
>> --- a/m4/package_attrdev.m4
>> +++ b/m4/package_attrdev.m4
>> @@ -1,14 +1,3 @@
>> -AC_DEFUN([AC_PACKAGE_NEED_ATTR_XATTR_H],
>> - [ AC_CHECK_HEADERS([attr/xattr.h])
>> - if test "$ac_cv_header_attr_xattr_h" != "yes"; then
>> - echo
>> - echo 'FATAL ERROR: attr/xattr.h does not exist.'
>> - echo 'Install the extended attributes (attr) development package.'
>> - echo 'Alternatively, run "make install-dev" from the attr source.'
>> - exit 1
>> - fi
>> - ])
>> -
>
>Looks like we could remove the check for getxattr too.
>
>AC_DEFUN([AC_PACKAGE_NEED_GETXATTR_LIBATTR],
>...
You're right. I will resend the patch.
--
Thanks,
Lu
>
>Thanks,
>Eryu
>
>> AC_DEFUN([AC_PACKAGE_NEED_ATTR_ERROR_H],
>> [ AC_CHECK_HEADERS([attr/error_context.h])
>> if test "$ac_cv_header_attr_error_context_h" != "yes"; then
>> --
>> 2.18.0
>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe fstests" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] build: remove <attr/xattr.h> check
2018-06-29 7:50 ` Lu Fengqi
@ 2018-06-30 4:02 ` Eryu Guan
2018-07-02 1:23 ` Lu Fengqi
0 siblings, 1 reply; 11+ messages in thread
From: Eryu Guan @ 2018-06-30 4:02 UTC (permalink / raw)
To: Lu Fengqi; +Cc: fstests
On Fri, Jun 29, 2018 at 03:50:26PM +0800, Lu Fengqi wrote:
> On Fri, Jun 29, 2018 at 02:46:02PM +0800, Eryu Guan wrote:
> >On Wed, Jun 27, 2018 at 06:18:54PM +0800, Lu Fengqi wrote:
> >> Since fsstress and src/t_immutable don't need attr/xattr.h, just remove
> >> <attr/xattr.h> check.
> >>
> >> Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
> >> ---
> >> configure.ac | 1 -
> >> m4/package_attrdev.m4 | 11 -----------
> >> 2 files changed, 12 deletions(-)
> >>
> >> diff --git a/configure.ac b/configure.ac
> >> index 57092f1c484b..63ea032dc564 100644
> >> --- a/configure.ac
> >> +++ b/configure.ac
> >> @@ -51,7 +51,6 @@ AC_PACKAGE_NEED_XFSCTL_MACRO
> >> AC_PACKAGE_NEED_XFS_HANDLE_H
> >>
> >> AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE
> >> -AC_PACKAGE_NEED_ATTR_XATTR_H
> >> AC_PACKAGE_NEED_ATTRIBUTES_H
> >> AC_PACKAGE_WANT_ATTRLIST_LIBATTR
> >> AC_PACKAGE_NEED_GETXATTR_LIBATTR
> >> diff --git a/m4/package_attrdev.m4 b/m4/package_attrdev.m4
> >> index 12251ceb63c3..6bf21b1799e5 100644
> >> --- a/m4/package_attrdev.m4
> >> +++ b/m4/package_attrdev.m4
> >> @@ -1,14 +1,3 @@
> >> -AC_DEFUN([AC_PACKAGE_NEED_ATTR_XATTR_H],
> >> - [ AC_CHECK_HEADERS([attr/xattr.h])
> >> - if test "$ac_cv_header_attr_xattr_h" != "yes"; then
> >> - echo
> >> - echo 'FATAL ERROR: attr/xattr.h does not exist.'
> >> - echo 'Install the extended attributes (attr) development package.'
> >> - echo 'Alternatively, run "make install-dev" from the attr source.'
> >> - exit 1
> >> - fi
> >> - ])
> >> -
> >
> >Looks like we could remove the check for getxattr too.
> >
> >AC_DEFUN([AC_PACKAGE_NEED_GETXATTR_LIBATTR],
> >...
>
> You're right. I will resend the patch.
It's a straightforward change, I can fix it on commit, no need to resend :)
Thanks,
Eryu
>
> --
> Thanks,
> Lu
>
> >
> >Thanks,
> >Eryu
> >
> >> AC_DEFUN([AC_PACKAGE_NEED_ATTR_ERROR_H],
> >> [ AC_CHECK_HEADERS([attr/error_context.h])
> >> if test "$ac_cv_header_attr_error_context_h" != "yes"; then
> >> --
> >> 2.18.0
> >>
> >>
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe fstests" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> >
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] build: remove <attr/xattr.h> check
2018-06-30 4:02 ` Eryu Guan
@ 2018-07-02 1:23 ` Lu Fengqi
2018-07-02 3:07 ` Xiao Yang
0 siblings, 1 reply; 11+ messages in thread
From: Lu Fengqi @ 2018-07-02 1:23 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests
On Sat, Jun 30, 2018 at 12:02:11PM +0800, Eryu Guan wrote:
>On Fri, Jun 29, 2018 at 03:50:26PM +0800, Lu Fengqi wrote:
>> On Fri, Jun 29, 2018 at 02:46:02PM +0800, Eryu Guan wrote:
>> >On Wed, Jun 27, 2018 at 06:18:54PM +0800, Lu Fengqi wrote:
>> >> Since fsstress and src/t_immutable don't need attr/xattr.h, just remove
>> >> <attr/xattr.h> check.
>> >>
>> >> Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
>> >> ---
>> >> configure.ac | 1 -
>> >> m4/package_attrdev.m4 | 11 -----------
>> >> 2 files changed, 12 deletions(-)
>> >>
>> >> diff --git a/configure.ac b/configure.ac
>> >> index 57092f1c484b..63ea032dc564 100644
>> >> --- a/configure.ac
>> >> +++ b/configure.ac
>> >> @@ -51,7 +51,6 @@ AC_PACKAGE_NEED_XFSCTL_MACRO
>> >> AC_PACKAGE_NEED_XFS_HANDLE_H
>> >>
>> >> AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE
>> >> -AC_PACKAGE_NEED_ATTR_XATTR_H
>> >> AC_PACKAGE_NEED_ATTRIBUTES_H
>> >> AC_PACKAGE_WANT_ATTRLIST_LIBATTR
>> >> AC_PACKAGE_NEED_GETXATTR_LIBATTR
>> >> diff --git a/m4/package_attrdev.m4 b/m4/package_attrdev.m4
>> >> index 12251ceb63c3..6bf21b1799e5 100644
>> >> --- a/m4/package_attrdev.m4
>> >> +++ b/m4/package_attrdev.m4
>> >> @@ -1,14 +1,3 @@
>> >> -AC_DEFUN([AC_PACKAGE_NEED_ATTR_XATTR_H],
>> >> - [ AC_CHECK_HEADERS([attr/xattr.h])
>> >> - if test "$ac_cv_header_attr_xattr_h" != "yes"; then
>> >> - echo
>> >> - echo 'FATAL ERROR: attr/xattr.h does not exist.'
>> >> - echo 'Install the extended attributes (attr) development package.'
>> >> - echo 'Alternatively, run "make install-dev" from the attr source.'
>> >> - exit 1
>> >> - fi
>> >> - ])
>> >> -
>> >
>> >Looks like we could remove the check for getxattr too.
>> >
>> >AC_DEFUN([AC_PACKAGE_NEED_GETXATTR_LIBATTR],
>> >...
>>
>> You're right. I will resend the patch.
>
>It's a straightforward change, I can fix it on commit, no need to resend :)
Sorry, but I have to say we have missed AC_PACKAGE_NEED_GETXATTR_LIBATTR
in configure.ac. So need I send a separate fix to remove it?
--
Thanks,
Lu
>
>Thanks,
>Eryu
>
>>
>> --
>> Thanks,
>> Lu
>>
>> >
>> >Thanks,
>> >Eryu
>> >
>> >> AC_DEFUN([AC_PACKAGE_NEED_ATTR_ERROR_H],
>> >> [ AC_CHECK_HEADERS([attr/error_context.h])
>> >> if test "$ac_cv_header_attr_error_context_h" != "yes"; then
>> >> --
>> >> 2.18.0
>> >>
>> >>
>> >>
>> >> --
>> >> To unsubscribe from this list: send the line "unsubscribe fstests" in
>> >> the body of a message to majordomo@vger.kernel.org
>> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> >
>> >
>>
>>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] build: remove <attr/xattr.h> check
2018-07-02 1:23 ` Lu Fengqi
@ 2018-07-02 3:07 ` Xiao Yang
2018-07-02 5:05 ` Lu Fengqi
0 siblings, 1 reply; 11+ messages in thread
From: Xiao Yang @ 2018-07-02 3:07 UTC (permalink / raw)
To: Lu Fengqi, Eryu Guan; +Cc: fstests, Zirong Lang
On 2018/07/02 9:23, Lu Fengqi wrote:
> On Sat, Jun 30, 2018 at 12:02:11PM +0800, Eryu Guan wrote:
>> On Fri, Jun 29, 2018 at 03:50:26PM +0800, Lu Fengqi wrote:
>>> On Fri, Jun 29, 2018 at 02:46:02PM +0800, Eryu Guan wrote:
>>>> On Wed, Jun 27, 2018 at 06:18:54PM +0800, Lu Fengqi wrote:
>>>>> Since fsstress and src/t_immutable don't need attr/xattr.h, just remove
>>>>> <attr/xattr.h> check.
>>>>>
>>>>> Signed-off-by: Lu Fengqi<lufq.fnst@cn.fujitsu.com>
>>>>> ---
>>>>> configure.ac | 1 -
>>>>> m4/package_attrdev.m4 | 11 -----------
>>>>> 2 files changed, 12 deletions(-)
>>>>>
>>>>> diff --git a/configure.ac b/configure.ac
>>>>> index 57092f1c484b..63ea032dc564 100644
>>>>> --- a/configure.ac
>>>>> +++ b/configure.ac
>>>>> @@ -51,7 +51,6 @@ AC_PACKAGE_NEED_XFSCTL_MACRO
>>>>> AC_PACKAGE_NEED_XFS_HANDLE_H
>>>>>
>>>>> AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE
>>>>> -AC_PACKAGE_NEED_ATTR_XATTR_H
>>>>> AC_PACKAGE_NEED_ATTRIBUTES_H
>>>>> AC_PACKAGE_WANT_ATTRLIST_LIBATTR
>>>>> AC_PACKAGE_NEED_GETXATTR_LIBATTR
>>>>> diff --git a/m4/package_attrdev.m4 b/m4/package_attrdev.m4
>>>>> index 12251ceb63c3..6bf21b1799e5 100644
>>>>> --- a/m4/package_attrdev.m4
>>>>> +++ b/m4/package_attrdev.m4
>>>>> @@ -1,14 +1,3 @@
>>>>> -AC_DEFUN([AC_PACKAGE_NEED_ATTR_XATTR_H],
>>>>> - [ AC_CHECK_HEADERS([attr/xattr.h])
>>>>> - if test "$ac_cv_header_attr_xattr_h" != "yes"; then
>>>>> - echo
>>>>> - echo 'FATAL ERROR: attr/xattr.h does not exist.'
>>>>> - echo 'Install the extended attributes (attr) development package.'
>>>>> - echo 'Alternatively, run "make install-dev" from the attr source.'
>>>>> - exit 1
>>>>> - fi
>>>>> - ])
>>>>> -
>>>> Looks like we could remove the check for getxattr too.
>>>>
>>>> AC_DEFUN([AC_PACKAGE_NEED_GETXATTR_LIBATTR],
>>>> ...
>>> You're right. I will resend the patch.
>> It's a straightforward change, I can fix it on commit, no need to resend :)
> Sorry, but I have to say we have missed AC_PACKAGE_NEED_GETXATTR_LIBATTR
> in configure.ac. So need I send a separate fix to remove it?
Hi FengQi, Eryu
Building src/ and ltp/ still failed due to undefined LIBATTR variable
even if we remove
AC_PACKAGE_NEED_GETXATTR_LIBATTR from configure.ac.
AC_PACKAGE_NEED_GETXATTR_LIBATTR is to check if attr library instead
of getxattr is available,
and building src/ and ltp/ depends on attr library.
It is sane to keep this
function(AC_DEFUN([AC_PACKAGE_NEED_GETXATTR_LIBATTR]).
Thanks,
Xiao Yang
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] build: remove <attr/xattr.h> check
2018-07-02 3:07 ` Xiao Yang
@ 2018-07-02 5:05 ` Lu Fengqi
0 siblings, 0 replies; 11+ messages in thread
From: Lu Fengqi @ 2018-07-02 5:05 UTC (permalink / raw)
To: yangx.jy; +Cc: lufq.fnst, guaneryu, fstests, zlang
Xiao Yang <yangx.jy@cn.fujitsu.com> 于2018年7月2日周一 上午11:53写道:
>
> On 2018/07/02 9:23, Lu Fengqi wrote:
> > On Sat, Jun 30, 2018 at 12:02:11PM +0800, Eryu Guan wrote:
> >> On Fri, Jun 29, 2018 at 03:50:26PM +0800, Lu Fengqi wrote:
> >>> On Fri, Jun 29, 2018 at 02:46:02PM +0800, Eryu Guan wrote:
> >>>> On Wed, Jun 27, 2018 at 06:18:54PM +0800, Lu Fengqi wrote:
> >>>>> Since fsstress and src/t_immutable don't need attr/xattr.h, just remove
> >>>>> <attr/xattr.h> check.
> >>>>>
> >>>>> Signed-off-by: Lu Fengqi<lufq.fnst@cn.fujitsu.com>
> >>>>> ---
> >>>>> configure.ac | 1 -
> >>>>> m4/package_attrdev.m4 | 11 -----------
> >>>>> 2 files changed, 12 deletions(-)
> >>>>>
> >>>>> diff --git a/configure.ac b/configure.ac
> >>>>> index 57092f1c484b..63ea032dc564 100644
> >>>>> --- a/configure.ac
> >>>>> +++ b/configure.ac
> >>>>> @@ -51,7 +51,6 @@ AC_PACKAGE_NEED_XFSCTL_MACRO
> >>>>> AC_PACKAGE_NEED_XFS_HANDLE_H
> >>>>>
> >>>>> AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE
> >>>>> -AC_PACKAGE_NEED_ATTR_XATTR_H
> >>>>> AC_PACKAGE_NEED_ATTRIBUTES_H
> >>>>> AC_PACKAGE_WANT_ATTRLIST_LIBATTR
> >>>>> AC_PACKAGE_NEED_GETXATTR_LIBATTR
> >>>>> diff --git a/m4/package_attrdev.m4 b/m4/package_attrdev.m4
> >>>>> index 12251ceb63c3..6bf21b1799e5 100644
> >>>>> --- a/m4/package_attrdev.m4
> >>>>> +++ b/m4/package_attrdev.m4
> >>>>> @@ -1,14 +1,3 @@
> >>>>> -AC_DEFUN([AC_PACKAGE_NEED_ATTR_XATTR_H],
> >>>>> - [ AC_CHECK_HEADERS([attr/xattr.h])
> >>>>> - if test "$ac_cv_header_attr_xattr_h" != "yes"; then
> >>>>> - echo
> >>>>> - echo 'FATAL ERROR: attr/xattr.h does not exist.'
> >>>>> - echo 'Install the extended attributes (attr) development package.'
> >>>>> - echo 'Alternatively, run "make install-dev" from the attr source.'
> >>>>> - exit 1
> >>>>> - fi
> >>>>> - ])
> >>>>> -
> >>>> Looks like we could remove the check for getxattr too.
> >>>>
> >>>> AC_DEFUN([AC_PACKAGE_NEED_GETXATTR_LIBATTR],
> >>>> ...
> >>> You're right. I will resend the patch.
> >> It's a straightforward change, I can fix it on commit, no need to resend :)
> > Sorry, but I have to say we have missed AC_PACKAGE_NEED_GETXATTR_LIBATTR
> > in configure.ac. So need I send a separate fix to remove it?
> Hi FengQi, Eryu
>
> Building src/ and ltp/ still failed due to undefined LIBATTR variable
> even if we remove
> AC_PACKAGE_NEED_GETXATTR_LIBATTR from configure.ac.
>
> AC_PACKAGE_NEED_GETXATTR_LIBATTR is to check if attr library instead
> of getxattr is available,
> and building src/ and ltp/ depends on attr library.
>
> It is sane to keep this
> function(AC_DEFUN([AC_PACKAGE_NEED_GETXATTR_LIBATTR]).
>
I also found this problem, so we do need to set LIBATTR. Since getxattr is no
longer owned by libattr, we still should remove
AC_PACKAGE_NEED_GETXATTR_LIBATTR. However, we can check the function
provided by libattr(such as attr_set, attr_remove...) to determine whether to
set LIBATTR. Patch is coming.
-------------------------------------------------------------
Thanks,
Lu
> Thanks,
> Xiao Yang
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 3/3] build: remove <attr/xattr.h> check
2018-06-27 8:49 [PATCH 0/3] use sys/xattr.h instead of attr/xattr.h Lu Fengqi
@ 2018-06-27 8:49 ` Lu Fengqi
0 siblings, 0 replies; 11+ messages in thread
From: Lu Fengqi @ 2018-06-27 8:49 UTC (permalink / raw)
To: fstests
Since fsstress and src/t_immutable don't need attr/xattr.h, just remove
<attr/xattr.h> check.
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
---
configure.ac | 1 -
m4/package_attrdev.m4 | 11 -----------
2 files changed, 12 deletions(-)
diff --git a/configure.ac b/configure.ac
index 57092f1c484b..63ea032dc564 100644
--- a/configure.ac
+++ b/configure.ac
@@ -51,7 +51,6 @@ AC_PACKAGE_NEED_XFSCTL_MACRO
AC_PACKAGE_NEED_XFS_HANDLE_H
AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE
-AC_PACKAGE_NEED_ATTR_XATTR_H
AC_PACKAGE_NEED_ATTRIBUTES_H
AC_PACKAGE_WANT_ATTRLIST_LIBATTR
AC_PACKAGE_NEED_GETXATTR_LIBATTR
diff --git a/m4/package_attrdev.m4 b/m4/package_attrdev.m4
index 12251ceb63c3..6bf21b1799e5 100644
--- a/m4/package_attrdev.m4
+++ b/m4/package_attrdev.m4
@@ -1,14 +1,3 @@
-AC_DEFUN([AC_PACKAGE_NEED_ATTR_XATTR_H],
- [ AC_CHECK_HEADERS([attr/xattr.h])
- if test "$ac_cv_header_attr_xattr_h" != "yes"; then
- echo
- echo 'FATAL ERROR: attr/xattr.h does not exist.'
- echo 'Install the extended attributes (attr) development package.'
- echo 'Alternatively, run "make install-dev" from the attr source.'
- exit 1
- fi
- ])
-
AC_DEFUN([AC_PACKAGE_NEED_ATTR_ERROR_H],
[ AC_CHECK_HEADERS([attr/error_context.h])
if test "$ac_cv_header_attr_error_context_h" != "yes"; then
--
2.18.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-07-02 5:05 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-27 10:18 [PATCH v2 0/3] use sys/xattr.h instead of attr/xattr.h Lu Fengqi
2018-06-27 10:18 ` [PATCH v2 1/3] fsstress: remove include <attr/xattr.h> Lu Fengqi
2018-06-27 10:18 ` [PATCH 2/3] src/t_immutable: use sys/xattr.h instead of attr/xattr.h Lu Fengqi
2018-06-27 10:18 ` [PATCH 3/3] build: remove <attr/xattr.h> check Lu Fengqi
2018-06-29 6:46 ` Eryu Guan
2018-06-29 7:50 ` Lu Fengqi
2018-06-30 4:02 ` Eryu Guan
2018-07-02 1:23 ` Lu Fengqi
2018-07-02 3:07 ` Xiao Yang
2018-07-02 5:05 ` Lu Fengqi
-- strict thread matches above, loose matches on Subject: below --
2018-06-27 8:49 [PATCH 0/3] use sys/xattr.h instead of attr/xattr.h Lu Fengqi
2018-06-27 8:49 ` [PATCH 3/3] build: remove <attr/xattr.h> check Lu Fengqi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.