* [PATCH] HID: add missing dependencies on HIDRAW
@ 2021-08-18 9:25 Tobias Junghans
2022-04-06 15:48 ` rishi gupta
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Junghans @ 2021-08-18 9:25 UTC (permalink / raw)
To: linux-input, Rishi Gupta, Jiri Kosina, Benjamin Tissoires
Cc: trivial, Tobias Junghans
hid-led, hid-u2fzero and hid-mcp2221 unconditionally access the hidraw
member of the hid_device structure to obtain the hidraw minor number.
Building without HIDRAW causes a NULL pointer dereference in the
corresponding probe handlers.
Signed-off-by: Tobias Junghans <tobias.junghans@inhub.de>
---
drivers/hid/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 160554903ef9..00416b3091e7 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -522,6 +522,7 @@ config HID_LCPOWER
config HID_LED
tristate "Simple RGB LED support"
depends on HID
+ depends on HIDRAW
depends on LEDS_CLASS
help
Support for simple RGB LED devices. Currently supported are:
@@ -1093,6 +1094,7 @@ config HID_UDRAW_PS3
config HID_U2FZERO
tristate "U2F Zero LED and RNG support"
depends on USB_HID
+ depends on HIDRAW
depends on LEDS_CLASS
depends on HW_RANDOM
help
@@ -1213,6 +1215,7 @@ config HID_ALPS
config HID_MCP2221
tristate "Microchip MCP2221 HID USB-to-I2C/SMbus host support"
depends on USB_HID && I2C
+ depends on HIDRAW
depends on GPIOLIB
help
Provides I2C and SMBUS host adapter functionality over USB-HID
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: add missing dependencies on HIDRAW
2021-08-18 9:25 [PATCH] HID: add missing dependencies on HIDRAW Tobias Junghans
@ 2022-04-06 15:48 ` rishi gupta
0 siblings, 0 replies; 2+ messages in thread
From: rishi gupta @ 2022-04-06 15:48 UTC (permalink / raw)
To: Tobias Junghans
Cc: open list:HID CORE LAYER, Jiri Kosina, Benjamin Tissoires, trivial
Thanks Tobias!
Reviewed-by: Rishi Gupta <gupt21@gmail.com>
On Wed, Aug 18, 2021 at 2:26 AM Tobias Junghans
<tobias.junghans@inhub.de> wrote:
>
> hid-led, hid-u2fzero and hid-mcp2221 unconditionally access the hidraw
> member of the hid_device structure to obtain the hidraw minor number.
> Building without HIDRAW causes a NULL pointer dereference in the
> corresponding probe handlers.
>
> Signed-off-by: Tobias Junghans <tobias.junghans@inhub.de>
> ---
> drivers/hid/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 160554903ef9..00416b3091e7 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -522,6 +522,7 @@ config HID_LCPOWER
> config HID_LED
> tristate "Simple RGB LED support"
> depends on HID
> + depends on HIDRAW
> depends on LEDS_CLASS
> help
> Support for simple RGB LED devices. Currently supported are:
> @@ -1093,6 +1094,7 @@ config HID_UDRAW_PS3
> config HID_U2FZERO
> tristate "U2F Zero LED and RNG support"
> depends on USB_HID
> + depends on HIDRAW
> depends on LEDS_CLASS
> depends on HW_RANDOM
> help
> @@ -1213,6 +1215,7 @@ config HID_ALPS
> config HID_MCP2221
> tristate "Microchip MCP2221 HID USB-to-I2C/SMbus host support"
> depends on USB_HID && I2C
> + depends on HIDRAW
> depends on GPIOLIB
> help
> Provides I2C and SMBUS host adapter functionality over USB-HID
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-06 17:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-18 9:25 [PATCH] HID: add missing dependencies on HIDRAW Tobias Junghans
2022-04-06 15:48 ` rishi gupta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.