From: Konstantin Khlebnikov <koct9i@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Baole Ni <baolex.ni@intel.com>, Pavel Machek <pavel@ucw.cz>,
chuansheng.liu@intel.com,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: Please don't replace numeric parameter like 0444 with macro
Date: Wed, 3 Aug 2016 11:07:28 +0300 [thread overview]
Message-ID: <CALYGNiPg9eXYdX209n8wEd03fh4Q45QT4EmUGjrZs+DEz-Jp5A@mail.gmail.com> (raw)
In-Reply-To: <20160803004226.GF2356@ZenIV.linux.org.uk>
On Wed, Aug 3, 2016 at 3:42 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Tue, Aug 02, 2016 at 04:58:29PM -0400, Linus Torvalds wrote:
>> [ So I answered similarly to another patch, but I'll just re-iterate
>> and change the subject line so that it stands out a bit from the
>> millions of actual patches ]
>>
>> On Tue, Aug 2, 2016 at 1:42 PM, Pavel Machek <pavel@ucw.cz> wrote:
>> >
>> > Everyone knows what 0644 is, but noone can read S_IRUSR | S_IWUSR |
>> > S_IRCRP | S_IROTH (*). Please don't do this.
>>
>> Absolutely. It's *much* easier to parse and understand the octal
>> numbers, while the symbolic macro names are just random line noise and
>> hard as hell to understand. You really have to think about it.
>>
>> So we should rather go the other way: convert existing bad symbolic
>> permission bit macro use to just use the octal numbers.
>>
>> The symbolic names are good for the *other* bits (ie sticky bit, and
>> the inode mode _type_ numbers etc), but for the permission bits, the
>> symbolic names are just insane crap. Nobody sane should ever use them.
>> Not in the kernel, not in user space.
>
> Except that you are inviting the mixes like S_IFDIR | 17 /* oops, should've
> been 017, or do we spell it 0017? */ that way. I certainly agree that this
> patch series had been a huge pile of manure, but "let's convert it in other
> direction" is inviting pretty much the same thing, with lovely potential for
> typos, etc.
We could add several macro with readable names for really used rwx
combinations, like:
#define KERN_SECRET_RO 0400
#define KERN_SECRET_RW 0600
#define KERN_SECRET_WO 0200
#define KERN_SECRET_DIR 0500
#define KERN_PUBLIC_RO 0444
#define KERN_PUBLIC_RW 0644
#define KERN_PUBLIC_DIR 0555
#define KERN_UNSAFE_RW 0666
#define KERN_UNSAFE_WO 0222
#define KERN_UNSAFE_DIR 0777
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: koct9i@gmail.com (Konstantin Khlebnikov)
To: linux-arm-kernel@lists.infradead.org
Subject: Please don't replace numeric parameter like 0444 with macro
Date: Wed, 3 Aug 2016 11:07:28 +0300 [thread overview]
Message-ID: <CALYGNiPg9eXYdX209n8wEd03fh4Q45QT4EmUGjrZs+DEz-Jp5A@mail.gmail.com> (raw)
In-Reply-To: <20160803004226.GF2356@ZenIV.linux.org.uk>
On Wed, Aug 3, 2016 at 3:42 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Tue, Aug 02, 2016 at 04:58:29PM -0400, Linus Torvalds wrote:
>> [ So I answered similarly to another patch, but I'll just re-iterate
>> and change the subject line so that it stands out a bit from the
>> millions of actual patches ]
>>
>> On Tue, Aug 2, 2016 at 1:42 PM, Pavel Machek <pavel@ucw.cz> wrote:
>> >
>> > Everyone knows what 0644 is, but noone can read S_IRUSR | S_IWUSR |
>> > S_IRCRP | S_IROTH (*). Please don't do this.
>>
>> Absolutely. It's *much* easier to parse and understand the octal
>> numbers, while the symbolic macro names are just random line noise and
>> hard as hell to understand. You really have to think about it.
>>
>> So we should rather go the other way: convert existing bad symbolic
>> permission bit macro use to just use the octal numbers.
>>
>> The symbolic names are good for the *other* bits (ie sticky bit, and
>> the inode mode _type_ numbers etc), but for the permission bits, the
>> symbolic names are just insane crap. Nobody sane should ever use them.
>> Not in the kernel, not in user space.
>
> Except that you are inviting the mixes like S_IFDIR | 17 /* oops, should've
> been 017, or do we spell it 0017? */ that way. I certainly agree that this
> patch series had been a huge pile of manure, but "let's convert it in other
> direction" is inviting pretty much the same thing, with lovely potential for
> typos, etc.
We could add several macro with readable names for really used rwx
combinations, like:
#define KERN_SECRET_RO 0400
#define KERN_SECRET_RW 0600
#define KERN_SECRET_WO 0200
#define KERN_SECRET_DIR 0500
#define KERN_PUBLIC_RO 0444
#define KERN_PUBLIC_RW 0644
#define KERN_PUBLIC_DIR 0555
#define KERN_UNSAFE_RW 0666
#define KERN_UNSAFE_WO 0222
#define KERN_UNSAFE_DIR 0777
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-08-03 8:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 20:58 Please don't replace numeric parameter like 0444 with macro Linus Torvalds
2016-08-02 20:58 ` Linus Torvalds
2016-08-02 21:53 ` Rob Landley
2016-08-02 21:53 ` Rob Landley
2016-08-02 23:39 ` [PATCH] checkpatch: Look for symbolic permissions and suggest octal instead Joe Perches
2016-08-03 0:15 ` Al Viro
2016-08-03 0:30 ` Joe Perches
2016-08-15 16:38 ` Joe Perches
2016-08-03 0:42 ` Please don't replace numeric parameter like 0444 with macro Al Viro
2016-08-03 0:42 ` Al Viro
2016-08-03 8:07 ` Konstantin Khlebnikov [this message]
2016-08-03 8:07 ` Konstantin Khlebnikov
2016-08-03 8:30 ` Richard Weinberger
2016-08-03 8:30 ` Richard Weinberger
2016-08-03 8:11 ` [PATCH] Add file permission mode helpers Ingo Molnar
2016-08-03 8:11 ` Ingo Molnar
2016-08-03 8:28 ` Greg Kroah-Hartman
2016-08-03 8:28 ` Greg Kroah-Hartman
2016-08-03 8:39 ` Ingo Molnar
2016-08-03 8:39 ` Ingo Molnar
2016-08-03 9:21 ` Willy Tarreau
2016-08-03 9:21 ` Willy Tarreau
2016-08-03 9:53 ` Marcel Holtmann
2016-08-03 9:53 ` Marcel Holtmann
2016-08-03 15:49 ` Joe Perches
2016-08-03 15:49 ` Joe Perches
2016-08-03 16:38 ` Pavel Machek
2016-08-03 16:38 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALYGNiPg9eXYdX209n8wEd03fh4Q45QT4EmUGjrZs+DEz-Jp5A@mail.gmail.com \
--to=koct9i@gmail.com \
--cc=baolex.ni@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=pavel@ucw.cz \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.