* [PATCH] zpool: add EXPORT_SYMBOL for functions
@ 2015-05-29 15:09 ` Dan Streetman
0 siblings, 0 replies; 12+ messages in thread
From: Dan Streetman @ 2015-05-29 15:09 UTC (permalink / raw)
To: Andrew Morton
Cc: Minchan Kim, Ganesh Mahendran, Kees Cook, linux-mm, linux-kernel,
Dan Streetman
Export the zpool functions that should be exported.
Signed-off-by: Dan Streetman <ddstreet@ieee.org>
---
mm/zpool.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/mm/zpool.c b/mm/zpool.c
index 6b1f103..884659d 100644
--- a/mm/zpool.c
+++ b/mm/zpool.c
@@ -188,6 +188,7 @@ struct zpool *zpool_create_pool(char *type, char *name, gfp_t gfp,
return zpool;
}
+EXPORT_SYMBOL(zpool_create_pool);
/**
* zpool_destroy_pool() - Destroy a zpool
@@ -211,6 +212,7 @@ void zpool_destroy_pool(struct zpool *zpool)
zpool_put_driver(zpool->driver);
kfree(zpool);
}
+EXPORT_SYMBOL(zpool_destroy_pool);
/**
* zpool_get_type() - Get the type of the zpool
@@ -226,6 +228,7 @@ char *zpool_get_type(struct zpool *zpool)
{
return zpool->type;
}
+EXPORT_SYMBOL(zpool_get_type);
/**
* zpool_malloc() - Allocate memory
@@ -248,6 +251,7 @@ int zpool_malloc(struct zpool *zpool, size_t size, gfp_t gfp,
{
return zpool->driver->malloc(zpool->pool, size, gfp, handle);
}
+EXPORT_SYMBOL(zpool_malloc);
/**
* zpool_free() - Free previously allocated memory
@@ -267,6 +271,7 @@ void zpool_free(struct zpool *zpool, unsigned long handle)
{
zpool->driver->free(zpool->pool, handle);
}
+EXPORT_SYMBOL(zpool_free);
/**
* zpool_shrink() - Shrink the pool size
@@ -290,6 +295,7 @@ int zpool_shrink(struct zpool *zpool, unsigned int pages,
{
return zpool->driver->shrink(zpool->pool, pages, reclaimed);
}
+EXPORT_SYMBOL(zpool_shrink);
/**
* zpool_map_handle() - Map a previously allocated handle into memory
@@ -318,6 +324,7 @@ void *zpool_map_handle(struct zpool *zpool, unsigned long handle,
{
return zpool->driver->map(zpool->pool, handle, mapmode);
}
+EXPORT_SYMBOL(zpool_map_handle);
/**
* zpool_unmap_handle() - Unmap a previously mapped handle
@@ -333,6 +340,7 @@ void zpool_unmap_handle(struct zpool *zpool, unsigned long handle)
{
zpool->driver->unmap(zpool->pool, handle);
}
+EXPORT_SYMBOL(zpool_unmap_handle);
/**
* zpool_get_total_size() - The total size of the pool
@@ -346,6 +354,7 @@ u64 zpool_get_total_size(struct zpool *zpool)
{
return zpool->driver->total_size(zpool->pool);
}
+EXPORT_SYMBOL(zpool_get_total_size);
static int __init init_zpool(void)
{
--
2.1.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] zpool: add EXPORT_SYMBOL for functions
@ 2015-05-29 15:09 ` Dan Streetman
0 siblings, 0 replies; 12+ messages in thread
From: Dan Streetman @ 2015-05-29 15:09 UTC (permalink / raw)
To: Andrew Morton
Cc: Minchan Kim, Ganesh Mahendran, Kees Cook, linux-mm, linux-kernel,
Dan Streetman
Export the zpool functions that should be exported.
Signed-off-by: Dan Streetman <ddstreet@ieee.org>
---
mm/zpool.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/mm/zpool.c b/mm/zpool.c
index 6b1f103..884659d 100644
--- a/mm/zpool.c
+++ b/mm/zpool.c
@@ -188,6 +188,7 @@ struct zpool *zpool_create_pool(char *type, char *name, gfp_t gfp,
return zpool;
}
+EXPORT_SYMBOL(zpool_create_pool);
/**
* zpool_destroy_pool() - Destroy a zpool
@@ -211,6 +212,7 @@ void zpool_destroy_pool(struct zpool *zpool)
zpool_put_driver(zpool->driver);
kfree(zpool);
}
+EXPORT_SYMBOL(zpool_destroy_pool);
/**
* zpool_get_type() - Get the type of the zpool
@@ -226,6 +228,7 @@ char *zpool_get_type(struct zpool *zpool)
{
return zpool->type;
}
+EXPORT_SYMBOL(zpool_get_type);
/**
* zpool_malloc() - Allocate memory
@@ -248,6 +251,7 @@ int zpool_malloc(struct zpool *zpool, size_t size, gfp_t gfp,
{
return zpool->driver->malloc(zpool->pool, size, gfp, handle);
}
+EXPORT_SYMBOL(zpool_malloc);
/**
* zpool_free() - Free previously allocated memory
@@ -267,6 +271,7 @@ void zpool_free(struct zpool *zpool, unsigned long handle)
{
zpool->driver->free(zpool->pool, handle);
}
+EXPORT_SYMBOL(zpool_free);
/**
* zpool_shrink() - Shrink the pool size
@@ -290,6 +295,7 @@ int zpool_shrink(struct zpool *zpool, unsigned int pages,
{
return zpool->driver->shrink(zpool->pool, pages, reclaimed);
}
+EXPORT_SYMBOL(zpool_shrink);
/**
* zpool_map_handle() - Map a previously allocated handle into memory
@@ -318,6 +324,7 @@ void *zpool_map_handle(struct zpool *zpool, unsigned long handle,
{
return zpool->driver->map(zpool->pool, handle, mapmode);
}
+EXPORT_SYMBOL(zpool_map_handle);
/**
* zpool_unmap_handle() - Unmap a previously mapped handle
@@ -333,6 +340,7 @@ void zpool_unmap_handle(struct zpool *zpool, unsigned long handle)
{
zpool->driver->unmap(zpool->pool, handle);
}
+EXPORT_SYMBOL(zpool_unmap_handle);
/**
* zpool_get_total_size() - The total size of the pool
@@ -346,6 +354,7 @@ u64 zpool_get_total_size(struct zpool *zpool)
{
return zpool->driver->total_size(zpool->pool);
}
+EXPORT_SYMBOL(zpool_get_total_size);
static int __init init_zpool(void)
{
--
2.1.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] zpool: add EXPORT_SYMBOL for functions
2015-05-29 15:09 ` Dan Streetman
@ 2015-05-29 15:22 ` Christoph Hellwig
-1 siblings, 0 replies; 12+ messages in thread
From: Christoph Hellwig @ 2015-05-29 15:22 UTC (permalink / raw)
To: Dan Streetman
Cc: Andrew Morton, Minchan Kim, Ganesh Mahendran, Kees Cook,
linux-mm, linux-kernel
On Fri, May 29, 2015 at 11:09:32AM -0400, Dan Streetman wrote:
> Export the zpool functions that should be exported.
Why?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] zpool: add EXPORT_SYMBOL for functions
@ 2015-05-29 15:22 ` Christoph Hellwig
0 siblings, 0 replies; 12+ messages in thread
From: Christoph Hellwig @ 2015-05-29 15:22 UTC (permalink / raw)
To: Dan Streetman
Cc: Andrew Morton, Minchan Kim, Ganesh Mahendran, Kees Cook,
linux-mm, linux-kernel
On Fri, May 29, 2015 at 11:09:32AM -0400, Dan Streetman wrote:
> Export the zpool functions that should be exported.
Why?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] zpool: add EXPORT_SYMBOL for functions
2015-05-29 15:22 ` Christoph Hellwig
@ 2015-05-29 15:36 ` Dan Streetman
-1 siblings, 0 replies; 12+ messages in thread
From: Dan Streetman @ 2015-05-29 15:36 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Andrew Morton, Minchan Kim, Ganesh Mahendran, Kees Cook,
Linux-MM, linux-kernel
On Fri, May 29, 2015 at 11:22 AM, Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, May 29, 2015 at 11:09:32AM -0400, Dan Streetman wrote:
>> Export the zpool functions that should be exported.
>
> Why?
because they are available for public use, per zpool.h? If, e.g.,
zram ever started using zpool, it would need them exported, wouldn't
it?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] zpool: add EXPORT_SYMBOL for functions
@ 2015-05-29 15:36 ` Dan Streetman
0 siblings, 0 replies; 12+ messages in thread
From: Dan Streetman @ 2015-05-29 15:36 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Andrew Morton, Minchan Kim, Ganesh Mahendran, Kees Cook,
Linux-MM, linux-kernel
On Fri, May 29, 2015 at 11:22 AM, Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, May 29, 2015 at 11:09:32AM -0400, Dan Streetman wrote:
>> Export the zpool functions that should be exported.
>
> Why?
because they are available for public use, per zpool.h? If, e.g.,
zram ever started using zpool, it would need them exported, wouldn't
it?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] zpool: add EXPORT_SYMBOL for functions
2015-05-29 15:36 ` Dan Streetman
@ 2015-05-29 16:30 ` Christoph Hellwig
-1 siblings, 0 replies; 12+ messages in thread
From: Christoph Hellwig @ 2015-05-29 16:30 UTC (permalink / raw)
To: Dan Streetman
Cc: Christoph Hellwig, Andrew Morton, Minchan Kim, Ganesh Mahendran,
Kees Cook, Linux-MM, linux-kernel
On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote:
> because they are available for public use, per zpool.h? If, e.g.,
> zram ever started using zpool, it would need them exported, wouldn't
> it?
If you want to use it in ram export it in the same series as those
changes, and explain what the exprots are for in your message body.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] zpool: add EXPORT_SYMBOL for functions
@ 2015-05-29 16:30 ` Christoph Hellwig
0 siblings, 0 replies; 12+ messages in thread
From: Christoph Hellwig @ 2015-05-29 16:30 UTC (permalink / raw)
To: Dan Streetman
Cc: Christoph Hellwig, Andrew Morton, Minchan Kim, Ganesh Mahendran,
Kees Cook, Linux-MM, linux-kernel
On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote:
> because they are available for public use, per zpool.h? If, e.g.,
> zram ever started using zpool, it would need them exported, wouldn't
> it?
If you want to use it in ram export it in the same series as those
changes, and explain what the exprots are for in your message body.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] zpool: add EXPORT_SYMBOL for functions
2015-05-29 16:30 ` Christoph Hellwig
@ 2015-05-29 16:35 ` Dan Streetman
-1 siblings, 0 replies; 12+ messages in thread
From: Dan Streetman @ 2015-05-29 16:35 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Andrew Morton, Minchan Kim, Ganesh Mahendran, Kees Cook,
Linux-MM, linux-kernel
On Fri, May 29, 2015 at 12:30 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote:
>> because they are available for public use, per zpool.h? If, e.g.,
>> zram ever started using zpool, it would need them exported, wouldn't
>> it?
>
> If you want to use it in ram export it in the same series as those
> changes, and explain what the exprots are for in your message body.
>
I don't want to use it in zram. I wrote zpool, but neglected to
export the functions. They should be exported though.
What's your reasoning for not wanting them exported?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] zpool: add EXPORT_SYMBOL for functions
@ 2015-05-29 16:35 ` Dan Streetman
0 siblings, 0 replies; 12+ messages in thread
From: Dan Streetman @ 2015-05-29 16:35 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Andrew Morton, Minchan Kim, Ganesh Mahendran, Kees Cook,
Linux-MM, linux-kernel
On Fri, May 29, 2015 at 12:30 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote:
>> because they are available for public use, per zpool.h? If, e.g.,
>> zram ever started using zpool, it would need them exported, wouldn't
>> it?
>
> If you want to use it in ram export it in the same series as those
> changes, and explain what the exprots are for in your message body.
>
I don't want to use it in zram. I wrote zpool, but neglected to
export the functions. They should be exported though.
What's your reasoning for not wanting them exported?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] zpool: add EXPORT_SYMBOL for functions
2015-05-29 16:35 ` Dan Streetman
@ 2015-05-29 21:37 ` Andrew Morton
-1 siblings, 0 replies; 12+ messages in thread
From: Andrew Morton @ 2015-05-29 21:37 UTC (permalink / raw)
To: Dan Streetman
Cc: Christoph Hellwig, Minchan Kim, Ganesh Mahendran, Kees Cook,
Linux-MM, linux-kernel
On Fri, 29 May 2015 12:35:46 -0400 Dan Streetman <ddstreet@ieee.org> wrote:
> On Fri, May 29, 2015 at 12:30 PM, Christoph Hellwig <hch@infradead.org> wrote:
> > On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote:
> >> because they are available for public use, per zpool.h? If, e.g.,
> >> zram ever started using zpool, it would need them exported, wouldn't
> >> it?
> >
> > If you want to use it in ram export it in the same series as those
> > changes, and explain what the exprots are for in your message body.
> >
>
> I don't want to use it in zram. I wrote zpool, but neglected to
> export the functions. They should be exported though.
>
> What's your reasoning for not wanting them exported?
It's just noise which has no value. Adding exports when there is a
demonstrated need is an OK approach.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] zpool: add EXPORT_SYMBOL for functions
@ 2015-05-29 21:37 ` Andrew Morton
0 siblings, 0 replies; 12+ messages in thread
From: Andrew Morton @ 2015-05-29 21:37 UTC (permalink / raw)
To: Dan Streetman
Cc: Christoph Hellwig, Minchan Kim, Ganesh Mahendran, Kees Cook,
Linux-MM, linux-kernel
On Fri, 29 May 2015 12:35:46 -0400 Dan Streetman <ddstreet@ieee.org> wrote:
> On Fri, May 29, 2015 at 12:30 PM, Christoph Hellwig <hch@infradead.org> wrote:
> > On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote:
> >> because they are available for public use, per zpool.h? If, e.g.,
> >> zram ever started using zpool, it would need them exported, wouldn't
> >> it?
> >
> > If you want to use it in ram export it in the same series as those
> > changes, and explain what the exprots are for in your message body.
> >
>
> I don't want to use it in zram. I wrote zpool, but neglected to
> export the functions. They should be exported though.
>
> What's your reasoning for not wanting them exported?
It's just noise which has no value. Adding exports when there is a
demonstrated need is an OK approach.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2015-05-29 21:37 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-29 15:09 [PATCH] zpool: add EXPORT_SYMBOL for functions Dan Streetman
2015-05-29 15:09 ` Dan Streetman
2015-05-29 15:22 ` Christoph Hellwig
2015-05-29 15:22 ` Christoph Hellwig
2015-05-29 15:36 ` Dan Streetman
2015-05-29 15:36 ` Dan Streetman
2015-05-29 16:30 ` Christoph Hellwig
2015-05-29 16:30 ` Christoph Hellwig
2015-05-29 16:35 ` Dan Streetman
2015-05-29 16:35 ` Dan Streetman
2015-05-29 21:37 ` Andrew Morton
2015-05-29 21:37 ` Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.