From: Rob Herring <robh@kernel.org>
To: Jacky Bai <ping.bai@nxp.com>
Cc: "A.s. Dong" <aisheng.dong@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"jacky.baip@gmail.com" <jacky.baip@gmail.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/2] ARM: dts: imx: Add basic dtsi file for imx6sll
Date: Fri, 16 Mar 2018 10:40:13 -0500 [thread overview]
Message-ID: <CAL_Jsq+=qMOAYw1+APwWKmgkfY=2c8OSes5ah2jrXnRVNU78mw@mail.gmail.com> (raw)
In-Reply-To: <HE1PR04MB3113DC090D0608077D396DCB87D30@HE1PR04MB3113.eurprd04.prod.outlook.com>
On Sun, Mar 11, 2018 at 11:43 PM, Jacky Bai <ping.bai@nxp.com> wrote:
>> > diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi
>> > + spi3 = &ecspi3;
>> > + spi4 = &ecspi4;
>> > + usbphy0 = &usbphy1;
>> > + usbphy1 = &usbphy2;
>>
>> Why do you need a alias for phys?
>
> The alias of usbphy seems used by drivers/usb/phy/phy-mxs-usb.c. So we need to add alias for usbphy.
That use should be fixed. The correct way to handle this is add a cell
to "fsl,anatop" with 0 or 1 to distinguish each phy.
>> > + };
>> > +
>> > + cpus {
>> > + #address-cells = <1>;
>> > + #size-cells = <0>;
>> > +
>> > + cpu0: cpu@0 {
>> > + compatible = "arm,cortex-a9";
>> > + device_type = "cpu";
>> > + reg = <0>;
>> > + next-level-cache = <&L2>;
>> > + operating-points = <
>> > + /* kHz uV */
>> > + 996000 1225000
>> > + 792000 1175000
>> > + 396000 1075000
>> > + 198000 975000
>> > + >;
>> > + fsl,soc-operating-points = <
>>
>> This is not documented.
>
> This is same as we used on other imx6 SOC. I don't know where to add doc for this property. Please give me some suggestion.
Along side other OPP binding docs. The real question is why you need
this and can't use the original OPP binding (which you have too) or
move to the v2 binding.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] ARM: dts: imx: Add basic dtsi file for imx6sll
Date: Fri, 16 Mar 2018 10:40:13 -0500 [thread overview]
Message-ID: <CAL_Jsq+=qMOAYw1+APwWKmgkfY=2c8OSes5ah2jrXnRVNU78mw@mail.gmail.com> (raw)
In-Reply-To: <HE1PR04MB3113DC090D0608077D396DCB87D30@HE1PR04MB3113.eurprd04.prod.outlook.com>
On Sun, Mar 11, 2018 at 11:43 PM, Jacky Bai <ping.bai@nxp.com> wrote:
>> > diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi
>> > + spi3 = &ecspi3;
>> > + spi4 = &ecspi4;
>> > + usbphy0 = &usbphy1;
>> > + usbphy1 = &usbphy2;
>>
>> Why do you need a alias for phys?
>
> The alias of usbphy seems used by drivers/usb/phy/phy-mxs-usb.c. So we need to add alias for usbphy.
That use should be fixed. The correct way to handle this is add a cell
to "fsl,anatop" with 0 or 1 to distinguish each phy.
>> > + };
>> > +
>> > + cpus {
>> > + #address-cells = <1>;
>> > + #size-cells = <0>;
>> > +
>> > + cpu0: cpu at 0 {
>> > + compatible = "arm,cortex-a9";
>> > + device_type = "cpu";
>> > + reg = <0>;
>> > + next-level-cache = <&L2>;
>> > + operating-points = <
>> > + /* kHz uV */
>> > + 996000 1225000
>> > + 792000 1175000
>> > + 396000 1075000
>> > + 198000 975000
>> > + >;
>> > + fsl,soc-operating-points = <
>>
>> This is not documented.
>
> This is same as we used on other imx6 SOC. I don't know where to add doc for this property. Please give me some suggestion.
Along side other OPP binding docs. The real question is why you need
this and can't use the original OPP binding (which you have too) or
move to the v2 binding.
Rob
next prev parent reply other threads:[~2018-03-16 15:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 10:03 [PATCH v4 1/2] ARM: dts: imx: Add basic dtsi file for imx6sll Bai Ping
2018-03-08 10:03 ` [PATCH v4 2/2] ARM: dts: imx: Add basic dts support for imx6sll EVK board Bai Ping
2018-03-08 10:03 ` Bai Ping
2018-03-08 15:35 ` Fabio Estevam
2018-03-08 15:35 ` Fabio Estevam
2018-03-09 3:36 ` Shawn Guo
2018-03-09 3:36 ` Shawn Guo
2018-03-09 5:06 ` Jacky Bai
2018-03-09 5:06 ` Jacky Bai
2018-03-09 23:44 ` Rob Herring
2018-03-09 23:44 ` Rob Herring
2018-03-09 3:15 ` [PATCH v4 1/2] ARM: dts: imx: Add basic dtsi file for imx6sll Shawn Guo
2018-03-09 3:15 ` Shawn Guo
2018-03-09 5:04 ` Jacky Bai
2018-03-09 5:04 ` Jacky Bai
2018-03-09 23:41 ` Rob Herring
2018-03-12 4:43 ` Jacky Bai
2018-03-12 4:43 ` Jacky Bai
2018-03-16 15:40 ` Rob Herring [this message]
2018-03-16 15:40 ` Rob Herring
2018-03-19 1:40 ` Jacky Bai
2018-03-19 1:40 ` Jacky Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+=qMOAYw1+APwWKmgkfY=2c8OSes5ah2jrXnRVNU78mw@mail.gmail.com' \
--to=robh@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=jacky.baip@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=ping.bai@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.