All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
	Frank Rowand <frowand.list@gmail.com>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] OF: properties: add missing of_node_put
Date: Wed, 16 Jan 2019 13:03:29 -0600	[thread overview]
Message-ID: <CAL_Jsq+H_0=mQ3hMg2BWKMZfPo+is53zvx6kpSHUMfKpSW=zJw@mail.gmail.com> (raw)
In-Reply-To: <1547372691-28324-3-git-send-email-Julia.Lawall@lip6.fr>

On Sun, Jan 13, 2019 at 4:21 AM Julia Lawall <Julia.Lawall@lip6.fr> wrote:
>
> Add an of_node_put when the result of of_graph_get_remote_port_parent is
> not available.
>
> The semantic match that finds this problem is as follows
> (http://coccinelle.lip6.fr):
>
> // <smpl>
> @r exists@
> local idexpression e;
> expression x;
> @@
> e = of_graph_get_remote_port_parent(...);
> ... when != x = e
>     when != true e == NULL
>     when != of_node_put(e)
>     when != of_fwnode_handle(e)
> (
> return e;
> |
> *return ...;
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
>  drivers/of/property.c |    1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
	Frank Rowand <frowand.list@gmail.com>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] OF: properties: add missing of_node_put
Date: Wed, 16 Jan 2019 19:03:29 +0000	[thread overview]
Message-ID: <CAL_Jsq+H_0=mQ3hMg2BWKMZfPo+is53zvx6kpSHUMfKpSW=zJw@mail.gmail.com> (raw)
In-Reply-To: <1547372691-28324-3-git-send-email-Julia.Lawall@lip6.fr>

On Sun, Jan 13, 2019 at 4:21 AM Julia Lawall <Julia.Lawall@lip6.fr> wrote:
>
> Add an of_node_put when the result of of_graph_get_remote_port_parent is
> not available.
>
> The semantic match that finds this problem is as follows
> (http://coccinelle.lip6.fr):
>
> // <smpl>
> @r exists@
> local idexpression e;
> expression x;
> @@
> e = of_graph_get_remote_port_parent(...);
> ... when != x = e
>     when != true e = NULL
>     when != of_node_put(e)
>     when != of_fwnode_handle(e)
> (
> return e;
> |
> *return ...;
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
>  drivers/of/property.c |    1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

Rob

  reply	other threads:[~2019-01-16 19:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-13  9:44 [PATCH 0/3] add missing of_node_put Julia Lawall
2019-01-13  9:44 ` Julia Lawall
2019-01-13  9:44 ` Julia Lawall
2019-01-13  9:44 ` Julia Lawall
2019-01-13  9:44 ` Julia Lawall
2019-01-13  9:44 ` [PATCH 1/3] drm: rcar-du: " Julia Lawall
2019-01-13  9:44   ` Julia Lawall
2019-01-13  9:44   ` Julia Lawall
2019-01-14 14:34   ` Kieran Bingham
2019-01-14 14:34     ` Kieran Bingham
2019-01-14 14:34     ` Kieran Bingham
2019-01-14 16:19     ` Julia Lawall
2019-01-14 16:19       ` Julia Lawall
2019-01-14 16:19       ` Julia Lawall
2019-01-13  9:44 ` [PATCH 2/3] OF: properties: " Julia Lawall
2019-01-13  9:44   ` Julia Lawall
2019-01-16 19:03   ` Rob Herring [this message]
2019-01-16 19:03     ` Rob Herring
2019-01-13  9:44 ` [PATCH 3/3] drm/meson: " Julia Lawall
2019-01-13  9:44   ` Julia Lawall
2019-01-13  9:44   ` Julia Lawall
2019-01-13  9:44   ` Julia Lawall
2019-01-13  9:44   ` Julia Lawall
2019-01-14 15:32   ` Neil Armstrong
2019-01-14 15:32     ` Neil Armstrong
2019-01-14 15:32     ` Neil Armstrong
2019-01-14 15:32     ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_Jsq+H_0=mQ3hMg2BWKMZfPo+is53zvx6kpSHUMfKpSW=zJw@mail.gmail.com' \
    --to=robh+dt@kernel.org \
    --cc=Julia.Lawall@lip6.fr \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.