From: Rob Herring <robh+dt@kernel.org> To: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Lee Jones <lee@kernel.org>, Zhou Wang <wangzhou1@hisilicon.com>, Tony Lindgren <tony@atomide.com>, Srinivas Kandagatla <srinivas.kandagatla@gmail.com>, Michael Ellerman <mpe@ellerman.id.au>, Vinod Koul <vinod.koul@intel.com>, Mark Brown <broonie@kernel.org>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, Joe Perches <joe@perches.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, dmaengine@vger.kernel.org Subject: Re: [PATCH 00/14] DT: Fix spelling of standard properties Date: Wed, 20 Apr 2016 18:58:21 -0500 [thread overview] Message-ID: <CAL_Jsq+JO41w2PweW0n1Z78=wPnYh+wfa==Hb8o37L3ynDndkA@mail.gmail.com> (raw) In-Reply-To: <1461166339-11109-1-git-send-email-geert+renesas@glider.be> On Wed, Apr 20, 2016 at 10:32 AM, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > Hi all, > > This patch series fixes misspellings of various standard DT properties > in DT binding documentation, DTS files, and error messages. > While most of these are harmless, some of them may cause hard-to-debug > failures. > > Please apply where appropriate. I'll happily take the whole series if you like, though I've not reviewed it all yet. > > Thanks! > > P.S. I used the following to detect misspellings: > > words="(address|clock|cooling|dma|gpio|index|interrupt|mbox|msi|nvmem|phy|phys|power-domain|pwm|reset|size|sleep|sound-dai|thermal-sensor)" > > git grep -Ew "${words}s-names" > git grep -E "[^-]\<${words}-name\>[^-]" > git grep -Ew "#${words}s-cells" # false positive phys-cells > git grep -E "#${words}-cell\>[^-]" > > git grep -w adress-cells > git grep -Ew "interrupts-(map|parent)" > > How can we prevent adding more of these? > > One simple option is to add the offenders to scripts/spelling.txt. > Alternatively, we may want to do something smarter and more DT specific? At least for #*-cells, we should be able to check most in dtc. When we find common properties, we can check the node for the phandle has a cells property. That would also check that the property is in fact a phandle. For *-names, we might be able to do a generic check in dtc for the corresponding property being present when we find a -names property. Though I suspect we're not consistent enough when/where we use plural. Rob
WARNING: multiple messages have this Message-ID (diff)
From: robh+dt@kernel.org (Rob Herring) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 00/14] DT: Fix spelling of standard properties Date: Wed, 20 Apr 2016 18:58:21 -0500 [thread overview] Message-ID: <CAL_Jsq+JO41w2PweW0n1Z78=wPnYh+wfa==Hb8o37L3ynDndkA@mail.gmail.com> (raw) In-Reply-To: <1461166339-11109-1-git-send-email-geert+renesas@glider.be> On Wed, Apr 20, 2016 at 10:32 AM, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > Hi all, > > This patch series fixes misspellings of various standard DT properties > in DT binding documentation, DTS files, and error messages. > While most of these are harmless, some of them may cause hard-to-debug > failures. > > Please apply where appropriate. I'll happily take the whole series if you like, though I've not reviewed it all yet. > > Thanks! > > P.S. I used the following to detect misspellings: > > words="(address|clock|cooling|dma|gpio|index|interrupt|mbox|msi|nvmem|phy|phys|power-domain|pwm|reset|size|sleep|sound-dai|thermal-sensor)" > > git grep -Ew "${words}s-names" > git grep -E "[^-]\<${words}-name\>[^-]" > git grep -Ew "#${words}s-cells" # false positive phys-cells > git grep -E "#${words}-cell\>[^-]" > > git grep -w adress-cells > git grep -Ew "interrupts-(map|parent)" > > How can we prevent adding more of these? > > One simple option is to add the offenders to scripts/spelling.txt. > Alternatively, we may want to do something smarter and more DT specific? At least for #*-cells, we should be able to check most in dtc. When we find common properties, we can check the node for the phandle has a cells property. That would also check that the property is in fact a phandle. For *-names, we might be able to do a generic check in dtc for the corresponding property being present when we find a -names property. Though I suspect we're not consistent enough when/where we use plural. Rob
next prev parent reply other threads:[~2016-04-20 23:58 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-20 15:32 [PATCH 00/14] DT: Fix spelling of standard properties Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-20 15:32 ` [PATCH 01/14] ARM: dts: STiH407: DT spelling s/interrupts-names/interrupt-names/ Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-20 15:32 ` [PATCH 02/14] ARM: dts: omap5-board-common: DT spelling s/interrupt-name/interrupt-names/ Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-20 15:32 ` [PATCH 04/14] ARM: dts: OMAP36xx: : DT spelling s/#address-cell/#address-cells/ Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-20 23:46 ` Rob Herring 2016-04-20 23:46 ` Rob Herring [not found] ` <CAL_JsqKSbGPKNZdZnowGpdF8zxXbh6g-wkq96+KmBNLwp7n=HQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-04-26 16:08 ` Tony Lindgren 2016-04-26 16:08 ` Tony Lindgren 2016-04-26 16:08 ` Tony Lindgren 2016-04-20 15:32 ` [PATCH 06/14] dmaengine: bcm2835: DT spelling s/interrupts-names/interrupt-names/ Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-25 15:26 ` Vinod Koul 2016-04-25 15:26 ` Vinod Koul 2016-04-25 16:30 ` Geert Uytterhoeven 2016-04-25 16:30 ` Geert Uytterhoeven 2016-04-25 16:30 ` Geert Uytterhoeven 2016-04-20 15:32 ` [PATCH 09/14] Input: touchscreen: Broadcom iProc: DT spelling s/clock-name/clock-names/ Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-20 17:42 ` Dmitry Torokhov 2016-04-20 17:42 ` Dmitry Torokhov 2016-04-20 15:32 ` [PATCH 10/14] misc: sram: DT spelling s/#adress-cells/#address-cells/ Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-25 13:44 ` Rob Herring 2016-04-25 13:44 ` Rob Herring 2016-04-20 15:32 ` [PATCH 11/14] PCI: hisi: DT spelling s/interrupts-*/interrupt-*/ Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-25 13:44 ` Rob Herring 2016-04-25 13:44 ` Rob Herring 2016-04-20 15:32 ` [PATCH 12/14] phy: phy-stih41x-usb: DT spelling s/#phy-cell/#phy-cells/ Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-25 13:45 ` Rob Herring 2016-04-25 13:45 ` Rob Herring 2016-04-20 15:32 ` [PATCH 13/14] rtc: rtc-sa1100: DT spelling s/interrupt-name/interrupt-names/ Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-20 21:22 ` Alexandre Belloni 2016-04-20 21:22 ` Alexandre Belloni 2016-04-20 15:32 ` [PATCH 14/14] regulator: ti-abb: DT spelling s/#{address,size}-cell/#{address,size}-cells/ Geert Uytterhoeven 2016-04-20 15:32 ` [PATCH 14/14] regulator: ti-abb: DT spelling s/#{address, size}-cell/#{address, size}-cells/ Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-21 19:29 ` [PATCH 14/14] regulator: ti-abb: DT spelling s/#{address,size}-cell/#{address,size}-cells/ Rob Herring 2016-04-21 19:29 ` [PATCH 14/14] regulator: ti-abb: DT spelling s/#{address, size}-cell/#{address, size}-cells/ Rob Herring 2016-04-21 19:29 ` Rob Herring [not found] ` <1461166339-11109-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org> 2016-04-20 15:32 ` [PATCH 03/14] ARM: dts: omap5-cm-t54: DT spelling s/interrupt-name/interrupt-names/ Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-20 15:32 ` [PATCH 05/14] arm64: dts: lg1312: DT spelling s/#interrupts-cells/#interrupt-cells/ Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-20 15:32 ` [PATCH 07/14] dt: booting-without-of: DT spelling s/#interrupt-cell/#interrupt-cells/ Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-20 15:32 ` [PATCH 08/14] powerpc: dts: acadia: DT spelling s/#interrupts-parent/#interrupt-parent/ Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-20 15:32 ` Geert Uytterhoeven 2016-04-20 15:37 ` [PATCH 00/14] DT: Fix spelling of standard properties Geert Uytterhoeven 2016-04-20 15:37 ` Geert Uytterhoeven 2016-04-20 15:37 ` Geert Uytterhoeven 2016-04-20 23:58 ` Rob Herring [this message] 2016-04-20 23:58 ` Rob Herring [not found] ` <CAL_Jsq+JO41w2PweW0n1Z78=wPnYh+wfa==Hb8o37L3ynDndkA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-04-21 19:35 ` Rob Herring 2016-04-21 19:35 ` Rob Herring 2016-04-21 19:35 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAL_Jsq+JO41w2PweW0n1Z78=wPnYh+wfa==Hb8o37L3ynDndkA@mail.gmail.com' \ --to=robh+dt@kernel.org \ --cc=alexandre.belloni@free-electrons.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=dmitry.torokhov@gmail.com \ --cc=geert+renesas@glider.be \ --cc=joe@perches.com \ --cc=lee@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=srinivas.kandagatla@gmail.com \ --cc=tony@atomide.com \ --cc=vinod.koul@intel.com \ --cc=wangzhou1@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.