All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Henry Chen <henryc.chen@mediatek.com>
Cc: "moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Fan Chen <fan.chen@mediatek.com>,
	"open list:THERMAL" <linux-pm@vger.kernel.org>,
	James Liao <jamesjj.liao@mediatek.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Georgi Djakov <georgi.djakov@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ryan Case <ryandcase@chromium.org>,
	Arvin Wang <arvin.wang@mediatek.com>,
	Nicolas Boichat <drinkcat@google.com>,
	Stephen Boyd <swboyd@chromium.org>,
	Mark Brown <broonie@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH V7 01/13] dt-bindings: soc: Add dvfsrc driver bindings
Date: Mon, 11 Jan 2021 09:42:54 -0600	[thread overview]
Message-ID: <CAL_Jsq+W3UL4-s6ezFJrhUYko2EBPsO9nMOGzGR1nQT3x_VtdQ@mail.gmail.com> (raw)
In-Reply-To: <1610333553.2992.7.camel@mtksdaap41>

On Sun, Jan 10, 2021 at 8:52 PM Henry Chen <henryc.chen@mediatek.com> wrote:
>
> Hi Rob,
>
> On Fri, 2021-01-08 at 20:30 -0700, Rob Herring wrote:
> > On Fri, 08 Jan 2021 15:48:03 +0800, Henry Chen wrote:
> > > Document the binding for enabling dvfsrc on MediaTek SoC.
> > >
> > > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> > > ---
> > >  .../devicetree/bindings/soc/mediatek/dvfsrc.yaml   | 67 ++++++++++++++++++++++
> > >  1 file changed, 67 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/soc/mediatek/dvfsrc.example.dts:19:18: fatal error: dt-bindings/interconnect/mtk,mt8183-emi.h: No such file or directory
> >    19 |         #include <dt-bindings/interconnect/mtk,mt8183-emi.h>
> >       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Sorry, because this header file is added on "[V7,07/13] dt-bindings:
> interconnect: add MT8183 interconnect dt-bindings".
> Should I change the order of the patchset (let the yaml pathc behind the
> header) to fixed that ?

DT headers should be part of the binding schema patch. (Or at least come first).

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Henry Chen <henryc.chen@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	James Liao <jamesjj.liao@mediatek.com>,
	Nicolas Boichat <drinkcat@google.com>,
	"open list:THERMAL" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Fan Chen <fan.chen@mediatek.com>,
	devicetree@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	Arvin Wang <arvin.wang@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Ryan Case <ryandcase@chromium.org>,
	Georgi Djakov <georgi.djakov@linaro.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V7 01/13] dt-bindings: soc: Add dvfsrc driver bindings
Date: Mon, 11 Jan 2021 09:42:54 -0600	[thread overview]
Message-ID: <CAL_Jsq+W3UL4-s6ezFJrhUYko2EBPsO9nMOGzGR1nQT3x_VtdQ@mail.gmail.com> (raw)
In-Reply-To: <1610333553.2992.7.camel@mtksdaap41>

On Sun, Jan 10, 2021 at 8:52 PM Henry Chen <henryc.chen@mediatek.com> wrote:
>
> Hi Rob,
>
> On Fri, 2021-01-08 at 20:30 -0700, Rob Herring wrote:
> > On Fri, 08 Jan 2021 15:48:03 +0800, Henry Chen wrote:
> > > Document the binding for enabling dvfsrc on MediaTek SoC.
> > >
> > > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> > > ---
> > >  .../devicetree/bindings/soc/mediatek/dvfsrc.yaml   | 67 ++++++++++++++++++++++
> > >  1 file changed, 67 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/soc/mediatek/dvfsrc.example.dts:19:18: fatal error: dt-bindings/interconnect/mtk,mt8183-emi.h: No such file or directory
> >    19 |         #include <dt-bindings/interconnect/mtk,mt8183-emi.h>
> >       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Sorry, because this header file is added on "[V7,07/13] dt-bindings:
> interconnect: add MT8183 interconnect dt-bindings".
> Should I change the order of the patchset (let the yaml pathc behind the
> header) to fixed that ?

DT headers should be part of the binding schema patch. (Or at least come first).

Rob

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Henry Chen <henryc.chen@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	James Liao <jamesjj.liao@mediatek.com>,
	Nicolas Boichat <drinkcat@google.com>,
	"open list:THERMAL" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Fan Chen <fan.chen@mediatek.com>,
	devicetree@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	Arvin Wang <arvin.wang@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Ryan Case <ryandcase@chromium.org>,
	Georgi Djakov <georgi.djakov@linaro.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V7 01/13] dt-bindings: soc: Add dvfsrc driver bindings
Date: Mon, 11 Jan 2021 09:42:54 -0600	[thread overview]
Message-ID: <CAL_Jsq+W3UL4-s6ezFJrhUYko2EBPsO9nMOGzGR1nQT3x_VtdQ@mail.gmail.com> (raw)
In-Reply-To: <1610333553.2992.7.camel@mtksdaap41>

On Sun, Jan 10, 2021 at 8:52 PM Henry Chen <henryc.chen@mediatek.com> wrote:
>
> Hi Rob,
>
> On Fri, 2021-01-08 at 20:30 -0700, Rob Herring wrote:
> > On Fri, 08 Jan 2021 15:48:03 +0800, Henry Chen wrote:
> > > Document the binding for enabling dvfsrc on MediaTek SoC.
> > >
> > > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> > > ---
> > >  .../devicetree/bindings/soc/mediatek/dvfsrc.yaml   | 67 ++++++++++++++++++++++
> > >  1 file changed, 67 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/soc/mediatek/dvfsrc.example.dts:19:18: fatal error: dt-bindings/interconnect/mtk,mt8183-emi.h: No such file or directory
> >    19 |         #include <dt-bindings/interconnect/mtk,mt8183-emi.h>
> >       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Sorry, because this header file is added on "[V7,07/13] dt-bindings:
> interconnect: add MT8183 interconnect dt-bindings".
> Should I change the order of the patchset (let the yaml pathc behind the
> header) to fixed that ?

DT headers should be part of the binding schema patch. (Or at least come first).

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-11 15:44 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08  7:48 [PATCH V7 00/13] Add driver for dvfsrc, support for active state of scpsys Henry Chen
2021-01-08  7:48 ` Henry Chen
2021-01-08  7:48 ` Henry Chen
2021-01-08  7:48 ` [PATCH V7 01/13] dt-bindings: soc: Add dvfsrc driver bindings Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-09  3:30   ` Rob Herring
2021-01-09  3:30     ` Rob Herring
2021-01-09  3:30     ` Rob Herring
2021-01-11  2:52     ` Henry Chen
2021-01-11  2:52       ` Henry Chen
2021-01-11  2:52       ` Henry Chen
2021-01-11 15:42       ` Rob Herring [this message]
2021-01-11 15:42         ` Rob Herring
2021-01-11 15:42         ` Rob Herring
2021-01-12  7:57         ` Henry Chen
2021-01-12  7:57           ` Henry Chen
2021-01-12  7:57           ` Henry Chen
2021-01-08  7:48 ` [PATCH V7 02/13] soc: mediatek: add header for mediatek SIP interface Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48 ` [PATCH V7 03/13] soc: mediatek: add driver for dvfsrc support Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48 ` [PATCH V7 04/13] soc: mediatek: add support for mt6873 Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48 ` [PATCH V7 05/13] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48 ` [PATCH V7 06/13] arm64: dts: mt8192: " Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48 ` [PATCH V7 07/13] dt-bindings: interconnect: add MT8183 interconnect dt-bindings Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48 ` [PATCH V7 08/13] dt-bindings: interconnect: add MT6873 " Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48 ` [PATCH V7 09/13] interconnect: mediatek: Add interconnect provider driver Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48 ` [PATCH V7 10/13] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48 ` [PATCH V7 11/13] arm64: dts: mt8192: " Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48 ` [PATCH V7 12/13] arm64: dts: mt8183: add dvfsrc regulator nodes Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48 ` [PATCH V7 13/13] arm64: dts: mt8192: " Henry Chen
2021-01-08  7:48   ` Henry Chen
2021-01-08  7:48   ` Henry Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_Jsq+W3UL4-s6ezFJrhUYko2EBPsO9nMOGzGR1nQT3x_VtdQ@mail.gmail.com \
    --to=robh@kernel.org \
    --cc=arvin.wang@mediatek.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@google.com \
    --cc=fan.chen@mediatek.com \
    --cc=georgi.djakov@linaro.org \
    --cc=henryc.chen@mediatek.com \
    --cc=jamesjj.liao@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=ryandcase@chromium.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.