From: Rob Herring <robh@kernel.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Bhanu Prakash Maiya <bhanumaiya@chromium.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Lee Jones <lee.jones@linaro.org>,
Furquan Shaikh <furquan@chromium.org>,
Raul E Rangel <rrangel@chromium.org>,
Eric Peers <epeers@google.com>,
Duncan Laurie <dlaurie@google.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart"
Date: Fri, 17 Jul 2020 13:02:17 -0600 [thread overview]
Message-ID: <CAL_Jsq+Xr5m4pxqbeEt+Zwb1GCWPKN1KBmdVtyKAmVFiLf=r1A@mail.gmail.com> (raw)
In-Reply-To: <3995892c-340c-3419-3c2d-934a3067f51b@collabora.com>
On Fri, Jul 17, 2020 at 3:53 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Rob,
>
> On 16/7/20 21:13, Rob Herring wrote:
> > On Wed, Jul 15, 2020 at 10:16:04PM -0700, Bhanu Prakash Maiya wrote:
> >> From: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> >>
> >> Add DT compatible string in
> >> Documentation/devicetree/bindings/mfd/cros_ec.txt
> >
> > Need to update this.
> >
> > With that,
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> >
>
> So this is an ACPI-only driver that is instantiated by using the Device Tree
> namespace link in ACPI. I am not sure how to deal with this, but I suspect we
> need a proper OF binding definition before accept it.
In that case, NAK because I have no bandwidth or desire for ACPI
stuff. The DT bindings in ACPI concept is flawed.
> The driver gets at least the baudrate and the flowcontrol from ACPI resources,
> so I'm wondering if we should also add the properties in the device-tree
> description (although we're not able to really test because there is not OF
> hardware that supports it yet). Or is fine to just accept the compatible for now
> and we can do this later when we have the possibility to test with OF-based
> hardware.
That's all defined by the serial device binding already, so it doesn't
really matter here.
You can keep my R-by, but don't send me more ACPI crap.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: devicetree@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Duncan Laurie <dlaurie@google.com>,
Raul E Rangel <rrangel@chromium.org>,
Bhanu Prakash Maiya <bhanumaiya@chromium.org>,
Benson Leung <bleung@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Furquan Shaikh <furquan@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
Lee Jones <lee.jones@linaro.org>, Eric Peers <epeers@google.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 2/2] dt-bindings: mfd: Add DT compatible string "google, cros_ec_uart"
Date: Fri, 17 Jul 2020 13:02:17 -0600 [thread overview]
Message-ID: <CAL_Jsq+Xr5m4pxqbeEt+Zwb1GCWPKN1KBmdVtyKAmVFiLf=r1A@mail.gmail.com> (raw)
In-Reply-To: <3995892c-340c-3419-3c2d-934a3067f51b@collabora.com>
On Fri, Jul 17, 2020 at 3:53 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Rob,
>
> On 16/7/20 21:13, Rob Herring wrote:
> > On Wed, Jul 15, 2020 at 10:16:04PM -0700, Bhanu Prakash Maiya wrote:
> >> From: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> >>
> >> Add DT compatible string in
> >> Documentation/devicetree/bindings/mfd/cros_ec.txt
> >
> > Need to update this.
> >
> > With that,
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> >
>
> So this is an ACPI-only driver that is instantiated by using the Device Tree
> namespace link in ACPI. I am not sure how to deal with this, but I suspect we
> need a proper OF binding definition before accept it.
In that case, NAK because I have no bandwidth or desire for ACPI
stuff. The DT bindings in ACPI concept is flawed.
> The driver gets at least the baudrate and the flowcontrol from ACPI resources,
> so I'm wondering if we should also add the properties in the device-tree
> description (although we're not able to really test because there is not OF
> hardware that supports it yet). Or is fine to just accept the compatible for now
> and we can do this later when we have the possibility to test with OF-based
> hardware.
That's all defined by the serial device binding already, so it doesn't
really matter here.
You can keep my R-by, but don't send me more ACPI crap.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-17 19:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 5:16 [PATCH v3 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" Bhanu Prakash Maiya
2020-07-16 5:16 ` [PATCH v3 2/2] dt-bindings: mfd: Add DT compatible string "google, cros_ec_uart" Bhanu Prakash Maiya
2020-07-16 19:13 ` [PATCH v3 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" Rob Herring
2020-07-16 19:13 ` Rob Herring
2020-07-17 9:53 ` Enric Balletbo i Serra
2020-07-17 9:53 ` Enric Balletbo i Serra
2020-07-17 19:02 ` Rob Herring [this message]
2020-07-17 19:02 ` [PATCH v3 2/2] dt-bindings: mfd: Add DT compatible string "google, cros_ec_uart" Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+Xr5m4pxqbeEt+Zwb1GCWPKN1KBmdVtyKAmVFiLf=r1A@mail.gmail.com' \
--to=robh@kernel.org \
--cc=bhanumaiya@chromium.org \
--cc=bleung@chromium.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dlaurie@google.com \
--cc=enric.balletbo@collabora.com \
--cc=epeers@google.com \
--cc=furquan@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=rrangel@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.