All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Dan Williams <dcbw@redhat.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Gustavo Padovan <gustavo@padovan.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Wei Xu <xuwei5@hisilicon.com>, Eyal Reizer <eyalr@ti.com>,
	Satish Patel <satish.patel@linaro.org>,
	netdev <netdev@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] bluetooth: hci_uart: add LL protocol serdev driver support
Date: Fri, 7 Apr 2017 13:48:52 -0500	[thread overview]
Message-ID: <CAL_Jsq+aM+xxbu=3v8_w9Ce+=t_pXmVWuisnckA8_8LOS-ftVA@mail.gmail.com> (raw)
In-Reply-To: <1491584978.2136.21.camel@redhat.com>

On Fri, Apr 7, 2017 at 12:09 PM, Dan Williams <dcbw@redhat.com> wrote:
> On Fri, 2017-04-07 at 09:35 -0500, Rob Herring wrote:
>> Turns out that the LL protocol and the TI-ST are the same thing
>> AFAICT.
>> The TI-ST adds firmware loading, GPIO control, and shared access for
>> NFC, FM radio, etc. For now, we're only implementing what is needed
>> for
>> BT. This mirrors other drivers like BCM and Intel, but uses the new
>> serdev bus.
>>
>> The firmware loading is greatly simplified by using existing
>> infrastructure to send commands. It may be a bit slower than the
>> original code using synchronous functions, but the real bottleneck is
>> likely doing firmware load at 115.2kbps.
>
> Is there no way to put the TI-specific stuff into a TI UART module
> rather than building it into the generic one?

In case it's not clear, all of HCI_LL is the TI specific part, not
just what I'm adding. So you are talking about putting each UART BT
protocol into a separate module. I'd assume that is doable, but seems
orthogonal to this patch set. I'd also assume there was some reason
that was not done already.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] bluetooth: hci_uart: add LL protocol serdev driver support
Date: Fri, 7 Apr 2017 13:48:52 -0500	[thread overview]
Message-ID: <CAL_Jsq+aM+xxbu=3v8_w9Ce+=t_pXmVWuisnckA8_8LOS-ftVA@mail.gmail.com> (raw)
In-Reply-To: <1491584978.2136.21.camel@redhat.com>

On Fri, Apr 7, 2017 at 12:09 PM, Dan Williams <dcbw@redhat.com> wrote:
> On Fri, 2017-04-07 at 09:35 -0500, Rob Herring wrote:
>> Turns out that the LL protocol and the TI-ST are the same thing
>> AFAICT.
>> The TI-ST adds firmware loading, GPIO control, and shared access for
>> NFC, FM radio, etc. For now, we're only implementing what is needed
>> for
>> BT. This mirrors other drivers like BCM and Intel, but uses the new
>> serdev bus.
>>
>> The firmware loading is greatly simplified by using existing
>> infrastructure to send commands. It may be a bit slower than the
>> original code using synchronous functions, but the real bottleneck is
>> likely doing firmware load at 115.2kbps.
>
> Is there no way to put the TI-specific stuff into a TI UART module
> rather than building it into the generic one?

In case it's not clear, all of HCI_LL is the TI specific part, not
just what I'm adding. So you are talking about putting each UART BT
protocol into a separate module. I'd assume that is doable, but seems
orthogonal to this patch set. I'd also assume there was some reason
that was not done already.

Rob

  reply	other threads:[~2017-04-07 18:49 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 18:30 [PATCH 0/4] TI Bluetooth serdev support Rob Herring
2017-04-05 18:30 ` Rob Herring
2017-04-05 18:30 ` Rob Herring
2017-04-05 18:30 ` [PATCH 1/4] dt-bindings: net: Add TI WiLink shared transport binding Rob Herring
2017-04-05 18:30   ` Rob Herring
     [not found] ` <20170405183005.20570-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-04-05 18:30   ` [PATCH 2/4] bluetooth: hci_uart: remove unused hci_uart_init_tty Rob Herring
2017-04-05 18:30     ` Rob Herring
2017-04-05 18:30     ` Rob Herring
2017-04-05 18:30   ` [PATCH 3/4] bluetooth: hci_uart: add LL protocol serdev driver support Rob Herring
2017-04-05 18:30     ` Rob Herring
2017-04-05 18:30     ` Rob Herring
     [not found]     ` <20170405183005.20570-4-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-04-07 14:35       ` [PATCH v2 " Rob Herring
2017-04-07 14:35         ` Rob Herring
2017-04-07 14:35         ` Rob Herring
2017-04-07 17:09         ` Dan Williams
2017-04-07 17:09           ` Dan Williams
2017-04-07 17:09           ` Dan Williams
2017-04-07 18:48           ` Rob Herring [this message]
2017-04-07 18:48             ` Rob Herring
     [not found]             ` <CAL_Jsq+aM+xxbu=3v8_w9Ce+=t_pXmVWuisnckA8_8LOS-ftVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-07 20:09               ` Dan Williams
2017-04-07 20:09                 ` Dan Williams
2017-04-07 20:09                 ` Dan Williams
2017-04-12 20:20         ` Marcel Holtmann
2017-04-12 20:20           ` Marcel Holtmann
2017-04-05 18:30   ` [PATCH 4/4] arm64: dts: hikey: add WL1835 Bluetooth device node Rob Herring
2017-04-05 18:30     ` Rob Herring
2017-04-05 18:30     ` Rob Herring
2017-04-30 15:14   ` [PATCH 0/4] TI Bluetooth serdev support Adam Ford
2017-04-30 15:14     ` Adam Ford
2017-04-30 15:14     ` Adam Ford
2017-04-30 16:04     ` Sebastian Reichel
2017-04-30 16:04       ` Sebastian Reichel
2017-04-30 16:04       ` Sebastian Reichel
2017-05-05 14:51       ` Adam Ford
2017-05-05 14:51         ` Adam Ford
2017-05-05 14:51         ` Adam Ford
2017-05-08 19:07         ` Sebastian Reichel
2017-05-08 19:07           ` Sebastian Reichel
     [not found]         ` <CAHCN7x+Mq=b6RN-ezU0400W=H=D7DR+Es1FHtT4GyozpVd8ALA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-08 21:12           ` Rob Herring
2017-05-08 21:12             ` Rob Herring
2017-05-08 21:12             ` Rob Herring
     [not found]             ` <CAL_JsqKBAPUPRtn+pEtz8B8pCrA=45RkEq6X_0i_HYoWsVmtyw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-09  4:48               ` Baruch Siach
2017-05-09  4:48                 ` Baruch Siach
2017-05-09  4:48                 ` Baruch Siach
     [not found]                 ` <20170509044837.oje2tfodytyuuuur-MwjkAAnuF3khR1HGirfZ1z4kX+cae0hd@public.gmane.org>
2017-05-09 14:14                   ` Rob Herring
2017-05-09 14:14                     ` Rob Herring
2017-05-09 14:14                     ` Rob Herring
2017-10-27 10:55                     ` Adam Ford
2017-10-27 10:55                       ` Adam Ford
2017-10-28 11:33                       ` Adam Ford
2017-10-28 11:33                         ` Adam Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_Jsq+aM+xxbu=3v8_w9Ce+=t_pXmVWuisnckA8_8LOS-ftVA@mail.gmail.com' \
    --to=robh@kernel.org \
    --cc=dcbw@redhat.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eyalr@ti.com \
    --cc=gustavo@padovan.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=satish.patel@linaro.org \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.