From: Rob Herring <robh+dt@kernel.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-omap <linux-omap@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
letux-kernel@openphoenux.org
Subject: Re: [PATCH 2/3] DT: EVM: add LEDs
Date: Thu, 29 Sep 2016 00:14:01 -0500 [thread overview]
Message-ID: <CAL_Jsq+hVD2TCubk8vGf8cS7dyLQj1o0ChnQ=MobKkV352uCSQ@mail.gmail.com> (raw)
In-Reply-To: <d68619a23d642eacf12fd0a3c51f19d006436cbe.1474953969.git.hns@goldelico.com>
On Tue, Sep 27, 2016 at 12:26 AM, H. Nikolaus Schaller
<hns@goldelico.com> wrote:
The subject gives no indication this is for OMAP. Please follow
standard patterns.
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> arch/arm/boot/dts/omap5-uevm.dts | 60 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 60 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
> index be659e8..19f5f0a 100644
> --- a/arch/arm/boot/dts/omap5-uevm.dts
> +++ b/arch/arm/boot/dts/omap5-uevm.dts
> @@ -17,6 +17,66 @@
> device_type = "memory";
> reg = <0x80000000 0x7F000000>; /* 2032 MB */
> };
> +
> + evm_leds {
> + compatible = "gpio-leds";
> +
> + led@1 {
Drop the unit address. There's no reg property.
> + label = "omap5:red:led";
> + gpios = <&gpio9 17 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "mmc0";
> + default-state = "off";
> + };
> +
> + led@2 {
> + label = "omap5:green:led";
> + gpios = <&gpio9 18 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "mmc1";
> + default-state = "off";
> + };
> +
> + led@3 {
> + label = "omap5:blue:led";
> + gpios = <&gpio9 19 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "mmc2";
> + default-state = "off";
> + };
> +
> + led@4 {
> + label = "omap5:green:led1";
> + gpios = <&gpio9 2 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "default-on";
> + default-state = "off";
> + };
> +
> + led@5 {
> + label = "omap5:green:led2";
> + gpios = <&gpio9 3 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "default-on";
> + default-state = "off";
> + };
> +
> + led@6 {
> + label = "omap5:green:led3";
> + gpios = <&gpio9 4 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + default-state = "off";
> + };
> +
> + led@7 {
> + label = "omap5:green:led4";
> + gpios = <&gpio9 5 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + default-state = "off";
> + };
> +
> + led@8 {
> + label = "omap5:green:led5";
> + gpios = <&gpio9 6 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + default-state = "off";
> + };
> + };
> };
>
> &hdmi {
> --
> 2.7.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "H. Nikolaus Schaller" <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
Cc: "Benoît Cousson"
<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"Tony Lindgren" <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Russell King" <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
linux-omap <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
letux-kernel-S0jZdbWzriLCfDggNXIi3w@public.gmane.org
Subject: Re: [PATCH 2/3] DT: EVM: add LEDs
Date: Thu, 29 Sep 2016 00:14:01 -0500 [thread overview]
Message-ID: <CAL_Jsq+hVD2TCubk8vGf8cS7dyLQj1o0ChnQ=MobKkV352uCSQ@mail.gmail.com> (raw)
In-Reply-To: <d68619a23d642eacf12fd0a3c51f19d006436cbe.1474953969.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
On Tue, Sep 27, 2016 at 12:26 AM, H. Nikolaus Schaller
<hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org> wrote:
The subject gives no indication this is for OMAP. Please follow
standard patterns.
> Signed-off-by: H. Nikolaus Schaller <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
> ---
> arch/arm/boot/dts/omap5-uevm.dts | 60 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 60 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
> index be659e8..19f5f0a 100644
> --- a/arch/arm/boot/dts/omap5-uevm.dts
> +++ b/arch/arm/boot/dts/omap5-uevm.dts
> @@ -17,6 +17,66 @@
> device_type = "memory";
> reg = <0x80000000 0x7F000000>; /* 2032 MB */
> };
> +
> + evm_leds {
> + compatible = "gpio-leds";
> +
> + led@1 {
Drop the unit address. There's no reg property.
> + label = "omap5:red:led";
> + gpios = <&gpio9 17 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "mmc0";
> + default-state = "off";
> + };
> +
> + led@2 {
> + label = "omap5:green:led";
> + gpios = <&gpio9 18 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "mmc1";
> + default-state = "off";
> + };
> +
> + led@3 {
> + label = "omap5:blue:led";
> + gpios = <&gpio9 19 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "mmc2";
> + default-state = "off";
> + };
> +
> + led@4 {
> + label = "omap5:green:led1";
> + gpios = <&gpio9 2 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "default-on";
> + default-state = "off";
> + };
> +
> + led@5 {
> + label = "omap5:green:led2";
> + gpios = <&gpio9 3 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "default-on";
> + default-state = "off";
> + };
> +
> + led@6 {
> + label = "omap5:green:led3";
> + gpios = <&gpio9 4 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + default-state = "off";
> + };
> +
> + led@7 {
> + label = "omap5:green:led4";
> + gpios = <&gpio9 5 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + default-state = "off";
> + };
> +
> + led@8 {
> + label = "omap5:green:led5";
> + gpios = <&gpio9 6 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + default-state = "off";
> + };
> + };
> };
>
> &hdmi {
> --
> 2.7.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-09-29 5:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 5:26 [PATCH 0/3] ARM: dts: omap5 uevm: add LEDs, USR1 button and EEPROM H. Nikolaus Schaller
2016-09-27 5:26 ` H. Nikolaus Schaller
2016-09-27 5:26 ` [PATCH 1/3] DT: EVM: add EEPROM H. Nikolaus Schaller
2016-09-27 5:26 ` [PATCH 2/3] DT: EVM: add LEDs H. Nikolaus Schaller
2016-09-27 5:26 ` H. Nikolaus Schaller
2016-09-27 19:49 ` Tony Lindgren
2016-09-27 19:49 ` Tony Lindgren
2016-09-27 20:10 ` H. Nikolaus Schaller
2016-09-27 20:10 ` H. Nikolaus Schaller
2016-09-28 3:37 ` Tony Lindgren
2016-09-28 6:49 ` H. Nikolaus Schaller
2016-09-28 15:12 ` Tony Lindgren
2016-09-28 15:12 ` Tony Lindgren
2016-09-28 15:28 ` H. Nikolaus Schaller
2016-09-28 16:12 ` Tony Lindgren
2016-09-28 16:12 ` Tony Lindgren
2016-09-29 5:14 ` Rob Herring [this message]
2016-09-29 5:14 ` Rob Herring
2016-09-29 5:18 ` H. Nikolaus Schaller
2016-09-29 5:20 ` H. Nikolaus Schaller
2016-09-29 5:20 ` H. Nikolaus Schaller
2016-09-27 5:26 ` [PATCH 3/3] DT: EVM: add USR1 button H. Nikolaus Schaller
2016-09-27 5:26 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+hVD2TCubk8vGf8cS7dyLQj1o0ChnQ=MobKkV352uCSQ@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.