From: Rob Herring <robh+dt@kernel.org> To: Hsin-Yi Wang <hsinyi@chromium.org> Cc: dri-devel <dri-devel@lists.freedesktop.org>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Mark Rutland <mark.rutland@arm.com>, Nicolas Boichat <drinkcat@chromium.org>, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Andrzej Hajda <a.hajda@samsung.com>, Neil Armstrong <narmstrong@baylibre.com>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@siol.net>, Philipp Zabel <p.zabel@pengutronix.de>, Enric Balletbo i Serra <enric.balletbo@collabora.com>, Matthias Brugger <mbrugger@suse.com>, Russell King <rmk+kernel@arm.linux.org.uk> Subject: Re: [PATCH RESEND 3/4] dt-bindings: drm/bridge: Add GPIO display mux binding Date: Fri, 13 Dec 2019 07:53:59 -0600 [thread overview] Message-ID: <CAL_Jsq+jkgDj6-SH1FrnjB1CQmf33=XUwN3N_fw_aJsQm3Fq9A@mail.gmail.com> (raw) In-Reply-To: <20191211061911.238393-4-hsinyi@chromium.org> On Wed, Dec 11, 2019 at 12:19 AM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > From: Nicolas Boichat <drinkcat@chromium.org> > > Add bindings for Generic GPIO mux driver. > > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > Change from RFC to v1: > - txt to yaml > --- > .../bindings/display/bridge/gpio-mux.yaml | 89 +++++++++++++++++++ > 1 file changed, 89 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/gpio-mux.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/gpio-mux.yaml b/Documentation/devicetree/bindings/display/bridge/gpio-mux.yaml > new file mode 100644 > index 000000000000..cef098749066 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/gpio-mux.yaml > @@ -0,0 +1,89 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/gpio-mux.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic display mux (1 input, 2 outputs) What makes it generic? Doesn't the mux chip have power supply, possibly a reset line or not, etc.? What about a mux where the GPIO controls the mux? Generally, we avoid 'generic' bindings because h/w is rarely generic. You can have a generic driver which works on multiple devices. > + > +maintainers: > + - Nicolas Boichat <drinkcat@chromium.org> > + > +description: | > + This bindings describes a simple display (e.g. HDMI) mux, that has 1 > + input, and 2 outputs. The mux status is controlled by hardware, and > + its status is read back using a GPIO. > + > +properties: > + compatible: > + const: gpio-display-mux > + > + detect-gpios: > + maxItems: 1 > + description: GPIO that indicates the active output > + > + ports: > + type: object > + > + properties: > + port@0: > + type: object > + description: | > + Video port for input. > + > + port@1: > + type: object > + description: | > + 2 video ports for output. > + The reg value in the endpoints matches the GPIO status: when > + GPIO is asserted, endpoint with reg value <1> is selected. You should describe 'endpoint@0' and 'endpoint@1' here too. > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - detect-gpios > + - ports > + > +examples: > + - | > + hdmi_mux: hdmi_mux { > + compatible = "gpio-display-mux"; > + status = "okay"; Don't show status in examples. > + detect-gpios = <&pio 36 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&hdmi_mux_pins>; > + ddc-i2c-bus = <&hdmiddc0>; Not documented. Is the i2c bus muxed too? If not, then this is in the wrong place. > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { /* input */ > + reg = <0>; > + > + hdmi_mux_in: endpoint { > + remote-endpoint = <&hdmi0_out>; > + }; > + }; > + > + port@1 { /* output */ > + reg = <1>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + hdmi_mux_out_anx: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&anx7688_in>; > + }; > + > + hdmi_mux_out_hdmi: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&hdmi_connector_in>; > + }; > + }; > + }; > + }; > -- > 2.24.0.525.g8f36a354ae-goog >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org> To: Hsin-Yi Wang <hsinyi@chromium.org> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Jernej Skrabec <jernej.skrabec@siol.net>, Nicolas Boichat <drinkcat@chromium.org>, Neil Armstrong <narmstrong@baylibre.com>, David Airlie <airlied@linux.ie>, Jonas Karlman <jonas@kwiboo.se>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Matthias Brugger <mbrugger@suse.com>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Enric Balletbo i Serra <enric.balletbo@collabora.com>, Russell King <rmk+kernel@arm.linux.org.uk> Subject: Re: [PATCH RESEND 3/4] dt-bindings: drm/bridge: Add GPIO display mux binding Date: Fri, 13 Dec 2019 07:53:59 -0600 [thread overview] Message-ID: <CAL_Jsq+jkgDj6-SH1FrnjB1CQmf33=XUwN3N_fw_aJsQm3Fq9A@mail.gmail.com> (raw) In-Reply-To: <20191211061911.238393-4-hsinyi@chromium.org> On Wed, Dec 11, 2019 at 12:19 AM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > From: Nicolas Boichat <drinkcat@chromium.org> > > Add bindings for Generic GPIO mux driver. > > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > Change from RFC to v1: > - txt to yaml > --- > .../bindings/display/bridge/gpio-mux.yaml | 89 +++++++++++++++++++ > 1 file changed, 89 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/gpio-mux.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/gpio-mux.yaml b/Documentation/devicetree/bindings/display/bridge/gpio-mux.yaml > new file mode 100644 > index 000000000000..cef098749066 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/gpio-mux.yaml > @@ -0,0 +1,89 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/gpio-mux.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic display mux (1 input, 2 outputs) What makes it generic? Doesn't the mux chip have power supply, possibly a reset line or not, etc.? What about a mux where the GPIO controls the mux? Generally, we avoid 'generic' bindings because h/w is rarely generic. You can have a generic driver which works on multiple devices. > + > +maintainers: > + - Nicolas Boichat <drinkcat@chromium.org> > + > +description: | > + This bindings describes a simple display (e.g. HDMI) mux, that has 1 > + input, and 2 outputs. The mux status is controlled by hardware, and > + its status is read back using a GPIO. > + > +properties: > + compatible: > + const: gpio-display-mux > + > + detect-gpios: > + maxItems: 1 > + description: GPIO that indicates the active output > + > + ports: > + type: object > + > + properties: > + port@0: > + type: object > + description: | > + Video port for input. > + > + port@1: > + type: object > + description: | > + 2 video ports for output. > + The reg value in the endpoints matches the GPIO status: when > + GPIO is asserted, endpoint with reg value <1> is selected. You should describe 'endpoint@0' and 'endpoint@1' here too. > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - detect-gpios > + - ports > + > +examples: > + - | > + hdmi_mux: hdmi_mux { > + compatible = "gpio-display-mux"; > + status = "okay"; Don't show status in examples. > + detect-gpios = <&pio 36 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&hdmi_mux_pins>; > + ddc-i2c-bus = <&hdmiddc0>; Not documented. Is the i2c bus muxed too? If not, then this is in the wrong place. > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { /* input */ > + reg = <0>; > + > + hdmi_mux_in: endpoint { > + remote-endpoint = <&hdmi0_out>; > + }; > + }; > + > + port@1 { /* output */ > + reg = <1>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + hdmi_mux_out_anx: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&anx7688_in>; > + }; > + > + hdmi_mux_out_hdmi: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&hdmi_connector_in>; > + }; > + }; > + }; > + }; > -- > 2.24.0.525.g8f36a354ae-goog > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-12-13 22:17 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-11 6:19 [PATCH RESEND 0/4] drm: bridge: anx7688 and mux drivers Hsin-Yi Wang 2019-12-11 6:19 ` Hsin-Yi Wang 2019-12-11 6:19 ` [PATCH RESEND 1/4] dt-bindings: drm/bridge: analogix-anx7688: Add ANX7688 transmitter binding Hsin-Yi Wang 2019-12-11 6:19 ` Hsin-Yi Wang 2019-12-19 20:45 ` Rob Herring 2019-12-19 20:45 ` Rob Herring 2019-12-20 3:20 ` Hsin-Yi Wang 2019-12-20 3:20 ` Hsin-Yi Wang 2019-12-20 3:22 ` Laurent Pinchart 2019-12-20 3:22 ` Laurent Pinchart 2019-12-20 3:51 ` Hsin-Yi Wang 2019-12-20 3:51 ` Hsin-Yi Wang 2019-12-11 6:19 ` [PATCH RESEND 2/4] drm: bridge: anx7688: Add anx7688 bridge driver support Hsin-Yi Wang 2019-12-11 6:19 ` Hsin-Yi Wang 2019-12-12 11:50 ` Enric Balletbo i Serra 2019-12-12 11:50 ` Enric Balletbo i Serra 2019-12-13 22:38 ` Laurent Pinchart 2019-12-13 22:38 ` Laurent Pinchart 2019-12-16 8:45 ` Hsin-Yi Wang 2019-12-16 8:45 ` Hsin-Yi Wang 2019-12-16 10:19 ` Nicolas Boichat 2019-12-16 10:19 ` Nicolas Boichat 2019-12-16 16:39 ` Laurent Pinchart 2019-12-16 16:39 ` Laurent Pinchart 2019-12-17 0:20 ` Nicolas Boichat 2019-12-17 0:40 ` Nicolas Boichat 2019-12-17 0:40 ` Nicolas Boichat 2019-12-17 0:52 ` Laurent Pinchart 2019-12-17 0:52 ` Laurent Pinchart 2019-12-17 6:04 ` Nicolas Boichat 2019-12-17 6:04 ` Nicolas Boichat 2019-12-11 6:19 ` [PATCH RESEND 3/4] dt-bindings: drm/bridge: Add GPIO display mux binding Hsin-Yi Wang 2019-12-11 6:19 ` Hsin-Yi Wang 2019-12-13 13:53 ` Rob Herring [this message] 2019-12-13 13:53 ` Rob Herring 2019-12-16 7:16 ` Hsin-Yi Wang 2019-12-16 7:16 ` Hsin-Yi Wang 2019-12-19 20:48 ` Rob Herring 2019-12-19 20:48 ` Rob Herring 2019-12-20 3:57 ` Hsin-Yi Wang 2019-12-20 3:57 ` Hsin-Yi Wang 2019-12-11 6:19 ` [PATCH RESEND 4/4] drm: bridge: Generic GPIO mux driver Hsin-Yi Wang 2019-12-11 6:19 ` Hsin-Yi Wang 2019-12-12 11:54 ` Enric Balletbo i Serra 2019-12-12 11:54 ` Enric Balletbo i Serra 2019-12-13 22:33 ` Laurent Pinchart 2019-12-13 22:33 ` Laurent Pinchart 2019-12-16 8:44 ` Hsin-Yi Wang 2019-12-16 8:44 ` Hsin-Yi Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAL_Jsq+jkgDj6-SH1FrnjB1CQmf33=XUwN3N_fw_aJsQm3Fq9A@mail.gmail.com' \ --to=robh+dt@kernel.org \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=drinkcat@chromium.org \ --cc=enric.balletbo@collabora.com \ --cc=hsinyi@chromium.org \ --cc=jernej.skrabec@siol.net \ --cc=jonas@kwiboo.se \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mbrugger@suse.com \ --cc=narmstrong@baylibre.com \ --cc=p.zabel@pengutronix.de \ --cc=rmk+kernel@arm.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.