* [PATCH] PCI: xilinx-cpm: Remove leftover bridge initialization
@ 2020-09-04 14:27 ` Lorenzo Pieralisi
0 siblings, 0 replies; 4+ messages in thread
From: Lorenzo Pieralisi @ 2020-09-04 14:27 UTC (permalink / raw)
To: linux-pci; +Cc: Lorenzo Pieralisi, Rob Herring, linux-arm-kernel
Some fields in the host bridge structure are now initialized
by default in the PCI/OF core functions therefore their
initialization in the host controller driver is superfluous.
Remove it.
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Rob Herring <robh@kernel.org>
---
drivers/pci/controller/pcie-xilinx-cpm.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/pci/controller/pcie-xilinx-cpm.c b/drivers/pci/controller/pcie-xilinx-cpm.c
index f3082de44e8a..f92e0152e65e 100644
--- a/drivers/pci/controller/pcie-xilinx-cpm.c
+++ b/drivers/pci/controller/pcie-xilinx-cpm.c
@@ -572,12 +572,8 @@ static int xilinx_cpm_pcie_probe(struct platform_device *pdev)
goto err_setup_irq;
}
- bridge->dev.parent = dev;
bridge->sysdata = port->cfg;
- bridge->busnr = port->cfg->busr.start;
bridge->ops = (struct pci_ops *)&pci_generic_ecam_ops.pci_ops;
- bridge->map_irq = of_irq_parse_and_map_pci;
- bridge->swizzle_irq = pci_common_swizzle;
err = pci_host_probe(bridge);
if (err < 0)
--
2.26.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] PCI: xilinx-cpm: Remove leftover bridge initialization
@ 2020-09-04 14:27 ` Lorenzo Pieralisi
0 siblings, 0 replies; 4+ messages in thread
From: Lorenzo Pieralisi @ 2020-09-04 14:27 UTC (permalink / raw)
To: linux-pci; +Cc: Rob Herring, Lorenzo Pieralisi, linux-arm-kernel
Some fields in the host bridge structure are now initialized
by default in the PCI/OF core functions therefore their
initialization in the host controller driver is superfluous.
Remove it.
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Rob Herring <robh@kernel.org>
---
drivers/pci/controller/pcie-xilinx-cpm.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/pci/controller/pcie-xilinx-cpm.c b/drivers/pci/controller/pcie-xilinx-cpm.c
index f3082de44e8a..f92e0152e65e 100644
--- a/drivers/pci/controller/pcie-xilinx-cpm.c
+++ b/drivers/pci/controller/pcie-xilinx-cpm.c
@@ -572,12 +572,8 @@ static int xilinx_cpm_pcie_probe(struct platform_device *pdev)
goto err_setup_irq;
}
- bridge->dev.parent = dev;
bridge->sysdata = port->cfg;
- bridge->busnr = port->cfg->busr.start;
bridge->ops = (struct pci_ops *)&pci_generic_ecam_ops.pci_ops;
- bridge->map_irq = of_irq_parse_and_map_pci;
- bridge->swizzle_irq = pci_common_swizzle;
err = pci_host_probe(bridge);
if (err < 0)
--
2.26.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: xilinx-cpm: Remove leftover bridge initialization
2020-09-04 14:27 ` Lorenzo Pieralisi
@ 2020-09-04 19:10 ` Rob Herring
-1 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-09-04 19:10 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: PCI, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Fri, Sep 4, 2020 at 8:27 AM Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> Some fields in the host bridge structure are now initialized
> by default in the PCI/OF core functions therefore their
> initialization in the host controller driver is superfluous.
>
> Remove it.
>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Rob Herring <robh@kernel.org>
> ---
> drivers/pci/controller/pcie-xilinx-cpm.c | 4 ----
> 1 file changed, 4 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: xilinx-cpm: Remove leftover bridge initialization
@ 2020-09-04 19:10 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-09-04 19:10 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: PCI, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Fri, Sep 4, 2020 at 8:27 AM Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> Some fields in the host bridge structure are now initialized
> by default in the PCI/OF core functions therefore their
> initialization in the host controller driver is superfluous.
>
> Remove it.
>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Rob Herring <robh@kernel.org>
> ---
> drivers/pci/controller/pcie-xilinx-cpm.c | 4 ----
> 1 file changed, 4 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-04 19:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-04 14:27 [PATCH] PCI: xilinx-cpm: Remove leftover bridge initialization Lorenzo Pieralisi
2020-09-04 14:27 ` Lorenzo Pieralisi
2020-09-04 19:10 ` Rob Herring
2020-09-04 19:10 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.