From: Rob Herring <robh@kernel.org>
To: Frank Rowand <frowand.list@gmail.com>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, Alan Tull <atull@kernel.org>,
Moritz Fischer <mdf@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
devicetree@vger.kernel.org, linux-fpga@vger.kernel.org
Subject: Re: [PATCH v4 04/18] powerpc/pseries: add of_node_put() in dlpar_detach_node()
Date: Fri, 19 Oct 2018 11:10:19 -0500 [thread overview]
Message-ID: <CAL_JsqJ+WW2kMHzExMrQvUCAODvOrDW3gTrJzvSUd_3n55oCwA@mail.gmail.com> (raw)
In-Reply-To: <780fb659-29e8-1ef4-4f62-97dacf36f6c8@gmail.com>
On Thu, Oct 18, 2018 at 2:09 PM Frank Rowand <frowand.list@gmail.com> wrote:
>
> On 10/18/18 10:09, Rob Herring wrote:
> > On Mon, Oct 15, 2018 at 07:37:24PM -0700, frowand.list@gmail.com wrote:
> >> From: Frank Rowand <frank.rowand@sony.com>
> >>
> >> "of: overlay: add missing of_node_get() in __of_attach_node_sysfs"
> >> added a missing of_node_get() to __of_attach_node_sysfs(). This
> >> results in a refcount imbalance for nodes attached with
> >> dlpar_attach_node(). The calling sequence from dlpar_attach_node()
> >> to __of_attach_node_sysfs() is:
> >>
> >> dlpar_attach_node()
> >> of_attach_node()
> >> __of_attach_node_sysfs()
> >
> > IIRC, there's a long standing item in the todo (Grant's) to convert the
> > open coded dlpar code. Maybe you want to do that first?
>
> I'd like to avoid extra delays to getting the current (with necesary
> fixes) series accepted because the series is rather intrusive and
> could have conflicts with other patches.
>
> I'm also worried that I don't have access to any of the systems that
> use the dynamic overlay code, and I don't have any way to test the
> changes.
Mainly I was thinking you are asking them to test changes now, so I
was thinking better to do that once than twice.
Either way is fine though.
> Can we encourage the users of this code to convert the open coded
> dlpar code?
That would be ideal...
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Frank Rowand <frowand.list@gmail.com>
Cc: devicetree@vger.kernel.org, Alan Tull <atull@kernel.org>,
linux-fpga@vger.kernel.org,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Moritz Fischer <mdf@kernel.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v4 04/18] powerpc/pseries: add of_node_put() in dlpar_detach_node()
Date: Fri, 19 Oct 2018 11:10:19 -0500 [thread overview]
Message-ID: <CAL_JsqJ+WW2kMHzExMrQvUCAODvOrDW3gTrJzvSUd_3n55oCwA@mail.gmail.com> (raw)
In-Reply-To: <780fb659-29e8-1ef4-4f62-97dacf36f6c8@gmail.com>
On Thu, Oct 18, 2018 at 2:09 PM Frank Rowand <frowand.list@gmail.com> wrote:
>
> On 10/18/18 10:09, Rob Herring wrote:
> > On Mon, Oct 15, 2018 at 07:37:24PM -0700, frowand.list@gmail.com wrote:
> >> From: Frank Rowand <frank.rowand@sony.com>
> >>
> >> "of: overlay: add missing of_node_get() in __of_attach_node_sysfs"
> >> added a missing of_node_get() to __of_attach_node_sysfs(). This
> >> results in a refcount imbalance for nodes attached with
> >> dlpar_attach_node(). The calling sequence from dlpar_attach_node()
> >> to __of_attach_node_sysfs() is:
> >>
> >> dlpar_attach_node()
> >> of_attach_node()
> >> __of_attach_node_sysfs()
> >
> > IIRC, there's a long standing item in the todo (Grant's) to convert the
> > open coded dlpar code. Maybe you want to do that first?
>
> I'd like to avoid extra delays to getting the current (with necesary
> fixes) series accepted because the series is rather intrusive and
> could have conflicts with other patches.
>
> I'm also worried that I don't have access to any of the systems that
> use the dynamic overlay code, and I don't have any way to test the
> changes.
Mainly I was thinking you are asking them to test changes now, so I
was thinking better to do that once than twice.
Either way is fine though.
> Can we encourage the users of this code to convert the open coded
> dlpar code?
That would be ideal...
Rob
next prev parent reply other threads:[~2018-10-19 16:10 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 2:37 [PATCH v4 00/18] of: overlay: validation checks, subsequent fixes frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-16 2:37 ` [PATCH v4 01/18] of: overlay: add tests to validate kfrees from overlay removal frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-17 21:30 ` Alan Tull
2018-10-17 21:30 ` Alan Tull
2018-10-17 21:30 ` Alan Tull
2018-10-18 20:24 ` Alan Tull
2018-10-18 20:24 ` Alan Tull
2018-10-18 20:24 ` Alan Tull
2018-10-18 17:03 ` Rob Herring
2018-10-18 17:03 ` Rob Herring
2018-10-18 19:01 ` Frank Rowand
2018-10-18 19:01 ` Frank Rowand
2018-10-16 2:37 ` [PATCH v4 02/18] of: overlay: add missing of_node_put() after add new node to changeset frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-18 17:05 ` Rob Herring
2018-10-18 17:05 ` Rob Herring
2018-10-18 19:02 ` Frank Rowand
2018-10-18 19:02 ` Frank Rowand
2018-10-16 2:37 ` [PATCH v4 03/18] of: overlay: add missing of_node_get() in __of_attach_node_sysfs frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-16 2:37 ` [PATCH v4 04/18] powerpc/pseries: add of_node_put() in dlpar_detach_node() frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-18 17:09 ` Rob Herring
2018-10-18 17:09 ` Rob Herring
2018-10-18 19:09 ` Frank Rowand
2018-10-18 19:09 ` Frank Rowand
2018-10-19 16:10 ` Rob Herring [this message]
2018-10-19 16:10 ` Rob Herring
2018-10-16 2:37 ` [PATCH v4 05/18] of: overlay: use prop add changeset entry for property in new nodes frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-16 2:37 ` [PATCH v4 06/18] of: overlay: do not duplicate properties from overlay for " frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-16 2:37 ` [PATCH v4 07/18] of: dynamic: change type of of_{at,de}tach_node() to void frowand.list
2018-10-16 2:37 ` [PATCH v4 07/18] of: dynamic: change type of of_{at, de}tach_node() " frowand.list
2018-10-16 2:37 ` [PATCH v4 08/18] of: overlay: reorder fields in struct fragment frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-16 2:37 ` [PATCH v4 09/18] of: overlay: validate overlay properties #address-cells and #size-cells frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-18 18:13 ` Rob Herring
2018-10-18 18:13 ` Rob Herring
2018-10-18 19:13 ` Frank Rowand
2018-10-18 19:13 ` Frank Rowand
2018-10-16 2:37 ` [PATCH v4 10/18] of: overlay: make all pr_debug() and pr_err() messages unique frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-16 2:37 ` [PATCH v4 11/18] of: overlay: test case of two fragments adding same node frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-16 2:37 ` [PATCH v4 12/18] of: overlay: check prevents multiple fragments add or delete " frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-16 2:37 ` [PATCH v4 13/18] of: overlay: check prevents multiple fragments touching same property frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-16 2:37 ` [PATCH v4 14/18] of: unittest: remove unused of_unittest_apply_overlay() argument frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-16 2:37 ` [PATCH v4 15/18] of: overlay: set node fields from properties when add new overlay node frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-16 2:37 ` [PATCH v4 16/18] of: unittest: allow base devicetree to have symbol metadata frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-16 2:37 ` [PATCH v4 17/18] of: unittest: find overlays[] entry by name instead of index frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-16 2:37 ` [PATCH v4 18/18] of: unittest: initialize args before calling of_*parse_*() frowand.list
2018-10-16 2:37 ` frowand.list
2018-10-16 9:47 ` [PATCH v4 00/18] of: overlay: validation checks, subsequent fixes Michael Ellerman
2018-10-16 9:47 ` Michael Ellerman
2018-10-17 3:08 ` Frank Rowand
2018-10-17 3:08 ` Frank Rowand
2018-10-17 21:16 ` Alan Tull
2018-10-17 21:16 ` Alan Tull
2018-10-17 21:16 ` Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJ+WW2kMHzExMrQvUCAODvOrDW3gTrJzvSUd_3n55oCwA@mail.gmail.com \
--to=robh@kernel.org \
--cc=atull@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mdf@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=pantelis.antoniou@konsulko.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.