From: Rob Herring <robh@kernel.org>
To: "Frédéric Danis" <frederic.danis.oss@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Marcel Holtmann <marcel@holtmann.org>,
Jiri Slaby <jslaby@suse.com>, Sebastian Reichel <sre@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
"Dr . H . Nikolaus Schaller" <hns@goldelico.com>,
Peter Hurley <peter@hurleysoftware.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
Loic Poulain <loic.poulain@intel.com>,
Pavel Machek <pavel@ucw.cz>, NeilBrown <neil@brown.name>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stephen Boyd <stephen.boyd@linaro.org>
Subject: Re: [PATCH v2 7/9] serdev: Introduce new bus for serial attached devices
Date: Wed, 18 Jan 2017 15:26:03 -0600 [thread overview]
Message-ID: <CAL_JsqJCg9wXA8hvo1TDPtyRN+ydMs1_S7yzwggvZAnq1aRgag@mail.gmail.com> (raw)
In-Reply-To: <09cdab76-ee1a-45da-699f-a66bf7148579@gmail.com>
On Wed, Jan 18, 2017 at 5:53 AM, Frédéric Danis
<frederic.danis.oss@gmail.com> wrote:
> Hello,
>
> Le 16/01/2017 à 23:54, Rob Herring a écrit :
>>
>> ---
>> v2:
>> - Add modalias sysfs attr and uevent hook
>
> ...
>>
>> +static int serdev_uevent(struct device *dev, struct kobj_uevent_env *env)
>> +{
>> + /* TODO: ACPI and platform modalias */
>> + return of_device_uevent_modalias(dev, env);
>> +}
>
> ...
>>
>> +static ssize_t modalias_show(struct device *dev,
>> + struct device_attribute *attr, char *buf)
>> +{
>> + ssize_t len = of_device_get_modalias(dev, buf, PAGE_SIZE - 2);
>> + buf[len] = '\n';
>> + buf[len+1] = 0;
>> + return len+1;
>> +}
>
>
> This prevents from building serdev as a module with following errors:
> ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko]
> undefined!
> ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!
Turns out, there's a fix already[1] that should be going in via Greg's tree.
Rob
[1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1299121.html
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Frédéric Danis" <frederic.danis.oss@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Marcel Holtmann <marcel@holtmann.org>,
Jiri Slaby <jslaby@suse.com>, Sebastian Reichel <sre@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
"Dr . H . Nikolaus Schaller" <hns@goldelico.com>,
Peter Hurley <peter@hurleysoftware.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
Loic Poulain <loic.poulain@intel.com>,
Pavel Machek <pavel@ucw.cz>, NeilBrown <neil@brown.name>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stephen Boyd <stephen.boyd@linaro.org>
Subject: Re: [PATCH v2 7/9] serdev: Introduce new bus for serial attached devices
Date: Wed, 18 Jan 2017 15:26:03 -0600 [thread overview]
Message-ID: <CAL_JsqJCg9wXA8hvo1TDPtyRN+ydMs1_S7yzwggvZAnq1aRgag@mail.gmail.com> (raw)
In-Reply-To: <09cdab76-ee1a-45da-699f-a66bf7148579@gmail.com>
On Wed, Jan 18, 2017 at 5:53 AM, Fr=C3=A9d=C3=A9ric Danis
<frederic.danis.oss@gmail.com> wrote:
> Hello,
>
> Le 16/01/2017 =C3=A0 23:54, Rob Herring a =C3=A9crit :
>>
>> ---
>> v2:
>> - Add modalias sysfs attr and uevent hook
>
> ...
>>
>> +static int serdev_uevent(struct device *dev, struct kobj_uevent_env *en=
v)
>> +{
>> + /* TODO: ACPI and platform modalias */
>> + return of_device_uevent_modalias(dev, env);
>> +}
>
> ...
>>
>> +static ssize_t modalias_show(struct device *dev,
>> + struct device_attribute *attr, char *buf)
>> +{
>> + ssize_t len =3D of_device_get_modalias(dev, buf, PAGE_SIZE - 2);
>> + buf[len] =3D '\n';
>> + buf[len+1] =3D 0;
>> + return len+1;
>> +}
>
>
> This prevents from building serdev as a module with following errors:
> ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko]
> undefined!
> ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefine=
d!
Turns out, there's a fix already[1] that should be going in via Greg's tree=
.
Rob
[1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1299121.ht=
ml
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "Frédéric Danis"
<frederic.danis.oss-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>,
Jiri Slaby <jslaby-IBi9RG/b67k@public.gmane.org>,
Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
"Dr . H . Nikolaus Schaller"
<hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>,
Peter Hurley
<peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>,
Andy Shevchenko
<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Alan Cox
<gnomes-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>,
Loic Poulain
<loic.poulain-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>,
NeilBrown <neil-+NVA1uvv1dVBDLzU/O5InQ@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"open list:BLUETOOTH DRIVERS"
<linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Stephen Boyd
<stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2 7/9] serdev: Introduce new bus for serial attached devices
Date: Wed, 18 Jan 2017 15:26:03 -0600 [thread overview]
Message-ID: <CAL_JsqJCg9wXA8hvo1TDPtyRN+ydMs1_S7yzwggvZAnq1aRgag@mail.gmail.com> (raw)
In-Reply-To: <09cdab76-ee1a-45da-699f-a66bf7148579-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wed, Jan 18, 2017 at 5:53 AM, Frédéric Danis
<frederic.danis.oss-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hello,
>
> Le 16/01/2017 à 23:54, Rob Herring a écrit :
>>
>> ---
>> v2:
>> - Add modalias sysfs attr and uevent hook
>
> ...
>>
>> +static int serdev_uevent(struct device *dev, struct kobj_uevent_env *env)
>> +{
>> + /* TODO: ACPI and platform modalias */
>> + return of_device_uevent_modalias(dev, env);
>> +}
>
> ...
>>
>> +static ssize_t modalias_show(struct device *dev,
>> + struct device_attribute *attr, char *buf)
>> +{
>> + ssize_t len = of_device_get_modalias(dev, buf, PAGE_SIZE - 2);
>> + buf[len] = '\n';
>> + buf[len+1] = 0;
>> + return len+1;
>> +}
>
>
> This prevents from building serdev as a module with following errors:
> ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko]
> undefined!
> ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!
Turns out, there's a fix already[1] that should be going in via Greg's tree.
Rob
[1] https://www.mail-archive.com/linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg1299121.html
next prev parent reply other threads:[~2017-01-18 21:26 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 22:54 [PATCH v2 0/9] Serial slave device bus Rob Herring
2017-01-16 22:54 ` [PATCH v2 1/9] tty: move the non-file related parts of tty_release to new tty_release_struct Rob Herring
2017-01-16 22:54 ` [PATCH v2 2/9] tty_port: allow a port to be opened with a tty that has no file handle Rob Herring
2017-01-17 14:57 ` One Thousand Gnomes
2017-01-19 13:37 ` Greg Kroah-Hartman
2017-01-19 15:05 ` Rob Herring
2017-01-19 15:23 ` Rob Herring
2017-01-16 22:54 ` [PATCH v2 3/9] tty_port: make tty_port_register_device wrap tty_port_register_device_attr Rob Herring
2017-01-16 22:54 ` [PATCH v2 4/9] tty: constify tty_ldisc_receive_buf buffer pointer Rob Herring
2017-01-19 16:24 ` Greg Kroah-Hartman
2017-01-16 22:54 ` [PATCH v2 5/9] tty_port: Add port client functions Rob Herring
2017-01-16 22:54 ` [PATCH v2 6/9] dt/bindings: Add a serial/UART attached device binding Rob Herring
2017-01-16 22:54 ` [PATCH v2 7/9] serdev: Introduce new bus for serial attached devices Rob Herring
2017-01-18 11:53 ` Frédéric Danis
2017-01-18 21:26 ` Rob Herring [this message]
2017-01-18 21:26 ` Rob Herring
2017-01-18 21:26 ` Rob Herring
2017-01-16 22:54 ` [PATCH v2 8/9] serdev: add a tty port controller driver Rob Herring
2017-01-18 12:42 ` Andy Shevchenko
2017-01-18 15:03 ` Rob Herring
2017-01-16 22:54 ` [PATCH v2 9/9] tty_port: register tty ports with serdev bus Rob Herring
2017-01-17 11:07 ` [PATCH v2 0/9] Serial slave device bus Pavel Machek
2017-01-20 1:36 ` msuchanek
2017-01-20 1:36 ` msuchanek
2017-01-20 9:50 ` Sebastian Reichel
2017-01-20 9:50 ` Sebastian Reichel
2017-01-20 13:44 ` Greg Kroah-Hartman
2017-01-20 13:44 ` Greg Kroah-Hartman
2017-01-20 13:55 ` Linus Walleij
2017-01-20 13:55 ` Linus Walleij
2017-01-20 14:14 ` Marcel Holtmann
2017-01-20 14:23 ` H. Nikolaus Schaller
2017-01-20 14:23 ` H. Nikolaus Schaller
2017-01-20 14:23 ` H. Nikolaus Schaller
2017-01-20 14:22 ` GPS drivers (was Re: [PATCH v2 0/9] Serial slave device bus) Pavel Machek
2017-01-20 15:26 ` Linus Walleij
2017-01-20 15:26 ` Linus Walleij
2017-01-20 16:16 ` Andy Shevchenko
2017-01-20 16:16 ` Andy Shevchenko
2017-01-27 20:02 ` Pavel Machek
2017-01-27 20:02 ` Pavel Machek
2017-01-20 20:23 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJCg9wXA8hvo1TDPtyRN+ydMs1_S7yzwggvZAnq1aRgag@mail.gmail.com \
--to=robh@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=frederic.danis.oss@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=jslaby@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=loic.poulain@intel.com \
--cc=marcel@holtmann.org \
--cc=neil@brown.name \
--cc=pavel@ucw.cz \
--cc=peter@hurleysoftware.com \
--cc=sre@kernel.org \
--cc=stephen.boyd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.