All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>,
	Stephen Boyd <sboyd@kernel.org>, Pavel Machek <pavel@ucw.cz>
Cc: Liviu Dudau <liviu.dudau@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux LED Subsystem <linux-leds@vger.kernel.org>,
	Michael Turquette <mturquette@baylibre.com>
Subject: Re: [PATCH 4/8] dt-bindings: clock: arm,syscon-icst: Use 'reg' instead of 'vco-offset' for VCO register address
Date: Fri, 10 Sep 2021 08:11:55 -0500	[thread overview]
Message-ID: <CAL_JsqJS2V959cbybBDHnj_X4OXiSeHocpknDN97u6r2y17PyA@mail.gmail.com> (raw)
In-Reply-To: <20210909213118.1087083-5-robh@kernel.org>

On Thu, Sep 9, 2021 at 4:31 PM Rob Herring <robh@kernel.org> wrote:
>
> 'reg' is the standard property for defining register banks/addresses. Add
> it to use for the VCO register address and deprecate 'vco-offset'. This
> will also allow for using standard node names with unit-addresses.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-clk@vger.kernel.org
> Cc: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> index 118c5543e037..c346287ca15d 100644
> --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> @@ -69,6 +69,10 @@ properties:
>        - arm,impd1-vco1
>        - arm,impd1-vco2
>
> +  reg:
> +    maxItems: 1
> +    description: The VCO register
> +
>    clocks:
>      description: Parent clock for the ICST VCO
>      maxItems: 1
> @@ -83,6 +87,7 @@ properties:
>    vco-offset:
>      $ref: '/schemas/types.yaml#/definitions/uint32'
>      description: Offset to the VCO register for the oscillator
> +    deprecated

Sigh, that should be 'deprecated: true'.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>,
	Stephen Boyd <sboyd@kernel.org>,  Pavel Machek <pavel@ucw.cz>
Cc: Liviu Dudau <liviu.dudau@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	 Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 linux-clk <linux-clk@vger.kernel.org>,
	devicetree@vger.kernel.org,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	 Linux LED Subsystem <linux-leds@vger.kernel.org>,
	Michael Turquette <mturquette@baylibre.com>
Subject: Re: [PATCH 4/8] dt-bindings: clock: arm,syscon-icst: Use 'reg' instead of 'vco-offset' for VCO register address
Date: Fri, 10 Sep 2021 08:11:55 -0500	[thread overview]
Message-ID: <CAL_JsqJS2V959cbybBDHnj_X4OXiSeHocpknDN97u6r2y17PyA@mail.gmail.com> (raw)
In-Reply-To: <20210909213118.1087083-5-robh@kernel.org>

On Thu, Sep 9, 2021 at 4:31 PM Rob Herring <robh@kernel.org> wrote:
>
> 'reg' is the standard property for defining register banks/addresses. Add
> it to use for the VCO register address and deprecate 'vco-offset'. This
> will also allow for using standard node names with unit-addresses.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-clk@vger.kernel.org
> Cc: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> index 118c5543e037..c346287ca15d 100644
> --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> @@ -69,6 +69,10 @@ properties:
>        - arm,impd1-vco1
>        - arm,impd1-vco2
>
> +  reg:
> +    maxItems: 1
> +    description: The VCO register
> +
>    clocks:
>      description: Parent clock for the ICST VCO
>      maxItems: 1
> @@ -83,6 +87,7 @@ properties:
>    vco-offset:
>      $ref: '/schemas/types.yaml#/definitions/uint32'
>      description: Offset to the VCO register for the oscillator
> +    deprecated

Sigh, that should be 'deprecated: true'.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-10 13:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09 21:31 [PATCH 0/8] Arm boards syscon 'unit_address_format' clean-ups Rob Herring
2021-09-09 21:31 ` Rob Herring
2021-09-09 21:31 ` [PATCH 1/8] dt-bindings: leds: Convert register-bit-led binding to DT schema Rob Herring
2021-09-09 21:31   ` Rob Herring
2021-09-09 21:31 ` [PATCH 2/8] dt-bindings: leds: register-bit-led: Use 'reg' instead of 'offset' Rob Herring
2021-09-09 21:31   ` Rob Herring
2021-09-09 21:31 ` [PATCH 3/8] leds: syscon: Support 'reg' in addition to 'offset' for register address Rob Herring
2021-09-09 21:31   ` Rob Herring
2021-09-09 21:31 ` [PATCH 4/8] dt-bindings: clock: arm,syscon-icst: Use 'reg' instead of 'vco-offset' for VCO " Rob Herring
2021-09-09 21:31   ` [PATCH 4/8] dt-bindings: clock: arm, syscon-icst: " Rob Herring
2021-09-10 13:11   ` Rob Herring [this message]
2021-09-10 13:11     ` [PATCH 4/8] dt-bindings: clock: arm,syscon-icst: " Rob Herring
2021-09-09 21:31 ` [PATCH 5/8] clk: versatile: clk-icst: Support 'reg' in addition to 'vco-offset' for " Rob Herring
2021-09-09 21:31   ` Rob Herring
2021-09-09 21:31 ` [PATCH 6/8] ARM: dts: arm: Update register-bit-led nodes 'reg' and node names Rob Herring
2021-09-09 21:31   ` Rob Herring
2021-09-14  8:25   ` Sudeep Holla
2021-09-14  8:25     ` Sudeep Holla
2021-09-17 23:41   ` Linus Walleij
2021-09-17 23:41     ` Linus Walleij
2021-09-09 21:31 ` [PATCH 7/8] ARM: dts: arm: Update ICST clock " Rob Herring
2021-09-09 21:31   ` Rob Herring
2021-09-09 21:31 ` [PATCH 8/8] kbuild: Enable dtc 'unit_address_format' warning by default Rob Herring
2021-09-09 21:31   ` Rob Herring
2021-09-10  0:27   ` Masahiro Yamada
2021-09-10  0:27     ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqJS2V959cbybBDHnj_X4OXiSeHocpknDN97u6r2y17PyA@mail.gmail.com \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=pavel@ucw.cz \
    --cc=sboyd@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.