* [PATCH] cpuidle: Convert to using %pOF instead of full_name
@ 2017-07-18 21:42 Rob Herring
2017-08-23 18:14 ` Rob Herring
0 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2017-07-18 21:42 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linux-kernel, devicetree, Daniel Lezcano, linux-pm
Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.
Signed-off-by: Rob Herring <robh@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-pm@vger.kernel.org
---
drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/cpuidle/dt_idle_states.c b/drivers/cpuidle/dt_idle_states.c
index ae8eb0359889..bafd4dbf55d4 100644
--- a/drivers/cpuidle/dt_idle_states.c
+++ b/drivers/cpuidle/dt_idle_states.c
@@ -53,16 +53,16 @@ static int init_state_node(struct cpuidle_state *idle_state,
err = of_property_read_u32(state_node, "entry-latency-us",
&entry_latency);
if (err) {
- pr_debug(" * %s missing entry-latency-us property\n",
- state_node->full_name);
+ pr_debug(" * %pOF missing entry-latency-us property\n",
+ state_node);
return -EINVAL;
}
err = of_property_read_u32(state_node, "exit-latency-us",
&exit_latency);
if (err) {
- pr_debug(" * %s missing exit-latency-us property\n",
- state_node->full_name);
+ pr_debug(" * %pOF missing exit-latency-us property\n",
+ state_node);
return -EINVAL;
}
/*
@@ -75,8 +75,8 @@ static int init_state_node(struct cpuidle_state *idle_state,
err = of_property_read_u32(state_node, "min-residency-us",
&idle_state->target_residency);
if (err) {
- pr_debug(" * %s missing min-residency-us property\n",
- state_node->full_name);
+ pr_debug(" * %pOF missing min-residency-us property\n",
+ state_node);
return -EINVAL;
}
@@ -186,8 +186,8 @@ int dt_init_idle_driver(struct cpuidle_driver *drv,
}
if (!idle_state_valid(state_node, i, cpumask)) {
- pr_warn("%s idle state not valid, bailing out\n",
- state_node->full_name);
+ pr_warn("%pOF idle state not valid, bailing out\n",
+ state_node);
err = -EINVAL;
break;
}
@@ -200,8 +200,8 @@ int dt_init_idle_driver(struct cpuidle_driver *drv,
idle_state = &drv->states[state_idx++];
err = init_state_node(idle_state, matches, state_node);
if (err) {
- pr_err("Parsing idle state node %s failed with err %d\n",
- state_node->full_name, err);
+ pr_err("Parsing idle state node %pOF failed with err %d\n",
+ state_node, err);
err = -EINVAL;
break;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] cpuidle: Convert to using %pOF instead of full_name
@ 2017-08-23 18:14 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2017-08-23 18:14 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linux-kernel, devicetree, Daniel Lezcano, linux-pm
On Tue, Jul 18, 2017 at 4:42 PM, Rob Herring <robh@kernel.org> wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: linux-pm@vger.kernel.org
> ---
> drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
Rafael, Ping. Please apply this one and 2 others for cpufreq and
PM-domains which haven't been applied yet.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cpuidle: Convert to using %pOF instead of full_name
@ 2017-08-23 18:14 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2017-08-23 18:14 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Daniel Lezcano,
linux-pm-u79uwXL29TY76Z2rM5mHXA
On Tue, Jul 18, 2017 at 4:42 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: "Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>
> Cc: Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> ---
> drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
Rafael, Ping. Please apply this one and 2 others for cpufreq and
PM-domains which haven't been applied yet.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cpuidle: Convert to using %pOF instead of full_name
2017-08-23 18:14 ` Rob Herring
(?)
@ 2017-08-23 20:34 ` Rafael J. Wysocki
2017-08-23 20:49 ` Rob Herring
-1 siblings, 1 reply; 8+ messages in thread
From: Rafael J. Wysocki @ 2017-08-23 20:34 UTC (permalink / raw)
To: Rob Herring
Cc: Rafael J. Wysocki, linux-kernel, devicetree, Daniel Lezcano, linux-pm
On Wed, Aug 23, 2017 at 8:14 PM, Rob Herring <robh@kernel.org> wrote:
> On Tue, Jul 18, 2017 at 4:42 PM, Rob Herring <robh@kernel.org> wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>> of the full path string for each node.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>> Cc: linux-pm@vger.kernel.org
>> ---
>> drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
>> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> Rafael, Ping. Please apply this one and 2 others for cpufreq and
> PM-domains which haven't been applied yet.
I thought that these would go in through the DT tree.
I'll try to find them, but next time please make it clear how you want
to route things.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cpuidle: Convert to using %pOF instead of full_name
@ 2017-08-23 20:49 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2017-08-23 20:49 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Rob Herring, Rafael J. Wysocki, linux-kernel, devicetree,
Daniel Lezcano, linux-pm
On Wed, Aug 23, 2017 at 3:34 PM, Rafael J. Wysocki <rafael@kernel.org> wrote:
> On Wed, Aug 23, 2017 at 8:14 PM, Rob Herring <robh@kernel.org> wrote:
>> On Tue, Jul 18, 2017 at 4:42 PM, Rob Herring <robh@kernel.org> wrote:
>>> Now that we have a custom printf format specifier, convert users of
>>> full_name to use %pOF instead. This is preparation to remove storing
>>> of the full path string for each node.
>>>
>>> Signed-off-by: Rob Herring <robh@kernel.org>
>>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
>>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> Cc: linux-pm@vger.kernel.org
>>> ---
>>> drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
>>> 1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> Rafael, Ping. Please apply this one and 2 others for cpufreq and
>> PM-domains which haven't been applied yet.
>
> I thought that these would go in through the DT tree.
>
> I'll try to find them, but next time please make it clear how you want
> to route things.
Sorry, I thought addressed TO you and not in a series was enough to imply that.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cpuidle: Convert to using %pOF instead of full_name
@ 2017-08-23 20:49 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2017-08-23 20:49 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Rob Herring, Rafael J. Wysocki,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Daniel Lezcano,
linux-pm-u79uwXL29TY76Z2rM5mHXA
On Wed, Aug 23, 2017 at 3:34 PM, Rafael J. Wysocki <rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Wed, Aug 23, 2017 at 8:14 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>> On Tue, Jul 18, 2017 at 4:42 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>>> Now that we have a custom printf format specifier, convert users of
>>> full_name to use %pOF instead. This is preparation to remove storing
>>> of the full path string for each node.
>>>
>>> Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>>> Cc: "Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>
>>> Cc: Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>> Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>> ---
>>> drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
>>> 1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> Rafael, Ping. Please apply this one and 2 others for cpufreq and
>> PM-domains which haven't been applied yet.
>
> I thought that these would go in through the DT tree.
>
> I'll try to find them, but next time please make it clear how you want
> to route things.
Sorry, I thought addressed TO you and not in a series was enough to imply that.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cpuidle: Convert to using %pOF instead of full_name
@ 2017-08-23 20:53 ` Rafael J. Wysocki
0 siblings, 0 replies; 8+ messages in thread
From: Rafael J. Wysocki @ 2017-08-23 20:53 UTC (permalink / raw)
To: Rob Herring
Cc: Rafael J. Wysocki, linux-kernel, devicetree, Daniel Lezcano, linux-pm
On Wednesday, August 23, 2017 10:49:00 PM CEST Rob Herring wrote:
> On Wed, Aug 23, 2017 at 3:34 PM, Rafael J. Wysocki <rafael@kernel.org> wrote:
> > On Wed, Aug 23, 2017 at 8:14 PM, Rob Herring <robh@kernel.org> wrote:
> >> On Tue, Jul 18, 2017 at 4:42 PM, Rob Herring <robh@kernel.org> wrote:
> >>> Now that we have a custom printf format specifier, convert users of
> >>> full_name to use %pOF instead. This is preparation to remove storing
> >>> of the full path string for each node.
> >>>
> >>> Signed-off-by: Rob Herring <robh@kernel.org>
> >>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> >>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> >>> Cc: linux-pm@vger.kernel.org
> >>> ---
> >>> drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
> >>> 1 file changed, 10 insertions(+), 10 deletions(-)
> >>
> >> Rafael, Ping. Please apply this one and 2 others for cpufreq and
> >> PM-domains which haven't been applied yet.
> >
> > I thought that these would go in through the DT tree.
> >
> > I'll try to find them, but next time please make it clear how you want
> > to route things.
>
> Sorry, I thought addressed TO you and not in a series was enough to imply that.
Well, Patchwork doesn't tell me who the patch was addressed to. :-)
Thanks,
Rafael
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cpuidle: Convert to using %pOF instead of full_name
@ 2017-08-23 20:53 ` Rafael J. Wysocki
0 siblings, 0 replies; 8+ messages in thread
From: Rafael J. Wysocki @ 2017-08-23 20:53 UTC (permalink / raw)
To: Rob Herring
Cc: Rafael J. Wysocki, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Daniel Lezcano,
linux-pm-u79uwXL29TY76Z2rM5mHXA
On Wednesday, August 23, 2017 10:49:00 PM CEST Rob Herring wrote:
> On Wed, Aug 23, 2017 at 3:34 PM, Rafael J. Wysocki <rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > On Wed, Aug 23, 2017 at 8:14 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> >> On Tue, Jul 18, 2017 at 4:42 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> >>> Now that we have a custom printf format specifier, convert users of
> >>> full_name to use %pOF instead. This is preparation to remove storing
> >>> of the full path string for each node.
> >>>
> >>> Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> >>> Cc: "Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>
> >>> Cc: Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> >>> Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> >>> ---
> >>> drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
> >>> 1 file changed, 10 insertions(+), 10 deletions(-)
> >>
> >> Rafael, Ping. Please apply this one and 2 others for cpufreq and
> >> PM-domains which haven't been applied yet.
> >
> > I thought that these would go in through the DT tree.
> >
> > I'll try to find them, but next time please make it clear how you want
> > to route things.
>
> Sorry, I thought addressed TO you and not in a series was enough to imply that.
Well, Patchwork doesn't tell me who the patch was addressed to. :-)
Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-08-23 21:02 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-18 21:42 [PATCH] cpuidle: Convert to using %pOF instead of full_name Rob Herring
2017-08-23 18:14 ` Rob Herring
2017-08-23 18:14 ` Rob Herring
2017-08-23 20:34 ` Rafael J. Wysocki
2017-08-23 20:49 ` Rob Herring
2017-08-23 20:49 ` Rob Herring
2017-08-23 20:53 ` Rafael J. Wysocki
2017-08-23 20:53 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.