All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Maxime Ripard" <maxime.ripard@bootlin.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Frank Rowand" <frowand.list@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@st.com>,
	netdev <netdev@vger.kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
	"Antoine Ténart" <antoine.tenart@bootlin.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: Re: [PATCH v2 05/11] dt-bindings: net: sun4i-emac: Convert the binding to a schemas
Date: Mon, 10 Jun 2019 12:59:29 -0600	[thread overview]
Message-ID: <CAL_JsqJahCJcdu=+fA=ewbGezuEJ2W6uwMVxkQpdY6w+1OWVVA@mail.gmail.com> (raw)
In-Reply-To: <20190610143139.GG28724@lunn.ch>

On Mon, Jun 10, 2019 at 8:31 AM Andrew Lunn <andrew@lunn.ch> wrote:
>
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +  - phy
> > +  - allwinner,sram
>
> Quoting ethernet.txt:
>
> - phy: the same as "phy-handle" property, not recommended for new bindings.
>
> - phy-handle: phandle, specifies a reference to a node representing a PHY
>   device; this property is described in the Devicetree Specification and so
>   preferred;
>
> Can this be expressed in Yaml? Accept phy, but give a warning. Accept
> phy-handle without a warning? Enforce that one or the other is
> present?

The common schema could have 'phy: false'. This works as long as we've
updated (or plan to) all the dts files to use phy-handle. The issue is
how far back do you need kernels to work with newer dtbs.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@st.com>,
	"Maxime Ripard" <maxime.ripard@bootlin.com>,
	netdev <netdev@vger.kernel.org>,
	linux-stm32@st-md-mailman.stormreply.com,
	"Antoine Ténart" <antoine.tenart@bootlin.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
	"Frank Rowand" <frowand.list@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: Re: [PATCH v2 05/11] dt-bindings: net: sun4i-emac: Convert the binding to a schemas
Date: Mon, 10 Jun 2019 12:59:29 -0600	[thread overview]
Message-ID: <CAL_JsqJahCJcdu=+fA=ewbGezuEJ2W6uwMVxkQpdY6w+1OWVVA@mail.gmail.com> (raw)
In-Reply-To: <20190610143139.GG28724@lunn.ch>

On Mon, Jun 10, 2019 at 8:31 AM Andrew Lunn <andrew@lunn.ch> wrote:
>
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +  - phy
> > +  - allwinner,sram
>
> Quoting ethernet.txt:
>
> - phy: the same as "phy-handle" property, not recommended for new bindings.
>
> - phy-handle: phandle, specifies a reference to a node representing a PHY
>   device; this property is described in the Devicetree Specification and so
>   preferred;
>
> Can this be expressed in Yaml? Accept phy, but give a warning. Accept
> phy-handle without a warning? Enforce that one or the other is
> present?

The common schema could have 'phy: false'. This works as long as we've
updated (or plan to) all the dts files to use phy-handle. The issue is
how far back do you need kernels to work with newer dtbs.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-06-10 18:59 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10  9:25 [PATCH v2 01/11] dt-bindings: net: Add YAML schemas for the generic Ethernet options Maxime Ripard
2019-06-10  9:25 ` Maxime Ripard
2019-06-10  9:25 ` [PATCH v2 02/11] dt-bindings: net: Add a YAML schemas for the generic PHY options Maxime Ripard
2019-06-10  9:25   ` Maxime Ripard
2019-06-10  9:25   ` Maxime Ripard
2019-06-10 14:23   ` Andrew Lunn
2019-06-10 14:23     ` Andrew Lunn
2019-06-10 19:05   ` Rob Herring
2019-06-10 19:05     ` Rob Herring
2019-06-10  9:25 ` [PATCH v2 03/11] MAINTAINERS: Add Ethernet PHY YAML file Maxime Ripard
2019-06-10  9:25   ` Maxime Ripard
2019-06-10 14:24   ` Andrew Lunn
2019-06-10 14:24     ` Andrew Lunn
2019-06-10  9:25 ` [PATCH v2 04/11] dt-bindings: net: phy: The interrupt property is not mandatory Maxime Ripard
2019-06-10  9:25   ` Maxime Ripard
2019-06-10 14:25   ` Andrew Lunn
2019-06-10 14:25     ` Andrew Lunn
2019-06-10 19:05   ` Rob Herring
2019-06-10 19:05     ` Rob Herring
2019-06-10  9:25 ` [PATCH v2 05/11] dt-bindings: net: sun4i-emac: Convert the binding to a schemas Maxime Ripard
2019-06-10  9:25   ` Maxime Ripard
2019-06-10 14:31   ` Andrew Lunn
2019-06-10 14:31     ` Andrew Lunn
2019-06-10 14:31     ` Andrew Lunn
2019-06-10 14:55     ` Maxime Ripard
2019-06-10 14:55       ` Maxime Ripard
2019-06-10 14:55       ` Maxime Ripard
2019-06-10 18:59     ` Rob Herring [this message]
2019-06-10 18:59       ` Rob Herring
2019-06-11 14:58       ` Maxime Ripard
2019-06-11 14:58         ` Maxime Ripard
2019-06-13 17:32         ` Rob Herring
2019-06-13 17:32           ` Rob Herring
2019-06-14  9:50           ` Maxime Ripard
2019-06-14  9:50             ` Maxime Ripard
2019-06-14  9:50             ` Maxime Ripard
2019-06-14 13:37             ` Rob Herring
2019-06-14 13:37               ` Rob Herring
2019-06-14 14:59               ` Maxime Ripard
2019-06-14 14:59                 ` Maxime Ripard
2019-06-14 14:59                 ` Maxime Ripard
2019-06-10  9:25 ` [PATCH v2 06/11] dt-bindings: net: sun4i-mdio: " Maxime Ripard
2019-06-10  9:25   ` Maxime Ripard
2019-06-10 14:37   ` Andrew Lunn
2019-06-10 14:37     ` Andrew Lunn
2019-06-10 14:37     ` Andrew Lunn
2019-06-11  9:53     ` Maxime Ripard
2019-06-11  9:53       ` Maxime Ripard
2019-06-11  9:53       ` Maxime Ripard
2019-06-10  9:25 ` [PATCH v2 07/11] dt-bindings: net: stmmac: " Maxime Ripard
2019-06-10  9:25   ` Maxime Ripard
2019-06-10 19:13   ` Rob Herring
2019-06-10 19:13     ` Rob Herring
2019-06-11 11:28     ` Maxime Ripard
2019-06-11 11:28       ` Maxime Ripard
2019-06-10  9:25 ` [PATCH v2 08/11] dt-bindings: net: sun7i-gmac: " Maxime Ripard
2019-06-10  9:25   ` Maxime Ripard
2019-06-10 19:14   ` Rob Herring
2019-06-10 19:14     ` Rob Herring
2019-06-10 19:14     ` Rob Herring
2019-06-10  9:25 ` [PATCH v2 09/11] dt-bindings: net: sun8i-emac: " Maxime Ripard
2019-06-10  9:25   ` Maxime Ripard
2019-06-10 19:22   ` Rob Herring
2019-06-10 19:22     ` Rob Herring
2019-06-11 11:31     ` Maxime Ripard
2019-06-11 11:31       ` Maxime Ripard
2019-06-11 11:31       ` Maxime Ripard
2019-06-10  9:25 ` [PATCH v2 10/11] dt-bindings: net: dwmac: Deprecate the PHY reset properties Maxime Ripard
2019-06-10  9:25   ` Maxime Ripard
2019-06-10 15:50   ` Martin Blumenstingl
2019-06-10 15:50     ` Martin Blumenstingl
2019-06-10 15:50     ` Martin Blumenstingl
2019-06-10  9:25 ` [PATCH v2 11/11] ARM: dts: sunxi: Switch to the generic PHY properties Maxime Ripard
2019-06-10  9:25   ` Maxime Ripard
2019-06-10 14:52   ` Andrew Lunn
2019-06-10 14:52     ` Andrew Lunn
2019-06-11 10:08   ` Chen-Yu Tsai
2019-06-11 10:08     ` Chen-Yu Tsai
2019-06-10 19:02 ` [PATCH v2 01/11] dt-bindings: net: Add YAML schemas for the generic Ethernet options Rob Herring
2019-06-10 19:02   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_JsqJahCJcdu=+fA=ewbGezuEJ2W6uwMVxkQpdY6w+1OWVVA@mail.gmail.com' \
    --to=robh+dt@kernel.org \
    --cc=alexandre.torgue@st.com \
    --cc=andrew@lunn.ch \
    --cc=antoine.tenart@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=frowand.list@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mark.rutland@arm.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.