All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	"open list:GENERIC PHY FRAMEWORK" <linux-phy@lists.infradead.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: phy: renesas,rcar-gen2-usb-phy: Convert to json-schema
Date: Tue, 17 May 2022 08:57:11 -0500	[thread overview]
Message-ID: <CAL_JsqJo-p+bh6VOKANq8pmMPbm1vZwmHt73yYaEhe9GfQ50dw@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdWnvYx93Xo4XHRi3vv8c1OCvX7zqGswHApRnc7VYM+X4g@mail.gmail.com>

On Tue, May 17, 2022 at 1:59 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Rob,
>
> On Tue, May 17, 2022 at 3:04 AM Rob Herring <robh@kernel.org> wrote:
> > On Mon, May 09, 2022 at 02:41:38PM +0200, Geert Uytterhoeven wrote:
> > > Convert the Renesas R-Car Gen2 USB PHY Device Tree binding documentation
> > > to json-schema.
> > >
> > > Add missing properties.
> > > Drop the second example, as it doesn't add any value.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > Validation gives:
> > >
> > >     Documentation/devicetree/bindings/phy/renesas,rcar-gen2-usb-phy.example.dtb: usb
> > >     -phy@e6590100: '#phy-cells' is a required property
> > >           From schema: dt-schema/dtschema/schemas/phy/phy-provider.yaml
> > >
> > > The latter considers '#phy-cells' a required property, as the node name
> > > matches "usb-phy".  But in this binding the actual PHY providers are the
> > > child nodes.
> > >
> > > Is there a way to fix this? Overriding "#phy-cells" to "false" doesn't
> > > work.
> > > Should all nodes and child nodes be renamed? The (Linux) driver doesn't
> > > care about the names of the children.
> >
> > There's an open issue in dtschema for this. I don't have an answer other
> > than don't use 'phy' in the parent node name.
>
> IC...
>
> > > ---
> > > This is the final conversion to json-schema of DT bindings for Renesas
> > > ARM SoCs, hurray!
> >
> > Great, certainly looking better than some! My tracking in linux-next
> > gives me this:
> >
> > For arm:
> >
> > Processing (r7|r8|r9|emev2|sh73a|gr-|iwg):
> > warnings: 283
> > undocumented compat: 32
> >
> > arch/arm/boot/dts/(r7|r8|r9|emev2|sh73a|gr-|iwg):32
> > ['ams,as3711']
>
> Board component
>
> > ['arm,coresight-etm3x']
>
> ARM core
>
> > ['dlg,da9063-onkey']
> > ['dlg,da9063-rtc']
> > ['dlg,da9063-watchdog']
> > ['dlg,da9063l']
> > ['dlg,da9210']
>
> Board components
>
> > ['i2c-demux-pinctrl']
>
> I2C framework
>
> > ['renesas,pci-r8a7742', 'renesas,pci-rcar-gen2']
> > ['renesas,pci-r8a7743', 'renesas,pci-rcar-gen2']
> > ['renesas,pci-r8a7744', 'renesas,pci-rcar-gen2']
> > ['renesas,pci-r8a7745', 'renesas,pci-rcar-gen2']
> > ['renesas,pci-r8a7790', 'renesas,pci-rcar-gen2']
> > ['renesas,pci-r8a7791', 'renesas,pci-rcar-gen2']
> > ['renesas,pci-r8a7794', 'renesas,pci-rcar-gen2']
> > ['renesas,pci-r9a06g032', 'renesas,pci-rzn1']
>
> https://lore.kernel.org/r/20220429134143.628428-3-herve.codina@bootlin.com
>
> > ['renesas,r2a11302ft']
>
> I2C device without bindings or upstream driver.
>
> > ['renesas,r9a06g032-dma', 'renesas,rzn1-dma']
>
> https://lore.kernel.org/r/20220427095653.91804-2-miquel.raynal@bootlin.com
>
> > ['renesas,r9a06g032-rtc', 'renesas,rzn1-rtc']
>
> https://lore.kernel.org/r/20220512143920.238987-2-miquel.raynal@bootlin.com
>
> > ['renesas,r9a06g032-wdt', 'renesas,rzn1-wdt']
>
> https://lore.kernel.org/r/20220413082527.155740-2-jjhiblot@traphandler.com
>
> > ['renesas,rzn1-dmamux']
>
> https://lore.kernel.org/r/20220421085112.78858-2-miquel.raynal@bootlin.com
>
> > ['renesas,usb-phy-r8a7742', 'renesas,rcar-gen2-usb-phy']
> > ['renesas,usb-phy-r8a7743', 'renesas,rcar-gen2-usb-phy']
> > ['renesas,usb-phy-r8a7744', 'renesas,rcar-gen2-usb-phy']
> > ['renesas,usb-phy-r8a7745', 'renesas,rcar-gen2-usb-phy']
> > ['renesas,usb-phy-r8a77470', 'renesas,rcar-gen2-usb-phy']
> > ['renesas,usb-phy-r8a7790', 'renesas,rcar-gen2-usb-phy']
> > ['renesas,usb-phy-r8a7791', 'renesas,rcar-gen2-usb-phy']
> > ['renesas,usb-phy-r8a7794', 'renesas,rcar-gen2-usb-phy']
>
> This patch.
>
> > ['sil,sii9022']
>
> https://lore.kernel.org/r/3b2619682694050696e5c85269ccc4f864590e66.1638540704.git.geert+renesas@glider.be
>
> > ['st,stmpe-ts']
> > ['st,stmpe811']
>
> Board components
>
> >
> > For arm64:
> >
> > Processing renesas:
> > warnings: 312
> > undocumented compat: 15
> >
> > undocumented here means no schema.
> >
> > arch/arm64/boot/dts/renesas:15
> > ['ilitek,ili2117']
>
> https://lore.kernel.org/r/0c5f06c9d262c1720b40d068b6eefe58ca406601.1638539806.git.geert+renesas@glider.be
>
> > ['micron,mt25qu512a', 'jedec,spi-nor']
>
> Board component
>
> > ['nxp,tda998x']
>
> https://lore.kernel.org/r/1f6bf58d76efc2e869b800534b818d1451ef98a2.1634822085.git.geert+renesas@glider.be
>
> > ['ovti,ov5645']
>
> Board component
>
> > ['renesas,r8a7795-mlp', 'renesas,rcar-gen3-mlp']
> > ['renesas,r8a7796-mlp', 'renesas,rcar-gen3-mlp']
> > ['renesas,r8a77961-mlp', 'renesas,rcar-gen3-mlp']
> > ['renesas,r8a77965-mlp', 'renesas,rcar-gen3-mlp']
> > ['renesas,r8a77990-mlp', 'renesas,rcar-gen3-mlp']
> > ['renesas,r8a77995-mlp', 'renesas,rcar-gen3-mlp']
>
> Driver in staging without any bindings
>
> > ['renesas,r9a07g043-ssi', 'renesas,rz-ssi']
>
> https://lore.kernel.org/r/20220423133154.141027-1-biju.das.jz@bp.renesas.com
>
> > ['renesas,r9a07g043-tsu', 'renesas,rzg2l-tsu']
>
> https://lore.kernel.org/r/20220501081930.23743-1-biju.das.jz@bp.renesas.com
>
> > ['renesas,r9a07g043-usbphy-ctrl', 'renesas,rzg2l-usbphy-ctrl']
>
> https://lore.kernel.org/r/20220423134601.141975-1-biju.das.jz@bp.renesas.com
>
> > ['renesas,r9a07g043-wdt', 'renesas,rzg2l-wdt']
>
> https://lore.kernel.org/r/20220424071323.151757-1-biju.das.jz@bp.renesas.com
>
> > ['ti,pcm3168a']
>
> Board component
>
> > I guess board level components don't count and some might be pending.
>
> Some have been pending (or blocked) for a long time...

Can you tell me which ones and I can apply them. If they have my tag
already, then I tend to ignore them.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	 Wolfram Sang <wsa+renesas@sang-engineering.com>,
	 "open list:GENERIC PHY FRAMEWORK"
	<linux-phy@lists.infradead.org>,
	 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	 Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: phy: renesas, rcar-gen2-usb-phy: Convert to json-schema
Date: Tue, 17 May 2022 08:57:11 -0500	[thread overview]
Message-ID: <CAL_JsqJo-p+bh6VOKANq8pmMPbm1vZwmHt73yYaEhe9GfQ50dw@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdWnvYx93Xo4XHRi3vv8c1OCvX7zqGswHApRnc7VYM+X4g@mail.gmail.com>

On Tue, May 17, 2022 at 1:59 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Rob,
>
> On Tue, May 17, 2022 at 3:04 AM Rob Herring <robh@kernel.org> wrote:
> > On Mon, May 09, 2022 at 02:41:38PM +0200, Geert Uytterhoeven wrote:
> > > Convert the Renesas R-Car Gen2 USB PHY Device Tree binding documentation
> > > to json-schema.
> > >
> > > Add missing properties.
> > > Drop the second example, as it doesn't add any value.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > Validation gives:
> > >
> > >     Documentation/devicetree/bindings/phy/renesas,rcar-gen2-usb-phy.example.dtb: usb
> > >     -phy@e6590100: '#phy-cells' is a required property
> > >           From schema: dt-schema/dtschema/schemas/phy/phy-provider.yaml
> > >
> > > The latter considers '#phy-cells' a required property, as the node name
> > > matches "usb-phy".  But in this binding the actual PHY providers are the
> > > child nodes.
> > >
> > > Is there a way to fix this? Overriding "#phy-cells" to "false" doesn't
> > > work.
> > > Should all nodes and child nodes be renamed? The (Linux) driver doesn't
> > > care about the names of the children.
> >
> > There's an open issue in dtschema for this. I don't have an answer other
> > than don't use 'phy' in the parent node name.
>
> IC...
>
> > > ---
> > > This is the final conversion to json-schema of DT bindings for Renesas
> > > ARM SoCs, hurray!
> >
> > Great, certainly looking better than some! My tracking in linux-next
> > gives me this:
> >
> > For arm:
> >
> > Processing (r7|r8|r9|emev2|sh73a|gr-|iwg):
> > warnings: 283
> > undocumented compat: 32
> >
> > arch/arm/boot/dts/(r7|r8|r9|emev2|sh73a|gr-|iwg):32
> > ['ams,as3711']
>
> Board component
>
> > ['arm,coresight-etm3x']
>
> ARM core
>
> > ['dlg,da9063-onkey']
> > ['dlg,da9063-rtc']
> > ['dlg,da9063-watchdog']
> > ['dlg,da9063l']
> > ['dlg,da9210']
>
> Board components
>
> > ['i2c-demux-pinctrl']
>
> I2C framework
>
> > ['renesas,pci-r8a7742', 'renesas,pci-rcar-gen2']
> > ['renesas,pci-r8a7743', 'renesas,pci-rcar-gen2']
> > ['renesas,pci-r8a7744', 'renesas,pci-rcar-gen2']
> > ['renesas,pci-r8a7745', 'renesas,pci-rcar-gen2']
> > ['renesas,pci-r8a7790', 'renesas,pci-rcar-gen2']
> > ['renesas,pci-r8a7791', 'renesas,pci-rcar-gen2']
> > ['renesas,pci-r8a7794', 'renesas,pci-rcar-gen2']
> > ['renesas,pci-r9a06g032', 'renesas,pci-rzn1']
>
> https://lore.kernel.org/r/20220429134143.628428-3-herve.codina@bootlin.com
>
> > ['renesas,r2a11302ft']
>
> I2C device without bindings or upstream driver.
>
> > ['renesas,r9a06g032-dma', 'renesas,rzn1-dma']
>
> https://lore.kernel.org/r/20220427095653.91804-2-miquel.raynal@bootlin.com
>
> > ['renesas,r9a06g032-rtc', 'renesas,rzn1-rtc']
>
> https://lore.kernel.org/r/20220512143920.238987-2-miquel.raynal@bootlin.com
>
> > ['renesas,r9a06g032-wdt', 'renesas,rzn1-wdt']
>
> https://lore.kernel.org/r/20220413082527.155740-2-jjhiblot@traphandler.com
>
> > ['renesas,rzn1-dmamux']
>
> https://lore.kernel.org/r/20220421085112.78858-2-miquel.raynal@bootlin.com
>
> > ['renesas,usb-phy-r8a7742', 'renesas,rcar-gen2-usb-phy']
> > ['renesas,usb-phy-r8a7743', 'renesas,rcar-gen2-usb-phy']
> > ['renesas,usb-phy-r8a7744', 'renesas,rcar-gen2-usb-phy']
> > ['renesas,usb-phy-r8a7745', 'renesas,rcar-gen2-usb-phy']
> > ['renesas,usb-phy-r8a77470', 'renesas,rcar-gen2-usb-phy']
> > ['renesas,usb-phy-r8a7790', 'renesas,rcar-gen2-usb-phy']
> > ['renesas,usb-phy-r8a7791', 'renesas,rcar-gen2-usb-phy']
> > ['renesas,usb-phy-r8a7794', 'renesas,rcar-gen2-usb-phy']
>
> This patch.
>
> > ['sil,sii9022']
>
> https://lore.kernel.org/r/3b2619682694050696e5c85269ccc4f864590e66.1638540704.git.geert+renesas@glider.be
>
> > ['st,stmpe-ts']
> > ['st,stmpe811']
>
> Board components
>
> >
> > For arm64:
> >
> > Processing renesas:
> > warnings: 312
> > undocumented compat: 15
> >
> > undocumented here means no schema.
> >
> > arch/arm64/boot/dts/renesas:15
> > ['ilitek,ili2117']
>
> https://lore.kernel.org/r/0c5f06c9d262c1720b40d068b6eefe58ca406601.1638539806.git.geert+renesas@glider.be
>
> > ['micron,mt25qu512a', 'jedec,spi-nor']
>
> Board component
>
> > ['nxp,tda998x']
>
> https://lore.kernel.org/r/1f6bf58d76efc2e869b800534b818d1451ef98a2.1634822085.git.geert+renesas@glider.be
>
> > ['ovti,ov5645']
>
> Board component
>
> > ['renesas,r8a7795-mlp', 'renesas,rcar-gen3-mlp']
> > ['renesas,r8a7796-mlp', 'renesas,rcar-gen3-mlp']
> > ['renesas,r8a77961-mlp', 'renesas,rcar-gen3-mlp']
> > ['renesas,r8a77965-mlp', 'renesas,rcar-gen3-mlp']
> > ['renesas,r8a77990-mlp', 'renesas,rcar-gen3-mlp']
> > ['renesas,r8a77995-mlp', 'renesas,rcar-gen3-mlp']
>
> Driver in staging without any bindings
>
> > ['renesas,r9a07g043-ssi', 'renesas,rz-ssi']
>
> https://lore.kernel.org/r/20220423133154.141027-1-biju.das.jz@bp.renesas.com
>
> > ['renesas,r9a07g043-tsu', 'renesas,rzg2l-tsu']
>
> https://lore.kernel.org/r/20220501081930.23743-1-biju.das.jz@bp.renesas.com
>
> > ['renesas,r9a07g043-usbphy-ctrl', 'renesas,rzg2l-usbphy-ctrl']
>
> https://lore.kernel.org/r/20220423134601.141975-1-biju.das.jz@bp.renesas.com
>
> > ['renesas,r9a07g043-wdt', 'renesas,rzg2l-wdt']
>
> https://lore.kernel.org/r/20220424071323.151757-1-biju.das.jz@bp.renesas.com
>
> > ['ti,pcm3168a']
>
> Board component
>
> > I guess board level components don't count and some might be pending.
>
> Some have been pending (or blocked) for a long time...

Can you tell me which ones and I can apply them. If they have my tag
already, then I tend to ignore them.

Rob

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2022-05-17 13:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 12:41 [PATCH] dt-bindings: phy: renesas,rcar-gen2-usb-phy: Convert to json-schema Geert Uytterhoeven
2022-05-09 12:41 ` [PATCH] dt-bindings: phy: renesas, rcar-gen2-usb-phy: " Geert Uytterhoeven
2022-05-17  1:04 ` [PATCH] dt-bindings: phy: renesas,rcar-gen2-usb-phy: " Rob Herring
2022-05-17  1:04   ` Rob Herring
2022-05-17  6:58   ` Geert Uytterhoeven
2022-05-17  6:58     ` [PATCH] dt-bindings: phy: renesas, rcar-gen2-usb-phy: " Geert Uytterhoeven
2022-05-17 13:57     ` Rob Herring [this message]
2022-05-17 13:57       ` Rob Herring
2022-05-19 13:41       ` Geert Uytterhoeven
2022-05-19 13:41         ` [PATCH] dt-bindings: phy: renesas,rcar-gen2-usb-phy: " Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqJo-p+bh6VOKANq8pmMPbm1vZwmHt73yYaEhe9GfQ50dw@mail.gmail.com \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=kishon@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=vkoul@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.