From: Rob Herring <robh+dt@kernel.org>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Hector Martin <marcan@marcan.st>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>
Subject: Re: [PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen
Date: Tue, 30 Nov 2021 12:25:00 -0600 [thread overview]
Message-ID: <CAL_JsqJr5LYkWafLB0+Voo6pKDbRSF9QaDfavKNvSP0FXcSAkw@mail.gmail.com> (raw)
In-Reply-To: <CABxcv=mkuJLrXr_nbELg39qJvUvV2y69FAisFKURR9bqa3FzKg@mail.gmail.com>
On Tue, Nov 30, 2021 at 12:45 AM Javier Martinez Canillas
<javier@dowhile0.org> wrote:
>
> > > >
> > > > Simpledrm is just a driver, but this is platform setup code. Why is this
> > > > code located here and not under arch/ or drivers/firmware/?
> > > >
>
> Agreed. Creating platform devices is something for platform code and
> not really a DRM driver.
>
> > > > I know that other drivers do similar things, it doesn't seem to belong here.
> > >
>
> Yeah, the simplefb driver does this but that seems like something that
> should be changed.
>
> > > This definitely doesn't belong in either of those, since it is not arch-
> > > or firmware-specific. It is implementing support for the standard
> > > simple-framebuffer OF binding, which specifies that it must be located
> > > within the /chosen node (and thus the default OF setup code won't do the
> > > matching for you); this applies to all OF platforms [1]
> > >
> > > Adding Rob; do you think this should move from simplefb/simpledrm to
> > > common OF code? (where?)
> >
> > of_platform_default_populate_init() should work.
>
> That should work but I still wonder if it is the correct place to add
> this logic.
It is because that is where most of the other devices are created
unless the bus handles it.
> I think that instead it could be done in the sysfb_create_simplefb()
> function [0], which already creates the "simple-framebuffer" device
> for x86 legacy BIOS and x86/arm64/riscv EFI so it makes sense to do
> the same for OF. That way the simplefb platform device registration
> code could also be dropped from the driver and users would just need
> to enable CONFIG_SYSFB and CONFIG_SYSFB_SIMPLEFB to have the same.
Doesn't look like that would share anything with anything else (BIOS/EFI/ACPI).
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: David Airlie <airlied@linux.ie>, Hector Martin <marcan@marcan.st>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>
Subject: Re: [PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen
Date: Tue, 30 Nov 2021 12:25:00 -0600 [thread overview]
Message-ID: <CAL_JsqJr5LYkWafLB0+Voo6pKDbRSF9QaDfavKNvSP0FXcSAkw@mail.gmail.com> (raw)
In-Reply-To: <CABxcv=mkuJLrXr_nbELg39qJvUvV2y69FAisFKURR9bqa3FzKg@mail.gmail.com>
On Tue, Nov 30, 2021 at 12:45 AM Javier Martinez Canillas
<javier@dowhile0.org> wrote:
>
> > > >
> > > > Simpledrm is just a driver, but this is platform setup code. Why is this
> > > > code located here and not under arch/ or drivers/firmware/?
> > > >
>
> Agreed. Creating platform devices is something for platform code and
> not really a DRM driver.
>
> > > > I know that other drivers do similar things, it doesn't seem to belong here.
> > >
>
> Yeah, the simplefb driver does this but that seems like something that
> should be changed.
>
> > > This definitely doesn't belong in either of those, since it is not arch-
> > > or firmware-specific. It is implementing support for the standard
> > > simple-framebuffer OF binding, which specifies that it must be located
> > > within the /chosen node (and thus the default OF setup code won't do the
> > > matching for you); this applies to all OF platforms [1]
> > >
> > > Adding Rob; do you think this should move from simplefb/simpledrm to
> > > common OF code? (where?)
> >
> > of_platform_default_populate_init() should work.
>
> That should work but I still wonder if it is the correct place to add
> this logic.
It is because that is where most of the other devices are created
unless the bus handles it.
> I think that instead it could be done in the sysfb_create_simplefb()
> function [0], which already creates the "simple-framebuffer" device
> for x86 legacy BIOS and x86/arm64/riscv EFI so it makes sense to do
> the same for OF. That way the simplefb platform device registration
> code could also be dropped from the driver and users would just need
> to enable CONFIG_SYSFB and CONFIG_SYSFB_SIMPLEFB to have the same.
Doesn't look like that would share anything with anything else (BIOS/EFI/ACPI).
Rob
next prev parent reply other threads:[~2021-11-30 18:25 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 14:58 [PATCH 0/3] drm/simpledrm: Apple M1 / DT platform support fixes Hector Martin
2021-11-17 14:58 ` Hector Martin
2021-11-17 14:58 ` [PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen Hector Martin
2021-11-17 14:58 ` Hector Martin
2021-11-18 9:19 ` Thomas Zimmermann
2021-11-18 9:19 ` Thomas Zimmermann
2021-11-20 3:23 ` Hector Martin
2021-11-20 3:23 ` Hector Martin
2021-11-29 11:26 ` Thomas Zimmermann
2021-11-29 11:26 ` Thomas Zimmermann
2021-11-29 19:29 ` Rob Herring
2021-11-29 19:29 ` Rob Herring
2021-11-30 6:44 ` Javier Martinez Canillas
2021-11-30 6:44 ` Javier Martinez Canillas
2021-11-30 8:31 ` Thomas Zimmermann
2021-11-30 8:31 ` Thomas Zimmermann
2021-11-30 9:31 ` Javier Martinez Canillas
2021-11-30 9:31 ` Javier Martinez Canillas
2021-11-30 18:25 ` Rob Herring [this message]
2021-11-30 18:25 ` Rob Herring
2021-11-19 1:21 ` kernel test robot
2021-11-19 1:21 ` kernel test robot
2021-11-17 14:58 ` [PATCH 2/3] drm/format-helper: Add drm_fb_xrgb8888_to_xrgb2101010_dstclip() Hector Martin
2021-11-17 14:58 ` Hector Martin
2021-11-18 9:16 ` Thomas Zimmermann
2021-11-18 9:16 ` Thomas Zimmermann
2021-11-22 9:52 ` Pekka Paalanen
2021-11-22 9:52 ` Pekka Paalanen
2021-11-22 10:05 ` Hector Martin
2021-11-22 10:05 ` Hector Martin
2021-11-22 10:39 ` Pekka Paalanen
2021-11-22 10:39 ` Pekka Paalanen
2021-11-17 14:58 ` [PATCH 3/3] drm/simpledrm: Enable XRGB2101010 format Hector Martin
2021-11-17 14:58 ` Hector Martin
2021-11-18 9:16 ` Thomas Zimmermann
2021-11-18 9:16 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJr5LYkWafLB0+Voo6pKDbRSF9QaDfavKNvSP0FXcSAkw@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=airlied@linux.ie \
--cc=alyssa@rosenzweig.io \
--cc=dri-devel@lists.freedesktop.org \
--cc=javier@dowhile0.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.