All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/3] Fix STi aliases property name
@ 2018-03-06  8:07 ` patrice.chotard
  0 siblings, 0 replies; 21+ messages in thread
From: patrice.chotard @ 2018-03-06  8:07 UTC (permalink / raw)
  To: robh+dt, mark.rutland, linux, linux-arm-kernel, linux-kernel,
	devicetree, gregkh, jslaby, linux-serial
  Cc: patrice.chotard

From: Patrice Chotard <patrice.chotard@st.com>

Since dtc v1.4.6-9-gaadd0b65c987, when compiling dtb with W=1 option,
the following warnings are triggered :
    
arch/arm/boot/dts/stih418-b2199.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih407-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih410-b2260.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih410-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

_ Patch 1, convert the aliases property name in lowercase in 
  all STi board dts files.

_ Patch 2, remove useless stdout-path property

_ Patch 3, rework the tty driver st-asc accordingly, as aliases id is retrieved 
  using of_alias_get_id() with a defined string with is not lowercase only.

v2: Fix Rob Herring's remarks :
  	  _ use serialN instead of ttyasN aliases to not break ABI
	  _ remove useless stdout-path property
	  _ update st-asc driver with "serial" alias prefix

Patrice Chotard (2):
  ARM: dts: STi: Fix aliases property name for STi boards
  ARM: dts: STi: Remove useless stdout-path for STi boards
  tty: st-asc: Update tty alias

 arch/arm/boot/dts/stih407-b2120.dts | 5 ++---
 arch/arm/boot/dts/stih410-b2120.dts | 5 ++---
 arch/arm/boot/dts/stih410-b2260.dts | 5 ++---
 arch/arm/boot/dts/stih418-b2199.dts | 5 ++---
 drivers/tty/serial/st-asc.c         | 2 +-
 5 files changed, 9 insertions(+), 13 deletions(-)

-- 
1.9.1


^ permalink raw reply	[flat|nested] 21+ messages in thread
* [PATCH v2 0/3] Fix STi aliases property name
@ 2018-03-06  8:07 ` patrice.chotard
  0 siblings, 0 replies; 21+ messages in thread
From: patrice.chotard @ 2018-03-06  8:07 UTC (permalink / raw)
  To: robh+dt, mark.rutland, linux, linux-arm-kernel, linux-kernel,
	devicetree, gregkh, jslaby, linux-serial
  Cc: patrice.chotard

From: Patrice Chotard <patrice.chotard@st.com>

Since dtc v1.4.6-9-gaadd0b65c987, when compiling dtb with W=1 option,
the following warnings are triggered :
    
arch/arm/boot/dts/stih418-b2199.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih407-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih410-b2260.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih410-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

_ Patch 1, convert the aliases property name in lowercase in 
  all STi board dts files.

_ Patch 2, remove useless stdout-path property

_ Patch 3, rework the tty driver st-asc accordingly, as aliases id is retrieved 
  using of_alias_get_id() with a defined string with is not lowercase only.

v2: Fix Rob Herring's remarks :
  	  _ use serialN instead of ttyasN aliases to not break ABI
	  _ remove useless stdout-path property
	  _ update st-asc driver with "serial" alias prefix

Patrice Chotard (2):
  ARM: dts: STi: Fix aliases property name for STi boards
  ARM: dts: STi: Remove useless stdout-path for STi boards
  tty: st-asc: Update tty alias

 arch/arm/boot/dts/stih407-b2120.dts | 5 ++---
 arch/arm/boot/dts/stih410-b2120.dts | 5 ++---
 arch/arm/boot/dts/stih410-b2260.dts | 5 ++---
 arch/arm/boot/dts/stih418-b2199.dts | 5 ++---
 drivers/tty/serial/st-asc.c         | 2 +-
 5 files changed, 9 insertions(+), 13 deletions(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 21+ messages in thread
* [PATCH v2 0/3] Fix STi aliases property name
@ 2018-03-06  8:07 ` patrice.chotard
  0 siblings, 0 replies; 21+ messages in thread
From: patrice.chotard at st.com @ 2018-03-06  8:07 UTC (permalink / raw)
  To: linux-arm-kernel

From: Patrice Chotard <patrice.chotard@st.com>

Since dtc v1.4.6-9-gaadd0b65c987, when compiling dtb with W=1 option,
the following warnings are triggered :
    
arch/arm/boot/dts/stih418-b2199.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih407-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih410-b2260.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih410-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

_ Patch 1, convert the aliases property name in lowercase in 
  all STi board dts files.

_ Patch 2, remove useless stdout-path property

_ Patch 3, rework the tty driver st-asc accordingly, as aliases id is retrieved 
  using of_alias_get_id() with a defined string with is not lowercase only.

v2: Fix Rob Herring's remarks :
  	  _ use serialN instead of ttyasN aliases to not break ABI
	  _ remove useless stdout-path property
	  _ update st-asc driver with "serial" alias prefix

Patrice Chotard (2):
  ARM: dts: STi: Fix aliases property name for STi boards
  ARM: dts: STi: Remove useless stdout-path for STi boards
  tty: st-asc: Update tty alias

 arch/arm/boot/dts/stih407-b2120.dts | 5 ++---
 arch/arm/boot/dts/stih410-b2120.dts | 5 ++---
 arch/arm/boot/dts/stih410-b2260.dts | 5 ++---
 arch/arm/boot/dts/stih418-b2199.dts | 5 ++---
 drivers/tty/serial/st-asc.c         | 2 +-
 5 files changed, 9 insertions(+), 13 deletions(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 21+ messages in thread
* [PATCH v2 1/3] ARM: dts: STi: Fix aliases property name for STi boards
  2018-03-06  8:07 ` patrice.chotard
  (?)
@ 2018-03-06  8:07   ` patrice.chotard
  -1 siblings, 0 replies; 21+ messages in thread
From: patrice.chotard @ 2018-03-06  8:07 UTC (permalink / raw)
  To: robh+dt, mark.rutland, linux, linux-arm-kernel, linux-kernel,
	devicetree, gregkh, jslaby, linux-serial
  Cc: patrice.chotard

From: Patrice Chotard <patrice.chotard@st.com>

Update serial aliases from "ttyASN" to more common "serialN".

Since dtc v1.4.6-9-gaadd0b65c987, aliases property name must
be lowercase only. This allows to fix following dtc warnings:

arch/arm/boot/dts/stih418-b2199.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih407-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih410-b2260.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih410-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---

v2: _ use serialN instead of ttyasN aliases to not break ABI


 arch/arm/boot/dts/stih407-b2120.dts | 4 ++--
 arch/arm/boot/dts/stih410-b2120.dts | 4 ++--
 arch/arm/boot/dts/stih410-b2260.dts | 4 ++--
 arch/arm/boot/dts/stih418-b2199.dts | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts
index de3c8bf129b5..2c4d6033b448 100644
--- a/arch/arm/boot/dts/stih407-b2120.dts
+++ b/arch/arm/boot/dts/stih407-b2120.dts
@@ -14,7 +14,7 @@
 	compatible = "st,stih407-b2120", "st,stih407";
 
 	chosen {
-		bootargs = "console=ttyAS0,115200 clk_ignore_unused";
+		bootargs = "console=serial0,115200 clk_ignore_unused";
 		stdout-path = &sbc_serial0;
 	};
 
@@ -24,7 +24,7 @@
 	};
 
 	aliases {
-		ttyAS0 = &sbc_serial0;
+		serial0 = &sbc_serial0;
 		ethernet0 = &ethernet0;
 	};
 
diff --git a/arch/arm/boot/dts/stih410-b2120.dts b/arch/arm/boot/dts/stih410-b2120.dts
index 0a59b7b0f4b2..5422850641e8 100644
--- a/arch/arm/boot/dts/stih410-b2120.dts
+++ b/arch/arm/boot/dts/stih410-b2120.dts
@@ -14,7 +14,7 @@
 	compatible = "st,stih410-b2120", "st,stih410";
 
 	chosen {
-		bootargs = "console=ttyAS0,115200 clk_ignore_unused";
+		bootargs = "console=serial0,115200 clk_ignore_unused";
 		stdout-path = &sbc_serial0;
 	};
 
@@ -24,7 +24,7 @@
 	};
 
 	aliases {
-		ttyAS0 = &sbc_serial0;
+		serial0 = &sbc_serial0;
 		ethernet0 = &ethernet0;
 	};
 
diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
index feb8834478fa..ca347160e35d 100644
--- a/arch/arm/boot/dts/stih410-b2260.dts
+++ b/arch/arm/boot/dts/stih410-b2260.dts
@@ -15,7 +15,7 @@
 	compatible = "st,stih410-b2260", "st,stih410";
 
 	chosen {
-		bootargs = "console=ttyAS1,115200 clk_ignore_unused";
+		bootargs = "console=serial1,115200 clk_ignore_unused";
 		stdout-path = &uart1;
 	};
 
@@ -25,7 +25,7 @@
 	};
 
 	aliases {
-		ttyAS1 = &uart1;
+		serial1 = &uart1;
 		ethernet0 = &ethernet0;
 	};
 
diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
index 39b4db2e3507..dbf7bb704a1a 100644
--- a/arch/arm/boot/dts/stih418-b2199.dts
+++ b/arch/arm/boot/dts/stih418-b2199.dts
@@ -14,7 +14,7 @@
 	compatible = "st,stih418-b2199", "st,stih418";
 
 	chosen {
-		bootargs = "console=ttyAS0,115200 clk_ignore_unused";
+		bootargs = "console=serial0,115200 clk_ignore_unused";
 		stdout-path = &sbc_serial0;
 	};
 
@@ -24,7 +24,7 @@
 	};
 
 	aliases {
-		ttyAS0 = &sbc_serial0;
+		serial0 = &sbc_serial0;
 		ethernet0 = &ethernet0;
 	};
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 21+ messages in thread
* [PATCH v2 1/3] ARM: dts: STi: Fix aliases property name for STi boards
@ 2018-03-06  8:07   ` patrice.chotard
  0 siblings, 0 replies; 21+ messages in thread
From: patrice.chotard @ 2018-03-06  8:07 UTC (permalink / raw)
  To: robh+dt, mark.rutland, linux, linux-arm-kernel, linux-kernel,
	devicetree, gregkh, jslaby, linux-serial
  Cc: patrice.chotard

From: Patrice Chotard <patrice.chotard@st.com>

Update serial aliases from "ttyASN" to more common "serialN".

Since dtc v1.4.6-9-gaadd0b65c987, aliases property name must
be lowercase only. This allows to fix following dtc warnings:

arch/arm/boot/dts/stih418-b2199.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih407-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih410-b2260.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih410-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---

v2: _ use serialN instead of ttyasN aliases to not break ABI


 arch/arm/boot/dts/stih407-b2120.dts | 4 ++--
 arch/arm/boot/dts/stih410-b2120.dts | 4 ++--
 arch/arm/boot/dts/stih410-b2260.dts | 4 ++--
 arch/arm/boot/dts/stih418-b2199.dts | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts
index de3c8bf129b5..2c4d6033b448 100644
--- a/arch/arm/boot/dts/stih407-b2120.dts
+++ b/arch/arm/boot/dts/stih407-b2120.dts
@@ -14,7 +14,7 @@
 	compatible = "st,stih407-b2120", "st,stih407";
 
 	chosen {
-		bootargs = "console=ttyAS0,115200 clk_ignore_unused";
+		bootargs = "console=serial0,115200 clk_ignore_unused";
 		stdout-path = &sbc_serial0;
 	};
 
@@ -24,7 +24,7 @@
 	};
 
 	aliases {
-		ttyAS0 = &sbc_serial0;
+		serial0 = &sbc_serial0;
 		ethernet0 = &ethernet0;
 	};
 
diff --git a/arch/arm/boot/dts/stih410-b2120.dts b/arch/arm/boot/dts/stih410-b2120.dts
index 0a59b7b0f4b2..5422850641e8 100644
--- a/arch/arm/boot/dts/stih410-b2120.dts
+++ b/arch/arm/boot/dts/stih410-b2120.dts
@@ -14,7 +14,7 @@
 	compatible = "st,stih410-b2120", "st,stih410";
 
 	chosen {
-		bootargs = "console=ttyAS0,115200 clk_ignore_unused";
+		bootargs = "console=serial0,115200 clk_ignore_unused";
 		stdout-path = &sbc_serial0;
 	};
 
@@ -24,7 +24,7 @@
 	};
 
 	aliases {
-		ttyAS0 = &sbc_serial0;
+		serial0 = &sbc_serial0;
 		ethernet0 = &ethernet0;
 	};
 
diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
index feb8834478fa..ca347160e35d 100644
--- a/arch/arm/boot/dts/stih410-b2260.dts
+++ b/arch/arm/boot/dts/stih410-b2260.dts
@@ -15,7 +15,7 @@
 	compatible = "st,stih410-b2260", "st,stih410";
 
 	chosen {
-		bootargs = "console=ttyAS1,115200 clk_ignore_unused";
+		bootargs = "console=serial1,115200 clk_ignore_unused";
 		stdout-path = &uart1;
 	};
 
@@ -25,7 +25,7 @@
 	};
 
 	aliases {
-		ttyAS1 = &uart1;
+		serial1 = &uart1;
 		ethernet0 = &ethernet0;
 	};
 
diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
index 39b4db2e3507..dbf7bb704a1a 100644
--- a/arch/arm/boot/dts/stih418-b2199.dts
+++ b/arch/arm/boot/dts/stih418-b2199.dts
@@ -14,7 +14,7 @@
 	compatible = "st,stih418-b2199", "st,stih418";
 
 	chosen {
-		bootargs = "console=ttyAS0,115200 clk_ignore_unused";
+		bootargs = "console=serial0,115200 clk_ignore_unused";
 		stdout-path = &sbc_serial0;
 	};
 
@@ -24,7 +24,7 @@
 	};
 
 	aliases {
-		ttyAS0 = &sbc_serial0;
+		serial0 = &sbc_serial0;
 		ethernet0 = &ethernet0;
 	};
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 21+ messages in thread
* [PATCH v2 1/3] ARM: dts: STi: Fix aliases property name for STi boards
@ 2018-03-06  8:07   ` patrice.chotard
  0 siblings, 0 replies; 21+ messages in thread
From: patrice.chotard at st.com @ 2018-03-06  8:07 UTC (permalink / raw)
  To: linux-arm-kernel

From: Patrice Chotard <patrice.chotard@st.com>

Update serial aliases from "ttyASN" to more common "serialN".

Since dtc v1.4.6-9-gaadd0b65c987, aliases property name must
be lowercase only. This allows to fix following dtc warnings:

arch/arm/boot/dts/stih418-b2199.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih407-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih410-b2260.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih410-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---

v2: _ use serialN instead of ttyasN aliases to not break ABI


 arch/arm/boot/dts/stih407-b2120.dts | 4 ++--
 arch/arm/boot/dts/stih410-b2120.dts | 4 ++--
 arch/arm/boot/dts/stih410-b2260.dts | 4 ++--
 arch/arm/boot/dts/stih418-b2199.dts | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts
index de3c8bf129b5..2c4d6033b448 100644
--- a/arch/arm/boot/dts/stih407-b2120.dts
+++ b/arch/arm/boot/dts/stih407-b2120.dts
@@ -14,7 +14,7 @@
 	compatible = "st,stih407-b2120", "st,stih407";
 
 	chosen {
-		bootargs = "console=ttyAS0,115200 clk_ignore_unused";
+		bootargs = "console=serial0,115200 clk_ignore_unused";
 		stdout-path = &sbc_serial0;
 	};
 
@@ -24,7 +24,7 @@
 	};
 
 	aliases {
-		ttyAS0 = &sbc_serial0;
+		serial0 = &sbc_serial0;
 		ethernet0 = &ethernet0;
 	};
 
diff --git a/arch/arm/boot/dts/stih410-b2120.dts b/arch/arm/boot/dts/stih410-b2120.dts
index 0a59b7b0f4b2..5422850641e8 100644
--- a/arch/arm/boot/dts/stih410-b2120.dts
+++ b/arch/arm/boot/dts/stih410-b2120.dts
@@ -14,7 +14,7 @@
 	compatible = "st,stih410-b2120", "st,stih410";
 
 	chosen {
-		bootargs = "console=ttyAS0,115200 clk_ignore_unused";
+		bootargs = "console=serial0,115200 clk_ignore_unused";
 		stdout-path = &sbc_serial0;
 	};
 
@@ -24,7 +24,7 @@
 	};
 
 	aliases {
-		ttyAS0 = &sbc_serial0;
+		serial0 = &sbc_serial0;
 		ethernet0 = &ethernet0;
 	};
 
diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
index feb8834478fa..ca347160e35d 100644
--- a/arch/arm/boot/dts/stih410-b2260.dts
+++ b/arch/arm/boot/dts/stih410-b2260.dts
@@ -15,7 +15,7 @@
 	compatible = "st,stih410-b2260", "st,stih410";
 
 	chosen {
-		bootargs = "console=ttyAS1,115200 clk_ignore_unused";
+		bootargs = "console=serial1,115200 clk_ignore_unused";
 		stdout-path = &uart1;
 	};
 
@@ -25,7 +25,7 @@
 	};
 
 	aliases {
-		ttyAS1 = &uart1;
+		serial1 = &uart1;
 		ethernet0 = &ethernet0;
 	};
 
diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
index 39b4db2e3507..dbf7bb704a1a 100644
--- a/arch/arm/boot/dts/stih418-b2199.dts
+++ b/arch/arm/boot/dts/stih418-b2199.dts
@@ -14,7 +14,7 @@
 	compatible = "st,stih418-b2199", "st,stih418";
 
 	chosen {
-		bootargs = "console=ttyAS0,115200 clk_ignore_unused";
+		bootargs = "console=serial0,115200 clk_ignore_unused";
 		stdout-path = &sbc_serial0;
 	};
 
@@ -24,7 +24,7 @@
 	};
 
 	aliases {
-		ttyAS0 = &sbc_serial0;
+		serial0 = &sbc_serial0;
 		ethernet0 = &ethernet0;
 	};
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 21+ messages in thread
* [PATCH v2 2/3] ARM: dts: STi: Remove useless stdout-path for STi boards
  2018-03-06  8:07 ` patrice.chotard
  (?)
@ 2018-03-06  8:07   ` patrice.chotard
  -1 siblings, 0 replies; 21+ messages in thread
From: patrice.chotard @ 2018-03-06  8:07 UTC (permalink / raw)
  To: robh+dt, mark.rutland, linux, linux-arm-kernel, linux-kernel,
	devicetree, gregkh, jslaby, linux-serial
  Cc: patrice.chotard

From: Patrice Chotard <patrice.chotard@st.com>

As serial interface is already specified into bootargs,
stdout-path can be removed.

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---

v2: _ none

 arch/arm/boot/dts/stih407-b2120.dts | 1 -
 arch/arm/boot/dts/stih410-b2120.dts | 1 -
 arch/arm/boot/dts/stih410-b2260.dts | 1 -
 arch/arm/boot/dts/stih418-b2199.dts | 1 -
 4 files changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts
index 2c4d6033b448..074b4cd0ca89 100644
--- a/arch/arm/boot/dts/stih407-b2120.dts
+++ b/arch/arm/boot/dts/stih407-b2120.dts
@@ -15,7 +15,6 @@
 
 	chosen {
 		bootargs = "console=serial0,115200 clk_ignore_unused";
-		stdout-path = &sbc_serial0;
 	};
 
 	memory@40000000 {
diff --git a/arch/arm/boot/dts/stih410-b2120.dts b/arch/arm/boot/dts/stih410-b2120.dts
index 5422850641e8..eae3050984d0 100644
--- a/arch/arm/boot/dts/stih410-b2120.dts
+++ b/arch/arm/boot/dts/stih410-b2120.dts
@@ -15,7 +15,6 @@
 
 	chosen {
 		bootargs = "console=serial0,115200 clk_ignore_unused";
-		stdout-path = &sbc_serial0;
 	};
 
 	memory@40000000 {
diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
index ca347160e35d..c26e388bd1a4 100644
--- a/arch/arm/boot/dts/stih410-b2260.dts
+++ b/arch/arm/boot/dts/stih410-b2260.dts
@@ -16,7 +16,6 @@
 
 	chosen {
 		bootargs = "console=serial1,115200 clk_ignore_unused";
-		stdout-path = &uart1;
 	};
 
 	memory@40000000 {
diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
index dbf7bb704a1a..d948f774fee7 100644
--- a/arch/arm/boot/dts/stih418-b2199.dts
+++ b/arch/arm/boot/dts/stih418-b2199.dts
@@ -15,7 +15,6 @@
 
 	chosen {
 		bootargs = "console=serial0,115200 clk_ignore_unused";
-		stdout-path = &sbc_serial0;
 	};
 
 	memory@40000000 {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 21+ messages in thread
* [PATCH v2 2/3] ARM: dts: STi: Remove useless stdout-path for STi boards
@ 2018-03-06  8:07   ` patrice.chotard
  0 siblings, 0 replies; 21+ messages in thread
From: patrice.chotard @ 2018-03-06  8:07 UTC (permalink / raw)
  To: robh+dt, mark.rutland, linux, linux-arm-kernel, linux-kernel,
	devicetree, gregkh, jslaby, linux-serial
  Cc: patrice.chotard

From: Patrice Chotard <patrice.chotard@st.com>

As serial interface is already specified into bootargs,
stdout-path can be removed.

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---

v2: _ none

 arch/arm/boot/dts/stih407-b2120.dts | 1 -
 arch/arm/boot/dts/stih410-b2120.dts | 1 -
 arch/arm/boot/dts/stih410-b2260.dts | 1 -
 arch/arm/boot/dts/stih418-b2199.dts | 1 -
 4 files changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts
index 2c4d6033b448..074b4cd0ca89 100644
--- a/arch/arm/boot/dts/stih407-b2120.dts
+++ b/arch/arm/boot/dts/stih407-b2120.dts
@@ -15,7 +15,6 @@
 
 	chosen {
 		bootargs = "console=serial0,115200 clk_ignore_unused";
-		stdout-path = &sbc_serial0;
 	};
 
 	memory@40000000 {
diff --git a/arch/arm/boot/dts/stih410-b2120.dts b/arch/arm/boot/dts/stih410-b2120.dts
index 5422850641e8..eae3050984d0 100644
--- a/arch/arm/boot/dts/stih410-b2120.dts
+++ b/arch/arm/boot/dts/stih410-b2120.dts
@@ -15,7 +15,6 @@
 
 	chosen {
 		bootargs = "console=serial0,115200 clk_ignore_unused";
-		stdout-path = &sbc_serial0;
 	};
 
 	memory@40000000 {
diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
index ca347160e35d..c26e388bd1a4 100644
--- a/arch/arm/boot/dts/stih410-b2260.dts
+++ b/arch/arm/boot/dts/stih410-b2260.dts
@@ -16,7 +16,6 @@
 
 	chosen {
 		bootargs = "console=serial1,115200 clk_ignore_unused";
-		stdout-path = &uart1;
 	};
 
 	memory@40000000 {
diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
index dbf7bb704a1a..d948f774fee7 100644
--- a/arch/arm/boot/dts/stih418-b2199.dts
+++ b/arch/arm/boot/dts/stih418-b2199.dts
@@ -15,7 +15,6 @@
 
 	chosen {
 		bootargs = "console=serial0,115200 clk_ignore_unused";
-		stdout-path = &sbc_serial0;
 	};
 
 	memory@40000000 {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 21+ messages in thread
* [PATCH v2 2/3] ARM: dts: STi: Remove useless stdout-path for STi boards
@ 2018-03-06  8:07   ` patrice.chotard
  0 siblings, 0 replies; 21+ messages in thread
From: patrice.chotard at st.com @ 2018-03-06  8:07 UTC (permalink / raw)
  To: linux-arm-kernel

From: Patrice Chotard <patrice.chotard@st.com>

As serial interface is already specified into bootargs,
stdout-path can be removed.

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---

v2: _ none

 arch/arm/boot/dts/stih407-b2120.dts | 1 -
 arch/arm/boot/dts/stih410-b2120.dts | 1 -
 arch/arm/boot/dts/stih410-b2260.dts | 1 -
 arch/arm/boot/dts/stih418-b2199.dts | 1 -
 4 files changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts
index 2c4d6033b448..074b4cd0ca89 100644
--- a/arch/arm/boot/dts/stih407-b2120.dts
+++ b/arch/arm/boot/dts/stih407-b2120.dts
@@ -15,7 +15,6 @@
 
 	chosen {
 		bootargs = "console=serial0,115200 clk_ignore_unused";
-		stdout-path = &sbc_serial0;
 	};
 
 	memory at 40000000 {
diff --git a/arch/arm/boot/dts/stih410-b2120.dts b/arch/arm/boot/dts/stih410-b2120.dts
index 5422850641e8..eae3050984d0 100644
--- a/arch/arm/boot/dts/stih410-b2120.dts
+++ b/arch/arm/boot/dts/stih410-b2120.dts
@@ -15,7 +15,6 @@
 
 	chosen {
 		bootargs = "console=serial0,115200 clk_ignore_unused";
-		stdout-path = &sbc_serial0;
 	};
 
 	memory at 40000000 {
diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
index ca347160e35d..c26e388bd1a4 100644
--- a/arch/arm/boot/dts/stih410-b2260.dts
+++ b/arch/arm/boot/dts/stih410-b2260.dts
@@ -16,7 +16,6 @@
 
 	chosen {
 		bootargs = "console=serial1,115200 clk_ignore_unused";
-		stdout-path = &uart1;
 	};
 
 	memory at 40000000 {
diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
index dbf7bb704a1a..d948f774fee7 100644
--- a/arch/arm/boot/dts/stih418-b2199.dts
+++ b/arch/arm/boot/dts/stih418-b2199.dts
@@ -15,7 +15,6 @@
 
 	chosen {
 		bootargs = "console=serial0,115200 clk_ignore_unused";
-		stdout-path = &sbc_serial0;
 	};
 
 	memory at 40000000 {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 21+ messages in thread
* [PATCH v2 3/3] tty: st-asc: Update tty alias
  2018-03-06  8:07 ` patrice.chotard
  (?)
@ 2018-03-06  8:07   ` patrice.chotard
  -1 siblings, 0 replies; 21+ messages in thread
From: patrice.chotard @ 2018-03-06  8:07 UTC (permalink / raw)
  To: robh+dt, mark.rutland, linux, linux-arm-kernel, linux-kernel,
	devicetree, gregkh, jslaby, linux-serial
  Cc: patrice.chotard

From: Patrice Chotard <patrice.chotard@st.com>

Since dtc v1.4.6-9-gaadd0b65c987, aliases property name
must include only lowercase and '-'.

After having updated all STi boards serial aliases from "ttyASN"
to "serialN", st-asc driver need to be updated accordingly as tty
aliases id is retrieved using of_alias_get_id(np, ASC_SERIAL_NAME);

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---

v2: _ update st-asc driver with "serial" alias prefix


 drivers/tty/serial/st-asc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index c763253514e9..f9372b690e54 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -29,7 +29,7 @@
 #include <linux/gpio/consumer.h>
 
 #define DRIVER_NAME "st-asc"
-#define ASC_SERIAL_NAME "ttyAS"
+#define ASC_SERIAL_NAME "serial"
 #define ASC_FIFO_SIZE 16
 #define ASC_MAX_PORTS 8
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 21+ messages in thread
* [PATCH v2 3/3] tty: st-asc: Update tty alias
@ 2018-03-06  8:07   ` patrice.chotard
  0 siblings, 0 replies; 21+ messages in thread
From: patrice.chotard @ 2018-03-06  8:07 UTC (permalink / raw)
  To: robh+dt, mark.rutland, linux, linux-arm-kernel, linux-kernel,
	devicetree, gregkh, jslaby, linux-serial
  Cc: patrice.chotard

From: Patrice Chotard <patrice.chotard@st.com>

Since dtc v1.4.6-9-gaadd0b65c987, aliases property name
must include only lowercase and '-'.

After having updated all STi boards serial aliases from "ttyASN"
to "serialN", st-asc driver need to be updated accordingly as tty
aliases id is retrieved using of_alias_get_id(np, ASC_SERIAL_NAME);

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---

v2: _ update st-asc driver with "serial" alias prefix


 drivers/tty/serial/st-asc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index c763253514e9..f9372b690e54 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -29,7 +29,7 @@
 #include <linux/gpio/consumer.h>
 
 #define DRIVER_NAME "st-asc"
-#define ASC_SERIAL_NAME "ttyAS"
+#define ASC_SERIAL_NAME "serial"
 #define ASC_FIFO_SIZE 16
 #define ASC_MAX_PORTS 8
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 21+ messages in thread
* [PATCH v2 3/3] tty: st-asc: Update tty alias
@ 2018-03-06  8:07   ` patrice.chotard
  0 siblings, 0 replies; 21+ messages in thread
From: patrice.chotard at st.com @ 2018-03-06  8:07 UTC (permalink / raw)
  To: linux-arm-kernel

From: Patrice Chotard <patrice.chotard@st.com>

Since dtc v1.4.6-9-gaadd0b65c987, aliases property name
must include only lowercase and '-'.

After having updated all STi boards serial aliases from "ttyASN"
to "serialN", st-asc driver need to be updated accordingly as tty
aliases id is retrieved using of_alias_get_id(np, ASC_SERIAL_NAME);

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---

v2: _ update st-asc driver with "serial" alias prefix


 drivers/tty/serial/st-asc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index c763253514e9..f9372b690e54 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -29,7 +29,7 @@
 #include <linux/gpio/consumer.h>
 
 #define DRIVER_NAME "st-asc"
-#define ASC_SERIAL_NAME "ttyAS"
+#define ASC_SERIAL_NAME "serial"
 #define ASC_FIFO_SIZE 16
 #define ASC_MAX_PORTS 8
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 21+ messages in thread
* Re: [PATCH v2 2/3] ARM: dts: STi: Remove useless stdout-path for STi boards
  2018-03-06  8:07   ` patrice.chotard
@ 2018-03-06 13:26     ` Rob Herring
  -1 siblings, 0 replies; 21+ messages in thread
From: Rob Herring @ 2018-03-06 13:26 UTC (permalink / raw)
  To: Patrice Chotard
  Cc: Mark Rutland, Russell King,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel, devicetree, Greg Kroah-Hartman, Jiri Slaby,
	linux-serial

On Tue, Mar 6, 2018 at 2:07 AM,  <patrice.chotard@st.com> wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
>
> As serial interface is already specified into bootargs,
> stdout-path can be removed.

Wrong way around. stdout-path is preferred over using console in bootargs.

>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> ---
>
> v2: _ none
>
>  arch/arm/boot/dts/stih407-b2120.dts | 1 -
>  arch/arm/boot/dts/stih410-b2120.dts | 1 -
>  arch/arm/boot/dts/stih410-b2260.dts | 1 -
>  arch/arm/boot/dts/stih418-b2199.dts | 1 -
>  4 files changed, 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts
> index 2c4d6033b448..074b4cd0ca89 100644
> --- a/arch/arm/boot/dts/stih407-b2120.dts
> +++ b/arch/arm/boot/dts/stih407-b2120.dts
> @@ -15,7 +15,6 @@
>
>         chosen {
>                 bootargs = "console=serial0,115200 clk_ignore_unused";
> -               stdout-path = &sbc_serial0;
>         };
>
>         memory@40000000 {
> diff --git a/arch/arm/boot/dts/stih410-b2120.dts b/arch/arm/boot/dts/stih410-b2120.dts
> index 5422850641e8..eae3050984d0 100644
> --- a/arch/arm/boot/dts/stih410-b2120.dts
> +++ b/arch/arm/boot/dts/stih410-b2120.dts
> @@ -15,7 +15,6 @@
>
>         chosen {
>                 bootargs = "console=serial0,115200 clk_ignore_unused";
> -               stdout-path = &sbc_serial0;
>         };
>
>         memory@40000000 {
> diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
> index ca347160e35d..c26e388bd1a4 100644
> --- a/arch/arm/boot/dts/stih410-b2260.dts
> +++ b/arch/arm/boot/dts/stih410-b2260.dts
> @@ -16,7 +16,6 @@
>
>         chosen {
>                 bootargs = "console=serial1,115200 clk_ignore_unused";
> -               stdout-path = &uart1;
>         };
>
>         memory@40000000 {
> diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
> index dbf7bb704a1a..d948f774fee7 100644
> --- a/arch/arm/boot/dts/stih418-b2199.dts
> +++ b/arch/arm/boot/dts/stih418-b2199.dts
> @@ -15,7 +15,6 @@
>
>         chosen {
>                 bootargs = "console=serial0,115200 clk_ignore_unused";
> -               stdout-path = &sbc_serial0;
>         };
>
>         memory@40000000 {
> --
> 1.9.1
>

^ permalink raw reply	[flat|nested] 21+ messages in thread
* [PATCH v2 2/3] ARM: dts: STi: Remove useless stdout-path for STi boards
@ 2018-03-06 13:26     ` Rob Herring
  0 siblings, 0 replies; 21+ messages in thread
From: Rob Herring @ 2018-03-06 13:26 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Mar 6, 2018 at 2:07 AM,  <patrice.chotard@st.com> wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
>
> As serial interface is already specified into bootargs,
> stdout-path can be removed.

Wrong way around. stdout-path is preferred over using console in bootargs.

>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> ---
>
> v2: _ none
>
>  arch/arm/boot/dts/stih407-b2120.dts | 1 -
>  arch/arm/boot/dts/stih410-b2120.dts | 1 -
>  arch/arm/boot/dts/stih410-b2260.dts | 1 -
>  arch/arm/boot/dts/stih418-b2199.dts | 1 -
>  4 files changed, 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts
> index 2c4d6033b448..074b4cd0ca89 100644
> --- a/arch/arm/boot/dts/stih407-b2120.dts
> +++ b/arch/arm/boot/dts/stih407-b2120.dts
> @@ -15,7 +15,6 @@
>
>         chosen {
>                 bootargs = "console=serial0,115200 clk_ignore_unused";
> -               stdout-path = &sbc_serial0;
>         };
>
>         memory at 40000000 {
> diff --git a/arch/arm/boot/dts/stih410-b2120.dts b/arch/arm/boot/dts/stih410-b2120.dts
> index 5422850641e8..eae3050984d0 100644
> --- a/arch/arm/boot/dts/stih410-b2120.dts
> +++ b/arch/arm/boot/dts/stih410-b2120.dts
> @@ -15,7 +15,6 @@
>
>         chosen {
>                 bootargs = "console=serial0,115200 clk_ignore_unused";
> -               stdout-path = &sbc_serial0;
>         };
>
>         memory at 40000000 {
> diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
> index ca347160e35d..c26e388bd1a4 100644
> --- a/arch/arm/boot/dts/stih410-b2260.dts
> +++ b/arch/arm/boot/dts/stih410-b2260.dts
> @@ -16,7 +16,6 @@
>
>         chosen {
>                 bootargs = "console=serial1,115200 clk_ignore_unused";
> -               stdout-path = &uart1;
>         };
>
>         memory at 40000000 {
> diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
> index dbf7bb704a1a..d948f774fee7 100644
> --- a/arch/arm/boot/dts/stih418-b2199.dts
> +++ b/arch/arm/boot/dts/stih418-b2199.dts
> @@ -15,7 +15,6 @@
>
>         chosen {
>                 bootargs = "console=serial0,115200 clk_ignore_unused";
> -               stdout-path = &sbc_serial0;
>         };
>
>         memory at 40000000 {
> --
> 1.9.1
>

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: [PATCH v2 3/3] tty: st-asc: Update tty alias
  2018-03-06  8:07   ` patrice.chotard
@ 2018-03-06 13:29     ` Rob Herring
  -1 siblings, 0 replies; 21+ messages in thread
From: Rob Herring @ 2018-03-06 13:29 UTC (permalink / raw)
  To: Patrice Chotard
  Cc: Mark Rutland, Russell King,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel, devicetree, Greg Kroah-Hartman, Jiri Slaby,
	linux-serial

On Tue, Mar 6, 2018 at 2:07 AM,  <patrice.chotard@st.com> wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
>
> Since dtc v1.4.6-9-gaadd0b65c987, aliases property name
> must include only lowercase and '-'.
>
> After having updated all STi boards serial aliases from "ttyASN"
> to "serialN", st-asc driver need to be updated accordingly as tty
> aliases id is retrieved using of_alias_get_id(np, ASC_SERIAL_NAME);

Again, changing the tty name breaks userspace. You can't do that.

You need to do something like this:

diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index c763253514e9..5f9f01fac6dd 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -782,7 +782,9 @@ static struct asc_port *asc_of_get_asc_port(struct
platform_device *pdev)
        if (!np)
                return NULL;

-       id = of_alias_get_id(np, ASC_SERIAL_NAME);
+       id = of_alias_get_id(np, "serial");
+       if (id < 0)
+               id = of_alias_get_id(np, ASC_SERIAL_NAME);

        if (id < 0)
                id = 0;

^ permalink raw reply related	[flat|nested] 21+ messages in thread
* [PATCH v2 3/3] tty: st-asc: Update tty alias
@ 2018-03-06 13:29     ` Rob Herring
  0 siblings, 0 replies; 21+ messages in thread
From: Rob Herring @ 2018-03-06 13:29 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Mar 6, 2018 at 2:07 AM,  <patrice.chotard@st.com> wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
>
> Since dtc v1.4.6-9-gaadd0b65c987, aliases property name
> must include only lowercase and '-'.
>
> After having updated all STi boards serial aliases from "ttyASN"
> to "serialN", st-asc driver need to be updated accordingly as tty
> aliases id is retrieved using of_alias_get_id(np, ASC_SERIAL_NAME);

Again, changing the tty name breaks userspace. You can't do that.

You need to do something like this:

diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index c763253514e9..5f9f01fac6dd 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -782,7 +782,9 @@ static struct asc_port *asc_of_get_asc_port(struct
platform_device *pdev)
        if (!np)
                return NULL;

-       id = of_alias_get_id(np, ASC_SERIAL_NAME);
+       id = of_alias_get_id(np, "serial");
+       if (id < 0)
+               id = of_alias_get_id(np, ASC_SERIAL_NAME);

        if (id < 0)
                id = 0;

^ permalink raw reply related	[flat|nested] 21+ messages in thread
* Re: [PATCH v2 2/3] ARM: dts: STi: Remove useless stdout-path for STi boards
  2018-03-06 13:26     ` Rob Herring
@ 2018-03-07  7:59       ` Patrice CHOTARD
  -1 siblings, 0 replies; 21+ messages in thread
From: Patrice CHOTARD @ 2018-03-07  7:59 UTC (permalink / raw)
  To: Rob Herring
  Cc: Mark Rutland, Russell King,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel, devicetree, Greg Kroah-Hartman, Jiri Slaby,
	linux-serial

Hi Rob

On 03/06/2018 02:26 PM, Rob Herring wrote:
> On Tue, Mar 6, 2018 at 2:07 AM,  <patrice.chotard@st.com> wrote:
>> From: Patrice Chotard <patrice.chotard@st.com>
>>
>> As serial interface is already specified into bootargs,
>> stdout-path can be removed.
> 
> Wrong way around. stdout-path is preferred over using console in bootargs.

Ah sorry, i misunderstood what you previously suggested. I will fix it.

Thanks

Patrice

> 
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
>> ---
>>
>> v2: _ none
>>
>>   arch/arm/boot/dts/stih407-b2120.dts | 1 -
>>   arch/arm/boot/dts/stih410-b2120.dts | 1 -
>>   arch/arm/boot/dts/stih410-b2260.dts | 1 -
>>   arch/arm/boot/dts/stih418-b2199.dts | 1 -
>>   4 files changed, 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts
>> index 2c4d6033b448..074b4cd0ca89 100644
>> --- a/arch/arm/boot/dts/stih407-b2120.dts
>> +++ b/arch/arm/boot/dts/stih407-b2120.dts
>> @@ -15,7 +15,6 @@
>>
>>          chosen {
>>                  bootargs = "console=serial0,115200 clk_ignore_unused";
>> -               stdout-path = &sbc_serial0;
>>          };
>>
>>          memory@40000000 {
>> diff --git a/arch/arm/boot/dts/stih410-b2120.dts b/arch/arm/boot/dts/stih410-b2120.dts
>> index 5422850641e8..eae3050984d0 100644
>> --- a/arch/arm/boot/dts/stih410-b2120.dts
>> +++ b/arch/arm/boot/dts/stih410-b2120.dts
>> @@ -15,7 +15,6 @@
>>
>>          chosen {
>>                  bootargs = "console=serial0,115200 clk_ignore_unused";
>> -               stdout-path = &sbc_serial0;
>>          };
>>
>>          memory@40000000 {
>> diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
>> index ca347160e35d..c26e388bd1a4 100644
>> --- a/arch/arm/boot/dts/stih410-b2260.dts
>> +++ b/arch/arm/boot/dts/stih410-b2260.dts
>> @@ -16,7 +16,6 @@
>>
>>          chosen {
>>                  bootargs = "console=serial1,115200 clk_ignore_unused";
>> -               stdout-path = &uart1;
>>          };
>>
>>          memory@40000000 {
>> diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
>> index dbf7bb704a1a..d948f774fee7 100644
>> --- a/arch/arm/boot/dts/stih418-b2199.dts
>> +++ b/arch/arm/boot/dts/stih418-b2199.dts
>> @@ -15,7 +15,6 @@
>>
>>          chosen {
>>                  bootargs = "console=serial0,115200 clk_ignore_unused";
>> -               stdout-path = &sbc_serial0;
>>          };
>>
>>          memory@40000000 {
>> --
>> 1.9.1
>>

^ permalink raw reply	[flat|nested] 21+ messages in thread
* [PATCH v2 2/3] ARM: dts: STi: Remove useless stdout-path for STi boards
@ 2018-03-07  7:59       ` Patrice CHOTARD
  0 siblings, 0 replies; 21+ messages in thread
From: Patrice CHOTARD @ 2018-03-07  7:59 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Rob

On 03/06/2018 02:26 PM, Rob Herring wrote:
> On Tue, Mar 6, 2018 at 2:07 AM,  <patrice.chotard@st.com> wrote:
>> From: Patrice Chotard <patrice.chotard@st.com>
>>
>> As serial interface is already specified into bootargs,
>> stdout-path can be removed.
> 
> Wrong way around. stdout-path is preferred over using console in bootargs.

Ah sorry, i misunderstood what you previously suggested. I will fix it.

Thanks

Patrice

> 
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
>> ---
>>
>> v2: _ none
>>
>>   arch/arm/boot/dts/stih407-b2120.dts | 1 -
>>   arch/arm/boot/dts/stih410-b2120.dts | 1 -
>>   arch/arm/boot/dts/stih410-b2260.dts | 1 -
>>   arch/arm/boot/dts/stih418-b2199.dts | 1 -
>>   4 files changed, 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts
>> index 2c4d6033b448..074b4cd0ca89 100644
>> --- a/arch/arm/boot/dts/stih407-b2120.dts
>> +++ b/arch/arm/boot/dts/stih407-b2120.dts
>> @@ -15,7 +15,6 @@
>>
>>          chosen {
>>                  bootargs = "console=serial0,115200 clk_ignore_unused";
>> -               stdout-path = &sbc_serial0;
>>          };
>>
>>          memory at 40000000 {
>> diff --git a/arch/arm/boot/dts/stih410-b2120.dts b/arch/arm/boot/dts/stih410-b2120.dts
>> index 5422850641e8..eae3050984d0 100644
>> --- a/arch/arm/boot/dts/stih410-b2120.dts
>> +++ b/arch/arm/boot/dts/stih410-b2120.dts
>> @@ -15,7 +15,6 @@
>>
>>          chosen {
>>                  bootargs = "console=serial0,115200 clk_ignore_unused";
>> -               stdout-path = &sbc_serial0;
>>          };
>>
>>          memory at 40000000 {
>> diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
>> index ca347160e35d..c26e388bd1a4 100644
>> --- a/arch/arm/boot/dts/stih410-b2260.dts
>> +++ b/arch/arm/boot/dts/stih410-b2260.dts
>> @@ -16,7 +16,6 @@
>>
>>          chosen {
>>                  bootargs = "console=serial1,115200 clk_ignore_unused";
>> -               stdout-path = &uart1;
>>          };
>>
>>          memory at 40000000 {
>> diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
>> index dbf7bb704a1a..d948f774fee7 100644
>> --- a/arch/arm/boot/dts/stih418-b2199.dts
>> +++ b/arch/arm/boot/dts/stih418-b2199.dts
>> @@ -15,7 +15,6 @@
>>
>>          chosen {
>>                  bootargs = "console=serial0,115200 clk_ignore_unused";
>> -               stdout-path = &sbc_serial0;
>>          };
>>
>>          memory at 40000000 {
>> --
>> 1.9.1
>>

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: [PATCH v2 3/3] tty: st-asc: Update tty alias
  2018-03-06 13:29     ` Rob Herring
  (?)
@ 2018-03-07  8:01       ` Patrice CHOTARD
  -1 siblings, 0 replies; 21+ messages in thread
From: Patrice CHOTARD @ 2018-03-07  8:01 UTC (permalink / raw)
  To: Rob Herring
  Cc: Mark Rutland, Russell King,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel, devicetree, Greg Kroah-Hartman, Jiri Slaby,
	linux-serial

Hi Rob

On 03/06/2018 02:29 PM, Rob Herring wrote:
> On Tue, Mar 6, 2018 at 2:07 AM,  <patrice.chotard@st.com> wrote:
>> From: Patrice Chotard <patrice.chotard@st.com>
>>
>> Since dtc v1.4.6-9-gaadd0b65c987, aliases property name
>> must include only lowercase and '-'.
>>
>> After having updated all STi boards serial aliases from "ttyASN"
>> to "serialN", st-asc driver need to be updated accordingly as tty
>> aliases id is retrieved using of_alias_get_id(np, ASC_SERIAL_NAME);
> 
> Again, changing the tty name breaks userspace. You can't do that.
> 
> You need to do something like this:
> 
> diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
> index c763253514e9..5f9f01fac6dd 100644
> --- a/drivers/tty/serial/st-asc.c
> +++ b/drivers/tty/serial/st-asc.c
> @@ -782,7 +782,9 @@ static struct asc_port *asc_of_get_asc_port(struct
> platform_device *pdev)
>          if (!np)
>                  return NULL;
> 
> -       id = of_alias_get_id(np, ASC_SERIAL_NAME);
> +       id = of_alias_get_id(np, "serial");
> +       if (id < 0)
> +               id = of_alias_get_id(np, ASC_SERIAL_NAME);
> 
>          if (id < 0)
>                  id = 0;
> 
I will fix this too

Patrice

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: [PATCH v2 3/3] tty: st-asc: Update tty alias
@ 2018-03-07  8:01       ` Patrice CHOTARD
  0 siblings, 0 replies; 21+ messages in thread
From: Patrice CHOTARD @ 2018-03-07  8:01 UTC (permalink / raw)
  To: Rob Herring
  Cc: Mark Rutland, devicetree, Greg Kroah-Hartman, Russell King,
	linux-kernel, linux-serial, Jiri Slaby,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

Hi Rob

On 03/06/2018 02:29 PM, Rob Herring wrote:
> On Tue, Mar 6, 2018 at 2:07 AM,  <patrice.chotard@st.com> wrote:
>> From: Patrice Chotard <patrice.chotard@st.com>
>>
>> Since dtc v1.4.6-9-gaadd0b65c987, aliases property name
>> must include only lowercase and '-'.
>>
>> After having updated all STi boards serial aliases from "ttyASN"
>> to "serialN", st-asc driver need to be updated accordingly as tty
>> aliases id is retrieved using of_alias_get_id(np, ASC_SERIAL_NAME);
> 
> Again, changing the tty name breaks userspace. You can't do that.
> 
> You need to do something like this:
> 
> diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
> index c763253514e9..5f9f01fac6dd 100644
> --- a/drivers/tty/serial/st-asc.c
> +++ b/drivers/tty/serial/st-asc.c
> @@ -782,7 +782,9 @@ static struct asc_port *asc_of_get_asc_port(struct
> platform_device *pdev)
>          if (!np)
>                  return NULL;
> 
> -       id = of_alias_get_id(np, ASC_SERIAL_NAME);
> +       id = of_alias_get_id(np, "serial");
> +       if (id < 0)
> +               id = of_alias_get_id(np, ASC_SERIAL_NAME);
> 
>          if (id < 0)
>                  id = 0;
> 
I will fix this too

Patrice

^ permalink raw reply	[flat|nested] 21+ messages in thread
* [PATCH v2 3/3] tty: st-asc: Update tty alias
@ 2018-03-07  8:01       ` Patrice CHOTARD
  0 siblings, 0 replies; 21+ messages in thread
From: Patrice CHOTARD @ 2018-03-07  8:01 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Rob

On 03/06/2018 02:29 PM, Rob Herring wrote:
> On Tue, Mar 6, 2018 at 2:07 AM,  <patrice.chotard@st.com> wrote:
>> From: Patrice Chotard <patrice.chotard@st.com>
>>
>> Since dtc v1.4.6-9-gaadd0b65c987, aliases property name
>> must include only lowercase and '-'.
>>
>> After having updated all STi boards serial aliases from "ttyASN"
>> to "serialN", st-asc driver need to be updated accordingly as tty
>> aliases id is retrieved using of_alias_get_id(np, ASC_SERIAL_NAME);
> 
> Again, changing the tty name breaks userspace. You can't do that.
> 
> You need to do something like this:
> 
> diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
> index c763253514e9..5f9f01fac6dd 100644
> --- a/drivers/tty/serial/st-asc.c
> +++ b/drivers/tty/serial/st-asc.c
> @@ -782,7 +782,9 @@ static struct asc_port *asc_of_get_asc_port(struct
> platform_device *pdev)
>          if (!np)
>                  return NULL;
> 
> -       id = of_alias_get_id(np, ASC_SERIAL_NAME);
> +       id = of_alias_get_id(np, "serial");
> +       if (id < 0)
> +               id = of_alias_get_id(np, ASC_SERIAL_NAME);
> 
>          if (id < 0)
>                  id = 0;
> 
I will fix this too

Patrice

^ permalink raw reply	[flat|nested] 21+ messages in thread
end of thread, other threads:[~2018-03-07  8:02 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-06  8:07 [PATCH v2 0/3] Fix STi aliases property name patrice.chotard
2018-03-06  8:07 ` patrice.chotard at st.com
2018-03-06  8:07 ` patrice.chotard
2018-03-06  8:07 ` [PATCH v2 1/3] ARM: dts: STi: Fix aliases property name for STi boards patrice.chotard
2018-03-06  8:07   ` patrice.chotard at st.com
2018-03-06  8:07   ` patrice.chotard
2018-03-06  8:07 ` [PATCH v2 2/3] ARM: dts: STi: Remove useless stdout-path " patrice.chotard
2018-03-06  8:07   ` patrice.chotard at st.com
2018-03-06  8:07   ` patrice.chotard
2018-03-06 13:26   ` Rob Herring
2018-03-06 13:26     ` Rob Herring
2018-03-07  7:59     ` Patrice CHOTARD
2018-03-07  7:59       ` Patrice CHOTARD
2018-03-06  8:07 ` [PATCH v2 3/3] tty: st-asc: Update tty alias patrice.chotard
2018-03-06  8:07   ` patrice.chotard at st.com
2018-03-06  8:07   ` patrice.chotard
2018-03-06 13:29   ` Rob Herring
2018-03-06 13:29     ` Rob Herring
2018-03-07  8:01     ` Patrice CHOTARD
2018-03-07  8:01       ` Patrice CHOTARD
2018-03-07  8:01       ` Patrice CHOTARD

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.