All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Russell King <rmk-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Geert Uytterhoeven
	<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
	Pantelis Antoniou
	<pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>,
	Grant Likely
	<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] ARM: OF implies OF_FLATTREE
Date: Tue, 13 Oct 2015 12:08:55 -0500	[thread overview]
Message-ID: <CAL_JsqK5Yym9BbUQuGxAZkDyAmaQCPriKZQQwjR1fY7ypNoQpA@mail.gmail.com> (raw)
In-Reply-To: <61301019.TKW9ocJ2jm@wuerfel>

On Mon, Oct 12, 2015 at 9:06 AM, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:
> On the ARM architecture, individual platforms select CONFIG_USE_OF if they
> need it, but all device tree code is keyed off CONFIG_OF. When building
> a platform without DT support and manually enabling CONFIG_OF, we now
> get a number of build errors, e.g.
>
> arch/arm/kernel/devtree.c: In function 'setup_machine_fdt':
> arch/arm/kernel/devtree.c:215:19: error: implicit declaration of function 'early_init_dt_verify' [-Werror=implicit-function-declaration]
>
> We could now try to separate the use case of booting from DT vs. the
> case of using the dynamic implementation, but that seems more complicated
> than it can gain us.

Agreed. It will only/mostly save init section code at that.

> This simply changes the ARM Kconfig file to always enable OF_RESERVED_MEM
> and OF_EARLY_FLATTREE when CONFIG_OF is enabled. These options add a little
> extra code when we just want the dynamic OF implementation, but that seems
> like a rather obscure case, and this version solves all CONFIG_OF related
> randconfig regressions.
>
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> Fixes: 0166dc11be91 ("of: make CONFIG_OF user selectable")

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index ee104950b30c..da71de8bba4f 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -75,6 +75,8 @@ config ARM
>         select IRQ_FORCED_THREADING
>         select MODULES_USE_ELF_REL
>         select NO_BOOTMEM
> +       select OF_EARLY_FLATTREE if OF
> +       select OF_RESERVED_MEM if OF
>         select OLD_SIGACTION
>         select OLD_SIGSUSPEND3
>         select PERF_USE_VMALLOC
> @@ -1695,8 +1697,6 @@ config USE_OF
>         bool "Flattened Device Tree support"
>         select IRQ_DOMAIN
>         select OF
> -       select OF_EARLY_FLATTREE
> -       select OF_RESERVED_MEM
>         help
>           Include support for flattened device tree machine descriptions.
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OF implies OF_FLATTREE
Date: Tue, 13 Oct 2015 12:08:55 -0500	[thread overview]
Message-ID: <CAL_JsqK5Yym9BbUQuGxAZkDyAmaQCPriKZQQwjR1fY7ypNoQpA@mail.gmail.com> (raw)
In-Reply-To: <61301019.TKW9ocJ2jm@wuerfel>

On Mon, Oct 12, 2015 at 9:06 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On the ARM architecture, individual platforms select CONFIG_USE_OF if they
> need it, but all device tree code is keyed off CONFIG_OF. When building
> a platform without DT support and manually enabling CONFIG_OF, we now
> get a number of build errors, e.g.
>
> arch/arm/kernel/devtree.c: In function 'setup_machine_fdt':
> arch/arm/kernel/devtree.c:215:19: error: implicit declaration of function 'early_init_dt_verify' [-Werror=implicit-function-declaration]
>
> We could now try to separate the use case of booting from DT vs. the
> case of using the dynamic implementation, but that seems more complicated
> than it can gain us.

Agreed. It will only/mostly save init section code at that.

> This simply changes the ARM Kconfig file to always enable OF_RESERVED_MEM
> and OF_EARLY_FLATTREE when CONFIG_OF is enabled. These options add a little
> extra code when we just want the dynamic OF implementation, but that seems
> like a rather obscure case, and this version solves all CONFIG_OF related
> randconfig regressions.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0166dc11be91 ("of: make CONFIG_OF user selectable")

Acked-by: Rob Herring <robh@kernel.org>

>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index ee104950b30c..da71de8bba4f 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -75,6 +75,8 @@ config ARM
>         select IRQ_FORCED_THREADING
>         select MODULES_USE_ELF_REL
>         select NO_BOOTMEM
> +       select OF_EARLY_FLATTREE if OF
> +       select OF_RESERVED_MEM if OF
>         select OLD_SIGACTION
>         select OLD_SIGSUSPEND3
>         select PERF_USE_VMALLOC
> @@ -1695,8 +1697,6 @@ config USE_OF
>         bool "Flattened Device Tree support"
>         select IRQ_DOMAIN
>         select OF
> -       select OF_EARLY_FLATTREE
> -       select OF_RESERVED_MEM
>         help
>           Include support for flattened device tree machine descriptions.
>

  reply	other threads:[~2015-10-13 17:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12 14:06 [PATCH] ARM: OF implies OF_FLATTREE Arnd Bergmann
2015-10-12 14:06 ` Arnd Bergmann
2015-10-13 17:08 ` Rob Herring [this message]
2015-10-13 17:08   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqK5Yym9BbUQuGxAZkDyAmaQCPriKZQQwjR1fY7ypNoQpA@mail.gmail.com \
    --to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
    --cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org \
    --cc=rmk-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.