Re: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager

From: Rob Herring <robh@kernel.org>
To: Nava kishore Manne <navam@xilinx.com>
Cc: "mdf@kernel.org" <mdf@kernel.org>,
	"trix@redhat.com" <trix@redhat.com>,
	Michal Simek <michals@xilinx.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	Jolly Shah <JOLLYS@xilinx.com>, Rajan Vaja <RAJANV@xilinx.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	Manish Narani <MNARANI@xilinx.com>,
	Amit Sunil Dhamne <amitsuni@xilinx.com>,
	Tejas Patel <tejasp@xlnx.xilinx.com>,
	"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"chinnikishore369@gmail.com" <chinnikishore369@gmail.com>,
	Appana Durga Kedareswara Rao <appanad@xilinx.com>
Subject: Re: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager
Date: Wed, 10 Mar 2021 10:19:44 -0700	[thread overview]
Message-ID: <CAL_JsqKAP5Up7=qJEM6E0HuV2-faaVqTg+S=pdD8RpWyJ3KVcQ@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqLDK5pNprA5RJq8VfTbQX=hP-8NUyY6Xsesz3TE6=YYeg@mail.gmail.com>

On Wed, Mar 10, 2021 at 10:12 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Mar 10, 2021 at 3:50 AM Nava kishore Manne <navam@xilinx.com> wrote:
> >
> > Hi Rob,
> >
> >         Thanks for providing the review comments.
> > Please find my response inline.
> >
> > > -----Original Message-----
> > > From: Rob Herring <robh@kernel.org>
> > > Sent: Tuesday, March 9, 2021 1:50 AM
> > > To: Nava kishore Manne <navam@xilinx.com>
> > > Cc: mdf@kernel.org; trix@redhat.com; Michal Simek <michals@xilinx.com>;
> > > gregkh@linuxfoundation.org; Jolly Shah <JOLLYS@xilinx.com>; Rajan Vaja
> > > <RAJANV@xilinx.com>; arnd@arndb.de; Manish Narani
> > > <MNARANI@xilinx.com>; Amit Sunil Dhamne <amitsuni@xilinx.com>; Tejas
> > > Patel <tejasp@xlnx.xilinx.com>; linux-fpga@vger.kernel.org;
> > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> > > kernel@lists.infradead.org; chinnikishore369@gmail.com; Appana Durga
> > > Kedareswara Rao <appanad@xilinx.com>
> > > Subject: Re: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga
> > > manager
> > >
> > > On Thu, Mar 04, 2021 at 12:32:23PM +0530, Nava kishore Manne wrote:
> > > > From: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
> > > >
> > > > This patch adds binding doc for versal fpga manager driver.
> > >
> > > Why do you need a DT entry for this? Can't the Versal firmware driver
> > > instantiate the fpga-mgr device?
> > >
> > This dt entry is need to handle the fpga regions properly for both full and Partial bitstream loading use cases and it cannot be done by Versal firmware driver instantiate.
>
> Ah yes, I forgot about that.

Looking at this some more, please convert xlnx,zynqmp-firmware.txt to
schema and add the node for this there. We don't need a whole other
schema file just for a node and compatible. Also, looks like
xlnx,zynqmp-pcap-fpga.txt is the prior version of the same thing, so
it should be handled in the schema too.

Rob