From: Rob Herring <robh+dt@kernel.org>
To: Yu Tu <yu.tu@amlogic.com>
Cc: "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH V5 1/5] dt-bindings: serial: meson: Drop legacy compatible.
Date: Mon, 10 Jan 2022 10:18:02 -0600 [thread overview]
Message-ID: <CAL_JsqKFLnfc5eaUHeo6EkbS0kkpA94rh=Zuda9V9aCragdVxw@mail.gmail.com> (raw)
In-Reply-To: <20220110104214.25321-2-yu.tu@amlogic.com>
On Mon, Jan 10, 2022 at 4:42 AM Yu Tu <yu.tu@amlogic.com> wrote:
>
> Deprecated, don't use anymore because legacy amlogic,meson-gx-uart
> compatible. Don't differentiate between GXBB, GXL and G12A which
> have different revisions of the UART IP. So it's split into
> GXBB,GXL and G12A.
You are breaking compatibility. If your dts is updated to use the new
compatible, then a kernel without the change will not work anymore. It
worked before without understanding the changes you are making. It
should continue to. A compatible value like this would accomplish what
you want:
"amlogic,meson-gxbb-uart", "amlogic,meson-gx-uart", "amlogic,meson-ao-uart"
A new kernel will match on "amlogic,meson-gxbb-uart" or
"amlogic,meson-gx-uart" depending if the dtb is updated or not. An old
kernel will continue to match on "amlogic,meson-gx-uart".
If you are going to go breaking things, the power domain distinction
in the compatible is odd...
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: Yu Tu <yu.tu@amlogic.com>
Cc: "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH V5 1/5] dt-bindings: serial: meson: Drop legacy compatible.
Date: Mon, 10 Jan 2022 10:18:02 -0600 [thread overview]
Message-ID: <CAL_JsqKFLnfc5eaUHeo6EkbS0kkpA94rh=Zuda9V9aCragdVxw@mail.gmail.com> (raw)
In-Reply-To: <20220110104214.25321-2-yu.tu@amlogic.com>
On Mon, Jan 10, 2022 at 4:42 AM Yu Tu <yu.tu@amlogic.com> wrote:
>
> Deprecated, don't use anymore because legacy amlogic,meson-gx-uart
> compatible. Don't differentiate between GXBB, GXL and G12A which
> have different revisions of the UART IP. So it's split into
> GXBB,GXL and G12A.
You are breaking compatibility. If your dts is updated to use the new
compatible, then a kernel without the change will not work anymore. It
worked before without understanding the changes you are making. It
should continue to. A compatible value like this would accomplish what
you want:
"amlogic,meson-gxbb-uart", "amlogic,meson-gx-uart", "amlogic,meson-ao-uart"
A new kernel will match on "amlogic,meson-gxbb-uart" or
"amlogic,meson-gx-uart" depending if the dtb is updated or not. An old
kernel will continue to match on "amlogic,meson-gx-uart".
If you are going to go breaking things, the power domain distinction
in the compatible is odd...
Rob
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: Yu Tu <yu.tu@amlogic.com>
Cc: "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH V5 1/5] dt-bindings: serial: meson: Drop legacy compatible.
Date: Mon, 10 Jan 2022 10:18:02 -0600 [thread overview]
Message-ID: <CAL_JsqKFLnfc5eaUHeo6EkbS0kkpA94rh=Zuda9V9aCragdVxw@mail.gmail.com> (raw)
In-Reply-To: <20220110104214.25321-2-yu.tu@amlogic.com>
On Mon, Jan 10, 2022 at 4:42 AM Yu Tu <yu.tu@amlogic.com> wrote:
>
> Deprecated, don't use anymore because legacy amlogic,meson-gx-uart
> compatible. Don't differentiate between GXBB, GXL and G12A which
> have different revisions of the UART IP. So it's split into
> GXBB,GXL and G12A.
You are breaking compatibility. If your dts is updated to use the new
compatible, then a kernel without the change will not work anymore. It
worked before without understanding the changes you are making. It
should continue to. A compatible value like this would accomplish what
you want:
"amlogic,meson-gxbb-uart", "amlogic,meson-gx-uart", "amlogic,meson-ao-uart"
A new kernel will match on "amlogic,meson-gxbb-uart" or
"amlogic,meson-gx-uart" depending if the dtb is updated or not. An old
kernel will continue to match on "amlogic,meson-gx-uart".
If you are going to go breaking things, the power domain distinction
in the compatible is odd...
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-10 16:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 10:42 [PATCH V5 0/5] The UART driver compatible with Yu Tu
2022-01-10 10:42 ` Yu Tu
2022-01-10 10:42 ` Yu Tu
2022-01-10 10:42 ` [PATCH V5 1/5] dt-bindings: serial: meson: Drop legacy compatible Yu Tu
2022-01-10 10:42 ` Yu Tu
2022-01-10 10:42 ` Yu Tu
2022-01-10 16:18 ` Rob Herring [this message]
2022-01-10 16:18 ` Rob Herring
2022-01-10 16:18 ` Rob Herring
2022-01-11 7:18 ` Yu Tu
2022-01-11 7:18 ` Yu Tu
2022-01-11 7:18 ` Yu Tu
2022-01-10 10:42 ` [PATCH V5 2/5] tty: serial: meson: Move request the register region Yu Tu
2022-01-10 10:42 ` Yu Tu
2022-01-10 10:42 ` Yu Tu
2022-01-10 11:58 ` Jiri Slaby
2022-01-10 11:58 ` Jiri Slaby
2022-01-10 11:58 ` Jiri Slaby
2022-01-11 2:48 ` Yu Tu
2022-01-11 2:48 ` Yu Tu
2022-01-11 2:48 ` Yu Tu
2022-01-13 7:25 ` Jiri Slaby
2022-01-13 7:25 ` Jiri Slaby
2022-01-13 7:25 ` Jiri Slaby
2022-01-10 10:42 ` [PATCH V5 3/5] tty: serial: meson: Using the common clock code describe Yu Tu
2022-01-10 10:42 ` Yu Tu
2022-01-10 10:42 ` Yu Tu
2022-01-10 12:11 ` Jiri Slaby
2022-01-10 12:11 ` Jiri Slaby
2022-01-10 12:11 ` Jiri Slaby
2022-01-11 3:13 ` Yu Tu
2022-01-11 3:13 ` Yu Tu
2022-01-11 3:13 ` Yu Tu
2022-01-10 10:42 ` [PATCH V5 4/5] tty: serial: meson: Make some bit of the REG5 register writable Yu Tu
2022-01-10 10:42 ` Yu Tu
2022-01-10 10:42 ` Yu Tu
2022-01-10 10:42 ` [PATCH V5 5/5] tty: serial: meson: Added S4 SOC compatibility Yu Tu
2022-01-10 10:42 ` Yu Tu
2022-01-10 10:42 ` Yu Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKFLnfc5eaUHeo6EkbS0kkpA94rh=Zuda9V9aCragdVxw@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=jirislaby@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=yu.tu@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.