All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Nick Kossifidis <mick@ics.forth.gr>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Frank Rowand <frowand.list@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] riscv: Remove non-standard linux,elfcorehdr handling
Date: Wed, 16 Jun 2021 08:47:46 -0600	[thread overview]
Message-ID: <CAL_JsqKJgz=ixNAJProoVFmQXGEOsTYX=bXTdtf7RLQErL1VRg@mail.gmail.com> (raw)
In-Reply-To: <ef1a9a97e0238a0ff2d8e044487602a5@mailhost.ics.forth.gr>

On Wed, Jun 16, 2021 at 4:43 AM Nick Kossifidis <mick@ics.forth.gr> wrote:
>
> Στις 2021-06-16 10:56, Geert Uytterhoeven έγραψε:
> >
> > I can't comment on the duplication on arm64, but to me, /chosen
> > sounds like the natural place for both "linux,elfcorehdr" and
> > "linux,usable-memory-range".  First rule of DT is "DT describes
> > hardware, not software policy", with /chosen describing some software
> > configuration.
> >
>
> We already have "linux,usable-memory" on /memory node:
> https://elixir.bootlin.com/linux/v5.13-rc6/source/drivers/of/fdt.c#L1011
> and it makes perfect sense to be there since it overrides /memory's reg
> property.
>
> Why define another binding for the same thing on /chosen ?

Go look at the thread adding "linux,usable-memory-range". There were
only 35 versions of it[1]. I wasn't happy with a 2nd way either, but
as I've mentioned before we don't always have /memory node.

Rob

[1] https://lore.kernel.org/linux-arm-kernel/20170403022606.12609-1-takahiro.akashi@linaro.org/

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: Nick Kossifidis <mick@ics.forth.gr>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Frank Rowand <frowand.list@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] riscv: Remove non-standard linux,elfcorehdr handling
Date: Wed, 16 Jun 2021 08:47:46 -0600	[thread overview]
Message-ID: <CAL_JsqKJgz=ixNAJProoVFmQXGEOsTYX=bXTdtf7RLQErL1VRg@mail.gmail.com> (raw)
In-Reply-To: <ef1a9a97e0238a0ff2d8e044487602a5@mailhost.ics.forth.gr>

On Wed, Jun 16, 2021 at 4:43 AM Nick Kossifidis <mick@ics.forth.gr> wrote:
>
> Στις 2021-06-16 10:56, Geert Uytterhoeven έγραψε:
> >
> > I can't comment on the duplication on arm64, but to me, /chosen
> > sounds like the natural place for both "linux,elfcorehdr" and
> > "linux,usable-memory-range".  First rule of DT is "DT describes
> > hardware, not software policy", with /chosen describing some software
> > configuration.
> >
>
> We already have "linux,usable-memory" on /memory node:
> https://elixir.bootlin.com/linux/v5.13-rc6/source/drivers/of/fdt.c#L1011
> and it makes perfect sense to be there since it overrides /memory's reg
> property.
>
> Why define another binding for the same thing on /chosen ?

Go look at the thread adding "linux,usable-memory-range". There were
only 35 versions of it[1]. I wasn't happy with a 2nd way either, but
as I've mentioned before we don't always have /memory node.

Rob

[1] https://lore.kernel.org/linux-arm-kernel/20170403022606.12609-1-takahiro.akashi@linaro.org/

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: Nick Kossifidis <mick@ics.forth.gr>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Frank Rowand <frowand.list@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] riscv: Remove non-standard linux,elfcorehdr handling
Date: Wed, 16 Jun 2021 08:47:46 -0600	[thread overview]
Message-ID: <CAL_JsqKJgz=ixNAJProoVFmQXGEOsTYX=bXTdtf7RLQErL1VRg@mail.gmail.com> (raw)
In-Reply-To: <ef1a9a97e0238a0ff2d8e044487602a5@mailhost.ics.forth.gr>

On Wed, Jun 16, 2021 at 4:43 AM Nick Kossifidis <mick@ics.forth.gr> wrote:
>
> Στις 2021-06-16 10:56, Geert Uytterhoeven έγραψε:
> >
> > I can't comment on the duplication on arm64, but to me, /chosen
> > sounds like the natural place for both "linux,elfcorehdr" and
> > "linux,usable-memory-range".  First rule of DT is "DT describes
> > hardware, not software policy", with /chosen describing some software
> > configuration.
> >
>
> We already have "linux,usable-memory" on /memory node:
> https://elixir.bootlin.com/linux/v5.13-rc6/source/drivers/of/fdt.c#L1011
> and it makes perfect sense to be there since it overrides /memory's reg
> property.
>
> Why define another binding for the same thing on /chosen ?

Go look at the thread adding "linux,usable-memory-range". There were
only 35 versions of it[1]. I wasn't happy with a 2nd way either, but
as I've mentioned before we don't always have /memory node.

Rob

[1] https://lore.kernel.org/linux-arm-kernel/20170403022606.12609-1-takahiro.akashi@linaro.org/

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-16 14:48 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 18:17 [PATCH 0/3] Add generic-support for linux,elfcorehdr and fix riscv Geert Uytterhoeven
2021-06-15 18:17 ` Geert Uytterhoeven
2021-06-15 18:17 ` Geert Uytterhoeven
2021-06-15 18:17 ` [PATCH 1/3] of: fdt: Add generic support for parsing elf core header properties Geert Uytterhoeven
2021-06-15 18:17   ` Geert Uytterhoeven
2021-06-15 18:17   ` Geert Uytterhoeven
2021-06-15 19:54   ` Rob Herring
2021-06-15 19:54     ` Rob Herring
2021-06-15 19:54     ` Rob Herring
2021-06-15 23:28   ` Nick Kossifidis
2021-06-15 23:28     ` Nick Kossifidis
2021-06-15 23:28     ` Nick Kossifidis
2021-06-16  7:58     ` Geert Uytterhoeven
2021-06-16  7:58       ` Geert Uytterhoeven
2021-06-16  7:58       ` Geert Uytterhoeven
2021-06-15 18:17 ` [PATCH 2/3] riscv: Remove non-standard linux,elfcorehdr handling Geert Uytterhoeven
2021-06-15 18:17   ` Geert Uytterhoeven
2021-06-15 18:17   ` Geert Uytterhoeven
2021-06-15 18:40   ` Nick Kossifidis
2021-06-15 18:40     ` Nick Kossifidis
2021-06-15 18:40     ` Nick Kossifidis
2021-06-15 19:54     ` Rob Herring
2021-06-15 19:54       ` Rob Herring
2021-06-15 19:54       ` Rob Herring
2021-06-15 23:19       ` Nick Kossifidis
2021-06-15 23:19         ` Nick Kossifidis
2021-06-15 23:19         ` Nick Kossifidis
2021-06-16  7:56         ` Geert Uytterhoeven
2021-06-16  7:56           ` Geert Uytterhoeven
2021-06-16  7:56           ` Geert Uytterhoeven
2021-06-16 10:43           ` Nick Kossifidis
2021-06-16 10:43             ` Nick Kossifidis
2021-06-16 10:43             ` Nick Kossifidis
2021-06-16 14:47             ` Rob Herring [this message]
2021-06-16 14:47               ` Rob Herring
2021-06-16 14:47               ` Rob Herring
2021-07-01  2:52               ` Palmer Dabbelt
2021-07-01  2:52                 ` Palmer Dabbelt
2021-07-01  2:52                 ` Palmer Dabbelt
2021-07-02 15:56                 ` Nick Kossifidis
2021-07-02 15:56                   ` Nick Kossifidis
2021-07-02 15:56                   ` Nick Kossifidis
2021-06-15 18:17 ` [PATCH 3/3] arm64: kdump: Remove custom linux,elfcorehdr parsing Geert Uytterhoeven
2021-06-15 18:17   ` Geert Uytterhoeven
2021-06-15 18:17   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_JsqKJgz=ixNAJProoVFmQXGEOsTYX=bXTdtf7RLQErL1VRg@mail.gmail.com' \
    --to=robh+dt@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mick@ics.forth.gr \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.