Re: [PATCH 02/13] driver-core: defer all probes until late_initcall

From: Rob Herring <robherring2@gmail.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Alexander Holler" <holler@ahsoftware.de>,
	"Alexandre Courbot" <gnurou@gmail.com>,
	"Andrzej Hajda" <a.hajda@samsung.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Grant Likely" <grant.likely@linaro.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Javier Martinez Canillas" <javier.martinez@collabora.co.uk>,
	"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Len Brown" <lenb@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Lv Zheng" <lv.zheng@intel.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Robert Moore" <robert.moore@intel.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Russell King" <linux@arm.linux.org.uk>,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	Terje =?ISO-8859-1 ?Q?Bergstr=F6m?= <tbergstrom@nvidia.com>,
	"Thierry Reding" <thierry.reding@gmail.com>
Subject: Re: [PATCH 02/13] driver-core: defer all probes until late_initcall
Date: Mon, 22 Jun 2015 19:07:08 -0500	[thread overview]
Message-ID: <CAL_JsqKTm-F2oajuj07W=DBBjH03FTnqNkGbizERmajCPgjnGg@mail.gmail.com> (raw)
In-Reply-To: <1585940.7Lfuk0LdBK@vostro.rjw.lan>

On Fri, Jun 19, 2015 at 6:20 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Friday, June 19, 2015 03:36:46 PM Tomeu Vizoso wrote:
>> On 18 June 2015 at 23:50, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>> > On Wednesday, June 17, 2015 03:42:12 PM Tomeu Vizoso wrote:
>> >> To decrease the chances of devices deferring their probes because of
>> >> dependencies not having probed yet because of their drivers not having
>> >> registered yet, delay all probing until the late initcall level.
>> >>
>> >> This will allow us to avoid deferred probes completely later by probing
>> >> dependencies on demand, or by probing them in dependency order.
>> >>
>> >> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>> >> ---
>> >>  drivers/base/dd.c | 8 +++++++-
>> >>  1 file changed, 7 insertions(+), 1 deletion(-)
>> >>
>> >> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
>> >> index a638bbb..18438aa 100644
>> >> --- a/drivers/base/dd.c
>> >> +++ b/drivers/base/dd.c
>> >> @@ -407,6 +407,12 @@ int driver_probe_device(struct device_driver *drv, struct device *dev)
>> >>       if (!device_is_registered(dev))
>> >>               return -ENODEV;
>> >>
>> >> +     /* Defer all probes until we start processing the queue */
>> >> +     if (!driver_deferred_probe_enable) {
>> >> +             driver_deferred_probe_add(dev);
>> >
>> > Do I think correctly that this will effectively force everybody to use deferred
>> > probing?
>>
>> Guess it depends on the meaning of "using deferred probing". It will
>> defer the probe of the first device to late_initcall (which will
>> happen much earlier in time than before), but afterwards all built-in
>> drivers will be available and depending on the order in which we try
>> to probe devices, none may actually ask to defer its probe.
>
> So this will break things like the PNP system driver which relies on probing
> stuff at the fs_initcall stage for correctness.  It may also break other
> things with similar assumptions.

Yes, but I think that this can be done for only OF based devices
rather than globally for all platform devices and solve that problem.
Matching is already dependent of the type of device.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/