Re: Re: [PATCH v6 11/11] arm64: dts: mt7986: add BPI-R3 nand/nor overlays

[Rob Herring <robh@kernel.org>]

On Sat, Nov 26, 2022 at 9:00 AM Frank Wunderlich
<frank-w@public-files.de> wrote:
>
> > Gesendet: Sonntag, 20. November 2022 um 17:12 Uhr
> > Von: "Rob Herring" <robh@kernel.org>
>
> > > Or should these overlays only duplicated and either include sd dts or emmc dts (but this creates again redundant code)?
> > > >> >> --- a/arch/arm64/boot/dts/mediatek/Makefile
> > > >> >> +++ b/arch/arm64/boot/dts/mediatek/Makefile
> > > >> >> @@ -8,6 +8,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb
> > > >> >>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb
> > > >> >>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb
> > > >> >>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtb
> > > >> >> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
> > > >> >> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
> > > >> >
> > > >> >These need rules to apply them to the base dtb(s). You just need:
> > > >> >
> > > >> >full.dtb := base.dtb overlay.dtb
> > > >> >dtb-y += full.dtb
>
> Hi,
>
> (removed most recipients to not spam all people with this)
>
> have now locally changed sd+emmc to overlays too and renamed to dtso...
> tried also this way to (arch/arm64/boot/dts/mediatek/Makefile):
>
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
>
> mt7986a-bananapi-bpi-r3-sd-nand.dtb := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
>
> does not work:
>
> make[3]: *** No rule to make target 'arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sd-nand.dtb', needed by 'arch/arm64/boot/dts/mediatek/'.  Stop.
>
> any thoughts? but this way i will need all possible combinations, i guess best way it to leave the overlays themselves.

You missed my correction:

full-dtbs := base.dtb overlay.dtb
dtb-y += full.dtb

Rob