Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery

From: Rob Herring <robh+dt@kernel.org>
To: Nishanth Menon <nm@ti.com>
Cc: "Laxman Dewangan" <ldewangan@nvidia.com>,
	"H. Nikolaus Schaller" <hns@goldelico.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Russell King" <linux@arm.linux.org.uk>,
	linux-omap <linux-omap@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Marek Belisko" <marek@goldelico.com>
Subject: Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery
Date: Fri, 8 Jan 2016 13:33:59 -0600	[thread overview]
Message-ID: <CAL_JsqKpEcQTrwDdY2JquzNs_yFu_1OgNmU=-vGwEmSLEtrqgA@mail.gmail.com> (raw)
In-Reply-To: <568D70A3.2070007@ti.com>

On Wed, Jan 6, 2016 at 1:53 PM, Nishanth Menon <nm@ti.com> wrote:
> On 01/06/2016 01:34 PM, Rob Herring wrote:
>> On Wed, Jan 6, 2016 at 8:36 AM, Nishanth Menon <nm@ti.com> wrote:
>>> On 01/06/2016 02:13 AM, Laxman Dewangan wrote:
>>>>
>>>> On Wednesday 06 January 2016 01:12 PM, H. Nikolaus Schaller wrote:
>>>>> Hi,
>>>>>
>>>>> Am 06.01.2016 um 00:40 schrieb Nishanth Menon <nm@ti.com>:
>>>>>
>>>>>> On 01/05/2016 06:01 AM, H. Nikolaus Schaller wrote:
>>>>>>> +        rtc {
>>>>>>> +            compatible = "ti,palmas-rtc";
>>>>>>> +            interrupt-parent = <&palmas>;
>>>>>>> +            interrupts = <8 IRQ_TYPE_NONE>;
>>>>>> IRQ_TYPE_NONE is not correct here -> it should have some polarity - if
>>>>>> it had none, there'd be no interrupt, right?
>>>>> Well, it just translates IRQ_TYPE_NONE through
>>>>>
>>>>> Linux/include/dt-bindings/interrupt-controller/irq.h
>>>>>
>>>>> to
>>>>>
>>>>> interrupts = <8 0>;
>>>>>
>>>>> which is given as an example in
>>>>>
>>>>> Documentation//devicetree/bindings/rtc/rtc-palmas.txt
>>>>>
>>>>> Since I don't know anything about the rtc driver beyond the bindings
>>>>> documentation I assume it is correct...
>>>>> I have added Laxman Dewangan because he introduced this interrupts =
>>>>> <8 0>;
>>>>>
>>>>
>>>> As this is for palmas interrupt controller, it does not use the second
>>>> field for interrupt from RTC.
>>>> So there is no really any polarity. It can be set to 0.
>>>>
>>>> The second argument will be used for GPIOs mainly. However, support need
>>>> to be added on GPIO driver for rising/falling configuration.
>>>
>>>
>>> Device tree represents the hardware - not to reflect how the driver
>>> works. if the driver is wrong, fix it. the interrupt polarity needs to
>>> be described in DT. based on palmas like designs, you should probably
>>> use IRQ_TYPE_EDGE_FALLING because that is the default signaling inside
>>> the SoC as it reaches Secondary interrupt handlers(SIH) registers.
>>
>> If the trigger type is not programmable, then not setting the trigger
>> type in the DT is fine. Internal connections are often not documented.
>>
>
> Weird, that is not what I got feedback when I send
> https://patchwork.ozlabs.org/patch/381125/
>
> If this is the new norm, I retract my objection.

I'm not saying that necessarily makes sense here. Given the above, you do know the polarity.

To put it another way, if the trigger type doesn't matter, why do you have a second cell?

Rob