From: Laxman Dewangan <ldewangan@nvidia.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>, Nishanth Menon <nm@ti.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Russell King" <linux@arm.linux.org.uk>,
linux-omap <linux-omap@vger.kernel.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Marek Belisko" <marek@goldelico.com>
Subject: Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery
Date: Wed, 6 Jan 2016 13:43:22 +0530 [thread overview]
Message-ID: <568CCCA2.4040004@nvidia.com> (raw)
In-Reply-To: <B2CEA92E-5F60-43C1-8265-F7C66FBD90D6@goldelico.com>
On Wednesday 06 January 2016 01:12 PM, H. Nikolaus Schaller wrote:
> Hi,
>
> Am 06.01.2016 um 00:40 schrieb Nishanth Menon <nm@ti.com>:
>
>> On 01/05/2016 06:01 AM, H. Nikolaus Schaller wrote:
>>> + rtc {
>>> + compatible = "ti,palmas-rtc";
>>> + interrupt-parent = <&palmas>;
>>> + interrupts = <8 IRQ_TYPE_NONE>;
>> IRQ_TYPE_NONE is not correct here -> it should have some polarity - if
>> it had none, there'd be no interrupt, right?
> Well, it just translates IRQ_TYPE_NONE through
>
> Linux/include/dt-bindings/interrupt-controller/irq.h
>
> to
>
> interrupts = <8 0>;
>
> which is given as an example in
>
> Documentation//devicetree/bindings/rtc/rtc-palmas.txt
>
> Since I don't know anything about the rtc driver beyond the bindings documentation I assume it is correct...
> I have added Laxman Dewangan because he introduced this interrupts = <8 0>;
>
As this is for palmas interrupt controller, it does not use the second
field for interrupt from RTC.
So there is no really any polarity. It can be set to 0.
The second argument will be used for GPIOs mainly. However, support need
to be added on GPIO driver for rising/falling configuration.
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: "H. Nikolaus Schaller"
<hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>,
Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
Cc: "Benoît Cousson"
<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"Tony Lindgren" <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Pawel Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Ian Campbell"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"Russell King" <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
linux-omap <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Marek Belisko" <marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
Subject: Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery
Date: Wed, 6 Jan 2016 13:43:22 +0530 [thread overview]
Message-ID: <568CCCA2.4040004@nvidia.com> (raw)
In-Reply-To: <B2CEA92E-5F60-43C1-8265-F7C66FBD90D6-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
On Wednesday 06 January 2016 01:12 PM, H. Nikolaus Schaller wrote:
> Hi,
>
> Am 06.01.2016 um 00:40 schrieb Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>:
>
>> On 01/05/2016 06:01 AM, H. Nikolaus Schaller wrote:
>>> + rtc {
>>> + compatible = "ti,palmas-rtc";
>>> + interrupt-parent = <&palmas>;
>>> + interrupts = <8 IRQ_TYPE_NONE>;
>> IRQ_TYPE_NONE is not correct here -> it should have some polarity - if
>> it had none, there'd be no interrupt, right?
> Well, it just translates IRQ_TYPE_NONE through
>
> Linux/include/dt-bindings/interrupt-controller/irq.h
>
> to
>
> interrupts = <8 0>;
>
> which is given as an example in
>
> Documentation//devicetree/bindings/rtc/rtc-palmas.txt
>
> Since I don't know anything about the rtc driver beyond the bindings documentation I assume it is correct...
> I have added Laxman Dewangan because he introduced this interrupts = <8 0>;
>
As this is for palmas interrupt controller, it does not use the second
field for interrupt from RTC.
So there is no really any polarity. It can be set to 0.
The second argument will be used for GPIOs mainly. However, support need
to be added on GPIO driver for rising/falling configuration.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-06 8:23 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 12:01 [PATCH 0/3] Enable twl603x-GPADC for some OMAP4/OMAP5 boards and Palmas-RTC for OMAP5 H. Nikolaus Schaller
2016-01-05 12:01 ` [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery H. Nikolaus Schaller
2016-01-05 12:01 ` H. Nikolaus Schaller
2016-01-05 23:40 ` Nishanth Menon
2016-01-05 23:40 ` Nishanth Menon
2016-01-06 1:00 ` Tony Lindgren
2016-01-06 1:00 ` Tony Lindgren
2016-01-06 8:11 ` H. Nikolaus Schaller
2016-01-06 16:41 ` Tony Lindgren
2016-01-06 16:41 ` Tony Lindgren
2016-01-06 16:47 ` H. Nikolaus Schaller
2016-01-06 17:09 ` Tony Lindgren
2016-01-06 17:09 ` Tony Lindgren
2016-01-08 17:49 ` H. Nikolaus Schaller
2016-01-08 18:15 ` Tony Lindgren
2016-01-08 18:32 ` H. Nikolaus Schaller
2016-01-08 18:32 ` H. Nikolaus Schaller
2016-01-08 19:04 ` Tony Lindgren
2016-01-08 19:31 ` H. Nikolaus Schaller
2016-01-11 20:24 ` Tony Lindgren
2016-01-12 0:09 ` Tony Lindgren
2016-01-12 0:09 ` Tony Lindgren
2016-01-12 13:30 ` H. Nikolaus Schaller
2016-01-12 13:30 ` H. Nikolaus Schaller
2016-01-12 21:27 ` H. Nikolaus Schaller
2016-01-12 21:37 ` Nishanth Menon
2016-01-12 21:37 ` Nishanth Menon
2016-01-12 22:13 ` Tony Lindgren
2016-01-12 22:13 ` Tony Lindgren
2016-01-13 10:25 ` H. Nikolaus Schaller
2016-01-13 14:55 ` Nishanth Menon
2016-01-13 15:14 ` Grygorii Strashko
2016-01-13 15:14 ` Grygorii Strashko
2016-01-13 16:48 ` Tony Lindgren
2016-01-13 17:12 ` Grygorii Strashko
2016-01-13 17:38 ` Nishanth Menon
2016-01-13 18:00 ` H. Nikolaus Schaller
2016-01-13 18:23 ` Nishanth Menon
2016-01-13 17:29 ` Nishanth Menon
2016-01-13 18:00 ` Tony Lindgren
2016-01-13 18:08 ` H. Nikolaus Schaller
2016-01-13 18:08 ` H. Nikolaus Schaller
2016-01-13 18:31 ` Nishanth Menon
2016-01-13 18:31 ` Nishanth Menon
2016-01-13 18:44 ` H. Nikolaus Schaller
2016-01-13 18:44 ` H. Nikolaus Schaller
2016-01-13 19:05 ` Nishanth Menon
2016-01-13 19:22 ` Grygorii Strashko
2016-01-13 19:40 ` Tony Lindgren
2016-01-13 22:32 ` Nishanth Menon
2016-01-14 10:01 ` Keerthy
2016-01-14 17:39 ` Nishanth Menon
2016-01-14 17:39 ` Nishanth Menon
2016-01-14 18:35 ` Tony Lindgren
2016-01-14 18:35 ` Tony Lindgren
2016-01-15 14:33 ` H. Nikolaus Schaller
2016-01-15 15:47 ` Tony Lindgren
2016-01-15 17:10 ` Tony Lindgren
2016-01-15 17:10 ` Tony Lindgren
2016-01-15 18:11 ` H. Nikolaus Schaller
2016-08-25 2:43 ` Matthijs van Duin
2016-01-13 18:18 ` Nishanth Menon
2016-01-06 7:42 ` H. Nikolaus Schaller
2016-01-06 8:13 ` Laxman Dewangan [this message]
2016-01-06 8:13 ` Laxman Dewangan
2016-01-06 14:36 ` Nishanth Menon
2016-01-06 19:34 ` Rob Herring
2016-01-06 19:34 ` Rob Herring
2016-01-06 19:53 ` Nishanth Menon
2016-01-06 19:53 ` Nishanth Menon
2016-01-08 19:33 ` Rob Herring
2016-01-05 12:01 ` [PATCH 2/3] ARM: dts: omap5-board-common: enable iio gpadc for Palmas H. Nikolaus Schaller
2016-01-05 12:01 ` H. Nikolaus Schaller
2016-01-05 12:01 ` [PATCH 3/3] ARM: dts: twl6030: add gpadc H. Nikolaus Schaller
2016-01-05 12:01 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568CCCA2.4040004@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=hns@goldelico.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marek@goldelico.com \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.