All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Michael van der Westhuizen
	<michael-XrNoQAPr3WXM9gW82pYGhQ@public.gmane.org>
Cc: "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Steffen Trumtrar
	<s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Thor Thayer
	<tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
	Andy Shevchenko
	<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [RESEND PATCH v2 1/2] dt: snps,dw-apb-ssi: Document new I/O data register width property
Date: Mon, 27 Jul 2015 08:35:53 -0500	[thread overview]
Message-ID: <CAL_JsqKwO0__jT_c8dYsp-LoreoTdC+_qmjj_s-UqGPfSrxdzg@mail.gmail.com> (raw)
In-Reply-To: <1437997035-3046-2-git-send-email-michael-XrNoQAPr3WXM9gW82pYGhQ@public.gmane.org>

On Mon, Jul 27, 2015 at 6:37 AM, Michael van der Westhuizen
<michael-XrNoQAPr3WXM9gW82pYGhQ@public.gmane.org> wrote:
> This change documents a new property for the snps,dw-apb-ssi device,
> allowing an implementer to specify either four byte or two bytes
> access to the SPI controller data register.
>
> This supports a change that unbreaks this driver on picoXcell
> platforms.
>
> Signed-off-by: Michael van der Westhuizen <michael-XrNoQAPr3WXM9gW82pYGhQ@public.gmane.org>
> ---
>
> Changes in v2:
>   - Incorporate review feedback from Andy Shevchenko, reworking the
>     bindings to reflect common practice.
>
>  Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt
> index bd99193..b4f1086 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt
> @@ -10,6 +10,8 @@ Required properties:
>  Optional properties:
>  - cs-gpios : Specifies the gpio pis to be used for chipselects.
>  - num-cs : The number of chipselects. If omitted, this will default to 4.
> +- snps,reg-io-width : The I/O register width (in bytes) implemented by
> +  this device.  Supported values are 2 or 4 (the default).

Drop the snps as this is already a common property (at least for UARTs).

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v2 1/2] dt: snps, dw-apb-ssi: Document new I/O data register width property
Date: Mon, 27 Jul 2015 08:35:53 -0500	[thread overview]
Message-ID: <CAL_JsqKwO0__jT_c8dYsp-LoreoTdC+_qmjj_s-UqGPfSrxdzg@mail.gmail.com> (raw)
In-Reply-To: <1437997035-3046-2-git-send-email-michael@smart-africa.com>

On Mon, Jul 27, 2015 at 6:37 AM, Michael van der Westhuizen
<michael@smart-africa.com> wrote:
> This change documents a new property for the snps,dw-apb-ssi device,
> allowing an implementer to specify either four byte or two bytes
> access to the SPI controller data register.
>
> This supports a change that unbreaks this driver on picoXcell
> platforms.
>
> Signed-off-by: Michael van der Westhuizen <michael@smart-africa.com>
> ---
>
> Changes in v2:
>   - Incorporate review feedback from Andy Shevchenko, reworking the
>     bindings to reflect common practice.
>
>  Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt
> index bd99193..b4f1086 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt
> @@ -10,6 +10,8 @@ Required properties:
>  Optional properties:
>  - cs-gpios : Specifies the gpio pis to be used for chipselects.
>  - num-cs : The number of chipselects. If omitted, this will default to 4.
> +- snps,reg-io-width : The I/O register width (in bytes) implemented by
> +  this device.  Supported values are 2 or 4 (the default).

Drop the snps as this is already a common property (at least for UARTs).

Rob

  parent reply	other threads:[~2015-07-27 13:35 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-19  8:43 [PATCH 0/2] spi: dw: Reintroduce optional 16 bit data register I/O Michael van der Westhuizen
2015-06-19  8:43 ` Michael van der Westhuizen
     [not found] ` <1434703435-25198-1-git-send-email-michael-XrNoQAPr3WXM9gW82pYGhQ@public.gmane.org>
2015-06-19  8:43   ` [PATCH 2/2] dt: snps,dw-apb-ssi: Describe 16 bit data register usage limitations Michael van der Westhuizen
2015-06-19  8:43     ` [PATCH 2/2] dt: snps, dw-apb-ssi: " Michael van der Westhuizen
2015-06-19  8:43   ` [PATCH 1/2] spi: dw: Allow interface drivers to limit data I/O to word sizes Michael van der Westhuizen
2015-06-19  8:43     ` Michael van der Westhuizen
     [not found]     ` <1434703435-25198-3-git-send-email-michael-XrNoQAPr3WXM9gW82pYGhQ@public.gmane.org>
2015-06-24 11:57       ` Andy Shevchenko
2015-06-24 11:57         ` Andy Shevchenko
2015-06-24 16:11         ` Michael van der Westhuizen
2015-06-24 16:34   ` [PATCH v2 0/2] spi: dw: Reintroduce optional 16 bit data register I/O Michael van der Westhuizen
2015-06-24 16:34     ` Michael van der Westhuizen
     [not found]     ` <1435163696-14767-1-git-send-email-michael-XrNoQAPr3WXM9gW82pYGhQ@public.gmane.org>
2015-06-24 16:34       ` [PATCH v2 1/2] dt: snps,dw-apb-ssi: Document new I/O data register width property Michael van der Westhuizen
2015-06-24 16:34         ` [PATCH v2 1/2] dt: snps, dw-apb-ssi: " Michael van der Westhuizen
2015-06-24 16:34       ` [PATCH v2 2/2] spi: dw: Allow interface drivers to limit data I/O to word sizes Michael van der Westhuizen
2015-06-24 16:34         ` Michael van der Westhuizen
     [not found]         ` <1435163696-14767-3-git-send-email-michael-XrNoQAPr3WXM9gW82pYGhQ@public.gmane.org>
2015-06-25 14:41           ` Andy Shevchenko
2015-06-25 14:41             ` Andy Shevchenko
2015-07-24 15:30       ` [PATCH v2 0/2] spi: dw: Reintroduce optional 16 bit data register I/O Andy Shevchenko
2015-07-24 15:30         ` Andy Shevchenko
     [not found]         ` <1437751812.29746.74.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-07-24 15:37           ` Mark Brown
2015-07-24 15:37             ` Mark Brown
     [not found]             ` <20150724153704.GM11162-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-07-27 10:58               ` Andy Shevchenko
2015-07-27 10:58                 ` Andy Shevchenko
     [not found]                 ` <1437994691.29746.80.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-07-27 11:19                   ` Mark Brown
2015-07-27 11:19                     ` Mark Brown
     [not found]                     ` <20150727111944.GW11162-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-07-27 11:38                       ` Michael van der Westhuizen
2015-07-27 11:38                         ` Michael van der Westhuizen
     [not found]                         ` <CCC70BC0-E1D0-4C27-A44D-2D16ED9B3049-XrNoQAPr3WXM9gW82pYGhQ@public.gmane.org>
2015-07-27 13:59                           ` Mark Brown
2015-07-27 13:59                             ` Mark Brown
     [not found]                             ` <20150727135915.GY11162-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-08-18 10:29                               ` Andy Shevchenko
2015-08-18 10:29                                 ` Andy Shevchenko
2015-07-27 11:37       ` [RESEND PATCH " Michael van der Westhuizen
2015-07-27 11:37         ` Michael van der Westhuizen
     [not found]         ` <1437997035-3046-1-git-send-email-michael-XrNoQAPr3WXM9gW82pYGhQ@public.gmane.org>
2015-07-27 11:37           ` [RESEND PATCH v2 1/2] dt: snps,dw-apb-ssi: Document new I/O data register width property Michael van der Westhuizen
2015-07-27 11:37             ` [RESEND PATCH v2 1/2] dt: snps, dw-apb-ssi: " Michael van der Westhuizen
     [not found]             ` <1437997035-3046-2-git-send-email-michael-XrNoQAPr3WXM9gW82pYGhQ@public.gmane.org>
2015-07-27 13:35               ` Rob Herring [this message]
2015-07-27 13:35                 ` Rob Herring
2015-07-27 11:37           ` [RESEND PATCH v2 2/2] spi: dw: Allow interface drivers to limit data I/O to word sizes Michael van der Westhuizen
2015-07-27 11:37             ` Michael van der Westhuizen
     [not found]             ` <1437997035-3046-3-git-send-email-michael-XrNoQAPr3WXM9gW82pYGhQ@public.gmane.org>
2015-08-18 10:36               ` Andy Shevchenko
2015-08-18 10:36                 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqKwO0__jT_c8dYsp-LoreoTdC+_qmjj_s-UqGPfSrxdzg@mail.gmail.com \
    --to=robherring2-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=michael-XrNoQAPr3WXM9gW82pYGhQ@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.