From: Rob Herring <robh+dt@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/8] of/address: Introduce of_dma_get_max_cpu_address()
Date: Fri, 16 Oct 2020 08:19:47 -0500 [thread overview]
Message-ID: <CAL_JsqKyRby5tp2JS1COodYf7F7sB_DJivyAe7FqQivp4KM6OA@mail.gmail.com> (raw)
In-Reply-To: <20201015054244.GD12218@lst.de>
On Thu, Oct 15, 2020 at 12:42 AM Christoph Hellwig <hch@lst.de> wrote:
>
> > +phys_addr_t __init of_dma_get_max_cpu_address(struct device_node *np)
> > +{
> > + phys_addr_t max_cpu_addr = PHYS_ADDR_MAX;
> > + struct of_range_parser parser;
> > + phys_addr_t subtree_max_addr;
> > + struct device_node *child;
> > + phys_addr_t cpu_end = 0;
> > + struct of_range range;
> > + const __be32 *ranges;
> > + int len;
> > +
> > + if (!np)
> > + np = of_root;
>
> Requiring of_root to be passed explicitly would seem more natural
> to me than the magic NULL argument. There doesn't seem to be any
> precedent for that kind of calling convention either.
I prefer that of_root is not more widely exposed and NULL regularly
means 'the whole tree'.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: devicetree@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Robin Murphy <robin.murphy@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 3/8] of/address: Introduce of_dma_get_max_cpu_address()
Date: Fri, 16 Oct 2020 08:19:47 -0500 [thread overview]
Message-ID: <CAL_JsqKyRby5tp2JS1COodYf7F7sB_DJivyAe7FqQivp4KM6OA@mail.gmail.com> (raw)
In-Reply-To: <20201015054244.GD12218@lst.de>
On Thu, Oct 15, 2020 at 12:42 AM Christoph Hellwig <hch@lst.de> wrote:
>
> > +phys_addr_t __init of_dma_get_max_cpu_address(struct device_node *np)
> > +{
> > + phys_addr_t max_cpu_addr = PHYS_ADDR_MAX;
> > + struct of_range_parser parser;
> > + phys_addr_t subtree_max_addr;
> > + struct device_node *child;
> > + phys_addr_t cpu_end = 0;
> > + struct of_range range;
> > + const __be32 *ranges;
> > + int len;
> > +
> > + if (!np)
> > + np = of_root;
>
> Requiring of_root to be passed explicitly would seem more natural
> to me than the magic NULL argument. There doesn't seem to be any
> precedent for that kind of calling convention either.
I prefer that of_root is not more widely exposed and NULL regularly
means 'the whole tree'.
Rob
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: devicetree@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Robin Murphy <robin.murphy@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 3/8] of/address: Introduce of_dma_get_max_cpu_address()
Date: Fri, 16 Oct 2020 08:19:47 -0500 [thread overview]
Message-ID: <CAL_JsqKyRby5tp2JS1COodYf7F7sB_DJivyAe7FqQivp4KM6OA@mail.gmail.com> (raw)
In-Reply-To: <20201015054244.GD12218@lst.de>
On Thu, Oct 15, 2020 at 12:42 AM Christoph Hellwig <hch@lst.de> wrote:
>
> > +phys_addr_t __init of_dma_get_max_cpu_address(struct device_node *np)
> > +{
> > + phys_addr_t max_cpu_addr = PHYS_ADDR_MAX;
> > + struct of_range_parser parser;
> > + phys_addr_t subtree_max_addr;
> > + struct device_node *child;
> > + phys_addr_t cpu_end = 0;
> > + struct of_range range;
> > + const __be32 *ranges;
> > + int len;
> > +
> > + if (!np)
> > + np = of_root;
>
> Requiring of_root to be passed explicitly would seem more natural
> to me than the magic NULL argument. There doesn't seem to be any
> precedent for that kind of calling convention either.
I prefer that of_root is not more widely exposed and NULL regularly
means 'the whole tree'.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-16 13:20 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 19:12 [PATCH v3 0/8] arm64: Default to 32-bit wide ZONE_DMA Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` [PATCH v3 1/8] arm64: mm: Move reserve_crashkernel() into mem_init() Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-15 8:40 ` Will Deacon
2020-10-15 8:40 ` Will Deacon
2020-10-15 8:40 ` Will Deacon
2020-10-15 8:55 ` Nicolas Saenz Julienne
2020-10-15 8:55 ` Nicolas Saenz Julienne
2020-10-15 8:55 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` [PATCH v3 2/8] arm64: mm: Move zone_dma_bits initialization into zone_sizes_init() Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` [PATCH v3 3/8] of/address: Introduce of_dma_get_max_cpu_address() Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 22:02 ` Rob Herring
2020-10-14 22:02 ` Rob Herring
2020-10-14 22:02 ` Rob Herring
2020-10-15 6:56 ` Ard Biesheuvel
2020-10-15 6:56 ` Ard Biesheuvel
2020-10-15 6:56 ` Ard Biesheuvel
2020-10-15 9:16 ` Nicolas Saenz Julienne
2020-10-15 9:16 ` Nicolas Saenz Julienne
2020-10-15 9:16 ` Nicolas Saenz Julienne
2020-10-15 9:18 ` Ard Biesheuvel
2020-10-15 9:18 ` Ard Biesheuvel
2020-10-15 9:18 ` Ard Biesheuvel
2020-10-15 8:54 ` Nicolas Saenz Julienne
2020-10-15 8:54 ` Nicolas Saenz Julienne
2020-10-15 8:54 ` Nicolas Saenz Julienne
2020-10-15 5:42 ` Christoph Hellwig
2020-10-15 5:42 ` Christoph Hellwig
2020-10-15 5:42 ` Christoph Hellwig
2020-10-15 10:03 ` Nicolas Saenz Julienne
2020-10-15 10:03 ` Nicolas Saenz Julienne
2020-10-15 10:03 ` Nicolas Saenz Julienne
2020-10-16 13:19 ` Rob Herring [this message]
2020-10-16 13:19 ` Rob Herring
2020-10-16 13:19 ` Rob Herring
2020-10-14 19:12 ` [PATCH v3 4/8] of: unittest: Add test for of_dma_get_max_cpu_address() Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 22:04 ` Rob Herring
2020-10-14 22:04 ` Rob Herring
2020-10-14 22:04 ` Rob Herring
2020-10-15 9:51 ` Nicolas Saenz Julienne
2020-10-15 9:51 ` Nicolas Saenz Julienne
2020-10-15 9:51 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` [PATCH v3 5/8] dma-direct: Turn zone_dma_bits default value into a define Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-15 5:38 ` Christoph Hellwig
2020-10-15 5:38 ` Christoph Hellwig
2020-10-15 5:38 ` Christoph Hellwig
2020-10-15 10:05 ` Nicolas Saenz Julienne
2020-10-15 10:05 ` Nicolas Saenz Julienne
2020-10-15 10:05 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` [PATCH v3 6/8] arm64: mm: Set ZONE_DMA size based on devicetree's dma-ranges Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-15 5:39 ` Christoph Hellwig
2020-10-15 5:39 ` Christoph Hellwig
2020-10-15 5:39 ` Christoph Hellwig
2020-10-15 10:05 ` Nicolas Saenz Julienne
2020-10-15 10:05 ` Nicolas Saenz Julienne
2020-10-15 10:05 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` [PATCH v3 7/8] arm64: mm: Set ZONE_DMA size based on early IORT scan Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-15 10:31 ` Lorenzo Pieralisi
2020-10-15 10:31 ` Lorenzo Pieralisi
2020-10-15 10:31 ` Lorenzo Pieralisi
2020-10-16 6:56 ` Ard Biesheuvel
2020-10-16 6:56 ` Ard Biesheuvel
2020-10-16 6:56 ` Ard Biesheuvel
2020-10-15 14:26 ` Hanjun Guo
2020-10-15 14:26 ` Hanjun Guo
2020-10-15 14:26 ` Hanjun Guo
2020-10-15 15:15 ` Nicolas Saenz Julienne
2020-10-15 15:15 ` Nicolas Saenz Julienne
2020-10-15 15:15 ` Nicolas Saenz Julienne
2020-10-15 18:03 ` Catalin Marinas
2020-10-15 18:03 ` Catalin Marinas
2020-10-15 18:03 ` Catalin Marinas
2020-10-16 6:51 ` Hanjun Guo
2020-10-16 6:51 ` Hanjun Guo
2020-10-16 6:51 ` Hanjun Guo
2020-10-16 6:54 ` Ard Biesheuvel
2020-10-16 6:54 ` Ard Biesheuvel
2020-10-16 6:54 ` Ard Biesheuvel
2020-10-16 7:27 ` Hanjun Guo
2020-10-16 7:27 ` Hanjun Guo
2020-10-16 7:27 ` Hanjun Guo
2020-10-16 7:34 ` Hanjun Guo
2020-10-16 7:34 ` Hanjun Guo
2020-10-16 7:34 ` Hanjun Guo
2020-10-14 19:12 ` [PATCH v3 8/8] mm: Update DMA zones description Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-15 5:40 ` Christoph Hellwig
2020-10-15 5:40 ` Christoph Hellwig
2020-10-15 5:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKyRby5tp2JS1COodYf7F7sB_DJivyAe7FqQivp4KM6OA@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jeremy.linton@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.