* [PATCH] video: offb: Pass actual name in offb_init_palette_hacks
@ 2018-12-07 12:58 ` Mathieu Malaterre
0 siblings, 0 replies; 9+ messages in thread
From: Mathieu Malaterre @ 2018-12-07 12:58 UTC (permalink / raw)
To: Rob Herring
Cc: Mathieu Malaterre, stable, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-kernel
This is a partial revert of commit 5c63e407aaab ("fbdev: Convert to
using %pOFn instead of device_node.name"). This is the minimal work to
get a Mac Mini G4 back to a bootable state. The function
offb_init_palette_hacks would need to handle the case where `name` has
been set to NULL.
Cc: Rob Herring <robh@kernel.org>
Fixes: 5c63e407aaab ("fbdev: Convert to using %pOFn instead of device_node.name")
Cc: stable@vger.kernel.org # v4.19+
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
drivers/video/fbdev/offb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
index 31f769d67195..6e75851f8142 100644
--- a/drivers/video/fbdev/offb.c
+++ b/drivers/video/fbdev/offb.c
@@ -648,7 +648,7 @@ static void __init offb_init_nodriver(struct device_node *dp, int no_real_node)
/* kludge for valkyrie */
if (strcmp(dp->name, "valkyrie") == 0)
address += 0x1000;
- offb_init_fb(no_real_node ? "bootx" : NULL,
+ offb_init_fb(no_real_node ? "bootx" : dp->name,
width, height, depth, pitch, address,
foreign_endian, no_real_node ? NULL : dp);
}
--
2.19.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] video: offb: Pass actual name in offb_init_palette_hacks
@ 2018-12-07 12:58 ` Mathieu Malaterre
0 siblings, 0 replies; 9+ messages in thread
From: Mathieu Malaterre @ 2018-12-07 12:58 UTC (permalink / raw)
To: Rob Herring
Cc: Mathieu Malaterre, stable, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-kernel
This is a partial revert of commit 5c63e407aaab ("fbdev: Convert to
using %pOFn instead of device_node.name"). This is the minimal work to
get a Mac Mini G4 back to a bootable state. The function
offb_init_palette_hacks would need to handle the case where `name` has
been set to NULL.
Cc: Rob Herring <robh@kernel.org>
Fixes: 5c63e407aaab ("fbdev: Convert to using %pOFn instead of device_node.name")
Cc: stable@vger.kernel.org # v4.19+
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
drivers/video/fbdev/offb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
index 31f769d67195..6e75851f8142 100644
--- a/drivers/video/fbdev/offb.c
+++ b/drivers/video/fbdev/offb.c
@@ -648,7 +648,7 @@ static void __init offb_init_nodriver(struct device_node *dp, int no_real_node)
/* kludge for valkyrie */
if (strcmp(dp->name, "valkyrie") = 0)
address += 0x1000;
- offb_init_fb(no_real_node ? "bootx" : NULL,
+ offb_init_fb(no_real_node ? "bootx" : dp->name,
width, height, depth, pitch, address,
foreign_endian, no_real_node ? NULL : dp);
}
--
2.19.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] video: offb: Pass actual name in offb_init_palette_hacks
2018-12-07 12:58 ` Mathieu Malaterre
@ 2018-12-20 16:10 ` Mathieu Malaterre
-1 siblings, 0 replies; 9+ messages in thread
From: Mathieu Malaterre @ 2018-12-20 16:10 UTC (permalink / raw)
To: Rob Herring
Cc: # v4 . 11, Bartlomiej Zolnierkiewicz, dri-devel,
Linux Fbdev development list, LKML
Rob, any comment ?
On Fri, Dec 7, 2018 at 1:59 PM Mathieu Malaterre <malat@debian.org> wrote:
>
> This is a partial revert of commit 5c63e407aaab ("fbdev: Convert to
> using %pOFn instead of device_node.name"). This is the minimal work to
> get a Mac Mini G4 back to a bootable state. The function
> offb_init_palette_hacks would need to handle the case where `name` has
> been set to NULL.
>
> Cc: Rob Herring <robh@kernel.org>
> Fixes: 5c63e407aaab ("fbdev: Convert to using %pOFn instead of device_node.name")
> Cc: stable@vger.kernel.org # v4.19+
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> drivers/video/fbdev/offb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
> index 31f769d67195..6e75851f8142 100644
> --- a/drivers/video/fbdev/offb.c
> +++ b/drivers/video/fbdev/offb.c
> @@ -648,7 +648,7 @@ static void __init offb_init_nodriver(struct device_node *dp, int no_real_node)
> /* kludge for valkyrie */
> if (strcmp(dp->name, "valkyrie") == 0)
> address += 0x1000;
> - offb_init_fb(no_real_node ? "bootx" : NULL,
> + offb_init_fb(no_real_node ? "bootx" : dp->name,
> width, height, depth, pitch, address,
> foreign_endian, no_real_node ? NULL : dp);
> }
> --
> 2.19.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] video: offb: Pass actual name in offb_init_palette_hacks
@ 2018-12-20 16:10 ` Mathieu Malaterre
0 siblings, 0 replies; 9+ messages in thread
From: Mathieu Malaterre @ 2018-12-20 16:10 UTC (permalink / raw)
To: Rob Herring
Cc: # v4 . 11, Bartlomiej Zolnierkiewicz, dri-devel,
Linux Fbdev development list, LKML
Rob, any comment ?
On Fri, Dec 7, 2018 at 1:59 PM Mathieu Malaterre <malat@debian.org> wrote:
>
> This is a partial revert of commit 5c63e407aaab ("fbdev: Convert to
> using %pOFn instead of device_node.name"). This is the minimal work to
> get a Mac Mini G4 back to a bootable state. The function
> offb_init_palette_hacks would need to handle the case where `name` has
> been set to NULL.
>
> Cc: Rob Herring <robh@kernel.org>
> Fixes: 5c63e407aaab ("fbdev: Convert to using %pOFn instead of device_node.name")
> Cc: stable@vger.kernel.org # v4.19+
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> drivers/video/fbdev/offb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
> index 31f769d67195..6e75851f8142 100644
> --- a/drivers/video/fbdev/offb.c
> +++ b/drivers/video/fbdev/offb.c
> @@ -648,7 +648,7 @@ static void __init offb_init_nodriver(struct device_node *dp, int no_real_node)
> /* kludge for valkyrie */
> if (strcmp(dp->name, "valkyrie") = 0)
> address += 0x1000;
> - offb_init_fb(no_real_node ? "bootx" : NULL,
> + offb_init_fb(no_real_node ? "bootx" : dp->name,
> width, height, depth, pitch, address,
> foreign_endian, no_real_node ? NULL : dp);
> }
> --
> 2.19.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] video: offb: Pass actual name in offb_init_palette_hacks
2018-12-20 16:10 ` Mathieu Malaterre
(?)
@ 2018-12-23 17:27 ` Mathieu Malaterre
-1 siblings, 0 replies; 9+ messages in thread
From: Mathieu Malaterre @ 2018-12-23 17:27 UTC (permalink / raw)
To: Rob Herring
Cc: Linux Fbdev development list, Bartlomiej Zolnierkiewicz, LKML,
dri-devel, # v4 . 11, Elimar Riesebieter
[-- Attachment #1.1: Type: text/plain, Size: 1711 bytes --]
Patch is far from perfect but was tested also by: Elimar Riesebieter
riesebie@lxtec.de
Le jeu. 20 déc. 2018 17:10, Mathieu Malaterre <malat@debian.org> a écrit :
> Rob, any comment ?
>
> On Fri, Dec 7, 2018 at 1:59 PM Mathieu Malaterre <malat@debian.org> wrote:
> >
> > This is a partial revert of commit 5c63e407aaab ("fbdev: Convert to
> > using %pOFn instead of device_node.name"). This is the minimal work to
> > get a Mac Mini G4 back to a bootable state. The function
> > offb_init_palette_hacks would need to handle the case where `name` has
> > been set to NULL.
> >
> > Cc: Rob Herring <robh@kernel.org>
> > Fixes: 5c63e407aaab ("fbdev: Convert to using %pOFn instead of
> device_node.name")
> > Cc: stable@vger.kernel.org # v4.19+
> > Signed-off-by: Mathieu Malaterre <malat@debian.org>
> > ---
> > drivers/video/fbdev/offb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
> > index 31f769d67195..6e75851f8142 100644
> > --- a/drivers/video/fbdev/offb.c
> > +++ b/drivers/video/fbdev/offb.c
> > @@ -648,7 +648,7 @@ static void __init offb_init_nodriver(struct
> device_node *dp, int no_real_node)
> > /* kludge for valkyrie */
> > if (strcmp(dp->name, "valkyrie") == 0)
> > address += 0x1000;
> > - offb_init_fb(no_real_node ? "bootx" : NULL,
> > + offb_init_fb(no_real_node ? "bootx" : dp->name,
> > width, height, depth, pitch, address,
> > foreign_endian, no_real_node ? NULL : dp);
> > }
> > --
> > 2.19.2
> >
>
[-- Attachment #1.2: Type: text/html, Size: 2764 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] video: offb: Pass actual name in offb_init_palette_hacks
2018-12-20 16:10 ` Mathieu Malaterre
@ 2019-01-02 20:03 ` Mathieu Malaterre
-1 siblings, 0 replies; 9+ messages in thread
From: Mathieu Malaterre @ 2019-01-02 20:03 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: # v4 . 11, Rob Herring, dri-devel, Linux Fbdev development list,
LKML, Elimar Riesebieter
Bartlomiej,
Do you need an Acked-by from Rob, or can you take it in the next round
of fixes for v4.20 ?
Just to repeat myself, previous code would call
offb_init_palette_hacks(), which in turn would do:
if (dp && !strncmp(name, "ATY,Rage128", 11)) {
with name=NULL.
Thanks
On Thu, Dec 20, 2018 at 5:10 PM Mathieu Malaterre <malat@debian.org> wrote:
>
> Rob, any comment ?
>
> On Fri, Dec 7, 2018 at 1:59 PM Mathieu Malaterre <malat@debian.org> wrote:
> >
> > This is a partial revert of commit 5c63e407aaab ("fbdev: Convert to
> > using %pOFn instead of device_node.name"). This is the minimal work to
> > get a Mac Mini G4 back to a bootable state. The function
> > offb_init_palette_hacks would need to handle the case where `name` has
> > been set to NULL.
> >
> > Cc: Rob Herring <robh@kernel.org>
> > Fixes: 5c63e407aaab ("fbdev: Convert to using %pOFn instead of device_node.name")
> > Cc: stable@vger.kernel.org # v4.19+
> > Signed-off-by: Mathieu Malaterre <malat@debian.org>
> > ---
> > drivers/video/fbdev/offb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
> > index 31f769d67195..6e75851f8142 100644
> > --- a/drivers/video/fbdev/offb.c
> > +++ b/drivers/video/fbdev/offb.c
> > @@ -648,7 +648,7 @@ static void __init offb_init_nodriver(struct device_node *dp, int no_real_node)
> > /* kludge for valkyrie */
> > if (strcmp(dp->name, "valkyrie") == 0)
> > address += 0x1000;
> > - offb_init_fb(no_real_node ? "bootx" : NULL,
> > + offb_init_fb(no_real_node ? "bootx" : dp->name,
> > width, height, depth, pitch, address,
> > foreign_endian, no_real_node ? NULL : dp);
> > }
> > --
> > 2.19.2
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] video: offb: Pass actual name in offb_init_palette_hacks
@ 2019-01-02 20:03 ` Mathieu Malaterre
0 siblings, 0 replies; 9+ messages in thread
From: Mathieu Malaterre @ 2019-01-02 20:03 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: # v4 . 11, Rob Herring, dri-devel, Linux Fbdev development list,
LKML, Elimar Riesebieter
Bartlomiej,
Do you need an Acked-by from Rob, or can you take it in the next round
of fixes for v4.20 ?
Just to repeat myself, previous code would call
offb_init_palette_hacks(), which in turn would do:
if (dp && !strncmp(name, "ATY,Rage128", 11)) {
with name=NULL.
Thanks
On Thu, Dec 20, 2018 at 5:10 PM Mathieu Malaterre <malat@debian.org> wrote:
>
> Rob, any comment ?
>
> On Fri, Dec 7, 2018 at 1:59 PM Mathieu Malaterre <malat@debian.org> wrote:
> >
> > This is a partial revert of commit 5c63e407aaab ("fbdev: Convert to
> > using %pOFn instead of device_node.name"). This is the minimal work to
> > get a Mac Mini G4 back to a bootable state. The function
> > offb_init_palette_hacks would need to handle the case where `name` has
> > been set to NULL.
> >
> > Cc: Rob Herring <robh@kernel.org>
> > Fixes: 5c63e407aaab ("fbdev: Convert to using %pOFn instead of device_node.name")
> > Cc: stable@vger.kernel.org # v4.19+
> > Signed-off-by: Mathieu Malaterre <malat@debian.org>
> > ---
> > drivers/video/fbdev/offb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
> > index 31f769d67195..6e75851f8142 100644
> > --- a/drivers/video/fbdev/offb.c
> > +++ b/drivers/video/fbdev/offb.c
> > @@ -648,7 +648,7 @@ static void __init offb_init_nodriver(struct device_node *dp, int no_real_node)
> > /* kludge for valkyrie */
> > if (strcmp(dp->name, "valkyrie") = 0)
> > address += 0x1000;
> > - offb_init_fb(no_real_node ? "bootx" : NULL,
> > + offb_init_fb(no_real_node ? "bootx" : dp->name,
> > width, height, depth, pitch, address,
> > foreign_endian, no_real_node ? NULL : dp);
> > }
> > --
> > 2.19.2
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] video: offb: Pass actual name in offb_init_palette_hacks
2019-01-02 20:03 ` Mathieu Malaterre
@ 2019-01-07 17:31 ` Rob Herring
-1 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2019-01-07 17:31 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Bartlomiej Zolnierkiewicz, # v4 . 11, dri-devel,
Linux Fbdev development list, LKML, Elimar Riesebieter
On Wed, Jan 2, 2019 at 2:03 PM Mathieu Malaterre <malat@debian.org> wrote:
>
> Bartlomiej,
>
> Do you need an Acked-by from Rob, or can you take it in the next round
> of fixes for v4.20 ?
Sorry, I missed this.
>
> Just to repeat myself, previous code would call
> offb_init_palette_hacks(), which in turn would do:
>
> if (dp && !strncmp(name, "ATY,Rage128", 11)) {
>
> with name=NULL.
I prefer to fix this properly using node name helper in
offb_init_palette_hacks(). I'll send a patch shortly.
Rob
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] video: offb: Pass actual name in offb_init_palette_hacks
@ 2019-01-07 17:31 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2019-01-07 17:31 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Bartlomiej Zolnierkiewicz, # v4 . 11, dri-devel,
Linux Fbdev development list, LKML, Elimar Riesebieter
On Wed, Jan 2, 2019 at 2:03 PM Mathieu Malaterre <malat@debian.org> wrote:
>
> Bartlomiej,
>
> Do you need an Acked-by from Rob, or can you take it in the next round
> of fixes for v4.20 ?
Sorry, I missed this.
>
> Just to repeat myself, previous code would call
> offb_init_palette_hacks(), which in turn would do:
>
> if (dp && !strncmp(name, "ATY,Rage128", 11)) {
>
> with name=NULL.
I prefer to fix this properly using node name helper in
offb_init_palette_hacks(). I'll send a patch shortly.
Rob
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-01-07 17:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-07 12:58 [PATCH] video: offb: Pass actual name in offb_init_palette_hacks Mathieu Malaterre
2018-12-07 12:58 ` Mathieu Malaterre
2018-12-20 16:10 ` Mathieu Malaterre
2018-12-20 16:10 ` Mathieu Malaterre
2018-12-23 17:27 ` Mathieu Malaterre
2019-01-02 20:03 ` Mathieu Malaterre
2019-01-02 20:03 ` Mathieu Malaterre
2019-01-07 17:31 ` Rob Herring
2019-01-07 17:31 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.