From: Rob Herring <robh@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Marcel Holtmann <marcel@holtmann.org>,
Jiri Slaby <jslaby@suse.com>, Sebastian Reichel <sre@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
"Dr . H . Nikolaus Schaller" <hns@goldelico.com>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
Loic Poulain <loic.poulain@intel.com>,
Peter Hurley <peter@hurleysoftware.com>,
NeilBrown <neil@brown.name>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 4/6] serio: serport: add support for buffered write and receive
Date: Fri, 26 Aug 2016 16:27:35 -0500 [thread overview]
Message-ID: <CAL_JsqLNeV9BDvRtRbDCKbrq-gO9jv8-kmGJNS9AKXUSmEvYOA@mail.gmail.com> (raw)
In-Reply-To: <20160826201202.GA27227@amd>
On Fri, Aug 26, 2016 at 3:12 PM, Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
>> @@ -133,26 +133,29 @@ static void serport_ldisc_receive(struct tty_struct *tty, const unsigned char *c
>> if (!test_bit(SERPORT_ACTIVE, &serport->flags))
>> goto out;
>>
>> - for (i = 0; i < count; i++) {
>> - if (fp) {
>> - switch (fp[i]) {
>> - case TTY_FRAME:
>> - ch_flags = SERIO_FRAME;
>> - break;
>> -
>> - case TTY_PARITY:
>> - ch_flags = SERIO_PARITY;
>> - break;
>> -
>> - default:
>> - ch_flags = 0;
>> - break;
>> + if (serio_buffered_mode_enabled(serport->serio)) {
>> + serio_receive_buf(serport->serio, cp, count);
>
> Elsewhere:
> + /* Use buffer receive if the driver provides a callback */
> + if (drv->receive_buf)
> + set_bit(SERIO_MODE_BUFFERED, &drv->flags);
>
> Could we use if (drv->receive_buf) above directly, and not require the
> bitfield?
I'm allowing for allowing drivers to provide both functions and be
able to switch between them. However, I didn't provide any mechanism
to do so yet.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
Cc: Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>,
Jiri Slaby <jslaby-IBi9RG/b67k@public.gmane.org>,
Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
"Dr . H . Nikolaus Schaller"
<hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>,
Alan Cox
<gnomes-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>,
Loic Poulain
<loic.poulain-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Peter Hurley
<peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>,
NeilBrown <neil-+NVA1uvv1dVBDLzU/O5InQ@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"open list:BLUETOOTH DRIVERS"
<linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC PATCH 4/6] serio: serport: add support for buffered write and receive
Date: Fri, 26 Aug 2016 16:27:35 -0500 [thread overview]
Message-ID: <CAL_JsqLNeV9BDvRtRbDCKbrq-gO9jv8-kmGJNS9AKXUSmEvYOA@mail.gmail.com> (raw)
In-Reply-To: <20160826201202.GA27227@amd>
On Fri, Aug 26, 2016 at 3:12 PM, Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org> wrote:
> Hi!
>
>> @@ -133,26 +133,29 @@ static void serport_ldisc_receive(struct tty_struct *tty, const unsigned char *c
>> if (!test_bit(SERPORT_ACTIVE, &serport->flags))
>> goto out;
>>
>> - for (i = 0; i < count; i++) {
>> - if (fp) {
>> - switch (fp[i]) {
>> - case TTY_FRAME:
>> - ch_flags = SERIO_FRAME;
>> - break;
>> -
>> - case TTY_PARITY:
>> - ch_flags = SERIO_PARITY;
>> - break;
>> -
>> - default:
>> - ch_flags = 0;
>> - break;
>> + if (serio_buffered_mode_enabled(serport->serio)) {
>> + serio_receive_buf(serport->serio, cp, count);
>
> Elsewhere:
> + /* Use buffer receive if the driver provides a callback */
> + if (drv->receive_buf)
> + set_bit(SERIO_MODE_BUFFERED, &drv->flags);
>
> Could we use if (drv->receive_buf) above directly, and not require the
> bitfield?
I'm allowing for allowing drivers to provide both functions and be
able to switch between them. However, I didn't provide any mechanism
to do so yet.
Rob
next prev parent reply other threads:[~2016-08-26 21:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 23:24 [RFC PATCH 0/6] UART slave devices using serio Rob Herring
2016-08-24 23:24 ` Rob Herring
2016-08-24 23:24 ` [RFC PATCH 1/6] serio: add DT driver binding Rob Herring
2016-08-29 9:57 ` Pavel Machek
2016-08-24 23:24 ` [RFC PATCH 1/6] serio: add OF " Rob Herring
2016-08-24 23:24 ` [RFC PATCH 2/6] serio: serport: hacks to get DT probe to work Rob Herring
2016-08-24 23:24 ` [RFC PATCH 3/6] serio: add buffer receive and write functions Rob Herring
2016-08-24 23:24 ` [RFC PATCH 4/6] serio: serport: add support for buffered write and receive Rob Herring
2016-08-24 23:24 ` Rob Herring
2016-08-26 20:12 ` Pavel Machek
2016-08-26 20:12 ` Pavel Machek
2016-08-26 21:27 ` Rob Herring [this message]
2016-08-26 21:27 ` Rob Herring
2016-08-26 22:24 ` Pavel Machek
2016-08-24 23:24 ` [RFC PATCH 5/6] serio: add serial configuration functions Rob Herring
2016-08-24 23:24 ` [RFC PATCH 6/6] bluetooth: hack up ldisc to use serio Rob Herring
2016-08-24 23:24 ` Rob Herring
2016-08-26 20:05 ` [RFC PATCH 0/6] UART slave devices using serio Pavel Machek
2016-08-26 20:05 ` Pavel Machek
2016-08-26 21:29 ` Rob Herring
2016-10-25 21:55 ` Sebastian Reichel
2016-10-25 22:02 ` Rob Herring
2016-10-25 22:02 ` Rob Herring
2016-10-26 2:51 ` Sebastian Reichel
2016-10-31 20:00 ` Peter Hurley
2016-10-31 20:08 ` Peter Hurley
2016-10-31 20:08 ` Peter Hurley
2016-11-01 3:40 ` Rob Herring
2016-11-01 3:40 ` Rob Herring
2016-11-02 3:49 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLNeV9BDvRtRbDCKbrq-gO9jv8-kmGJNS9AKXUSmEvYOA@mail.gmail.com \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=jslaby@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=loic.poulain@intel.com \
--cc=marcel@holtmann.org \
--cc=neil@brown.name \
--cc=pavel@ucw.cz \
--cc=peter@hurleysoftware.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.