All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH] of: return of_get_cpu_node from of_cpu_device_node_get if CPUs are not registered
Date: Mon, 24 Jul 2017 11:00:36 -0500	[thread overview]
Message-ID: <CAL_JsqLQBJL11XzmvSyD61syHKQKmzBVuUupo_Ctupaj8nxvVg@mail.gmail.com> (raw)
In-Reply-To: <1500904513-10483-1-git-send-email-sudeep.holla@arm.com>

On Mon, Jul 24, 2017 at 8:55 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
> Instead of the callsites choosing between of_cpu_device_node_get if the
> CPUs are registered as of_node is populated by then and of_get_cpu_node
> when the CPUs are not yet registered as CPU of_nodes are not yet stashed
> thereby needing to parse the device tree, we can call of_get_cpu_node
> in case the CPUs are not yet registered.
>
> This will allow to use of_cpu_device_node_get anywhere hiding the
> details from the caller.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  include/linux/of_device.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hi Rob,
>
> Let me know if you are OK with this change. I keep seeing different
> drivers calling of_get_cpu_node or of_cpu_device_node_get based on what
> they are aware of or copying from other place without knowing the
> details. I am trying to avoid that and ask to use of_cpu_device_node_get
> at all places instead.

Seems fine to me.

Acked-by: Rob Herring <robh@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>
Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Frank Rowand
	<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] of: return of_get_cpu_node from of_cpu_device_node_get if CPUs are not registered
Date: Mon, 24 Jul 2017 11:00:36 -0500	[thread overview]
Message-ID: <CAL_JsqLQBJL11XzmvSyD61syHKQKmzBVuUupo_Ctupaj8nxvVg@mail.gmail.com> (raw)
In-Reply-To: <1500904513-10483-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>

On Mon, Jul 24, 2017 at 8:55 AM, Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org> wrote:
> Instead of the callsites choosing between of_cpu_device_node_get if the
> CPUs are registered as of_node is populated by then and of_get_cpu_node
> when the CPUs are not yet registered as CPU of_nodes are not yet stashed
> thereby needing to parse the device tree, we can call of_get_cpu_node
> in case the CPUs are not yet registered.
>
> This will allow to use of_cpu_device_node_get anywhere hiding the
> details from the caller.
>
> Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>
> ---
>  include/linux/of_device.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hi Rob,
>
> Let me know if you are OK with this change. I keep seeing different
> drivers calling of_get_cpu_node or of_cpu_device_node_get based on what
> they are aware of or copying from other place without knowing the
> details. I am trying to avoid that and ask to use of_cpu_device_node_get
> at all places instead.

Seems fine to me.

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-07-24 16:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 13:55 [PATCH] of: return of_get_cpu_node from of_cpu_device_node_get if CPUs are not registered Sudeep Holla
2017-07-24 16:00 ` Rob Herring [this message]
2017-07-24 16:00   ` Rob Herring
2017-07-24 16:32   ` Sudeep Holla
2017-07-24 16:32     ` Sudeep Holla
2017-08-02 17:45     ` Sudeep Holla
2017-08-02 17:45       ` Sudeep Holla
2017-08-21 17:20     ` Rob Herring
2017-08-21 17:20       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqLQBJL11XzmvSyD61syHKQKmzBVuUupo_Ctupaj8nxvVg@mail.gmail.com \
    --to=robh+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.