All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Michal Simek <monstr@monstr.eu>
Cc: "Alvaro G. M." <alvaro.gamez@hazent.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b
Date: Fri, 16 Mar 2018 10:18:31 -0500	[thread overview]
Message-ID: <CAL_JsqLY5+Za_TjxyoH_ozoi8S-6L47eZ94W8qdV9DsO4HLXHw@mail.gmail.com> (raw)
In-Reply-To: <4d5dc903-0e88-e1b9-9761-43a84865c45b@monstr.eu>

On Wed, Mar 14, 2018 at 10:04 AM, Michal Simek <monstr@monstr.eu> wrote:
> On 12.3.2018 11:21, Michal Simek wrote:
>> On 12.3.2018 08:52, Alvaro G. M. wrote:
>>> On Fri, Mar 09, 2018 at 01:05:11PM -0600, Rob Herring wrote:
>>>> On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M. <alvaro.gamez@hazent.com> wrote:
>>>>> Hi,
>>>>>
>>>>> I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
>>>>> makes microblaze unbootable.
>>>>>
>>>>> I'm sorry I can't provide any console output, as nothing appears at all,
>>>>> even when setting earlyprintk (or at least I wasn't able to get anything
>>>>> back!).
>>>>
>>>> Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
>>>> memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
>>>> !CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
>>>> it can be removed, but I'm still investigating. Can you try out this
>>>> branch[1].
>>>>
>>>> Rob
>>>>
>>>> [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
>>>> microblaze-fixes
>>>
>>> Hi, Rob!
>>>
>>> This branch does indeed solve the issue. My microblaze system is now
>>> booting as it did before, and everything seems normal now. Thanks!
>>>
>>> Tested-by: Alvaro Gamez Machado <alvaro.gamez@hazent.com>
>>>
>>
>> I have tested it and I can also confirm that your two patches are fixing
>> issue with
>>
>> 809d0e2c: 00240034 26000000 746f6f62 206d656d    4.$....&bootmem
>> 809d0e3c: 6f6c6c61 666f2063 33353220 62203830    alloc of 25308 b
>> 809d0e4c: 73657479 69616620 2164656c 00000000    ytes failed!....
>> 809d0e5c: 00000000 0029003c 06000000 6e72654b    ....<.).....Kern
>> 809d0e6c: 70206c65 63696e61 6e202d20 7320746f    el panic - not s
>>
>> Can you please update that second commit with reasonable description and
>> send it out? I will take it via my tree and will send pull request to Linus.
>>
>
> I couldn't wait to fix current issue till 4.16 is done that's why I have
> sent that patches with updated commit message to lkml.

Thanks for writing my commit msg. :) I got distracted looking at
whether other arches got broken too and didn't get this sent out.

BTW, there is a more simple fix of just moving setup_memory() call to
before unflattening if you prefer for 4.16.

Rob

  reply	other threads:[~2018-03-16 15:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-09 12:51 Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b Alvaro G. M.
2018-03-09 19:05 ` Rob Herring
2018-03-10 13:15   ` Michal Simek
2018-03-12  7:52   ` Alvaro G. M.
2018-03-12 10:21     ` Michal Simek
2018-03-14 15:04       ` Michal Simek
2018-03-16 15:18         ` Rob Herring [this message]
2018-03-16 18:02           ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqLY5+Za_TjxyoH_ozoi8S-6L47eZ94W8qdV9DsO4HLXHw@mail.gmail.com \
    --to=robh@kernel.org \
    --cc=alvaro.gamez@hazent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monstr@monstr.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.