* [PATCH] frv: add io{read,write}{16,32}be functions
@ 2015-04-20 15:36 Guenter Roeck
2015-04-20 16:36 ` Greg Kroah-Hartman
2015-04-23 4:11 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Guenter Roeck @ 2015-04-20 15:36 UTC (permalink / raw)
To: David Howells
Cc: linux-kernel, Guenter Roeck, Kevin Cernekee, Rob Herring,
Greg Kroah-Hartman
These functions are used in various drivers, including the latest
version of the 8250 driver. The latter causes the following build
failure.
drivers/tty/serial/8250/8250_core.c: In function 'mem32be_serial_out':
drivers/tty/serial/8250/8250_core.c:456:2: error:
implicit declaration of function 'iowrite32be'
drivers/tty/serial/8250/8250_core.c: In function 'mem32be_serial_in':
drivers/tty/serial/8250/8250_core.c:462:2: error:
implicit declaration of function 'ioread32be'
Cc: Kevin Cernekee <cernekee@gmail.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fixes: c627f2ceb692 ("serial: 8250: Add support for big-endian MMIO
accesses")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
Build failure seen in next-20150420.
arch/frv/include/asm/io.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/frv/include/asm/io.h b/arch/frv/include/asm/io.h
index 99bb7ef..0b78bc8 100644
--- a/arch/frv/include/asm/io.h
+++ b/arch/frv/include/asm/io.h
@@ -342,6 +342,11 @@ static inline void iowrite32(u32 val, void __iomem *p)
__flush_PCI_writes();
}
+#define ioread16be(addr) be16_to_cpu(ioread16(addr))
+#define ioread32be(addr) be32_to_cpu(ioread32(addr))
+#define iowrite16be(v, addr) iowrite16(cpu_to_be16(v), (addr))
+#define iowrite32be(v, addr) iowrite32(cpu_to_be32(v), (addr))
+
static inline void ioread8_rep(void __iomem *p, void *dst, unsigned long count)
{
io_insb((unsigned long) p, dst, count);
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] frv: add io{read,write}{16,32}be functions
2015-04-20 15:36 [PATCH] frv: add io{read,write}{16,32}be functions Guenter Roeck
@ 2015-04-20 16:36 ` Greg Kroah-Hartman
2015-04-23 4:11 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2015-04-20 16:36 UTC (permalink / raw)
To: Guenter Roeck; +Cc: David Howells, linux-kernel, Kevin Cernekee, Rob Herring
On Mon, Apr 20, 2015 at 08:36:15AM -0700, Guenter Roeck wrote:
> These functions are used in various drivers, including the latest
> version of the 8250 driver. The latter causes the following build
> failure.
>
> drivers/tty/serial/8250/8250_core.c: In function 'mem32be_serial_out':
> drivers/tty/serial/8250/8250_core.c:456:2: error:
> implicit declaration of function 'iowrite32be'
> drivers/tty/serial/8250/8250_core.c: In function 'mem32be_serial_in':
> drivers/tty/serial/8250/8250_core.c:462:2: error:
> implicit declaration of function 'ioread32be'
>
> Cc: Kevin Cernekee <cernekee@gmail.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Fixes: c627f2ceb692 ("serial: 8250: Add support for big-endian MMIO
> accesses")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Build failure seen in next-20150420.
>
> arch/frv/include/asm/io.h | 5 +++++
> 1 file changed, 5 insertions(+)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] frv: add io{read,write}{16,32}be functions
2015-04-20 15:36 [PATCH] frv: add io{read,write}{16,32}be functions Guenter Roeck
2015-04-20 16:36 ` Greg Kroah-Hartman
@ 2015-04-23 4:11 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2015-04-23 4:11 UTC (permalink / raw)
To: Guenter Roeck
Cc: David Howells, linux-kernel, Kevin Cernekee, Greg Kroah-Hartman
On Mon, Apr 20, 2015 at 10:36 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> These functions are used in various drivers, including the latest
> version of the 8250 driver. The latter causes the following build
> failure.
>
> drivers/tty/serial/8250/8250_core.c: In function 'mem32be_serial_out':
> drivers/tty/serial/8250/8250_core.c:456:2: error:
> implicit declaration of function 'iowrite32be'
> drivers/tty/serial/8250/8250_core.c: In function 'mem32be_serial_in':
> drivers/tty/serial/8250/8250_core.c:462:2: error:
> implicit declaration of function 'ioread32be'
>
> Cc: Kevin Cernekee <cernekee@gmail.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Fixes: c627f2ceb692 ("serial: 8250: Add support for big-endian MMIO
> accesses")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Build failure seen in next-20150420.
Applied. Thanks.
Rob
>
> arch/frv/include/asm/io.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/frv/include/asm/io.h b/arch/frv/include/asm/io.h
> index 99bb7ef..0b78bc8 100644
> --- a/arch/frv/include/asm/io.h
> +++ b/arch/frv/include/asm/io.h
> @@ -342,6 +342,11 @@ static inline void iowrite32(u32 val, void __iomem *p)
> __flush_PCI_writes();
> }
>
> +#define ioread16be(addr) be16_to_cpu(ioread16(addr))
> +#define ioread32be(addr) be32_to_cpu(ioread32(addr))
> +#define iowrite16be(v, addr) iowrite16(cpu_to_be16(v), (addr))
> +#define iowrite32be(v, addr) iowrite32(cpu_to_be32(v), (addr))
> +
> static inline void ioread8_rep(void __iomem *p, void *dst, unsigned long count)
> {
> io_insb((unsigned long) p, dst, count);
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-23 4:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-20 15:36 [PATCH] frv: add io{read,write}{16,32}be functions Guenter Roeck
2015-04-20 16:36 ` Greg Kroah-Hartman
2015-04-23 4:11 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.