All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: i2c: mv64xxx: Fix the example compatible
@ 2019-07-03  9:53 Maxime Ripard
  2019-07-03  9:53 ` [PATCH 2/2] dt-bindings: i2c: sun6i-p2wi: Fix the binding example Maxime Ripard
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Maxime Ripard @ 2019-07-03  9:53 UTC (permalink / raw)
  To: Wolfram Sang, Mark Rutland, Rob Herring, Frank Rowand, Gregory Clement
  Cc: linux-i2c, devicetree, Maxime Ripard

One example has a compatible that isn't a valid combination according to
the binding, and now that the examples are validated as well, this
generates a warning.

Let's fix this.

Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
index 9a5654ef5670..001f2b7abad0 100644
--- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
@@ -105,7 +105,7 @@ examples:
 
   - |
     i2c@11000 {
-        compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";
+        compatible = "marvell,mv78230-i2c";
         reg = <0x11000 0x100>;
         interrupts = <29>;
         clock-frequency = <100000>;
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/2] dt-bindings: i2c: sun6i-p2wi: Fix the binding example
  2019-07-03  9:53 [PATCH 1/2] dt-bindings: i2c: mv64xxx: Fix the example compatible Maxime Ripard
@ 2019-07-03  9:53 ` Maxime Ripard
  2019-07-05 10:34   ` Gregory CLEMENT
                     ` (2 more replies)
  2019-07-05 10:34 ` [PATCH 1/2] dt-bindings: i2c: mv64xxx: Fix the example compatible Gregory CLEMENT
                   ` (2 subsequent siblings)
  3 siblings, 3 replies; 8+ messages in thread
From: Maxime Ripard @ 2019-07-03  9:53 UTC (permalink / raw)
  To: Wolfram Sang, Mark Rutland, Rob Herring, Frank Rowand, Gregory Clement
  Cc: linux-i2c, devicetree, Maxime Ripard

Even though the binding claims that the frequency can go up to 6MHz, the
common i2c binding sets a limit at 3MHz, which then triggers a warning.

Since the only SoC that uses that bus uses a frequency of 100kHz, and that
this bus hasn't been found in an SoC for something like 5 years, let's just
fix the example to have a frequency within the acceptable range for i2c.

Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 .../devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml b/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
index 1804abe24f14..f9d526b7da01 100644
--- a/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
+++ b/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
@@ -51,7 +51,7 @@ examples:
         reg = <0x01f03400 0x400>;
         interrupts = <0 39 4>;
         clocks = <&apb0_gates 3>;
-        clock-frequency = <6000000>;
+        clock-frequency = <100000>;
         resets = <&apb0_rst 3>;
         #address-cells = <1>;
         #size-cells = <0>;
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] dt-bindings: i2c: mv64xxx: Fix the example compatible
  2019-07-03  9:53 [PATCH 1/2] dt-bindings: i2c: mv64xxx: Fix the example compatible Maxime Ripard
  2019-07-03  9:53 ` [PATCH 2/2] dt-bindings: i2c: sun6i-p2wi: Fix the binding example Maxime Ripard
@ 2019-07-05 10:34 ` Gregory CLEMENT
  2019-07-05 16:22 ` Rob Herring
  2019-07-05 18:32 ` Wolfram Sang
  3 siblings, 0 replies; 8+ messages in thread
From: Gregory CLEMENT @ 2019-07-05 10:34 UTC (permalink / raw)
  To: Maxime Ripard, Wolfram Sang, Mark Rutland, Rob Herring, Frank Rowand
  Cc: linux-i2c, devicetree

Maxime Ripard <maxime.ripard@bootlin.com> writes:

> One example has a compatible that isn't a valid combination according to
> the binding, and now that the examples are validated as well, this
> generates a warning.
>
> Let's fix this.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>


Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>

Thanks,

Gregory

> ---
>  Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> index 9a5654ef5670..001f2b7abad0 100644
> --- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> @@ -105,7 +105,7 @@ examples:
>  
>    - |
>      i2c@11000 {
> -        compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";
> +        compatible = "marvell,mv78230-i2c";
>          reg = <0x11000 0x100>;
>          interrupts = <29>;
>          clock-frequency = <100000>;
> -- 
> 2.21.0
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] dt-bindings: i2c: sun6i-p2wi: Fix the binding example
  2019-07-03  9:53 ` [PATCH 2/2] dt-bindings: i2c: sun6i-p2wi: Fix the binding example Maxime Ripard
@ 2019-07-05 10:34   ` Gregory CLEMENT
  2019-07-05 16:21   ` Rob Herring
  2019-07-05 18:33   ` Wolfram Sang
  2 siblings, 0 replies; 8+ messages in thread
From: Gregory CLEMENT @ 2019-07-05 10:34 UTC (permalink / raw)
  To: Maxime Ripard, Wolfram Sang, Mark Rutland, Rob Herring, Frank Rowand
  Cc: linux-i2c, devicetree

Maxime Ripard <maxime.ripard@bootlin.com> writes:

> Even though the binding claims that the frequency can go up to 6MHz, the
> common i2c binding sets a limit at 3MHz, which then triggers a warning.
>
> Since the only SoC that uses that bus uses a frequency of 100kHz, and that
> this bus hasn't been found in an SoC for something like 5 years, let's just
> fix the example to have a frequency within the acceptable range for i2c.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>

Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>

Thanks,

Gregory
> ---
>  .../devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml b/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
> index 1804abe24f14..f9d526b7da01 100644
> --- a/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
> +++ b/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml
> @@ -51,7 +51,7 @@ examples:
>          reg = <0x01f03400 0x400>;
>          interrupts = <0 39 4>;
>          clocks = <&apb0_gates 3>;
> -        clock-frequency = <6000000>;
> +        clock-frequency = <100000>;
>          resets = <&apb0_rst 3>;
>          #address-cells = <1>;
>          #size-cells = <0>;
> -- 
> 2.21.0
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] dt-bindings: i2c: sun6i-p2wi: Fix the binding example
  2019-07-03  9:53 ` [PATCH 2/2] dt-bindings: i2c: sun6i-p2wi: Fix the binding example Maxime Ripard
  2019-07-05 10:34   ` Gregory CLEMENT
@ 2019-07-05 16:21   ` Rob Herring
  2019-07-05 18:33   ` Wolfram Sang
  2 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2019-07-05 16:21 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Wolfram Sang, Mark Rutland, Frank Rowand, Gregory Clement,
	Linux I2C, devicetree

On Wed, Jul 3, 2019 at 3:53 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Even though the binding claims that the frequency can go up to 6MHz, the
> common i2c binding sets a limit at 3MHz, which then triggers a warning.
>
> Since the only SoC that uses that bus uses a frequency of 100kHz, and that
> this bus hasn't been found in an SoC for something like 5 years, let's just
> fix the example to have a frequency within the acceptable range for i2c.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
>  .../devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] dt-bindings: i2c: mv64xxx: Fix the example compatible
  2019-07-03  9:53 [PATCH 1/2] dt-bindings: i2c: mv64xxx: Fix the example compatible Maxime Ripard
  2019-07-03  9:53 ` [PATCH 2/2] dt-bindings: i2c: sun6i-p2wi: Fix the binding example Maxime Ripard
  2019-07-05 10:34 ` [PATCH 1/2] dt-bindings: i2c: mv64xxx: Fix the example compatible Gregory CLEMENT
@ 2019-07-05 16:22 ` Rob Herring
  2019-07-05 18:32 ` Wolfram Sang
  3 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2019-07-05 16:22 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Wolfram Sang, Mark Rutland, Frank Rowand, Gregory Clement,
	Linux I2C, devicetree

On Wed, Jul 3, 2019 at 3:53 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> One example has a compatible that isn't a valid combination according to
> the binding, and now that the examples are validated as well, this
> generates a warning.
>
> Let's fix this.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
>  Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] dt-bindings: i2c: mv64xxx: Fix the example compatible
  2019-07-03  9:53 [PATCH 1/2] dt-bindings: i2c: mv64xxx: Fix the example compatible Maxime Ripard
                   ` (2 preceding siblings ...)
  2019-07-05 16:22 ` Rob Herring
@ 2019-07-05 18:32 ` Wolfram Sang
  3 siblings, 0 replies; 8+ messages in thread
From: Wolfram Sang @ 2019-07-05 18:32 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Mark Rutland, Rob Herring, Frank Rowand, Gregory Clement,
	linux-i2c, devicetree

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

On Wed, Jul 03, 2019 at 11:53:37AM +0200, Maxime Ripard wrote:
> One example has a compatible that isn't a valid combination according to
> the binding, and now that the examples are validated as well, this
> generates a warning.
> 
> Let's fix this.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] dt-bindings: i2c: sun6i-p2wi: Fix the binding example
  2019-07-03  9:53 ` [PATCH 2/2] dt-bindings: i2c: sun6i-p2wi: Fix the binding example Maxime Ripard
  2019-07-05 10:34   ` Gregory CLEMENT
  2019-07-05 16:21   ` Rob Herring
@ 2019-07-05 18:33   ` Wolfram Sang
  2 siblings, 0 replies; 8+ messages in thread
From: Wolfram Sang @ 2019-07-05 18:33 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Mark Rutland, Rob Herring, Frank Rowand, Gregory Clement,
	linux-i2c, devicetree

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

On Wed, Jul 03, 2019 at 11:53:38AM +0200, Maxime Ripard wrote:
> Even though the binding claims that the frequency can go up to 6MHz, the
> common i2c binding sets a limit at 3MHz, which then triggers a warning.
> 
> Since the only SoC that uses that bus uses a frequency of 100kHz, and that
> this bus hasn't been found in an SoC for something like 5 years, let's just
> fix the example to have a frequency within the acceptable range for i2c.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-07-05 18:33 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-03  9:53 [PATCH 1/2] dt-bindings: i2c: mv64xxx: Fix the example compatible Maxime Ripard
2019-07-03  9:53 ` [PATCH 2/2] dt-bindings: i2c: sun6i-p2wi: Fix the binding example Maxime Ripard
2019-07-05 10:34   ` Gregory CLEMENT
2019-07-05 16:21   ` Rob Herring
2019-07-05 18:33   ` Wolfram Sang
2019-07-05 10:34 ` [PATCH 1/2] dt-bindings: i2c: mv64xxx: Fix the example compatible Gregory CLEMENT
2019-07-05 16:22 ` Rob Herring
2019-07-05 18:32 ` Wolfram Sang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.