* [PATCH] drm/panfrost: Add missing _fini() calls in panfrost_device_fini()
@ 2019-05-13 8:17 Boris Brezillon
2019-05-13 13:12 ` Steven Price
2019-05-13 14:55 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Boris Brezillon @ 2019-05-13 8:17 UTC (permalink / raw)
To: Rob Herring, Tomeu Vizoso; +Cc: Boris Brezillon, dri-devel
panfrost_{job,mmu,gpu,reset}_fini() were missing.
Fixes: f3ba91228e8e ("drm/panfrost: Add initial panfrost driver")
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
---
drivers/gpu/drm/panfrost/panfrost_device.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
index 970f669c6d29..3b2bced1b015 100644
--- a/drivers/gpu/drm/panfrost/panfrost_device.c
+++ b/drivers/gpu/drm/panfrost/panfrost_device.c
@@ -165,6 +165,10 @@ int panfrost_device_init(struct panfrost_device *pfdev)
void panfrost_device_fini(struct panfrost_device *pfdev)
{
+ panfrost_job_fini(pfdev);
+ panfrost_mmu_fini(pfdev);
+ panfrost_gpu_fini(pfdev);
+ panfrost_reset_fini(pfdev);
panfrost_regulator_fini(pfdev);
panfrost_clk_fini(pfdev);
}
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panfrost: Add missing _fini() calls in panfrost_device_fini()
2019-05-13 8:17 [PATCH] drm/panfrost: Add missing _fini() calls in panfrost_device_fini() Boris Brezillon
@ 2019-05-13 13:12 ` Steven Price
2019-05-13 14:55 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Steven Price @ 2019-05-13 13:12 UTC (permalink / raw)
To: Boris Brezillon, Rob Herring, Tomeu Vizoso; +Cc: dri-devel
On 13/05/2019 09:17, Boris Brezillon wrote:
> panfrost_{job,mmu,gpu,reset}_fini() were missing.
>
> Fixes: f3ba91228e8e ("drm/panfrost: Add initial panfrost driver")
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Steven Price <steven.price@arm.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_device.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
> index 970f669c6d29..3b2bced1b015 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.c
> @@ -165,6 +165,10 @@ int panfrost_device_init(struct panfrost_device *pfdev)
>
> void panfrost_device_fini(struct panfrost_device *pfdev)
> {
> + panfrost_job_fini(pfdev);
> + panfrost_mmu_fini(pfdev);
> + panfrost_gpu_fini(pfdev);
> + panfrost_reset_fini(pfdev);
> panfrost_regulator_fini(pfdev);
> panfrost_clk_fini(pfdev);
> }
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panfrost: Add missing _fini() calls in panfrost_device_fini()
2019-05-13 8:17 [PATCH] drm/panfrost: Add missing _fini() calls in panfrost_device_fini() Boris Brezillon
2019-05-13 13:12 ` Steven Price
@ 2019-05-13 14:55 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2019-05-13 14:55 UTC (permalink / raw)
To: Boris Brezillon; +Cc: dri-devel
On Mon, May 13, 2019 at 3:17 AM Boris Brezillon
<boris.brezillon@collabora.com> wrote:
>
> panfrost_{job,mmu,gpu,reset}_fini() were missing.
>
> Fixes: f3ba91228e8e ("drm/panfrost: Add initial panfrost driver")
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_device.c | 4 ++++
> 1 file changed, 4 insertions(+)
Applied.
Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-13 14:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13 8:17 [PATCH] drm/panfrost: Add missing _fini() calls in panfrost_device_fini() Boris Brezillon
2019-05-13 13:12 ` Steven Price
2019-05-13 14:55 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.