[meta-oe][PATCH 1/2] st: add x11 to REQUIRED_DISTRO_FEATURES to suck less

[meta-oe][PATCH 1/2] st: add x11 to REQUIRED_DISTRO_FEATURES to suck less

[Martin Jansa]

* errors like:
  ERROR: Nothing PROVIDES 'libx11' (but meta-openembedded/meta-oe/recipes-graphics/suckless/st_0.8.4.bb DEPENDS on or otherwise requires it)
  ERROR: Nothing PROVIDES 'libxft' (but meta-openembedded/meta-oe/recipes-graphics/suckless/st_0.8.4.bb DEPENDS on or otherwise requires it)
  ERROR: Nothing RPROVIDES 'st' (but meta-openembedded/meta-oe/recipes-graphics/suckless/st_0.8.4.bb RDEPENDS on or otherwise requires it)
  ERROR: Nothing RPROVIDES 'libx11-locale' (but meta-openembedded/meta-oe/recipes-graphics/suckless/st_0.8.4.bb RDEPENDS on or otherwise requires it)
  ERROR: Nothing RPROVIDES 'st-dev' (but meta-openembedded/meta-oe/recipes-graphics/suckless/st_0.8.4.bb RDEPENDS on or otherwise requires it)
  in bitbake world suck

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta-oe/recipes-graphics/suckless/st_0.8.4.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-graphics/suckless/st_0.8.4.bb b/meta-oe/recipes-graphics/suckless/st_0.8.4.bb
index 1f4961cb20..7d859e1478 100644
--- a/meta-oe/recipes-graphics/suckless/st_0.8.4.bb
+++ b/meta-oe/recipes-graphics/suckless/st_0.8.4.bb
@@ -5,7 +5,9 @@ SRC_URI = " \
  http://dl.suckless.org/${BPN}/${BPN}-${PV}.tar.gz \
 "
 
-inherit pkgconfig
+inherit pkgconfig features_check
+
+REQUIRED_DISTRO_FEATURES = "x11"
 
 SRC_URI[sha256sum] = "d42d3ceceb4d6a65e32e90a5336e3d446db612c3fbd9ebc1780bc6c9a03346a6"
 
-- 
2.25.1

[meta-oe][PATCH 2/2] st: fix indentation

[Martin Jansa]

* using combination of 4, 2 and 1 space for indentation in the same file
  sucks almost the same as tabs and spaces in the same file!

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta-oe/recipes-graphics/suckless/st_0.8.4.bb | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/meta-oe/recipes-graphics/suckless/st_0.8.4.bb b/meta-oe/recipes-graphics/suckless/st_0.8.4.bb
index 7d859e1478..906179501b 100644
--- a/meta-oe/recipes-graphics/suckless/st_0.8.4.bb
+++ b/meta-oe/recipes-graphics/suckless/st_0.8.4.bb
@@ -1,9 +1,7 @@
 SECTION = "shadow"
 LICENSE = "MIT-X"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=04c3ca13a702147c62db90f556c5b3ca"
-SRC_URI = " \
- http://dl.suckless.org/${BPN}/${BPN}-${PV}.tar.gz \
-"
+SRC_URI = "http://dl.suckless.org/${BPN}/${BP}.tar.gz"
 
 inherit pkgconfig features_check
 
@@ -23,5 +21,5 @@ do_install() {
 }
 
 FILES_${PN} += " \
-  ${datadir}/terminfo \
+    ${datadir}/terminfo \
 "
-- 
2.25.1

Re: [oe] [meta-oe][PATCH 2/2] st: fix indentation

[Andreas Müller]

On Sat, Sep 12, 2020 at 12:09 PM Martin Jansa <Martin.Jansa@gmail.com> wrote:
>
> * using combination of 4, 2 and 1 space for indentation in the same file
>   sucks almost the same as tabs and spaces in the same file!
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Yeah - this is really one of the ugly recipes... Not your job but one
still has to ask git what it is building...

Andreas