[PATCH] xfce4-session: Remove unneeded pkg_postinst

[PATCH] xfce4-session: Remove unneeded pkg_postinst

[Ash Charles]

The pkg_postinst inherited from previous versions of this recipe no
longer seems necessary; no error message seen at runtime in a quick
test.  As it made the generated packages unnecessarily
machine-specific, remove this post-install step. Based on the ensuring
discussion, this supersedes the original patch [1].

[1] http://lists.openembedded.org/pipermail/openembedded-devel/2015-February/100454.html

Signed-off-by: Ash Charles <ashcharles@gmail.com>
---
 meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb b/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb
index 74289fb..aa82a7c 100644
--- a/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb
+++ b/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb
@@ -17,11 +17,6 @@ ALTERNATIVE_${PN} = "x-session-manager"
 ALTERNATIVE_TARGET[x-session-manager] = "${bindir}/xfce4-session"
 ALTERNATIVE_PRIORITY_${PN} = "100"
 
-# protect from frightening message that xfce might not work correctly
-pkg_postinst_${PN} () {
-    echo 127.0.0.1    ${MACHINE} >> /etc/hosts
-}
-
 PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES','systemd','systemd','consolekit',d)}"
 PACKAGECONFIG[systemd] = "--enable-systemd, --disable-systemd, polkit, systemd"
 PACKAGECONFIG[consolekit] = ",,,consolekit"
-- 
2.1.0

Re: [PATCH] xfce4-session: Remove unneeded pkg_postinst

[Andreas Müller]

On Mon, Feb 23, 2015 at 5:40 PM, Ash Charles <ashcharles@gmail.com> wrote:
> The pkg_postinst inherited from previous versions of this recipe no
> longer seems necessary; no error message seen at runtime in a quick
> test.  As it made the generated packages unnecessarily
> machine-specific, remove this post-install step. Based on the ensuring
> discussion, this supersedes the original patch [1].
>
> [1] http://lists.openembedded.org/pipermail/openembedded-devel/2015-February/100454.html
>
> Signed-off-by: Ash Charles <ashcharles@gmail.com>
> ---
>  meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb b/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb
> index 74289fb..aa82a7c 100644
> --- a/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb
> +++ b/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb
> @@ -17,11 +17,6 @@ ALTERNATIVE_${PN} = "x-session-manager"
>  ALTERNATIVE_TARGET[x-session-manager] = "${bindir}/xfce4-session"
>  ALTERNATIVE_PRIORITY_${PN} = "100"
>
> -# protect from frightening message that xfce might not work correctly
> -pkg_postinst_${PN} () {
> -    echo 127.0.0.1    ${MACHINE} >> /etc/hosts
> -}
> -
>  PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES','systemd','systemd','consolekit',d)}"
>  PACKAGECONFIG[systemd] = "--enable-systemd, --disable-systemd, polkit, systemd"
>  PACKAGECONFIG[consolekit] = ",,,consolekit"
> --
> 2.1.0
>
Tested-by: Andreas Müller <schnitzeltony@googlemail.com>