All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays
@ 2016-07-29 22:27 Khem Raj
  2016-07-29 22:28 ` [PATCH 2/3] ffmpeg: Upgrade to 3.1.1 Khem Raj
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Khem Raj @ 2016-07-29 22:27 UTC (permalink / raw)
  To: openembedded-core

From: Herve Jourdain <herve.jourdain@neuf.fr>

Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-kernel/linux/linux-dtb.inc | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc
index 74f5ef8..8528d64 100644
--- a/meta/recipes-kernel/linux/linux-dtb.inc
+++ b/meta/recipes-kernel/linux/linux-dtb.inc
@@ -33,12 +33,13 @@ do_compile_append() {
 do_install_append() {
 	for DTB in ${KERNEL_DEVICETREE}; do
 		DTB=`normalize_dtb "${DTB}"`
-		DTB_BASE_NAME=`basename ${DTB} .dtb`
+		DTB_EXT=${DTB##*.}
+		DTB_BASE_NAME=`basename ${DTB} ."${DTB_EXT}"`
 		for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
 			symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
 			DTB_SYMLINK_NAME=`echo ${symlink_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
 			DTB_PATH=`get_real_dtb_path_in_kernel "${DTB}"`
-			install -m 0644 ${DTB_PATH} ${D}/${KERNEL_IMAGEDEST}/devicetree-${DTB_SYMLINK_NAME}.dtb
+			install -m 0644 ${DTB_PATH} ${D}/${KERNEL_IMAGEDEST}/devicetree-${DTB_SYMLINK_NAME}.${DTB_EXT}
 		done
 	done
 }
@@ -46,7 +47,8 @@ do_install_append() {
 do_deploy_append() {
 	for DTB in ${KERNEL_DEVICETREE}; do
 		DTB=`normalize_dtb "${DTB}"`
-		DTB_BASE_NAME=`basename ${DTB} .dtb`
+		DTB_EXT=${DTB##*.}
+		DTB_BASE_NAME=`basename ${DTB} ."${DTB_EXT}"`
 		for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
 			base_name=${type}"-"${KERNEL_IMAGE_BASE_NAME}
 			symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
@@ -54,8 +56,8 @@ do_deploy_append() {
 			DTB_SYMLINK_NAME=`echo ${symlink_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
 			DTB_PATH=`get_real_dtb_path_in_kernel "${DTB}"`
 			install -d ${DEPLOYDIR}
-			install -m 0644 ${DTB_PATH} ${DEPLOYDIR}/${DTB_NAME}.dtb
-			ln -sf ${DTB_NAME}.dtb ${DEPLOYDIR}/${DTB_SYMLINK_NAME}.dtb
+			install -m 0644 ${DTB_PATH} ${DEPLOYDIR}/${DTB_NAME}.${DTB_EXT}
+			ln -sf ${DTB_NAME}.${DTB_EXT} ${DEPLOYDIR}/${DTB_SYMLINK_NAME}.${DTB_EXT}
 		done
 	done
 }
@@ -65,9 +67,10 @@ pkg_postinst_kernel-devicetree () {
 	for DTB in ${KERNEL_DEVICETREE}; do
 		for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
 			symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
+			DTB_EXT=${DTB##*.}
 			DTB_BASE_NAME=`basename ${DTB} | awk -F "." '{print $1}'`
 			DTB_SYMLINK_NAME=`echo ${symlink_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
-			update-alternatives --install /${KERNEL_IMAGEDEST}/${DTB_BASE_NAME}.dtb ${DTB_BASE_NAME}.dtb /boot/devicetree-${DTB_SYMLINK_NAME}.dtb ${KERNEL_PRIORITY} || true
+			update-alternatives --install /${KERNEL_IMAGEDEST}/${DTB_BASE_NAME}.${DTB_EXT} ${DTB_BASE_NAME}.${DTB_EXT} /boot/devicetree-${DTB_SYMLINK_NAME}.${DTB_EXT} ${KERNEL_PRIORITY} || true
 		done
 	done
 }
@@ -77,9 +80,10 @@ pkg_postrm_kernel-devicetree () {
 	for DTB in ${KERNEL_DEVICETREE}; do
 		for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
 			symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
+			DTB_EXT=${DTB##*.}
 			DTB_BASE_NAME=`basename ${DTB} | awk -F "." '{print $1}'`
 			DTB_SYMLINK_NAME=`echo ${symlink_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
-			update-alternatives --remove ${DTB_BASE_NAME}.dtb /boot/devicetree-${DTB_SYMLINK_NAME}.dtb ${KERNEL_PRIORITY} || true
+			update-alternatives --remove ${DTB_BASE_NAME}.${DTB_EXT} /boot/devicetree-${DTB_SYMLINK_NAME}.${DTB_EXT} ${KERNEL_PRIORITY} || true
 		done
 	done
 }
-- 
2.9.0



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/3] ffmpeg: Upgrade to 3.1.1
  2016-07-29 22:27 [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays Khem Raj
@ 2016-07-29 22:28 ` Khem Raj
  2016-07-29 22:28 ` [PATCH 3/3] gdb: Cache gnu gettext config vars for musl builds Khem Raj
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 10+ messages in thread
From: Khem Raj @ 2016-07-29 22:28 UTC (permalink / raw)
  To: openembedded-core

Fix build on mips64 while on it.
It was failing for mips64 with 3.1 too

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../ffmpeg/ffmpeg/mips64_cpu_detection.patch       | 32 ++++++++++++++++++++++
 .../ffmpeg/{ffmpeg_3.1.bb => ffmpeg_3.1.1.bb}      |  9 +++---
 2 files changed, 37 insertions(+), 4 deletions(-)
 create mode 100644 meta/recipes-multimedia/ffmpeg/ffmpeg/mips64_cpu_detection.patch
 rename meta/recipes-multimedia/ffmpeg/{ffmpeg_3.1.bb => ffmpeg_3.1.1.bb} (95%)

diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg/mips64_cpu_detection.patch b/meta/recipes-multimedia/ffmpeg/ffmpeg/mips64_cpu_detection.patch
new file mode 100644
index 0000000..69429af
--- /dev/null
+++ b/meta/recipes-multimedia/ffmpeg/ffmpeg/mips64_cpu_detection.patch
@@ -0,0 +1,32 @@
+It will add -mips64r6 and -mips64r2 to cmdline which will
+cause conflicts
+
+in OE we user mips32r2 and mips64r2 for mips arch versions
+so there is no benefit of detecting it automatically by
+poking at tools especially in cross env
+
+Fixes errors like
+
+linking -mnan=2008 module with previous -mnan=legacy modules
+failed to merge target specific data of file
+
+-Khem
+Upstream-Status: Inappropriate [OE-Specific]
+
+Index: ffmpeg-3.1.1/configure
+===================================================================
+--- ffmpeg-3.1.1.orig/configure
++++ ffmpeg-3.1.1/configure
+@@ -5220,12 +5220,9 @@ elif enabled mips; then
+ 
+     # Enable minimum ISA based on selected options
+     if enabled mips64; then
+-        enabled mips64r6 && check_inline_asm_flags mips64r6 '"dlsa $0, $0, $0, 1"' '-mips64r6'
+         enabled mips64r2 && check_inline_asm_flags mips64r2 '"dext $0, $0, 0, 1"' '-mips64r2'
+         disabled mips64r6 && disabled mips64r2 && check_inline_asm_flags mips64r1 '"daddi $0, $0, 0"' '-mips64'
+     else
+-        enabled mips32r6 && check_inline_asm_flags mips32r6 '"aui $0, $0, 0"' '-mips32r6'
+-        enabled mips32r5 && check_inline_asm_flags mips32r5 '"eretnc"' '-mips32r5'
+         enabled mips32r2 && check_inline_asm_flags mips32r2 '"ext $0, $0, 0, 1"' '-mips32r2'
+         disabled mips32r6 && disabled mips32r5 && disabled mips32r2 && check_inline_asm_flags mips32r1 '"addi $0, $0, 0"' '-mips32'
+     fi
diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg_3.1.bb b/meta/recipes-multimedia/ffmpeg/ffmpeg_3.1.1.bb
similarity index 95%
rename from meta/recipes-multimedia/ffmpeg/ffmpeg_3.1.bb
rename to meta/recipes-multimedia/ffmpeg/ffmpeg_3.1.1.bb
index 2d83ef0..b8acb61 100644
--- a/meta/recipes-multimedia/ffmpeg/ffmpeg_3.1.bb
+++ b/meta/recipes-multimedia/ffmpeg/ffmpeg_3.1.1.bb
@@ -13,10 +13,11 @@ LIC_FILES_CHKSUM = "file://COPYING.GPLv2;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
                     file://COPYING.LGPLv2.1;md5=bd7a443320af8c812e4c18d1b79df004 \
                     file://COPYING.LGPLv3;md5=e6a600fd5e1d9cbde2d983680233ad02"
 
-SRC_URI = "https://www.ffmpeg.org/releases/${BP}.tar.xz"
-
-SRC_URI[md5sum] = "24ef0c0d541c857c8bc39215619b126f"
-SRC_URI[sha256sum] = "919022430e2dad782fabccffdd6c4cae4e7029f84f0701aa662f036a9ca65423"
+SRC_URI = "https://www.ffmpeg.org/releases/${BP}.tar.xz \
+           file://mips64_cpu_detection.patch \
+          "
+SRC_URI[md5sum] = "4ba7033da5d9ac4d0391516c7e5d97e4"
+SRC_URI[sha256sum] = "71bc11f2a8202ef3fbe5e43a9a163b4b698855da39fb6216d9a4614eddd031db"
 
 # Build fails when thumb is enabled: https://bugzilla.yoctoproject.org/show_bug.cgi?id=7717
 ARM_INSTRUCTION_SET = "arm"
-- 
2.9.0



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/3] gdb: Cache gnu gettext config vars for musl builds
  2016-07-29 22:27 [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays Khem Raj
  2016-07-29 22:28 ` [PATCH 2/3] ffmpeg: Upgrade to 3.1.1 Khem Raj
@ 2016-07-29 22:28 ` Khem Raj
  2016-07-30 11:00 ` [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays Otavio Salvador
  2016-08-18 15:45 ` Khem Raj
  3 siblings, 0 replies; 10+ messages in thread
From: Khem Raj @ 2016-07-29 22:28 UTC (permalink / raw)
  To: openembedded-core

intl is used in gdb as well and we run the configure for
it when running do compile. So we need to insert these
caching of variables to extra oe_make

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-devtools/gdb/gdb_7.11.bb | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/recipes-devtools/gdb/gdb_7.11.bb b/meta/recipes-devtools/gdb/gdb_7.11.bb
index f02e643..57cffc9 100644
--- a/meta/recipes-devtools/gdb/gdb_7.11.bb
+++ b/meta/recipes-devtools/gdb/gdb_7.11.bb
@@ -3,6 +3,11 @@ require gdb-${PV}.inc
 
 inherit python3-dir
 
+EXTRA_OEMAKE_append_libc-musl = "\
+                                 gt_cv_func_gnugettext1_libc=yes \
+                                 gt_cv_func_gnugettext2_libc=yes \
+                                "
+
 do_configure_prepend() {
 	if [ -n "${@bb.utils.contains('PACKAGECONFIG', 'python', 'python', '', d)}" ]; then
 		cat > ${WORKDIR}/python << EOF
-- 
2.9.0



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays
  2016-07-29 22:27 [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays Khem Raj
  2016-07-29 22:28 ` [PATCH 2/3] ffmpeg: Upgrade to 3.1.1 Khem Raj
  2016-07-29 22:28 ` [PATCH 3/3] gdb: Cache gnu gettext config vars for musl builds Khem Raj
@ 2016-07-30 11:00 ` Otavio Salvador
  2016-07-31 21:17   ` Paul Eggleton
  2016-08-18 15:45 ` Khem Raj
  3 siblings, 1 reply; 10+ messages in thread
From: Otavio Salvador @ 2016-07-30 11:00 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer

On Fri, Jul 29, 2016 at 7:27 PM, Khem Raj <raj.khem@gmail.com> wrote:
> From: Herve Jourdain <herve.jourdain@neuf.fr>
>
> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-kernel/linux/linux-dtb.inc | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc
> index 74f5ef8..8528d64 100644
> --- a/meta/recipes-kernel/linux/linux-dtb.inc
> +++ b/meta/recipes-kernel/linux/linux-dtb.inc
> @@ -33,12 +33,13 @@ do_compile_append() {
>  do_install_append() {
>         for DTB in ${KERNEL_DEVICETREE}; do
>                 DTB=`normalize_dtb "${DTB}"`
> -               DTB_BASE_NAME=`basename ${DTB} .dtb`
> +               DTB_EXT=${DTB##*.}

Bashism, no?

> +               DTB_BASE_NAME=`basename ${DTB} ."${DTB_EXT}"`
>                 for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
>                         symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
>                         DTB_SYMLINK_NAME=`echo ${symlink_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
>                         DTB_PATH=`get_real_dtb_path_in_kernel "${DTB}"`
> -                       install -m 0644 ${DTB_PATH} ${D}/${KERNEL_IMAGEDEST}/devicetree-${DTB_SYMLINK_NAME}.dtb
> +                       install -m 0644 ${DTB_PATH} ${D}/${KERNEL_IMAGEDEST}/devicetree-${DTB_SYMLINK_NAME}.${DTB_EXT}
>                 done
>         done
>  }
> @@ -46,7 +47,8 @@ do_install_append() {
>  do_deploy_append() {
>         for DTB in ${KERNEL_DEVICETREE}; do
>                 DTB=`normalize_dtb "${DTB}"`
> -               DTB_BASE_NAME=`basename ${DTB} .dtb`
> +               DTB_EXT=${DTB##*.}
> +               DTB_BASE_NAME=`basename ${DTB} ."${DTB_EXT}"`
>                 for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
>                         base_name=${type}"-"${KERNEL_IMAGE_BASE_NAME}
>                         symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
> @@ -54,8 +56,8 @@ do_deploy_append() {
>                         DTB_SYMLINK_NAME=`echo ${symlink_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
>                         DTB_PATH=`get_real_dtb_path_in_kernel "${DTB}"`
>                         install -d ${DEPLOYDIR}
> -                       install -m 0644 ${DTB_PATH} ${DEPLOYDIR}/${DTB_NAME}.dtb
> -                       ln -sf ${DTB_NAME}.dtb ${DEPLOYDIR}/${DTB_SYMLINK_NAME}.dtb
> +                       install -m 0644 ${DTB_PATH} ${DEPLOYDIR}/${DTB_NAME}.${DTB_EXT}
> +                       ln -sf ${DTB_NAME}.${DTB_EXT} ${DEPLOYDIR}/${DTB_SYMLINK_NAME}.${DTB_EXT}
>                 done
>         done
>  }
> @@ -65,9 +67,10 @@ pkg_postinst_kernel-devicetree () {
>         for DTB in ${KERNEL_DEVICETREE}; do
>                 for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
>                         symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
> +                       DTB_EXT=${DTB##*.}
>                         DTB_BASE_NAME=`basename ${DTB} | awk -F "." '{print $1}'`
>                         DTB_SYMLINK_NAME=`echo ${symlink_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
> -                       update-alternatives --install /${KERNEL_IMAGEDEST}/${DTB_BASE_NAME}.dtb ${DTB_BASE_NAME}.dtb /boot/devicetree-${DTB_SYMLINK_NAME}.dtb ${KERNEL_PRIORITY} || true
> +                       update-alternatives --install /${KERNEL_IMAGEDEST}/${DTB_BASE_NAME}.${DTB_EXT} ${DTB_BASE_NAME}.${DTB_EXT} /boot/devicetree-${DTB_SYMLINK_NAME}.${DTB_EXT} ${KERNEL_PRIORITY} || true
>                 done
>         done
>  }
> @@ -77,9 +80,10 @@ pkg_postrm_kernel-devicetree () {
>         for DTB in ${KERNEL_DEVICETREE}; do
>                 for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
>                         symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
> +                       DTB_EXT=${DTB##*.}
>                         DTB_BASE_NAME=`basename ${DTB} | awk -F "." '{print $1}'`
>                         DTB_SYMLINK_NAME=`echo ${symlink_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
> -                       update-alternatives --remove ${DTB_BASE_NAME}.dtb /boot/devicetree-${DTB_SYMLINK_NAME}.dtb ${KERNEL_PRIORITY} || true
> +                       update-alternatives --remove ${DTB_BASE_NAME}.${DTB_EXT} /boot/devicetree-${DTB_SYMLINK_NAME}.${DTB_EXT} ${KERNEL_PRIORITY} || true
>                 done
>         done
>  }
> --
> 2.9.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays
  2016-07-30 11:00 ` [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays Otavio Salvador
@ 2016-07-31 21:17   ` Paul Eggleton
  2016-08-08  7:31     ` Andreas Müller
  0 siblings, 1 reply; 10+ messages in thread
From: Paul Eggleton @ 2016-07-31 21:17 UTC (permalink / raw)
  To: Otavio Salvador; +Cc: openembedded-core

On Sat, 30 Jul 2016 08:00:45 Otavio Salvador wrote:
> On Fri, Jul 29, 2016 at 7:27 PM, Khem Raj <raj.khem@gmail.com> wrote:
> > From: Herve Jourdain <herve.jourdain@neuf.fr>
> > 
> > Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> > 
> >  meta/recipes-kernel/linux/linux-dtb.inc | 18 +++++++++++-------
> >  1 file changed, 11 insertions(+), 7 deletions(-)
> > 
> > diff --git a/meta/recipes-kernel/linux/linux-dtb.inc
> > b/meta/recipes-kernel/linux/linux-dtb.inc index 74f5ef8..8528d64 100644
> > --- a/meta/recipes-kernel/linux/linux-dtb.inc
> > +++ b/meta/recipes-kernel/linux/linux-dtb.inc
> > @@ -33,12 +33,13 @@ do_compile_append() {
> > 
> >  do_install_append() {
> >  
> >         for DTB in ${KERNEL_DEVICETREE}; do
> >         
> >                 DTB=`normalize_dtb "${DTB}"`
> > 
> > -               DTB_BASE_NAME=`basename ${DTB} .dtb`
> > +               DTB_EXT=${DTB##*.}
> 
> Bashism, no?

No:

  http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays
  2016-07-31 21:17   ` Paul Eggleton
@ 2016-08-08  7:31     ` Andreas Müller
  2016-08-09  9:22       ` Andreas Müller
  0 siblings, 1 reply; 10+ messages in thread
From: Andreas Müller @ 2016-08-08  7:31 UTC (permalink / raw)
  To: Paul Eggleton
  Cc: Otavio Salvador, Patches and discussions about the oe-core layer

On Sun, Jul 31, 2016 at 11:17 PM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> On Sat, 30 Jul 2016 08:00:45 Otavio Salvador wrote:
>> On Fri, Jul 29, 2016 at 7:27 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> > From: Herve Jourdain <herve.jourdain@neuf.fr>
>> >
>> > Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
>> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> > ---
>> >
>> >  meta/recipes-kernel/linux/linux-dtb.inc | 18 +++++++++++-------
>> >  1 file changed, 11 insertions(+), 7 deletions(-)
>> >
>> > diff --git a/meta/recipes-kernel/linux/linux-dtb.inc
>> > b/meta/recipes-kernel/linux/linux-dtb.inc index 74f5ef8..8528d64 100644
>> > --- a/meta/recipes-kernel/linux/linux-dtb.inc
>> > +++ b/meta/recipes-kernel/linux/linux-dtb.inc
>> > @@ -33,12 +33,13 @@ do_compile_append() {
>> >
>> >  do_install_append() {
>> >
>> >         for DTB in ${KERNEL_DEVICETREE}; do
>> >
>> >                 DTB=`normalize_dtb "${DTB}"`
>> >
>> > -               DTB_BASE_NAME=`basename ${DTB} .dtb`
>> > +               DTB_EXT=${DTB##*.}
>>
>> Bashism, no?
>
> No:
>
>   http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html
>
Anything wrong with this patch. The orinal patch was sent end of May!

Andreas


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays
  2016-08-08  7:31     ` Andreas Müller
@ 2016-08-09  9:22       ` Andreas Müller
  2016-08-09 10:00         ` Burton, Ross
  0 siblings, 1 reply; 10+ messages in thread
From: Andreas Müller @ 2016-08-09  9:22 UTC (permalink / raw)
  To: Paul Eggleton
  Cc: Otavio Salvador, Patches and discussions about the oe-core layer

On Mon, Aug 8, 2016 at 9:31 AM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> On Sun, Jul 31, 2016 at 11:17 PM, Paul Eggleton
> <paul.eggleton@linux.intel.com> wrote:
>> On Sat, 30 Jul 2016 08:00:45 Otavio Salvador wrote:
>>> On Fri, Jul 29, 2016 at 7:27 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>> > From: Herve Jourdain <herve.jourdain@neuf.fr>
>>> >
>>> > Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
>>> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> > ---
>>> >
>>> >  meta/recipes-kernel/linux/linux-dtb.inc | 18 +++++++++++-------
>>> >  1 file changed, 11 insertions(+), 7 deletions(-)
>>> >
>>> > diff --git a/meta/recipes-kernel/linux/linux-dtb.inc
>>> > b/meta/recipes-kernel/linux/linux-dtb.inc index 74f5ef8..8528d64 100644
>>> > --- a/meta/recipes-kernel/linux/linux-dtb.inc
>>> > +++ b/meta/recipes-kernel/linux/linux-dtb.inc
>>> > @@ -33,12 +33,13 @@ do_compile_append() {
>>> >
>>> >  do_install_append() {
>>> >
>>> >         for DTB in ${KERNEL_DEVICETREE}; do
>>> >
>>> >                 DTB=`normalize_dtb "${DTB}"`
>>> >
>>> > -               DTB_BASE_NAME=`basename ${DTB} .dtb`
>>> > +               DTB_EXT=${DTB##*.}
>>>
>>> Bashism, no?
>>
>> No:
>>
>>   http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html
>>
> Anything wrong with this patch. The orinal patch was sent end of May!
>
Should read before sending... What I meant:

Is there anything wrong with this patch? The original patch was sent
end of May, there were pings / a resend but it was never applied. Why
I insist: It is necessary for RaspberryPi's open source (VC4) patch
series pending for very long time.

Andreas


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays
  2016-08-09  9:22       ` Andreas Müller
@ 2016-08-09 10:00         ` Burton, Ross
  2016-08-09 10:56           ` Andreas Müller
  0 siblings, 1 reply; 10+ messages in thread
From: Burton, Ross @ 2016-08-09 10:00 UTC (permalink / raw)
  To: Andreas Müller
  Cc: Paul Eggleton, Otavio Salvador,
	Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

On 9 August 2016 at 10:22, Andreas Müller <schnitzeltony@googlemail.com>
wrote:

> Is there anything wrong with this patch? The original patch was sent
> end of May, there were pings / a resend but it was never applied. Why
> I insist: It is necessary for RaspberryPi's open source (VC4) patch
> series pending for very long time.
>

Just slipped through the net, now in my staging branch for master.

Ross

[-- Attachment #2: Type: text/html, Size: 840 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays
  2016-08-09 10:00         ` Burton, Ross
@ 2016-08-09 10:56           ` Andreas Müller
  0 siblings, 0 replies; 10+ messages in thread
From: Andreas Müller @ 2016-08-09 10:56 UTC (permalink / raw)
  To: Burton, Ross
  Cc: Paul Eggleton, Otavio Salvador,
	Patches and discussions about the oe-core layer

On Tue, Aug 9, 2016 at 12:00 PM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 9 August 2016 at 10:22, Andreas Müller <schnitzeltony@googlemail.com>
> wrote:
>>
>> Is there anything wrong with this patch? The original patch was sent
>> end of May, there were pings / a resend but it was never applied. Why
>> I insist: It is necessary for RaspberryPi's open source (VC4) patch
>> series pending for very long time.
>
>
> Just slipped through the net, now in my staging branch for master.
>
> Ross
Thanks


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays
  2016-07-29 22:27 [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays Khem Raj
                   ` (2 preceding siblings ...)
  2016-07-30 11:00 ` [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays Otavio Salvador
@ 2016-08-18 15:45 ` Khem Raj
  3 siblings, 0 replies; 10+ messages in thread
From: Khem Raj @ 2016-08-18 15:45 UTC (permalink / raw)
  To: OE Core mailing list, Armin Kuster

[-- Attachment #1: Type: text/plain, Size: 3771 bytes --]

Armin

Can this be back ported to krogoth please?

> On Jul 29, 2016, at 3:27 PM, Khem Raj <raj.khem@gmail.com> wrote:
> 
> From: Herve Jourdain <herve.jourdain@neuf.fr>
> 
> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-kernel/linux/linux-dtb.inc | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
> 
> diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc
> index 74f5ef8..8528d64 100644
> --- a/meta/recipes-kernel/linux/linux-dtb.inc
> +++ b/meta/recipes-kernel/linux/linux-dtb.inc
> @@ -33,12 +33,13 @@ do_compile_append() {
> do_install_append() {
> 	for DTB in ${KERNEL_DEVICETREE}; do
> 		DTB=`normalize_dtb "${DTB}"`
> -		DTB_BASE_NAME=`basename ${DTB} .dtb`
> +		DTB_EXT=${DTB##*.}
> +		DTB_BASE_NAME=`basename ${DTB} ."${DTB_EXT}"`
> 		for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
> 			symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
> 			DTB_SYMLINK_NAME=`echo ${symlink_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
> 			DTB_PATH=`get_real_dtb_path_in_kernel "${DTB}"`
> -			install -m 0644 ${DTB_PATH} ${D}/${KERNEL_IMAGEDEST}/devicetree-${DTB_SYMLINK_NAME}.dtb
> +			install -m 0644 ${DTB_PATH} ${D}/${KERNEL_IMAGEDEST}/devicetree-${DTB_SYMLINK_NAME}.${DTB_EXT}
> 		done
> 	done
> }
> @@ -46,7 +47,8 @@ do_install_append() {
> do_deploy_append() {
> 	for DTB in ${KERNEL_DEVICETREE}; do
> 		DTB=`normalize_dtb "${DTB}"`
> -		DTB_BASE_NAME=`basename ${DTB} .dtb`
> +		DTB_EXT=${DTB##*.}
> +		DTB_BASE_NAME=`basename ${DTB} ."${DTB_EXT}"`
> 		for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
> 			base_name=${type}"-"${KERNEL_IMAGE_BASE_NAME}
> 			symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
> @@ -54,8 +56,8 @@ do_deploy_append() {
> 			DTB_SYMLINK_NAME=`echo ${symlink_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
> 			DTB_PATH=`get_real_dtb_path_in_kernel "${DTB}"`
> 			install -d ${DEPLOYDIR}
> -			install -m 0644 ${DTB_PATH} ${DEPLOYDIR}/${DTB_NAME}.dtb
> -			ln -sf ${DTB_NAME}.dtb ${DEPLOYDIR}/${DTB_SYMLINK_NAME}.dtb
> +			install -m 0644 ${DTB_PATH} ${DEPLOYDIR}/${DTB_NAME}.${DTB_EXT}
> +			ln -sf ${DTB_NAME}.${DTB_EXT} ${DEPLOYDIR}/${DTB_SYMLINK_NAME}.${DTB_EXT}
> 		done
> 	done
> }
> @@ -65,9 +67,10 @@ pkg_postinst_kernel-devicetree () {
> 	for DTB in ${KERNEL_DEVICETREE}; do
> 		for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
> 			symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
> +			DTB_EXT=${DTB##*.}
> 			DTB_BASE_NAME=`basename ${DTB} | awk -F "." '{print $1}'`
> 			DTB_SYMLINK_NAME=`echo ${symlink_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
> -			update-alternatives --install /${KERNEL_IMAGEDEST}/${DTB_BASE_NAME}.dtb ${DTB_BASE_NAME}.dtb /boot/devicetree-${DTB_SYMLINK_NAME}.dtb ${KERNEL_PRIORITY} || true
> +			update-alternatives --install /${KERNEL_IMAGEDEST}/${DTB_BASE_NAME}.${DTB_EXT} ${DTB_BASE_NAME}.${DTB_EXT} /boot/devicetree-${DTB_SYMLINK_NAME}.${DTB_EXT} ${KERNEL_PRIORITY} || true
> 		done
> 	done
> }
> @@ -77,9 +80,10 @@ pkg_postrm_kernel-devicetree () {
> 	for DTB in ${KERNEL_DEVICETREE}; do
> 		for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
> 			symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
> +			DTB_EXT=${DTB##*.}
> 			DTB_BASE_NAME=`basename ${DTB} | awk -F "." '{print $1}'`
> 			DTB_SYMLINK_NAME=`echo ${symlink_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
> -			update-alternatives --remove ${DTB_BASE_NAME}.dtb /boot/devicetree-${DTB_SYMLINK_NAME}.dtb ${KERNEL_PRIORITY} || true
> +			update-alternatives --remove ${DTB_BASE_NAME}.${DTB_EXT} /boot/devicetree-${DTB_SYMLINK_NAME}.${DTB_EXT} ${KERNEL_PRIORITY} || true
> 		done
> 	done
> }
> --
> 2.9.0
> 


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2016-08-18 15:45 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-29 22:27 [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays Khem Raj
2016-07-29 22:28 ` [PATCH 2/3] ffmpeg: Upgrade to 3.1.1 Khem Raj
2016-07-29 22:28 ` [PATCH 3/3] gdb: Cache gnu gettext config vars for musl builds Khem Raj
2016-07-30 11:00 ` [PATCH 1/3] linux-dtb.inc: Support for .dtbo files for dtb overlays Otavio Salvador
2016-07-31 21:17   ` Paul Eggleton
2016-08-08  7:31     ` Andreas Müller
2016-08-09  9:22       ` Andreas Müller
2016-08-09 10:00         ` Burton, Ross
2016-08-09 10:56           ` Andreas Müller
2016-08-18 15:45 ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.