* [PATCH 0/2] meta: fix gdbm and clutter-gst-3.0 @ 2015-11-12 8:51 Robert Yang 2015-11-12 8:51 ` [PATCH 1/2] gdbm 1.8.3: install libgdbm_compat Robert Yang 2015-11-12 8:51 ` [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev Robert Yang 0 siblings, 2 replies; 9+ messages in thread From: Robert Yang @ 2015-11-12 8:51 UTC (permalink / raw) To: openembedded-core The following changes since commit e44ed8c18e395b9c055aefee113b90708e8a8a2f: build-appliance-image: Update to jethro head revision (2015-11-03 14:02:57 +0000) are available in the git repository at: git://git.openembedded.org/openembedded-core-contrib rbt/2fixes http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/2fixes Robert Yang (2): gdbm 1.8.3: install libgdbm_compat clutter-gst-3.0: add --enable/disable-gudev meta/recipes-graphics/clutter/clutter-gst-3.0.inc | 15 ++++++- .../0001-configure.ac-add-enable-gudev.patch | 45 ++++++++++++++++++++ meta/recipes-support/gdbm/gdbm_1.8.3.bb | 1 + 3 files changed, 60 insertions(+), 1 deletion(-) create mode 100644 meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch -- 1.7.9.5 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] gdbm 1.8.3: install libgdbm_compat 2015-11-12 8:51 [PATCH 0/2] meta: fix gdbm and clutter-gst-3.0 Robert Yang @ 2015-11-12 8:51 ` Robert Yang 2015-11-12 8:51 ` [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev Robert Yang 1 sibling, 0 replies; 9+ messages in thread From: Robert Yang @ 2015-11-12 8:51 UTC (permalink / raw) To: openembedded-core It has been built but not installed by default, while 1.11 builds and installs it. Fixed when build non_gplv3 + perl: powerpc64-wrs-linux-gcc -m64 -mhard-float -mcpu=e6500 --sysroot=/mnt/docker/test_p/bitbake_build/tmp/sysroots/fsl-t2xxx -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed - fstack-protector -shared NDBM_File.o -o ../../lib/auto/NDBM_File/NDBM_File.so \ -lgdbm -lgdbm_compat \ ld: cannot find -lgdbm_compat collect2: error: ld returned 1 exit status Makefile:473: recipe for target '../../lib/auto/NDBM_File/NDBM_File.so' failed Signed-off-by: Robert Yang <liezhi.yang@windriver.com> --- meta/recipes-support/gdbm/gdbm_1.8.3.bb | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/recipes-support/gdbm/gdbm_1.8.3.bb b/meta/recipes-support/gdbm/gdbm_1.8.3.bb index af01b6c..b253dc1 100644 --- a/meta/recipes-support/gdbm/gdbm_1.8.3.bb +++ b/meta/recipes-support/gdbm/gdbm_1.8.3.bb @@ -19,6 +19,7 @@ inherit autotools texinfo BBCLASSEXTEND = "native nativesdk" do_install_append () { + oe_runmake install-compat DESTDIR=${D} install -d ${D}${includedir}/gdbm install -m 0644 ${S}/dbm.h ${D}${includedir}/ install -m 0644 ${S}/ndbm.h ${D}${includedir}/ -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev 2015-11-12 8:51 [PATCH 0/2] meta: fix gdbm and clutter-gst-3.0 Robert Yang 2015-11-12 8:51 ` [PATCH 1/2] gdbm 1.8.3: install libgdbm_compat Robert Yang @ 2015-11-12 8:51 ` Robert Yang 2015-11-12 9:00 ` Andreas Müller 1 sibling, 1 reply; 9+ messages in thread From: Robert Yang @ 2015-11-12 8:51 UTC (permalink / raw) To: openembedded-core Fix dangling dependns on gudev, and systemd doesn't provide libgudev, so it can't be enabled when systemd either. Fixed: libtool: error: cannot find the library 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' or unhandled argument 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' Signed-off-by: Robert Yang <liezhi.yang@windriver.com> --- meta/recipes-graphics/clutter/clutter-gst-3.0.inc | 15 ++++++- .../0001-configure.ac-add-enable-gudev.patch | 45 ++++++++++++++++++++ 2 files changed, 59 insertions(+), 1 deletion(-) create mode 100644 meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch diff --git a/meta/recipes-graphics/clutter/clutter-gst-3.0.inc b/meta/recipes-graphics/clutter/clutter-gst-3.0.inc index d4fed71..c29bc7a 100644 --- a/meta/recipes-graphics/clutter/clutter-gst-3.0.inc +++ b/meta/recipes-graphics/clutter/clutter-gst-3.0.inc @@ -4,7 +4,12 @@ LICENSE = "LGPLv2+" inherit clutter -SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch" +SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch \ + file://0001-configure.ac-add-enable-gudev.patch \ + " + +PACKAGECONFIG ??= "" +PACKAGECONFIG[gudev] = "--enable-gudev,--disable-gudev,udev" DEPENDS = "gstreamer1.0-plugins-base gstreamer1.0-plugins-bad clutter-1.0" RDEPENDS_${PN} += "gstreamer1.0-meta-base" @@ -12,6 +17,14 @@ PACKAGES =+ "${PN}-examples" EXTRA_OECONF += "--disable-introspection" +python () { + if bb.utils.contains('EXTRA_OECONF', '--enable-gudev', True, False, d) and \ + bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d): + bb.warn("%s: gudev can't be enabled since systemd doesn't provide libgudev" % \ + d.getVar("PN", True)) + d.appendVar('EXTRA_OECONF', ' --disable-gudev') +} + FILES_${PN} += "${libdir}/gstreamer-1.0/lib*.so" FILES_${PN}-dev += "${libdir}/gstreamer-1.0/*.la" FILES_${PN}-dbg += "${libdir}/gstreamer-1.0/.debug/lib*.so" diff --git a/meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch b/meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch new file mode 100644 index 0000000..59f9fd8 --- /dev/null +++ b/meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch @@ -0,0 +1,45 @@ +From 3454c53e9d906ef7e39e82e81a446bcece566e53 Mon Sep 17 00:00:00 2001 +From: Robert Yang <liezhi.yang@windriver.com> +Date: Wed, 11 Nov 2015 22:34:51 -0800 +Subject: [PATCH] configure.ac: add --enable-gudev + +So that we can enable/disable gudev support clearly + +Upstream-Status: Pending + +Signed-off-by: Robert Yang <liezhi.yang@windriver.com> +--- + configure.ac | 11 ++++++++++- + 1 file changed, 10 insertions(+), 1 deletion(-) + +diff --git a/configure.ac b/configure.ac +index 92022cb..595c944 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -209,13 +209,22 @@ AS_IF([test "x$have_cogl_osx" = xyes], + AC_SUBST([GL_LDFLAGS]) + ]) + +-PKG_CHECK_MODULES(GUDEV, ++have_gudev=no ++AC_ARG_ENABLE([gudev], ++ [AC_HELP_STRING([--enable-gudev=@<:@no/yes@:>@], ++ [Enable gudev support @<:@default=no@:>@])], ++ [], ++ enable_gudev=gudev) ++ ++AS_IF([test "x$enable_gudev" = "xyes"], [ ++ PKG_CHECK_MODULES(GUDEV, + [gudev-1.0], + [ + have_gudev=yes + AC_DEFINE([HAVE_GUDEV], [1], + ["Defined if gudev is available"]) + ],[ have_gudev=no ]) ++]) + + dnl ======================================================================== + dnl Experimental support for hardware accelerated decoders. +-- +1.7.9.5 + -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev 2015-11-12 8:51 ` [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev Robert Yang @ 2015-11-12 9:00 ` Andreas Müller 2015-11-12 9:06 ` Robert Yang 0 siblings, 1 reply; 9+ messages in thread From: Andreas Müller @ 2015-11-12 9:00 UTC (permalink / raw) To: Robert Yang; +Cc: Patches and discussions about the oe-core layer On Thu, Nov 12, 2015 at 9:51 AM, Robert Yang <liezhi.yang@windriver.com> wrote: > Fix dangling dependns on gudev, and systemd doesn't provide libgudev, so > it can't be enabled when systemd either. > > Fixed: > libtool: error: cannot find the library 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' or unhandled argument > 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' > > Signed-off-by: Robert Yang <liezhi.yang@windriver.com> > --- > meta/recipes-graphics/clutter/clutter-gst-3.0.inc | 15 ++++++- > .../0001-configure.ac-add-enable-gudev.patch | 45 ++++++++++++++++++++ > 2 files changed, 59 insertions(+), 1 deletion(-) > create mode 100644 meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch > > diff --git a/meta/recipes-graphics/clutter/clutter-gst-3.0.inc b/meta/recipes-graphics/clutter/clutter-gst-3.0.inc > index d4fed71..c29bc7a 100644 > --- a/meta/recipes-graphics/clutter/clutter-gst-3.0.inc > +++ b/meta/recipes-graphics/clutter/clutter-gst-3.0.inc > @@ -4,7 +4,12 @@ LICENSE = "LGPLv2+" > > inherit clutter > > -SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch" > +SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch \ > + file://0001-configure.ac-add-enable-gudev.patch \ > + " > + > +PACKAGECONFIG ??= "" > +PACKAGECONFIG[gudev] = "--enable-gudev,--disable-gudev,udev" > > DEPENDS = "gstreamer1.0-plugins-base gstreamer1.0-plugins-bad clutter-1.0" > RDEPENDS_${PN} += "gstreamer1.0-meta-base" > @@ -12,6 +17,14 @@ PACKAGES =+ "${PN}-examples" > > EXTRA_OECONF += "--disable-introspection" > > +python () { > + if bb.utils.contains('EXTRA_OECONF', '--enable-gudev', True, False, d) and \ > + bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d): > + bb.warn("%s: gudev can't be enabled since systemd doesn't provide libgudev" % \ > + d.getVar("PN", True)) > + d.appendVar('EXTRA_OECONF', ' --disable-gudev') > +} > + I think this part of the patch is wrong: You have to replace udev by gudev in DEPENDS part of packageconfig above and skip python function complete. Andreas ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev 2015-11-12 9:00 ` Andreas Müller @ 2015-11-12 9:06 ` Robert Yang 2015-11-12 9:17 ` Andreas Müller 2015-11-12 10:25 ` Martin Jansa 0 siblings, 2 replies; 9+ messages in thread From: Robert Yang @ 2015-11-12 9:06 UTC (permalink / raw) To: Andreas Müller; +Cc: Patches and discussions about the oe-core layer On 11/12/2015 05:00 PM, Andreas Müller wrote: > On Thu, Nov 12, 2015 at 9:51 AM, Robert Yang <liezhi.yang@windriver.com> wrote: >> Fix dangling dependns on gudev, and systemd doesn't provide libgudev, so >> it can't be enabled when systemd either. >> >> Fixed: >> libtool: error: cannot find the library 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' or unhandled argument >> 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' >> >> Signed-off-by: Robert Yang <liezhi.yang@windriver.com> >> --- >> meta/recipes-graphics/clutter/clutter-gst-3.0.inc | 15 ++++++- >> .../0001-configure.ac-add-enable-gudev.patch | 45 ++++++++++++++++++++ >> 2 files changed, 59 insertions(+), 1 deletion(-) >> create mode 100644 meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch >> >> diff --git a/meta/recipes-graphics/clutter/clutter-gst-3.0.inc b/meta/recipes-graphics/clutter/clutter-gst-3.0.inc >> index d4fed71..c29bc7a 100644 >> --- a/meta/recipes-graphics/clutter/clutter-gst-3.0.inc >> +++ b/meta/recipes-graphics/clutter/clutter-gst-3.0.inc >> @@ -4,7 +4,12 @@ LICENSE = "LGPLv2+" >> >> inherit clutter >> >> -SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch" >> +SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch \ >> + file://0001-configure.ac-add-enable-gudev.patch \ >> + " >> + >> +PACKAGECONFIG ??= "" >> +PACKAGECONFIG[gudev] = "--enable-gudev,--disable-gudev,udev" >> >> DEPENDS = "gstreamer1.0-plugins-base gstreamer1.0-plugins-bad clutter-1.0" >> RDEPENDS_${PN} += "gstreamer1.0-meta-base" >> @@ -12,6 +17,14 @@ PACKAGES =+ "${PN}-examples" >> >> EXTRA_OECONF += "--disable-introspection" >> >> +python () { >> + if bb.utils.contains('EXTRA_OECONF', '--enable-gudev', True, False, d) and \ >> + bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d): >> + bb.warn("%s: gudev can't be enabled since systemd doesn't provide libgudev" % \ >> + d.getVar("PN", True)) >> + d.appendVar('EXTRA_OECONF', ' --disable-gudev') >> +} >> + > I think this part of the patch is wrong: You have to replace udev by > gudev in DEPENDS part of packageconfig above and skip python function I think that there is no gudev but udev ? udev provides gudev, but systemd only provides udev, no gudev. // Robert > complete. > > Andreas > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev 2015-11-12 9:06 ` Robert Yang @ 2015-11-12 9:17 ` Andreas Müller 2015-11-13 5:54 ` Robert Yang 2015-11-12 10:25 ` Martin Jansa 1 sibling, 1 reply; 9+ messages in thread From: Andreas Müller @ 2015-11-12 9:17 UTC (permalink / raw) To: Robert Yang; +Cc: Patches and discussions about the oe-core layer On Thu, Nov 12, 2015 at 10:06 AM, Robert Yang <liezhi.yang@windriver.com> wrote: > > > On 11/12/2015 05:00 PM, Andreas Müller wrote: >> >> On Thu, Nov 12, 2015 at 9:51 AM, Robert Yang <liezhi.yang@windriver.com> >> wrote: >>> >>> Fix dangling dependns on gudev, and systemd doesn't provide libgudev, so >>> it can't be enabled when systemd either. >>> >>> Fixed: >>> libtool: error: cannot find the library >>> 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' or unhandled argument >>> 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' >>> >>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com> >>> --- >>> meta/recipes-graphics/clutter/clutter-gst-3.0.inc | 15 ++++++- >>> .../0001-configure.ac-add-enable-gudev.patch | 45 >>> ++++++++++++++++++++ >>> 2 files changed, 59 insertions(+), 1 deletion(-) >>> create mode 100644 >>> meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch >>> >>> diff --git a/meta/recipes-graphics/clutter/clutter-gst-3.0.inc >>> b/meta/recipes-graphics/clutter/clutter-gst-3.0.inc >>> index d4fed71..c29bc7a 100644 >>> --- a/meta/recipes-graphics/clutter/clutter-gst-3.0.inc >>> +++ b/meta/recipes-graphics/clutter/clutter-gst-3.0.inc >>> @@ -4,7 +4,12 @@ LICENSE = "LGPLv2+" >>> >>> inherit clutter >>> >>> -SRC_URI += >>> "file://0001-Install-example-binary-needed-for-core-image-clutter.patch" >>> +SRC_URI += >>> "file://0001-Install-example-binary-needed-for-core-image-clutter.patch \ >>> + file://0001-configure.ac-add-enable-gudev.patch \ >>> + " >>> + >>> +PACKAGECONFIG ??= "" >>> +PACKAGECONFIG[gudev] = "--enable-gudev,--disable-gudev,udev" >>> >>> DEPENDS = "gstreamer1.0-plugins-base gstreamer1.0-plugins-bad >>> clutter-1.0" >>> RDEPENDS_${PN} += "gstreamer1.0-meta-base" >>> @@ -12,6 +17,14 @@ PACKAGES =+ "${PN}-examples" >>> >>> EXTRA_OECONF += "--disable-introspection" >>> >>> +python () { >>> + if bb.utils.contains('EXTRA_OECONF', '--enable-gudev', True, False, >>> d) and \ >>> + bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d): >>> + bb.warn("%s: gudev can't be enabled since systemd doesn't >>> provide libgudev" % \ >>> + d.getVar("PN", True)) >>> + d.appendVar('EXTRA_OECONF', ' --disable-gudev') >>> +} >>> + >> >> I think this part of the patch is wrong: You have to replace udev by >> gudev in DEPENDS part of packageconfig above and skip python function > > > I think that there is no gudev but udev ? udev provides gudev, but systemd > only provides udev, no gudev. > Sorry I meant libgudev - it is in meta-oe. I think there two cases of interest (packageconfig 'gudev' not set is boring - so not a case :) * distros with system: If packageconfig 'gudev' is set and meta-oe is not layers a parse error will occure similar to your python code. * non-systemd-distros: If packageconfig is set udev is pulled in (udev provides gudev for non systemd distros) Regards Andreas ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev 2015-11-12 9:17 ` Andreas Müller @ 2015-11-13 5:54 ` Robert Yang 2015-11-18 23:01 ` Burton, Ross 0 siblings, 1 reply; 9+ messages in thread From: Robert Yang @ 2015-11-13 5:54 UTC (permalink / raw) To: Andreas Müller; +Cc: Patches and discussions about the oe-core layer On 11/12/2015 05:17 PM, Andreas Müller wrote: > On Thu, Nov 12, 2015 at 10:06 AM, Robert Yang <liezhi.yang@windriver.com> wrote: >> >> >> On 11/12/2015 05:00 PM, Andreas Müller wrote: >>> >>> On Thu, Nov 12, 2015 at 9:51 AM, Robert Yang <liezhi.yang@windriver.com> >>> wrote: >>>> >>>> Fix dangling dependns on gudev, and systemd doesn't provide libgudev, so >>>> it can't be enabled when systemd either. >>>> >>>> Fixed: >>>> libtool: error: cannot find the library >>>> 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' or unhandled argument >>>> 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' >>>> >>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com> >>>> --- >>>> meta/recipes-graphics/clutter/clutter-gst-3.0.inc | 15 ++++++- >>>> .../0001-configure.ac-add-enable-gudev.patch | 45 >>>> ++++++++++++++++++++ >>>> 2 files changed, 59 insertions(+), 1 deletion(-) >>>> create mode 100644 >>>> meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch >>>> >>>> diff --git a/meta/recipes-graphics/clutter/clutter-gst-3.0.inc >>>> b/meta/recipes-graphics/clutter/clutter-gst-3.0.inc >>>> index d4fed71..c29bc7a 100644 >>>> --- a/meta/recipes-graphics/clutter/clutter-gst-3.0.inc >>>> +++ b/meta/recipes-graphics/clutter/clutter-gst-3.0.inc >>>> @@ -4,7 +4,12 @@ LICENSE = "LGPLv2+" >>>> >>>> inherit clutter >>>> >>>> -SRC_URI += >>>> "file://0001-Install-example-binary-needed-for-core-image-clutter.patch" >>>> +SRC_URI += >>>> "file://0001-Install-example-binary-needed-for-core-image-clutter.patch \ >>>> + file://0001-configure.ac-add-enable-gudev.patch \ >>>> + " >>>> + >>>> +PACKAGECONFIG ??= "" >>>> +PACKAGECONFIG[gudev] = "--enable-gudev,--disable-gudev,udev" >>>> >>>> DEPENDS = "gstreamer1.0-plugins-base gstreamer1.0-plugins-bad >>>> clutter-1.0" >>>> RDEPENDS_${PN} += "gstreamer1.0-meta-base" >>>> @@ -12,6 +17,14 @@ PACKAGES =+ "${PN}-examples" >>>> >>>> EXTRA_OECONF += "--disable-introspection" >>>> >>>> +python () { >>>> + if bb.utils.contains('EXTRA_OECONF', '--enable-gudev', True, False, >>>> d) and \ >>>> + bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d): >>>> + bb.warn("%s: gudev can't be enabled since systemd doesn't >>>> provide libgudev" % \ >>>> + d.getVar("PN", True)) >>>> + d.appendVar('EXTRA_OECONF', ' --disable-gudev') >>>> +} >>>> + >>> >>> I think this part of the patch is wrong: You have to replace udev by >>> gudev in DEPENDS part of packageconfig above and skip python function >> >> >> I think that there is no gudev but udev ? udev provides gudev, but systemd >> only provides udev, no gudev. >> > Sorry I meant libgudev - it is in meta-oe. > > I think there two cases of interest (packageconfig 'gudev' not set is > boring - so not a case :) > > * distros with system: If packageconfig 'gudev' is set and meta-oe is > not layers a parse error will occure similar to your python code. > * non-systemd-distros: If packageconfig is set udev is pulled in (udev > provides gudev for non systemd distros) Sorry, what did you mean, please ? Are fine with this patch ? // Robert > > Regards > > Andreas > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev 2015-11-13 5:54 ` Robert Yang @ 2015-11-18 23:01 ` Burton, Ross 0 siblings, 0 replies; 9+ messages in thread From: Burton, Ross @ 2015-11-18 23:01 UTC (permalink / raw) To: Robert Yang; +Cc: Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 292 bytes --] On 13 November 2015 at 05:54, Robert Yang <liezhi.yang@windriver.com> wrote: > Sorry, what did you mean, please ? Are fine with this patch ? > No. The code checks for libgudev but your adding a build dependency of udev, which only provides gudev when systemd isn't enabled. Ross [-- Attachment #2: Type: text/html, Size: 779 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev 2015-11-12 9:06 ` Robert Yang 2015-11-12 9:17 ` Andreas Müller @ 2015-11-12 10:25 ` Martin Jansa 1 sibling, 0 replies; 9+ messages in thread From: Martin Jansa @ 2015-11-12 10:25 UTC (permalink / raw) To: Robert Yang; +Cc: Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 3050 bytes --] On Thu, Nov 12, 2015 at 05:06:54PM +0800, Robert Yang wrote: > > > On 11/12/2015 05:00 PM, Andreas Müller wrote: > > On Thu, Nov 12, 2015 at 9:51 AM, Robert Yang <liezhi.yang@windriver.com> wrote: > >> Fix dangling dependns on gudev, and systemd doesn't provide libgudev, so > >> it can't be enabled when systemd either. > >> > >> Fixed: > >> libtool: error: cannot find the library 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' or unhandled argument > >> 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' > >> > >> Signed-off-by: Robert Yang <liezhi.yang@windriver.com> > >> --- > >> meta/recipes-graphics/clutter/clutter-gst-3.0.inc | 15 ++++++- > >> .../0001-configure.ac-add-enable-gudev.patch | 45 ++++++++++++++++++++ > >> 2 files changed, 59 insertions(+), 1 deletion(-) > >> create mode 100644 meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch > >> > >> diff --git a/meta/recipes-graphics/clutter/clutter-gst-3.0.inc b/meta/recipes-graphics/clutter/clutter-gst-3.0.inc > >> index d4fed71..c29bc7a 100644 > >> --- a/meta/recipes-graphics/clutter/clutter-gst-3.0.inc > >> +++ b/meta/recipes-graphics/clutter/clutter-gst-3.0.inc > >> @@ -4,7 +4,12 @@ LICENSE = "LGPLv2+" > >> > >> inherit clutter > >> > >> -SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch" > >> +SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch \ > >> + file://0001-configure.ac-add-enable-gudev.patch \ > >> + " > >> + > >> +PACKAGECONFIG ??= "" > >> +PACKAGECONFIG[gudev] = "--enable-gudev,--disable-gudev,udev" > >> > >> DEPENDS = "gstreamer1.0-plugins-base gstreamer1.0-plugins-bad clutter-1.0" > >> RDEPENDS_${PN} += "gstreamer1.0-meta-base" > >> @@ -12,6 +17,14 @@ PACKAGES =+ "${PN}-examples" > >> > >> EXTRA_OECONF += "--disable-introspection" > >> > >> +python () { > >> + if bb.utils.contains('EXTRA_OECONF', '--enable-gudev', True, False, d) and \ > >> + bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d): > >> + bb.warn("%s: gudev can't be enabled since systemd doesn't provide libgudev" % \ > >> + d.getVar("PN", True)) > >> + d.appendVar('EXTRA_OECONF', ' --disable-gudev') > >> +} > >> + > > I think this part of the patch is wrong: You have to replace udev by > > gudev in DEPENDS part of packageconfig above and skip python function > > I think that there is no gudev but udev ? udev provides gudev, but systemd > only provides udev, no gudev. There is gudev in meta-oe (for people using systemd): meta-oe/recipes-gnome/libgudev/libgudev_230.bb > > // Robert > > > complete. > > > > Andreas > > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 188 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-11-18 23:01 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-11-12 8:51 [PATCH 0/2] meta: fix gdbm and clutter-gst-3.0 Robert Yang 2015-11-12 8:51 ` [PATCH 1/2] gdbm 1.8.3: install libgdbm_compat Robert Yang 2015-11-12 8:51 ` [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev Robert Yang 2015-11-12 9:00 ` Andreas Müller 2015-11-12 9:06 ` Robert Yang 2015-11-12 9:17 ` Andreas Müller 2015-11-13 5:54 ` Robert Yang 2015-11-18 23:01 ` Burton, Ross 2015-11-12 10:25 ` Martin Jansa
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.