[PATCH] meson.bbclass: avoid unexpected operating-system names

[PATCH] meson.bbclass: avoid unexpected operating-system names

[Andreas M?ller]

For example 'linux-gnueabi' is not what meson consumers expect: See canonical
table of OS names for Meson (thanks Ross). Surprisingly this did not pop up
earlier but wrong system-name can break building as described in [1]

[1] https://lists.openembedded.org/g/openembedded-core/topic/meson_host_machine_system/73023862

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 meta/classes/meson.bbclass | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/classes/meson.bbclass b/meta/classes/meson.bbclass
index 06034e8b47..167263f76c 100644
--- a/meta/classes/meson.bbclass
+++ b/meta/classes/meson.bbclass
@@ -68,6 +68,9 @@ def meson_operating_system(var, d):
     os = d.getVar(var)
     if "mingw" in os:
         return "windows"
+    # avoid e.g 'linux-gnueabi'
+    elif "linux" in os:
+        return "linux"
     else:
         return os
 
-- 
2.21.1

Re: [PATCH] meson.bbclass: avoid unexpected operating-system names

[Andreas M?ller]

On Thu, Apr 16, 2020 at 12:30 AM Andreas Müller <schnitzeltony@gmail.com> wrote:
>
> For example 'linux-gnueabi' is not what meson consumers expect: See canonical
> table of OS names for Meson (thanks Ross). Surprisingly this did not pop up
> earlier but wrong system-name can break building as described in [1]
>
> [1] https://lists.openembedded.org/g/openembedded-core/topic/meson_host_machine_system/73023862

Ping

* at least I consider it important: The issue fixed can cause
undetected misconfigurations
* yes meson can do better but this is not in the scope of this patch

Andreas