[PATCH] matchbox-wm: fix QA issues with composite enabled

[PATCH] matchbox-wm: fix QA issues with composite enabled

[Awais Belal]

If we try and enable composite support using --enable-composite
through EXTRA_OECONF the following warnings are seen
WARNING: matchbox-wm-1.2.1-r0 do_package_qa: QA Issue: matchbox-wm rdepends on libxcomposite, but it isn't a build dependency, missing libxcomposite in DEPENDS or PACKAGECONFIG? [build-deps]
WARNING: matchbox-wm-1.2.1-r0 do_package_qa: QA Issue: matchbox-wm rdepends on libxdamage, but it isn't a build dependency, missing libxdamage in DEPENDS or PACKAGECONFIG? [build-deps]
This fixes the above mentioned warnings.

Signed-off-by: Awais Belal <awais_belal@mentor.com>
---
 meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.2.bb b/meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.2.bb
index 815a75f..58e21a4 100644
--- a/meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.2.bb
+++ b/meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.2.bb
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://src/wm.h;endline=21;md5=a7e844465edbcf79c282369f93caa
                     file://src/wm.c;endline=21;md5=8dc9d24477d87ef5dfbc2e4927146aab"
 
 SECTION = "x11/wm"
-DEPENDS = "libmatchbox virtual/libx11 libxext libxrender startup-notification expat gconf libxcursor libxfixes"
+DEPENDS = "libmatchbox virtual/libx11 libxext libxrender startup-notification expat gconf libxcursor libxfixes libxcomposite libxdamage"
 
 # SRCREV tagged 1.2.2
 SRCREV = "27da947e7fbdf9659f7e5bd1e92af92af6c03970"
-- 
2.7.4

Re: [PATCH] matchbox-wm: fix QA issues with composite enabled

[Andreas Müller]

On Mon, Mar 26, 2018 at 12:40 PM, Awais Belal <awais_belal@mentor.com> wrote:
> If we try and enable composite support using --enable-composite
> through EXTRA_OECONF the following warnings are seen
> WARNING: matchbox-wm-1.2.1-r0 do_package_qa: QA Issue: matchbox-wm rdepends on libxcomposite, but it isn't a build dependency, missing libxcomposite in DEPENDS or PACKAGECONFIG? [build-deps]
> WARNING: matchbox-wm-1.2.1-r0 do_package_qa: QA Issue: matchbox-wm rdepends on libxdamage, but it isn't a build dependency, missing libxdamage in DEPENDS or PACKAGECONFIG? [build-deps]
> This fixes the above mentioned warnings.
>
> Signed-off-by: Awais Belal <awais_belal@mentor.com>
> ---
>  meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.2.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.2.bb b/meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.2.bb
> index 815a75f..58e21a4 100644
> --- a/meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.2.bb
> +++ b/meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.2.bb
> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://src/wm.h;endline=21;md5=a7e844465edbcf79c282369f93caa
>                      file://src/wm.c;endline=21;md5=8dc9d24477d87ef5dfbc2e4927146aab"
>
>  SECTION = "x11/wm"
> -DEPENDS = "libmatchbox virtual/libx11 libxext libxrender startup-notification expat gconf libxcursor libxfixes"
> +DEPENDS = "libmatchbox virtual/libx11 libxext libxrender startup-notification expat gconf libxcursor libxfixes libxcomposite libxdamage"
>
>  # SRCREV tagged 1.2.2
>  SRCREV = "27da947e7fbdf9659f7e5bd1e92af92af6c03970"
> --
> 2.7.4
>
Maybe I missed something but from what I read it seems you are adding
options to your EXTRA_OECONF and fix QA by adding dependencies for all
cases.

Isn't this exactly what PACKAGECONFIGs are for?

Andreas

Re: [PATCH] matchbox-wm: fix QA issues with composite enabled

[Burton, Ross]

On 26 March 2018 at 12:15, Andreas Müller <schnitzeltony@gmail.com> wrote:
> On Mon, Mar 26, 2018 at 12:40 PM, Awais Belal <awais_belal@mentor.com> wrote:
>> If we try and enable composite support using --enable-composite
>> through EXTRA_OECONF the following warnings are seen
>> WARNING: matchbox-wm-1.2.1-r0 do_package_qa: QA Issue: matchbox-wm rdepends on libxcomposite, but it isn't a build dependency, missing libxcomposite in DEPENDS or PACKAGECONFIG? [build-deps]
>> WARNING: matchbox-wm-1.2.1-r0 do_package_qa: QA Issue: matchbox-wm rdepends on libxdamage, but it isn't a build dependency, missing libxdamage in DEPENDS or PACKAGECONFIG? [build-deps]
>> This fixes the above mentioned warnings.
>>
>> Signed-off-by: Awais Belal <awais_belal@mentor.com>
>> ---
>>  meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.2.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.2.bb b/meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.2.bb
>> index 815a75f..58e21a4 100644
>> --- a/meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.2.bb
>> +++ b/meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.2.bb
>> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://src/wm.h;endline=21;md5=a7e844465edbcf79c282369f93caa
>>                      file://src/wm.c;endline=21;md5=8dc9d24477d87ef5dfbc2e4927146aab"
>>
>>  SECTION = "x11/wm"
>> -DEPENDS = "libmatchbox virtual/libx11 libxext libxrender startup-notification expat gconf libxcursor libxfixes"
>> +DEPENDS = "libmatchbox virtual/libx11 libxext libxrender startup-notification expat gconf libxcursor libxfixes libxcomposite libxdamage"
>>
>>  # SRCREV tagged 1.2.2
>>  SRCREV = "27da947e7fbdf9659f7e5bd1e92af92af6c03970"
>> --
>> 2.7.4
>>
> Maybe I missed something but from what I read it seems you are adding
> options to your EXTRA_OECONF and fix QA by adding dependencies for all
> cases.
>
> Isn't this exactly what PACKAGECONFIGs are for?

Yes, if the dependencies are only required when specific options are
turned on, then add a PACKAGECONFIG (or add the DEPENDS in your
bbappend where you turn the options on).

Ross