[PATCH] efi_loader: Do not enable by default on armv7

[PATCH] efi_loader: Do not enable by default on armv7

[Tom Rini]

We have had EFI loader support enabled by default on armv7 platforms for
a long time now.  However, there has been little uptake in the wider
community to use EFI loader support as the step to start a generic OS
distribution, on this architecture family and the focus has been on
armv8 instead.  Disable this by default for armv7 only.

Cc: Alexander Graf <agraf@csgraf.de>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: Mark Kettenis <kettenis@openbsd.org>
Cc: Masahisa Kojima <masahisa.kojima@linaro.org>
Cc: Peter Robinson <pbrobinson@gmail.com>
Cc: Sughosh Ganu <sughosh.ganu@linaro.org>
Cc: Vagrant Cascadian <vagrant@debian.org>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
I'm very much looking for feedback here that this is the wrong approach
and that I've missed the off the shelf distributions that make use of
this.
---
 lib/efi_loader/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
index 6242caceb7f9..8a22fe9951a3 100644
--- a/lib/efi_loader/Kconfig
+++ b/lib/efi_loader/Kconfig
@@ -10,7 +10,7 @@ config EFI_LOADER
 	depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT
 	# We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB
 	depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT
-	default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
+	default y if !ARM || SYS_CPU = armv8
 	select LIB_UUID
 	select HAVE_BLOCK_DEVICE
 	select REGEX
-- 
2.17.1

Re: [PATCH] efi_loader: Do not enable by default on armv7

[Heinrich Schuchardt]

On 6/27/21 9:44 PM, Tom Rini wrote:
> We have had EFI loader support enabled by default on armv7 platforms for
> a long time now.  However, there has been little uptake in the wider
> community to use EFI loader support as the step to start a generic OS
> distribution, on this architecture family and the focus has been on
> armv8 instead.  Disable this by default for armv7 only.

NAK

Please, read https://fedoraproject.org/wiki/Changes/uEFIforARMv7.

Best regards

Heinrich

>
> Cc: Alexander Graf <agraf@csgraf.de>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Cc: Mark Kettenis <kettenis@openbsd.org>
> Cc: Masahisa Kojima <masahisa.kojima@linaro.org>
> Cc: Peter Robinson <pbrobinson@gmail.com>
> Cc: Sughosh Ganu <sughosh.ganu@linaro.org>
> Cc: Vagrant Cascadian <vagrant@debian.org>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> I'm very much looking for feedback here that this is the wrong approach
> and that I've missed the off the shelf distributions that make use of
> this.
> ---
>   lib/efi_loader/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index 6242caceb7f9..8a22fe9951a3 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -10,7 +10,7 @@ config EFI_LOADER
>   	depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT
>   	# We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB
>   	depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT
> -	default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
> +	default y if !ARM || SYS_CPU = armv8
>   	select LIB_UUID
>   	select HAVE_BLOCK_DEVICE
>   	select REGEX
>

Re: [PATCH] efi_loader: Do not enable by default on armv7

[Mark Kettenis]

> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Date: Sun, 27 Jun 2021 23:03:58 +0200
> 
> On 6/27/21 9:44 PM, Tom Rini wrote:
> > We have had EFI loader support enabled by default on armv7 platforms for
> > a long time now.  However, there has been little uptake in the wider
> > community to use EFI loader support as the step to start a generic OS
> > distribution, on this architecture family and the focus has been on
> > armv8 instead.  Disable this by default for armv7 only.
> 
> NAK
> 
> Please, read https://fedoraproject.org/wiki/Changes/uEFIforARMv7.

+1

OpenBSD/armv7 relies on EFI loader support as well.

Cheers.

> > Cc: Alexander Graf <agraf@csgraf.de>
> > Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> > Cc: Mark Kettenis <kettenis@openbsd.org>
> > Cc: Masahisa Kojima <masahisa.kojima@linaro.org>
> > Cc: Peter Robinson <pbrobinson@gmail.com>
> > Cc: Sughosh Ganu <sughosh.ganu@linaro.org>
> > Cc: Vagrant Cascadian <vagrant@debian.org>
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> > I'm very much looking for feedback here that this is the wrong approach
> > and that I've missed the off the shelf distributions that make use of
> > this.
> > ---
> >   lib/efi_loader/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> > index 6242caceb7f9..8a22fe9951a3 100644
> > --- a/lib/efi_loader/Kconfig
> > +++ b/lib/efi_loader/Kconfig
> > @@ -10,7 +10,7 @@ config EFI_LOADER
> >   	depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT
> >   	# We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB
> >   	depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT
> > -	default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
> > +	default y if !ARM || SYS_CPU = armv8
> >   	select LIB_UUID
> >   	select HAVE_BLOCK_DEVICE
> >   	select REGEX
> >
> 
> 

Re: [PATCH] efi_loader: Do not enable by default on armv7

[Heinrich Schuchardt]

On 6/27/21 11:03 PM, Heinrich Schuchardt wrote:
> On 6/27/21 9:44 PM, Tom Rini wrote:
>> We have had EFI loader support enabled by default on armv7 platforms for
>> a long time now.  However, there has been little uptake in the wider
>> community to use EFI loader support as the step to start a generic OS
>> distribution, on this architecture family and the focus has been on
>> armv8 instead.  Disable this by default for armv7 only.
>
> NAK
>
> Please, read https://fedoraproject.org/wiki/Changes/uEFIforARMv7.

OpenBSD and FreeBSD rely on UEFI for booting.

>
> Best regards
>
> Heinrich
>
>>
>> Cc: Alexander Graf <agraf@csgraf.de>
>> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
>> Cc: Mark Kettenis <kettenis@openbsd.org>
>> Cc: Masahisa Kojima <masahisa.kojima@linaro.org>
>> Cc: Peter Robinson <pbrobinson@gmail.com>
>> Cc: Sughosh Ganu <sughosh.ganu@linaro.org>
>> Cc: Vagrant Cascadian <vagrant@debian.org>
>> Signed-off-by: Tom Rini <trini@konsulko.com>
>> ---
>> I'm very much looking for feedback here that this is the wrong approach
>> and that I've missed the off the shelf distributions that make use of
>> this.
>> ---
>>   lib/efi_loader/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
>> index 6242caceb7f9..8a22fe9951a3 100644
>> --- a/lib/efi_loader/Kconfig
>> +++ b/lib/efi_loader/Kconfig
>> @@ -10,7 +10,7 @@ config EFI_LOADER
>>       depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT
>>       # We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB
>>       depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT
>> -    default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
>> +    default y if !ARM || SYS_CPU = armv8
>>       select LIB_UUID
>>       select HAVE_BLOCK_DEVICE
>>       select REGEX
>>
>

Re: [PATCH] efi_loader: Do not enable by default on armv7

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

On Sun, Jun 27, 2021 at 11:08:04PM +0200, Mark Kettenis wrote:
> > From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > Date: Sun, 27 Jun 2021 23:03:58 +0200
> > 
> > On 6/27/21 9:44 PM, Tom Rini wrote:
> > > We have had EFI loader support enabled by default on armv7 platforms for
> > > a long time now.  However, there has been little uptake in the wider
> > > community to use EFI loader support as the step to start a generic OS
> > > distribution, on this architecture family and the focus has been on
> > > armv8 instead.  Disable this by default for armv7 only.
> > 
> > NAK
> > 
> > Please, read https://fedoraproject.org/wiki/Changes/uEFIforARMv7.
> 
> +1
> 
> OpenBSD/armv7 relies on EFI loader support as well.

OK, thanks guys.  I missed the Fedora link and I thought *BSD was still
using a custom loader on v7.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH] efi_loader: Do not enable by default on armv7

[Peter Robinson]

On Sun, Jun 27, 2021 at 10:22 PM Tom Rini <trini@konsulko.com> wrote:
>
> On Sun, Jun 27, 2021 at 11:08:04PM +0200, Mark Kettenis wrote:
> > > From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > > Date: Sun, 27 Jun 2021 23:03:58 +0200
> > >
> > > On 6/27/21 9:44 PM, Tom Rini wrote:
> > > > We have had EFI loader support enabled by default on armv7 platforms for
> > > > a long time now.  However, there has been little uptake in the wider
> > > > community to use EFI loader support as the step to start a generic OS
> > > > distribution, on this architecture family and the focus has been on
> > > > armv8 instead.  Disable this by default for armv7 only.
> > >
> > > NAK
> > >
> > > Please, read https://fedoraproject.org/wiki/Changes/uEFIforARMv7.
> >
> > +1
> >
> > OpenBSD/armv7 relies on EFI loader support as well.
>
> OK, thanks guys.  I missed the Fedora link and I thought *BSD was still
> using a custom loader on v7.

Yes, so Fedora uses UEFI by default for across all arm devices now.
Linaro also uses it for a bunch of their reference platforms but Ilias
will be able to better provide details there.

Peter

Re: [PATCH] efi_loader: Do not enable by default on armv7

[Ilias Apalodimas]

On Mon, Jun 28, 2021 at 08:45:13AM +0100, Peter Robinson wrote:
> On Sun, Jun 27, 2021 at 10:22 PM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Sun, Jun 27, 2021 at 11:08:04PM +0200, Mark Kettenis wrote:
> > > > From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > > > Date: Sun, 27 Jun 2021 23:03:58 +0200
> > > >
> > > > On 6/27/21 9:44 PM, Tom Rini wrote:
> > > > > We have had EFI loader support enabled by default on armv7 platforms for
> > > > > a long time now.  However, there has been little uptake in the wider
> > > > > community to use EFI loader support as the step to start a generic OS
> > > > > distribution, on this architecture family and the focus has been on
> > > > > armv8 instead.  Disable this by default for armv7 only.
> > > >
> > > > NAK
> > > >
> > > > Please, read https://fedoraproject.org/wiki/Changes/uEFIforARMv7.
> > >
> > > +1
> > >
> > > OpenBSD/armv7 relies on EFI loader support as well.
> >
> > OK, thanks guys.  I missed the Fedora link and I thought *BSD was still
> > using a custom loader on v7.
> 
> Yes, so Fedora uses UEFI by default for across all arm devices now.
> Linaro also uses it for a bunch of their reference platforms but Ilias
> will be able to better provide details there.
> 

Yes we are also booting every platform with EFI.  And tbh it's not only a
matter of distros that already use it.  Arm itself has the SystemReady
specification [1] which mandates the use of EFI in most of it's flavors (SR,
ES and IR). Keeping in mind U-Boot's EFI support is very close to be 100%
compliant,  I think it's beneficial overall to have pre-canned board configs
that support that.

[1] https://developer.arm.com/architectures/system-architectures/arm-systemready


Cheers
/Ilias