All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] sunxi: A64/H5 devices: enable usb keyboard support
@ 2018-04-09 12:15 Peter Robinson
  2018-04-09 12:53 ` Maxime Ripard
  2018-04-09 13:50 ` Antony Antony
  0 siblings, 2 replies; 9+ messages in thread
From: Peter Robinson @ 2018-04-09 12:15 UTC (permalink / raw)
  To: u-boot

Now the A64/H5 SoCs support video output it's useful to enable usb keyboard
support so console can be used via standard keyboard/video interface.

Tested on Pine64.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 configs/a64-olinuxino_defconfig       | 2 ++
 configs/bananapi_m64_defconfig        | 2 ++
 configs/nanopi_a64_defconfig          | 2 ++
 configs/nanopi_neo2_defconfig         | 2 ++
 configs/nanopi_neo_plus2_defconfig    | 2 ++
 configs/orangepi_pc2_defconfig        | 2 ++
 configs/orangepi_win_defconfig        | 2 ++
 configs/orangepi_zero_plus2_defconfig | 2 ++
 configs/pine64_plus_defconfig         | 2 ++
 configs/sopine_baseboard_defconfig    | 2 ++
 10 files changed, 20 insertions(+)

diff --git a/configs/a64-olinuxino_defconfig b/configs/a64-olinuxino_defconfig
index 6edefa4f67..c4cdec4771 100644
--- a/configs/a64-olinuxino_defconfig
+++ b/configs/a64-olinuxino_defconfig
@@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/bananapi_m64_defconfig b/configs/bananapi_m64_defconfig
index 60cbfd9b2b..4174dd7aac 100644
--- a/configs/bananapi_m64_defconfig
+++ b/configs/bananapi_m64_defconfig
@@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/nanopi_a64_defconfig b/configs/nanopi_a64_defconfig
index 122fcc5794..3bef473d48 100644
--- a/configs/nanopi_a64_defconfig
+++ b/configs/nanopi_a64_defconfig
@@ -12,3 +12,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-nanopi-a64"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/nanopi_neo2_defconfig b/configs/nanopi_neo2_defconfig
index f27529d7d4..6622a186f3 100644
--- a/configs/nanopi_neo2_defconfig
+++ b/configs/nanopi_neo2_defconfig
@@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/nanopi_neo_plus2_defconfig b/configs/nanopi_neo_plus2_defconfig
index 5f69799e06..1c6ad4647d 100644
--- a/configs/nanopi_neo_plus2_defconfig
+++ b/configs/nanopi_neo_plus2_defconfig
@@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo-plus2"
 # CONFIG_SPL_EFI_PARTITION is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/orangepi_pc2_defconfig b/configs/orangepi_pc2_defconfig
index 893780a0f7..7d01e6f27c 100644
--- a/configs/orangepi_pc2_defconfig
+++ b/configs/orangepi_pc2_defconfig
@@ -15,3 +15,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/orangepi_win_defconfig b/configs/orangepi_win_defconfig
index 0fd297752d..85f0731c3c 100644
--- a/configs/orangepi_win_defconfig
+++ b/configs/orangepi_win_defconfig
@@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-orangepi-win"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/orangepi_zero_plus2_defconfig b/configs/orangepi_zero_plus2_defconfig
index b48f13e7b1..4f1f008ea8 100644
--- a/configs/orangepi_zero_plus2_defconfig
+++ b/configs/orangepi_zero_plus2_defconfig
@@ -15,3 +15,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-zero-plus2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/pine64_plus_defconfig b/configs/pine64_plus_defconfig
index 23365a57c3..42281a9d7d 100644
--- a/configs/pine64_plus_defconfig
+++ b/configs/pine64_plus_defconfig
@@ -15,3 +15,5 @@ CONFIG_RTL8211E_PINE64_GIGABIT_FIX=y
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/sopine_baseboard_defconfig b/configs/sopine_baseboard_defconfig
index 503e3903ca..30cb6b93d0 100644
--- a/configs/sopine_baseboard_defconfig
+++ b/configs/sopine_baseboard_defconfig
@@ -19,3 +19,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pine64-plus"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] sunxi: A64/H5 devices: enable usb keyboard support
  2018-04-09 12:15 [U-Boot] [PATCH] sunxi: A64/H5 devices: enable usb keyboard support Peter Robinson
@ 2018-04-09 12:53 ` Maxime Ripard
  2018-04-09 13:13   ` Peter Robinson
  2018-04-09 13:50 ` Antony Antony
  1 sibling, 1 reply; 9+ messages in thread
From: Maxime Ripard @ 2018-04-09 12:53 UTC (permalink / raw)
  To: u-boot

On Mon, Apr 09, 2018 at 01:15:00PM +0100, Peter Robinson wrote:
> Now the A64/H5 SoCs support video output it's useful to enable usb keyboard
> support so console can be used via standard keyboard/video interface.
> 
> Tested on Pine64.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Don't forget any maintainers when you're sending a patch :)

> ---
>  configs/a64-olinuxino_defconfig       | 2 ++
>  configs/bananapi_m64_defconfig        | 2 ++
>  configs/nanopi_a64_defconfig          | 2 ++
>  configs/nanopi_neo2_defconfig         | 2 ++
>  configs/nanopi_neo_plus2_defconfig    | 2 ++
>  configs/orangepi_pc2_defconfig        | 2 ++
>  configs/orangepi_win_defconfig        | 2 ++
>  configs/orangepi_zero_plus2_defconfig | 2 ++
>  configs/pine64_plus_defconfig         | 2 ++
>  configs/sopine_baseboard_defconfig    | 2 ++
>  10 files changed, 20 insertions(+)
> 
> diff --git a/configs/a64-olinuxino_defconfig b/configs/a64-olinuxino_defconfig
> index 6edefa4f67..c4cdec4771 100644
> --- a/configs/a64-olinuxino_defconfig
> +++ b/configs/a64-olinuxino_defconfig
> @@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino"
>  CONFIG_SUN8I_EMAC=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
> +CONFIG_DM_KEYBOARD=y
> +CONFIG_USB_KEYBOARD=y

Both are already selected by ARCH_SUNXI if DISTRO_DEFAULTS is set. In
turn, DISTRO_DEFAULTS is enabled by default if ARCH_SUNXI is. Why do
you need to enable it in the defconfig?

If this doesn't work for some reason, this should be fixed at the
Kconfig level, not in the defconfig.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180409/b121773c/attachment.sig>

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] sunxi: A64/H5 devices: enable usb keyboard support
  2018-04-09 12:53 ` Maxime Ripard
@ 2018-04-09 13:13   ` Peter Robinson
  0 siblings, 0 replies; 9+ messages in thread
From: Peter Robinson @ 2018-04-09 13:13 UTC (permalink / raw)
  To: u-boot

On Mon, Apr 9, 2018 at 1:53 PM, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> On Mon, Apr 09, 2018 at 01:15:00PM +0100, Peter Robinson wrote:
>> Now the A64/H5 SoCs support video output it's useful to enable usb keyboard
>> support so console can be used via standard keyboard/video interface.
>>
>> Tested on Pine64.
>>
>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>
> Don't forget any maintainers when you're sending a patch :)

The list in the cc: is what ./scripts/get_maintainer.pl returned when
run against the patch

>> ---
>>  configs/a64-olinuxino_defconfig       | 2 ++
>>  configs/bananapi_m64_defconfig        | 2 ++
>>  configs/nanopi_a64_defconfig          | 2 ++
>>  configs/nanopi_neo2_defconfig         | 2 ++
>>  configs/nanopi_neo_plus2_defconfig    | 2 ++
>>  configs/orangepi_pc2_defconfig        | 2 ++
>>  configs/orangepi_win_defconfig        | 2 ++
>>  configs/orangepi_zero_plus2_defconfig | 2 ++
>>  configs/pine64_plus_defconfig         | 2 ++
>>  configs/sopine_baseboard_defconfig    | 2 ++
>>  10 files changed, 20 insertions(+)
>>
>> diff --git a/configs/a64-olinuxino_defconfig b/configs/a64-olinuxino_defconfig
>> index 6edefa4f67..c4cdec4771 100644
>> --- a/configs/a64-olinuxino_defconfig
>> +++ b/configs/a64-olinuxino_defconfig
>> @@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino"
>>  CONFIG_SUN8I_EMAC=y
>>  CONFIG_USB_EHCI_HCD=y
>>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
>> +CONFIG_DM_KEYBOARD=y
>> +CONFIG_USB_KEYBOARD=y
>
> Both are already selected by ARCH_SUNXI if DISTRO_DEFAULTS is set. In
> turn, DISTRO_DEFAULTS is enabled by default if ARCH_SUNXI is. Why do
> you need to enable it in the defconfig?
>
> If this doesn't work for some reason, this should be fixed at the
> Kconfig level, not in the defconfig.
>
> Maxime
>
> --
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] sunxi: A64/H5 devices: enable usb keyboard support
  2018-04-09 12:15 [U-Boot] [PATCH] sunxi: A64/H5 devices: enable usb keyboard support Peter Robinson
  2018-04-09 12:53 ` Maxime Ripard
@ 2018-04-09 13:50 ` Antony Antony
  2018-04-18 11:47   ` Peter Robinson
  1 sibling, 1 reply; 9+ messages in thread
From: Antony Antony @ 2018-04-09 13:50 UTC (permalink / raw)
  To: u-boot

On Mon, Apr 09, 2018 at 01:15:00PM +0100, Peter Robinson wrote:
> Now the A64/H5 SoCs support video output it's useful to enable usb keyboard
> support so console can be used via standard keyboard/video interface.
> 
> Tested on Pine64.

Is it usefull on devices without video output(no HDMI, VGA)?


>  configs/nanopi_neo2_defconfig         | 2 ++
>  configs/nanopi_neo_plus2_defconfig    | 2 ++


> --- a/configs/nanopi_neo2_defconfig
> +++ b/configs/nanopi_neo2_defconfig
> @@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo2"
>  CONFIG_SUN8I_EMAC=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
> +CONFIG_DM_KEYBOARD=y
> +CONFIG_USB_KEYBOARD=y
> diff --git a/configs/nanopi_neo_plus2_defconfig b/configs/nanopi_neo_plus2_defconfig
> index 5f69799e06..1c6ad4647d 100644
> --- a/configs/nanopi_neo_plus2_defconfig
> +++ b/configs/nanopi_neo_plus2_defconfig
> @@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo-plus2"
>  # CONFIG_SPL_EFI_PARTITION is not set
>  CONFIG_SUN8I_EMAC=y
>  CONFIG_USB_EHCI_HCD=y
> +CONFIG_DM_KEYBOARD=y
> +CONFIG_USB_KEYBOARD=y

these two devices have no video out. I am not sure all these have HDMI output.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] sunxi: A64/H5 devices: enable usb keyboard support
  2018-04-09 13:50 ` Antony Antony
@ 2018-04-18 11:47   ` Peter Robinson
  0 siblings, 0 replies; 9+ messages in thread
From: Peter Robinson @ 2018-04-18 11:47 UTC (permalink / raw)
  To: u-boot

On Mon, Apr 9, 2018 at 2:50 PM, Antony Antony <antony@phenome.org> wrote:
> On Mon, Apr 09, 2018 at 01:15:00PM +0100, Peter Robinson wrote:
>> Now the A64/H5 SoCs support video output it's useful to enable usb keyboard
>> support so console can be used via standard keyboard/video interface.
>>
>> Tested on Pine64.
>
> Is it usefull on devices without video output(no HDMI, VGA)?
>
>
>>  configs/nanopi_neo2_defconfig         | 2 ++
>>  configs/nanopi_neo_plus2_defconfig    | 2 ++
>
>
>> --- a/configs/nanopi_neo2_defconfig
>> +++ b/configs/nanopi_neo2_defconfig
>> @@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo2"
>>  CONFIG_SUN8I_EMAC=y
>>  CONFIG_USB_EHCI_HCD=y
>>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
>> +CONFIG_DM_KEYBOARD=y
>> +CONFIG_USB_KEYBOARD=y
>> diff --git a/configs/nanopi_neo_plus2_defconfig b/configs/nanopi_neo_plus2_defconfig
>> index 5f69799e06..1c6ad4647d 100644
>> --- a/configs/nanopi_neo_plus2_defconfig
>> +++ b/configs/nanopi_neo_plus2_defconfig
>> @@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo-plus2"
>>  # CONFIG_SPL_EFI_PARTITION is not set
>>  CONFIG_SUN8I_EMAC=y
>>  CONFIG_USB_EHCI_HCD=y
>> +CONFIG_DM_KEYBOARD=y
>> +CONFIG_USB_KEYBOARD=y
>
> these two devices have no video out. I am not sure all these have HDMI output.

Well it's likely a moot point as the HDMI seems enabled on the SoC by
default but I'll update to drop those two.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] sunxi: A64/H5 devices: enable usb keyboard support
  2018-04-18 16:17   ` Peter Robinson
@ 2018-04-18 16:30     ` Andre Przywara
  0 siblings, 0 replies; 9+ messages in thread
From: Andre Przywara @ 2018-04-18 16:30 UTC (permalink / raw)
  To: u-boot

Hi,

On 18/04/18 17:17, Peter Robinson wrote:
> On Wed, Apr 18, 2018 at 4:29 PM, Andre Przywara <andre.przywara@arm.com> wrote:
>> Hi,
>>
>> On 18/04/18 16:19, Peter Robinson wrote:
>>> Now the A64/H5 SoCs support video output it's useful to enable usb keyboard
>>> support so console can be used via standard keyboard/video interface.
>>>
>>> Tested on Pine64.
>>
>> Mmmh, as Maxime mentioned before: That should be already enabled?
>>
>> $ git describe HEAD
>> v2018.03
>> $ make -s pine64_plus_defconfig
>> $ grep KEYBOARD .config
>> CONFIG_DM_KEYBOARD=y
>> CONFIG_USB_KEYBOARD=y
>>
>> Plus I use this for ages with *_defconfig on various Allwinner boards.
>>
>> So what am I missing here?
> 
> I couldn't see where it came from in the config

As Maxime mentioned the other day [1]:
arch/arm/Kconfig:
config ARCH_SUNXI
	....
	select DM_KEYBOARD
	....
        select USB_KEYBOARD if DISTRO_DEFAULTS
Kconfig:
config DISTRO_DEFAULTS
        default y if ARCH_SUNXI || TEGRA


> and it wasn't working for me when I tested it on 2018.03

That is weird. Are you sure the USB port you connected the keyboard to
actually works? I found this to be a problem on some boards, due to
missing regulator support. I think I used the lower port on the Pine64
and that worked fine.

Cheers,
Andre.

[1]: https://lists.denx.de/pipermail/u-boot/2018-April/324976.html

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] sunxi: A64/H5 devices: enable usb keyboard support
  2018-04-18 15:29 ` Andre Przywara
@ 2018-04-18 16:17   ` Peter Robinson
  2018-04-18 16:30     ` Andre Przywara
  0 siblings, 1 reply; 9+ messages in thread
From: Peter Robinson @ 2018-04-18 16:17 UTC (permalink / raw)
  To: u-boot

On Wed, Apr 18, 2018 at 4:29 PM, Andre Przywara <andre.przywara@arm.com> wrote:
> Hi,
>
> On 18/04/18 16:19, Peter Robinson wrote:
>> Now the A64/H5 SoCs support video output it's useful to enable usb keyboard
>> support so console can be used via standard keyboard/video interface.
>>
>> Tested on Pine64.
>
> Mmmh, as Maxime mentioned before: That should be already enabled?
>
> $ git describe HEAD
> v2018.03
> $ make -s pine64_plus_defconfig
> $ grep KEYBOARD .config
> CONFIG_DM_KEYBOARD=y
> CONFIG_USB_KEYBOARD=y
>
> Plus I use this for ages with *_defconfig on various Allwinner boards.
>
> So what am I missing here?

I couldn't see where it came from in the config and it wasn't working
for me when I tested it on 2018.03

> Cheers,
> Andre.
>
>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>> ---
>>  configs/a64-olinuxino_defconfig       | 2 ++
>>  configs/bananapi_m64_defconfig        | 2 ++
>>  configs/nanopi_a64_defconfig          | 2 ++
>>  configs/orangepi_pc2_defconfig        | 2 ++
>>  configs/orangepi_win_defconfig        | 2 ++
>>  configs/orangepi_zero_plus2_defconfig | 2 ++
>>  configs/pine64_plus_defconfig         | 2 ++
>>  configs/sopine_baseboard_defconfig    | 2 ++
>>  8 files changed, 16 insertions(+)
>>
>> diff --git a/configs/a64-olinuxino_defconfig b/configs/a64-olinuxino_defconfig
>> index b32df990a0..b0e23fc630 100644
>> --- a/configs/a64-olinuxino_defconfig
>> +++ b/configs/a64-olinuxino_defconfig
>> @@ -12,3 +12,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino"
>>  CONFIG_SUN8I_EMAC=y
>>  CONFIG_USB_EHCI_HCD=y
>>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
>> +CONFIG_DM_KEYBOARD=y
>> +CONFIG_USB_KEYBOARD=y
>> diff --git a/configs/bananapi_m64_defconfig b/configs/bananapi_m64_defconfig
>> index 47f31c6d9d..c2997223ab 100644
>> --- a/configs/bananapi_m64_defconfig
>> +++ b/configs/bananapi_m64_defconfig
>> @@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64"
>>  CONFIG_SUN8I_EMAC=y
>>  CONFIG_USB_EHCI_HCD=y
>>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
>> +CONFIG_DM_KEYBOARD=y
>> +CONFIG_USB_KEYBOARD=y
>> diff --git a/configs/nanopi_a64_defconfig b/configs/nanopi_a64_defconfig
>> index 0a04911c81..458fcc6f8e 100644
>> --- a/configs/nanopi_a64_defconfig
>> +++ b/configs/nanopi_a64_defconfig
>> @@ -11,3 +11,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-nanopi-a64"
>>  CONFIG_SUN8I_EMAC=y
>>  CONFIG_USB_EHCI_HCD=y
>>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
>> +CONFIG_DM_KEYBOARD=y
>> +CONFIG_USB_KEYBOARD=y
>> diff --git a/configs/orangepi_pc2_defconfig b/configs/orangepi_pc2_defconfig
>> index dd5f2c78ab..f89b67894d 100644
>> --- a/configs/orangepi_pc2_defconfig
>> +++ b/configs/orangepi_pc2_defconfig
>> @@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
>>  CONFIG_SUN8I_EMAC=y
>>  CONFIG_USB_EHCI_HCD=y
>>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
>> +CONFIG_DM_KEYBOARD=y
>> +CONFIG_USB_KEYBOARD=y
>> diff --git a/configs/orangepi_win_defconfig b/configs/orangepi_win_defconfig
>> index d7211b5823..de014a2766 100644
>> --- a/configs/orangepi_win_defconfig
>> +++ b/configs/orangepi_win_defconfig
>> @@ -12,3 +12,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-orangepi-win"
>>  CONFIG_SUN8I_EMAC=y
>>  CONFIG_USB_EHCI_HCD=y
>>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
>> +CONFIG_DM_KEYBOARD=y
>> +CONFIG_USB_KEYBOARD=y
>> diff --git a/configs/orangepi_zero_plus2_defconfig b/configs/orangepi_zero_plus2_defconfig
>> index fdb6bb4ed9..fb5f1b2388 100644
>> --- a/configs/orangepi_zero_plus2_defconfig
>> +++ b/configs/orangepi_zero_plus2_defconfig
>> @@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-zero-plus2"
>>  CONFIG_SUN8I_EMAC=y
>>  CONFIG_USB_EHCI_HCD=y
>>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
>> +CONFIG_DM_KEYBOARD=y
>> +CONFIG_USB_KEYBOARD=y
>> diff --git a/configs/pine64_plus_defconfig b/configs/pine64_plus_defconfig
>> index 21ce06f370..b4dbc7d03e 100644
>> --- a/configs/pine64_plus_defconfig
>> +++ b/configs/pine64_plus_defconfig
>> @@ -14,3 +14,5 @@ CONFIG_RTL8211E_PINE64_GIGABIT_FIX=y
>>  CONFIG_SUN8I_EMAC=y
>>  CONFIG_USB_EHCI_HCD=y
>>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
>> +CONFIG_DM_KEYBOARD=y
>> +CONFIG_USB_KEYBOARD=y
>> diff --git a/configs/sopine_baseboard_defconfig b/configs/sopine_baseboard_defconfig
>> index 05436a1b43..a7db99d1e2 100644
>> --- a/configs/sopine_baseboard_defconfig
>> +++ b/configs/sopine_baseboard_defconfig
>> @@ -18,3 +18,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pine64-plus"
>>  CONFIG_SUN8I_EMAC=y
>>  CONFIG_USB_EHCI_HCD=y
>>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
>> +CONFIG_DM_KEYBOARD=y
>> +CONFIG_USB_KEYBOARD=y
>>

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] sunxi: A64/H5 devices: enable usb keyboard support
  2018-04-18 15:19 Peter Robinson
@ 2018-04-18 15:29 ` Andre Przywara
  2018-04-18 16:17   ` Peter Robinson
  0 siblings, 1 reply; 9+ messages in thread
From: Andre Przywara @ 2018-04-18 15:29 UTC (permalink / raw)
  To: u-boot

Hi,

On 18/04/18 16:19, Peter Robinson wrote:
> Now the A64/H5 SoCs support video output it's useful to enable usb keyboard
> support so console can be used via standard keyboard/video interface.
> 
> Tested on Pine64.

Mmmh, as Maxime mentioned before: That should be already enabled?

$ git describe HEAD
v2018.03
$ make -s pine64_plus_defconfig
$ grep KEYBOARD .config
CONFIG_DM_KEYBOARD=y
CONFIG_USB_KEYBOARD=y

Plus I use this for ages with *_defconfig on various Allwinner boards.

So what am I missing here?

Cheers,
Andre.

> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  configs/a64-olinuxino_defconfig       | 2 ++
>  configs/bananapi_m64_defconfig        | 2 ++
>  configs/nanopi_a64_defconfig          | 2 ++
>  configs/orangepi_pc2_defconfig        | 2 ++
>  configs/orangepi_win_defconfig        | 2 ++
>  configs/orangepi_zero_plus2_defconfig | 2 ++
>  configs/pine64_plus_defconfig         | 2 ++
>  configs/sopine_baseboard_defconfig    | 2 ++
>  8 files changed, 16 insertions(+)
> 
> diff --git a/configs/a64-olinuxino_defconfig b/configs/a64-olinuxino_defconfig
> index b32df990a0..b0e23fc630 100644
> --- a/configs/a64-olinuxino_defconfig
> +++ b/configs/a64-olinuxino_defconfig
> @@ -12,3 +12,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino"
>  CONFIG_SUN8I_EMAC=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
> +CONFIG_DM_KEYBOARD=y
> +CONFIG_USB_KEYBOARD=y
> diff --git a/configs/bananapi_m64_defconfig b/configs/bananapi_m64_defconfig
> index 47f31c6d9d..c2997223ab 100644
> --- a/configs/bananapi_m64_defconfig
> +++ b/configs/bananapi_m64_defconfig
> @@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64"
>  CONFIG_SUN8I_EMAC=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
> +CONFIG_DM_KEYBOARD=y
> +CONFIG_USB_KEYBOARD=y
> diff --git a/configs/nanopi_a64_defconfig b/configs/nanopi_a64_defconfig
> index 0a04911c81..458fcc6f8e 100644
> --- a/configs/nanopi_a64_defconfig
> +++ b/configs/nanopi_a64_defconfig
> @@ -11,3 +11,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-nanopi-a64"
>  CONFIG_SUN8I_EMAC=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
> +CONFIG_DM_KEYBOARD=y
> +CONFIG_USB_KEYBOARD=y
> diff --git a/configs/orangepi_pc2_defconfig b/configs/orangepi_pc2_defconfig
> index dd5f2c78ab..f89b67894d 100644
> --- a/configs/orangepi_pc2_defconfig
> +++ b/configs/orangepi_pc2_defconfig
> @@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
>  CONFIG_SUN8I_EMAC=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
> +CONFIG_DM_KEYBOARD=y
> +CONFIG_USB_KEYBOARD=y
> diff --git a/configs/orangepi_win_defconfig b/configs/orangepi_win_defconfig
> index d7211b5823..de014a2766 100644
> --- a/configs/orangepi_win_defconfig
> +++ b/configs/orangepi_win_defconfig
> @@ -12,3 +12,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-orangepi-win"
>  CONFIG_SUN8I_EMAC=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
> +CONFIG_DM_KEYBOARD=y
> +CONFIG_USB_KEYBOARD=y
> diff --git a/configs/orangepi_zero_plus2_defconfig b/configs/orangepi_zero_plus2_defconfig
> index fdb6bb4ed9..fb5f1b2388 100644
> --- a/configs/orangepi_zero_plus2_defconfig
> +++ b/configs/orangepi_zero_plus2_defconfig
> @@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-zero-plus2"
>  CONFIG_SUN8I_EMAC=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
> +CONFIG_DM_KEYBOARD=y
> +CONFIG_USB_KEYBOARD=y
> diff --git a/configs/pine64_plus_defconfig b/configs/pine64_plus_defconfig
> index 21ce06f370..b4dbc7d03e 100644
> --- a/configs/pine64_plus_defconfig
> +++ b/configs/pine64_plus_defconfig
> @@ -14,3 +14,5 @@ CONFIG_RTL8211E_PINE64_GIGABIT_FIX=y
>  CONFIG_SUN8I_EMAC=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
> +CONFIG_DM_KEYBOARD=y
> +CONFIG_USB_KEYBOARD=y
> diff --git a/configs/sopine_baseboard_defconfig b/configs/sopine_baseboard_defconfig
> index 05436a1b43..a7db99d1e2 100644
> --- a/configs/sopine_baseboard_defconfig
> +++ b/configs/sopine_baseboard_defconfig
> @@ -18,3 +18,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pine64-plus"
>  CONFIG_SUN8I_EMAC=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
> +CONFIG_DM_KEYBOARD=y
> +CONFIG_USB_KEYBOARD=y
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] sunxi: A64/H5 devices: enable usb keyboard support
@ 2018-04-18 15:19 Peter Robinson
  2018-04-18 15:29 ` Andre Przywara
  0 siblings, 1 reply; 9+ messages in thread
From: Peter Robinson @ 2018-04-18 15:19 UTC (permalink / raw)
  To: u-boot

Now the A64/H5 SoCs support video output it's useful to enable usb keyboard
support so console can be used via standard keyboard/video interface.

Tested on Pine64.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 configs/a64-olinuxino_defconfig       | 2 ++
 configs/bananapi_m64_defconfig        | 2 ++
 configs/nanopi_a64_defconfig          | 2 ++
 configs/orangepi_pc2_defconfig        | 2 ++
 configs/orangepi_win_defconfig        | 2 ++
 configs/orangepi_zero_plus2_defconfig | 2 ++
 configs/pine64_plus_defconfig         | 2 ++
 configs/sopine_baseboard_defconfig    | 2 ++
 8 files changed, 16 insertions(+)

diff --git a/configs/a64-olinuxino_defconfig b/configs/a64-olinuxino_defconfig
index b32df990a0..b0e23fc630 100644
--- a/configs/a64-olinuxino_defconfig
+++ b/configs/a64-olinuxino_defconfig
@@ -12,3 +12,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/bananapi_m64_defconfig b/configs/bananapi_m64_defconfig
index 47f31c6d9d..c2997223ab 100644
--- a/configs/bananapi_m64_defconfig
+++ b/configs/bananapi_m64_defconfig
@@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/nanopi_a64_defconfig b/configs/nanopi_a64_defconfig
index 0a04911c81..458fcc6f8e 100644
--- a/configs/nanopi_a64_defconfig
+++ b/configs/nanopi_a64_defconfig
@@ -11,3 +11,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-nanopi-a64"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/orangepi_pc2_defconfig b/configs/orangepi_pc2_defconfig
index dd5f2c78ab..f89b67894d 100644
--- a/configs/orangepi_pc2_defconfig
+++ b/configs/orangepi_pc2_defconfig
@@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/orangepi_win_defconfig b/configs/orangepi_win_defconfig
index d7211b5823..de014a2766 100644
--- a/configs/orangepi_win_defconfig
+++ b/configs/orangepi_win_defconfig
@@ -12,3 +12,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-orangepi-win"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/orangepi_zero_plus2_defconfig b/configs/orangepi_zero_plus2_defconfig
index fdb6bb4ed9..fb5f1b2388 100644
--- a/configs/orangepi_zero_plus2_defconfig
+++ b/configs/orangepi_zero_plus2_defconfig
@@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-zero-plus2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/pine64_plus_defconfig b/configs/pine64_plus_defconfig
index 21ce06f370..b4dbc7d03e 100644
--- a/configs/pine64_plus_defconfig
+++ b/configs/pine64_plus_defconfig
@@ -14,3 +14,5 @@ CONFIG_RTL8211E_PINE64_GIGABIT_FIX=y
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
diff --git a/configs/sopine_baseboard_defconfig b/configs/sopine_baseboard_defconfig
index 05436a1b43..a7db99d1e2 100644
--- a/configs/sopine_baseboard_defconfig
+++ b/configs/sopine_baseboard_defconfig
@@ -18,3 +18,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pine64-plus"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-04-18 16:30 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-09 12:15 [U-Boot] [PATCH] sunxi: A64/H5 devices: enable usb keyboard support Peter Robinson
2018-04-09 12:53 ` Maxime Ripard
2018-04-09 13:13   ` Peter Robinson
2018-04-09 13:50 ` Antony Antony
2018-04-18 11:47   ` Peter Robinson
2018-04-18 15:19 Peter Robinson
2018-04-18 15:29 ` Andre Przywara
2018-04-18 16:17   ` Peter Robinson
2018-04-18 16:30     ` Andre Przywara

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.