[PATCH 1/2] pmemblk: clean up error logs

* [PATCH 1/2] pmemblk: clean up error logs
@ 2016-12-20 23:56 Robert Elliott
  2016-12-20 23:56 ` [PATCH 2/2] pmemblk: Clarify fsize is in MiB not MB Robert Elliott
  0 siblings, 1 reply; 6+ messages in thread
From: Robert Elliott @ 2016-12-20 23:56 UTC (permalink / raw)
  To: fio; +Cc: Robert Elliott

From: Robert Elliott <elliott@hpe.com>

Print the errno string rather than the number, and prefix
all log_err prints with pmemblk rather than fio.
---
 engines/pmemblk.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/engines/pmemblk.c b/engines/pmemblk.c
index ca72697..977a02b 100644
--- a/engines/pmemblk.c
+++ b/engines/pmemblk.c
@@ -119,7 +119,7 @@ int load_libpmemblk(const char *path)
 	return 0;
 
 errorout:
-	log_err("fio: unable to load libpmemblk: %s\n", dlerror());
+	log_err("pmemblk: unable to load libpmemblk: %s\n", dlerror());
 	if (dl)
 		dlclose(dl);
 
@@ -267,9 +267,8 @@ static fio_pmemblk_file_t pmb_open(const char *pathspec, int flags)
 			    pmemblk_create(path, bsize, fsize, 0644);
 		}
 		if (!pmb->pmb_pool) {
-			log_err
-			    ("fio: enable to open pmemblk pool file (errno %d)\n",
-			     errno);
+			log_err("pmemblk: unable to open pmemblk pool file %s (%s)\n",
+			     path, strerror(errno));
 			goto error;
 		}
 
@@ -331,14 +330,14 @@ static int pmb_get_flags(struct thread_data *td, uint64_t *pflags)
 	if (!td->o.use_thread) {
 		if (!thread_warned) {
 			thread_warned = 1;
-			log_err("fio: must set thread=1 for pmemblk engine\n");
+			log_err("pmemblk: must set thread=1 for pmemblk engine\n");
 		}
 		return 1;
 	}
 
 	if (!td->o.odirect && !odirect_warned) {
 		odirect_warned = 1;
-		log_info("fio: direct == 0, but pmemblk is always direct\n");
+		log_info("pmemblk: direct == 0, but pmemblk is always direct\n");
 	}
 
 	if (td->o.allow_create)
-- 
2.9.3


^ permalink raw reply related	[flat|nested] 6+ messages in thread